Re: net: fec: fix regression on i.MX28 introduced by rx_copybreak support

2014-11-05 Thread David Miller
From: Lothar Waßmann Date: Wed, 5 Nov 2014 06:21:48 +0100 > David Miller wrote: >> Because it goes "(n + (d - 1)) / d" >> >> Which for 'd' of 4 gives: >> >> 1 --> 4 >> 2 --> 4 >> 3 --> 4 >> 4 --> 4 >> > '1', not '4'. > The loop has to be done once for each (probably partial) WORD of input > dat

Re: net: fec: fix regression on i.MX28 introduced by rx_copybreak support

2014-11-04 Thread Lothar Waßmann
Hi, David Miller wrote: > From: Lothar Waßmann > Date: Tue, 4 Nov 2014 11:29:12 +0100 > > > Hi David, > > > > Lothar Waßmann wrote: > >> David Miller wrote: > >> > From: Lothar Waßmann > >> > Date: Thu, 30 Oct 2014 07:51:04 +0100 > >> > > >> > >> Also, I don't thnk your DIV_ROUND_UP() elimina

Re: net: fec: fix regression on i.MX28 introduced by rx_copybreak support

2014-11-04 Thread David Miller
From: Lothar Waßmann Date: Tue, 4 Nov 2014 11:29:12 +0100 > Hi David, > > Lothar Waßmann wrote: >> David Miller wrote: >> > From: Lothar Waßmann >> > Date: Thu, 30 Oct 2014 07:51:04 +0100 >> > >> > >> Also, I don't thnk your DIV_ROUND_UP() eliminate for the loop >> > >> in swap_buffer() is val

Re: net: fec: fix regression on i.MX28 introduced by rx_copybreak support

2014-11-04 Thread Lothar Waßmann
Hi David, Lothar Waßmann wrote: > David Miller wrote: > > From: Lothar Waßmann > > Date: Thu, 30 Oct 2014 07:51:04 +0100 > > > > >> Also, I don't thnk your DIV_ROUND_UP() eliminate for the loop > > >> in swap_buffer() is valid. The whole point is that the current > > >> code handles buffers whi

Re: net: fec: fix regression on i.MX28 introduced by rx_copybreak support

2014-10-30 Thread Lothar Waßmann
Hi, David Miller wrote: > From: Lothar Waßmann > Date: Thu, 30 Oct 2014 07:51:04 +0100 > > >> Also, I don't thnk your DIV_ROUND_UP() eliminate for the loop > >> in swap_buffer() is valid. The whole point is that the current > >> code handles buffers which have a length which is not a multiple >

Re: net: fec: fix regression on i.MX28 introduced by rx_copybreak support

2014-10-30 Thread David Miller
From: Lothar Waßmann Date: Thu, 30 Oct 2014 07:51:04 +0100 >> Also, I don't thnk your DIV_ROUND_UP() eliminate for the loop >> in swap_buffer() is valid. The whole point is that the current >> code handles buffers which have a length which is not a multiple >> of 4 properly, after your change it

Re: net: fec: fix regression on i.MX28 introduced by rx_copybreak support

2014-10-29 Thread Lothar Waßmann
Hi, David Miller wrote: > From: Lothar Waßmann > Date: Tue, 28 Oct 2014 14:22:55 +0100 > > > Changes wrt. v1: > > - added some cleanup patches > > - simplify handling of 'quirks' flags as suggested by Russell King. > > - remove DIV_ROUND_UP() from byte swapping loop as suggested by > > Eric Du

Re: net: fec: fix regression on i.MX28 introduced by rx_copybreak support

2014-10-29 Thread David Miller
From: Lothar Waßmann Date: Tue, 28 Oct 2014 14:22:55 +0100 > Changes wrt. v1: > - added some cleanup patches > - simplify handling of 'quirks' flags as suggested by Russell King. > - remove DIV_ROUND_UP() from byte swapping loop as suggested by > Eric Dumazet > > Changes wrt. v2: > - rebased a