Re: objtool warnings in prerelease clang-9

2019-07-10 Thread Josh Poimboeuf
On Wed, Jul 10, 2019 at 04:42:43PM -0700, Nick Desaulniers wrote: > 7e: 0f 85 00 00 00 00jne 0 > > 0080: R_X86_64_PC32 __x86_indirect_thunk_r11-4 > 84: c3retq > > I've sent you the .o file off thread as well. Thanks for taking a >

Re: objtool warnings in prerelease clang-9

2019-07-10 Thread Nick Desaulniers
On Wed, Jul 10, 2019 at 4:22 PM Josh Poimboeuf wrote: > > On Sat, Jul 06, 2019 at 10:50:01AM -0500, Josh Poimboeuf wrote: > > On Tue, Jul 02, 2019 at 11:58:27PM +0200, Thomas Gleixner wrote: > > > platform-quirks.o: > > > > > > if (x86_platform.set_legacy_features) > > > 74: 4c 8b 1d 0

Re: objtool warnings in prerelease clang-9

2019-07-10 Thread Josh Poimboeuf
On Sat, Jul 06, 2019 at 10:50:01AM -0500, Josh Poimboeuf wrote: > On Tue, Jul 02, 2019 at 11:58:27PM +0200, Thomas Gleixner wrote: > > platform-quirks.o: > > > > if (x86_platform.set_legacy_features) > > 74: 4c 8b 1d 00 00 00 00mov0x0(%rip),%r11# 7b > > > > 7b: 4d

Re: objtool warnings in prerelease clang-9

2019-07-06 Thread Josh Poimboeuf
On Tue, Jul 02, 2019 at 11:58:27PM +0200, Thomas Gleixner wrote: > platform-quirks.o: > > if (x86_platform.set_legacy_features) > 74: 4c 8b 1d 00 00 00 00mov0x0(%rip),%r11# 7b > > 7b: 4d 85 dbtest %r11,%r11 > 7e: 0f 85 00 00 00 00 jne

Re: objtool warnings in prerelease clang-9

2019-07-02 Thread Peter Zijlstra
Hi Nick, That is good news; and I'll strive to read the email in more detail in the morning when there is a better chance of me actually understanding some of it :-) But his here is something I felt needed clarification: On Tue, Jul 02, 2019 at 01:53:51PM -0700, Nick Desaulniers wrote: > Of in

Re: objtool warnings in prerelease clang-9

2019-07-02 Thread Nick Desaulniers
On Tue, Jul 2, 2019 at 2:58 PM Thomas Gleixner wrote: > On Tue, 2 Jul 2019, Nick Desaulniers wrote: > > TL;DR > > LLVM currently has a bug when unrolling loops containing asm goto and > > we have a fix in hand. > > > > Conservatively, we can block loop unrolling when we see asm goto in a loop: > >

Re: objtool warnings in prerelease clang-9

2019-07-02 Thread Thomas Gleixner
Nick, On Tue, 2 Jul 2019, Nick Desaulniers wrote: > On Tue, Jul 2, 2019 at 2:58 PM Thomas Gleixner wrote: > > On Tue, 2 Jul 2019, Nick Desaulniers wrote: > > > > This causes objtool to not find any issues in > > > arch/x86/kernel/cpu/mtrr/generic.o. I don't observe any duplication > > > in the

Re: objtool warnings in prerelease clang-9

2019-07-02 Thread Thomas Gleixner
Nick, On Tue, 2 Jul 2019, Nick Desaulniers wrote: > TL;DR > LLVM currently has a bug when unrolling loops containing asm goto and > we have a fix in hand. > > Conservatively, we can block loop unrolling when we see asm goto in a loop: Makes sense in order to make progress. > This causes obj

Re: objtool warnings in prerelease clang-9

2019-07-02 Thread Nick Desaulniers
On Tue, Jul 2, 2019 at 3:07 PM Peter Zijlstra wrote: > > > Hi Nick, > > That is good news; and I'll strive to read the email in more detail > in the morning when there is a better chance of me actually > understanding some of it :-) > > But his here is something I felt needed clarification: > > On

Re: objtool warnings in prerelease clang-9

2019-07-02 Thread Nick Desaulniers
On Tue, Jul 2, 2019 at 3:20 PM Thomas Gleixner wrote: > > Nick, > > On Tue, 2 Jul 2019, Nick Desaulniers wrote: > > On Tue, Jul 2, 2019 at 2:58 PM Thomas Gleixner wrote: > > > On Tue, 2 Jul 2019, Nick Desaulniers wrote: > > > > > > This causes objtool to not find any issues in > > > > arch/x86/ke