On 24/07/2015 07:30, Vinod Koul wrote:
On Fri, Jul 24, 2015 at 07:51:28AM +0200, Julia Lawall wrote:
Yes for dmaengine drivers I do ask this question which typically ends up in
driver invoking devm_irq_free() in driver's remove callback
IMHO don't think devm irq calls are very useful, they do m
On Fri, 24 Jul 2015, Vinod Koul wrote:
> On Fri, Jul 24, 2015 at 07:51:28AM +0200, Julia Lawall wrote:
> > > Yes for dmaengine drivers I do ask this question which typically ends up
> > > in
> > > driver invoking devm_irq_free() in driver's remove callback
> > >
> > > IMHO don't think devm irq c
On Fri, Jul 24, 2015 at 07:51:28AM +0200, Julia Lawall wrote:
> > Yes for dmaengine drivers I do ask this question which typically ends up in
> > driver invoking devm_irq_free() in driver's remove callback
> >
> > IMHO don't think devm irq calls are very useful, they do make stuff
> > complicate
>
> Yes for dmaengine drivers I do ask this question which typically ends up in
> driver invoking devm_irq_free() in driver's remove callback
>
> IMHO don't think devm irq calls are very useful, they do make stuff
> complicate
Would it be better then to just go back to request_irq (or whatever is
a
On Thu, Jul 23, 2015 at 07:24:10PM +0200, Julia Lawall wrote:
>
>
> On Thu, 23 Jul 2015, Vinod Koul wrote:
>
> > On Wed, Jul 22, 2015 at 03:26:01PM +0100, Alex Smith wrote:
> >
> > > >>>I think the explicit devm_free_irq() here is unnecessary, as when
> > > >>>remove is
> > > >>>called there sh
On Thu, 23 Jul 2015, Vinod Koul wrote:
> On Wed, Jul 22, 2015 at 03:26:01PM +0100, Alex Smith wrote:
>
> > >>>I think the explicit devm_free_irq() here is unnecessary, as when remove
> > >>>is
> > >>>called there should be no remaining users of the DMA controller and
> > >>>therefore
> > >>>no
On Wed, Jul 22, 2015 at 03:26:01PM +0100, Alex Smith wrote:
> >>>I think the explicit devm_free_irq() here is unnecessary, as when remove is
> >>>called there should be no remaining users of the DMA controller and
> >>>therefore
> >>>no chance of an IRQ occurring between the controller being unre
On 21/07/2015 05:15, Vinod Koul wrote:
On Mon, Jul 20, 2015 at 10:28:14AM +0200, Julia Lawall wrote:
On Mon, 20 Jul 2015, Alex Smith wrote:
On 19/07/2015 10:08, Julia Lawall wrote:
The file drivers/dma/dma-jz4780.c has a probe function that sets up irqs
using devm_request_irq. The probe func
On Mon, Jul 20, 2015 at 10:28:14AM +0200, Julia Lawall wrote:
> On Mon, 20 Jul 2015, Alex Smith wrote:
>
> > On 19/07/2015 10:08, Julia Lawall wrote:
> > > The file drivers/dma/dma-jz4780.c has a probe function that sets up irqs
> > > using devm_request_irq. The probe function then ends with:
> >
On Mon, 20 Jul 2015, Alex Smith wrote:
> On 19/07/2015 10:08, Julia Lawall wrote:
> > The file drivers/dma/dma-jz4780.c has a probe function that sets up irqs
> > using devm_request_irq. The probe function then ends with:
> >
> > err_unregister_dev:
> > dma_async_device_unregister(dd);
> >
>
On 19/07/2015 10:08, Julia Lawall wrote:
The file drivers/dma/dma-jz4780.c has a probe function that sets up irqs
using devm_request_irq. The probe function then ends with:
err_unregister_dev:
dma_async_device_unregister(dd);
err_disable_clk:
clk_disable_unprepare(jzdma->clk);
11 matches
Mail list logo