Re: question about drivers/dma/dma-jz4780.c

2015-07-24 Thread Alex Smith
On 24/07/2015 07:30, Vinod Koul wrote: On Fri, Jul 24, 2015 at 07:51:28AM +0200, Julia Lawall wrote: Yes for dmaengine drivers I do ask this question which typically ends up in driver invoking devm_irq_free() in driver's remove callback IMHO don't think devm irq calls are very useful, they do m

Re: question about drivers/dma/dma-jz4780.c

2015-07-23 Thread Julia Lawall
On Fri, 24 Jul 2015, Vinod Koul wrote: > On Fri, Jul 24, 2015 at 07:51:28AM +0200, Julia Lawall wrote: > > > Yes for dmaengine drivers I do ask this question which typically ends up > > > in > > > driver invoking devm_irq_free() in driver's remove callback > > > > > > IMHO don't think devm irq c

Re: question about drivers/dma/dma-jz4780.c

2015-07-23 Thread Vinod Koul
On Fri, Jul 24, 2015 at 07:51:28AM +0200, Julia Lawall wrote: > > Yes for dmaengine drivers I do ask this question which typically ends up in > > driver invoking devm_irq_free() in driver's remove callback > > > > IMHO don't think devm irq calls are very useful, they do make stuff > > complicate >

Re: question about drivers/dma/dma-jz4780.c

2015-07-23 Thread Julia Lawall
> Yes for dmaengine drivers I do ask this question which typically ends up in > driver invoking devm_irq_free() in driver's remove callback > > IMHO don't think devm irq calls are very useful, they do make stuff > complicate Would it be better then to just go back to request_irq (or whatever is a

Re: question about drivers/dma/dma-jz4780.c

2015-07-23 Thread Vinod Koul
On Thu, Jul 23, 2015 at 07:24:10PM +0200, Julia Lawall wrote: > > > On Thu, 23 Jul 2015, Vinod Koul wrote: > > > On Wed, Jul 22, 2015 at 03:26:01PM +0100, Alex Smith wrote: > > > > > >>>I think the explicit devm_free_irq() here is unnecessary, as when > > > >>>remove is > > > >>>called there sh

Re: question about drivers/dma/dma-jz4780.c

2015-07-23 Thread Julia Lawall
On Thu, 23 Jul 2015, Vinod Koul wrote: > On Wed, Jul 22, 2015 at 03:26:01PM +0100, Alex Smith wrote: > > > >>>I think the explicit devm_free_irq() here is unnecessary, as when remove > > >>>is > > >>>called there should be no remaining users of the DMA controller and > > >>>therefore > > >>>no

Re: question about drivers/dma/dma-jz4780.c

2015-07-23 Thread Vinod Koul
On Wed, Jul 22, 2015 at 03:26:01PM +0100, Alex Smith wrote: > >>>I think the explicit devm_free_irq() here is unnecessary, as when remove is > >>>called there should be no remaining users of the DMA controller and > >>>therefore > >>>no chance of an IRQ occurring between the controller being unre

Re: question about drivers/dma/dma-jz4780.c

2015-07-22 Thread Alex Smith
On 21/07/2015 05:15, Vinod Koul wrote: On Mon, Jul 20, 2015 at 10:28:14AM +0200, Julia Lawall wrote: On Mon, 20 Jul 2015, Alex Smith wrote: On 19/07/2015 10:08, Julia Lawall wrote: The file drivers/dma/dma-jz4780.c has a probe function that sets up irqs using devm_request_irq. The probe func

Re: question about drivers/dma/dma-jz4780.c

2015-07-20 Thread Vinod Koul
On Mon, Jul 20, 2015 at 10:28:14AM +0200, Julia Lawall wrote: > On Mon, 20 Jul 2015, Alex Smith wrote: > > > On 19/07/2015 10:08, Julia Lawall wrote: > > > The file drivers/dma/dma-jz4780.c has a probe function that sets up irqs > > > using devm_request_irq. The probe function then ends with: > >

Re: question about drivers/dma/dma-jz4780.c

2015-07-20 Thread Julia Lawall
On Mon, 20 Jul 2015, Alex Smith wrote: > On 19/07/2015 10:08, Julia Lawall wrote: > > The file drivers/dma/dma-jz4780.c has a probe function that sets up irqs > > using devm_request_irq. The probe function then ends with: > > > > err_unregister_dev: > > dma_async_device_unregister(dd); > > >

Re: question about drivers/dma/dma-jz4780.c

2015-07-20 Thread Alex Smith
On 19/07/2015 10:08, Julia Lawall wrote: The file drivers/dma/dma-jz4780.c has a probe function that sets up irqs using devm_request_irq. The probe function then ends with: err_unregister_dev: dma_async_device_unregister(dd); err_disable_clk: clk_disable_unprepare(jzdma->clk);