Re: rtc: fix chardev initialization races

2018-05-22 Thread Jiri Kosina
On Tue, 22 May 2018, Uwe Kleine-König wrote: > [adding linux-rtc ML and Alexandre to Cc:] > > Hello, > > On Tue, May 22, 2018 at 02:09:36PM +0200, Jiri Kosina wrote: > > On Mon, 21 May 2018, Uwe Kleine-König wrote: > > > > > > The race looks like that (thanks Jiri): > > > > > > > > CPU0:

Re: rtc: fix chardev initialization races

2018-05-22 Thread Uwe Kleine-König
[adding linux-rtc ML and Alexandre to Cc:] Hello, On Tue, May 22, 2018 at 02:09:36PM +0200, Jiri Kosina wrote: > On Mon, 21 May 2018, Uwe Kleine-König wrote: > > > > The race looks like that (thanks Jiri): > > > > > > CPU0:CPU1: > > > sys_load_module() > > > do_

Re: rtc: fix chardev initialization races

2018-05-22 Thread Jiri Kosina
On Mon, 21 May 2018, Uwe Kleine-König wrote: > > The race looks like that (thanks Jiri): > > > > CPU0:CPU1: > > sys_load_module() > > do_init_module() > > do_one_initcall() > >cmos_do_probe() > > rtc_device_register() > > __register_chrdev() > >

Re: rtc: fix chardev initialization races

2018-05-21 Thread Uwe Kleine-König
On Wed, Feb 26, 2014 at 11:33:13AM +0100, Ales Novak wrote: > In many rtc modules, the chardevice file in rtc module probe is > being created prematurely. If the probe fails after the chardevice > file has been created (e.g. after rtc_device_register), it's possible > for a program to open() it, wh