Re: signal quality and cable diagnostic

2020-05-24 Thread Russell King - ARM Linux admin
On Sun, May 24, 2020 at 11:27:57PM +0200, Pavel Machek wrote: > > > The SNR seems to be most universal value, when it comes to comparing > > > different situations (different links and different PHYs). The > > > resolution of BER is not that detailed, for the NXP PHY is says only > > > "BER below 1

Re: signal quality and cable diagnostic

2020-05-24 Thread Pavel Machek
On Tue 2020-05-12 15:04:18, Andrew Lunn wrote: > > > As for getting / setting the threshold, perhaps ETHTOOL_MSG_LINKINFO_GET > > > and ETHTOOL_MSG_LINKINFO_SET. Unless you expect more configurable > > > parameters like this in which case we may want to consider adding new > > > request type (e.g.

Re: signal quality and cable diagnostic

2020-05-24 Thread Pavel Machek
> > The SNR seems to be most universal value, when it comes to comparing > > different situations (different links and different PHYs). The > > resolution of BER is not that detailed, for the NXP PHY is says only > > "BER below 1e-10" or not. > > The point I was trying to make is that SQI is inten

Re: signal quality and cable diagnostic

2020-05-14 Thread Christian Herber
On Tue, May 14, 2020 at 08:28:00AM +, Oleksij Rempel wrote: > On Thu, May 14, 2020 at 07:13:30AM +, Christian Herber wrote: > > On Tue, May 12, 2020 at 10:22:01AM +0200, Oleksij Rempel wrote: > > > > > So I think we should pass raw SQI value to user space, at least in the > > > first implem

Re: [EXT] Re: signal quality and cable diagnostic

2020-05-14 Thread Oleksij Rempel
Hi Christian, On Thu, May 14, 2020 at 07:13:30AM +, Christian Herber wrote: > On Tue, May 12, 2020 at 10:22:01AM +0200, Oleksij Rempel wrote: > > > So I think we should pass raw SQI value to user space, at least in the > > first implementation. > > > What do you think about this? > > Hi Ole

RE: [EXT] Re: signal quality and cable diagnostic

2020-05-14 Thread Christian Herber
On Tue, May 12, 2020 at 10:22:01AM +0200, Oleksij Rempel wrote: > So I think we should pass raw SQI value to user space, at least in the > first implementation. > What do you think about this? Hi Oleksij, I had a check about the background of this SQI thing. The table you reference with concre

Re: signal quality and cable diagnostic

2020-05-12 Thread Andrew Lunn
> > As for getting / setting the threshold, perhaps ETHTOOL_MSG_LINKINFO_GET > > and ETHTOOL_MSG_LINKINFO_SET. Unless you expect more configurable > > parameters like this in which case we may want to consider adding new > > request type (e.g. link params or link management). > > Currently in my s

Re: signal quality and cable diagnostic

2020-05-12 Thread Robert Schwebel
On Tue, May 12, 2020 at 10:22:01AM +0200, Oleksij Rempel wrote: > > Pair A: OK > > Pair A: Signal Quality Index class D > > At least for automotive, avionics, (rockets till it is deployed :D) > etc... the cable integrity will probably not change, except we have some > sudden water infiltration int

Re: signal quality and cable diagnostic

2020-05-12 Thread Oleksij Rempel
On Mon, May 11, 2020 at 04:33:37PM +0200, Andrew Lunn wrote: > On Mon, May 11, 2020 at 04:13:10PM +0200, Oleksij Rempel wrote: > > Hi Andrew, > > > > First of all, great work! As your cable diagnostic patches are in > > net-next now and can be used as base for the follow-up discussion. > > > > Do

Re: signal quality and cable diagnostic

2020-05-11 Thread Oleksij Rempel
On Mon, May 11, 2020 at 04:59:26PM +0200, Michal Kubecek wrote: > On Mon, May 11, 2020 at 04:13:10PM +0200, Oleksij Rempel wrote: > > > > I continue to work on TJA11xx PHY and need to export some additional > > cable diagnostic/link stability information: Signal Quality Index (SQI). > > The PHY da

Re: Re: signal quality and cable diagnostic

2020-05-11 Thread Oleksij Rempel
On Mon, May 11, 2020 at 09:54:35PM +0200, Andrew Lunn wrote: > On Mon, May 11, 2020 at 07:32:05PM +, Christian Herber wrote: > > On May 11, 2020 4:33:53 PM Andrew Lunn wrote: > > > > > > Are the classes part of the Open Alliance specification? Ideally we > > > want to report something standard

Re: Re: signal quality and cable diagnostic

2020-05-11 Thread Andrew Lunn
On Mon, May 11, 2020 at 07:32:05PM +, Christian Herber wrote: > On May 11, 2020 4:33:53 PM Andrew Lunn wrote: > > > > Are the classes part of the Open Alliance specification? Ideally we > > want to report something standardized, not something proprietary to > > NXP. > > > >Andrew > >

RE: Re: signal quality and cable diagnostic

2020-05-11 Thread Christian Herber
On May 11, 2020 4:33:53 PM Andrew Lunn wrote: > > Are the classes part of the Open Alliance specification? Ideally we > want to report something standardized, not something proprietary to > NXP. > >Andrew Hi Andrew, Such mechanisms are standardized and supported by pretty much all device

Re: signal quality and cable diagnostic

2020-05-11 Thread Michal Kubecek
On Mon, May 11, 2020 at 04:13:10PM +0200, Oleksij Rempel wrote: > > I continue to work on TJA11xx PHY and need to export some additional > cable diagnostic/link stability information: Signal Quality Index (SQI). > The PHY data sheet describes it as following [1]: >

Re: signal quality and cable diagnostic

2020-05-11 Thread Andrew Lunn
On Mon, May 11, 2020 at 04:13:10PM +0200, Oleksij Rempel wrote: > Hi Andrew, > > First of all, great work! As your cable diagnostic patches are in > net-next now and can be used as base for the follow-up discussion. > > Do you already have ethtool patches somewhere? :=) Can you please give a > li