Re: statx(2) API and documentation

2018-10-18 Thread Miklos Szeredi
On Thu, Oct 18, 2018 at 6:04 PM, David Howells wrote: > Miklos Szeredi wrote: > >> I'm trying to implement statx for fuse and ran into the following issues: >> >> - Need a STATX_ATTRIBUTES bit, so that userspace can explicitly ask >> for stx_attribute; otherwise if querying has non-zero cost, the

Re: statx(2) API and documentation

2018-10-18 Thread David Howells
Miklos Szeredi wrote: > I'm trying to implement statx for fuse and ran into the following issues: > > - Need a STATX_ATTRIBUTES bit, so that userspace can explicitly ask > for stx_attribute; otherwise if querying has non-zero cost, then > filesystem cannot do it without regressing performance.

Re: statx(2) API and documentation

2018-10-18 Thread Florian Weimer
* Jan Kara: > On Thu 18-10-18 01:15:13, Amir Goldstein wrote: >> FYI, I identified a similar anti-pattern in fanotify UAPI when I wanted to >> add new flags and did not want to change the UAPI _ALL_ constants. >> This is how we plan to solve it: >> https://github.com/amir73il/linux/commit/8c2b1aca

Re: statx(2) API and documentation

2018-10-18 Thread Miklos Szeredi
On Thu, Oct 18, 2018 at 9:39 AM, Florian Weimer wrote: > * Miklos Szeredi: > >> On Thu, Oct 18, 2018 at 12:22 AM, Florian Weimer wrote: >>> * Andreas Dilger: >>> > So what's the point exactly? Ah, I see your point... STATX_ALL seems to be mostly useful for the kernel to mask o

Re: statx(2) API and documentation

2018-10-18 Thread Jan Kara
On Thu 18-10-18 01:15:13, Amir Goldstein wrote: > On Wed, Oct 17, 2018 at 10:12 PM Miklos Szeredi wrote: > > > >> - STATX_ALL definition is unclear, can this change, or is it fixed? > > >> If it's the former, than that's a backward compatibility nightmare. > > >> If it's the latter, then what's t

Re: statx(2) API and documentation

2018-10-18 Thread Florian Weimer
* Miklos Szeredi: > On Thu, Oct 18, 2018 at 12:22 AM, Florian Weimer wrote: >> * Andreas Dilger: >> So what's the point exactly? >>> >>> Ah, I see your point... STATX_ALL seems to be mostly useful for the kernel >>> to mask off flags that it doesn't currently understand. It doesn't make >>

Re: statx(2) API and documentation

2018-10-18 Thread Miklos Szeredi
On Thu, Oct 18, 2018 at 12:22 AM, Florian Weimer wrote: > * Andreas Dilger: > >>> So what's the point exactly? >> >> Ah, I see your point... STATX_ALL seems to be mostly useful for the kernel >> to mask off flags that it doesn't currently understand. It doesn't make >> much sense for application

Re: statx(2) API and documentation

2018-10-18 Thread Miklos Szeredi
On Wed, Oct 17, 2018 at 10:22 PM, Andreas Dilger wrote: > On Oct 17, 2018, at 1:04 PM, Miklos Szeredi wrote: >> So what's the point exactly? > > Ah, I see your point... STATX_ALL seems to be mostly useful for the kernel > to mask off flags that it doesn't currently understand. And even there i

Re: statx(2) API and documentation

2018-10-17 Thread Florian Weimer
* Andreas Dilger: >> So what's the point exactly? > > Ah, I see your point... STATX_ALL seems to be mostly useful for the kernel > to mask off flags that it doesn't currently understand. It doesn't make > much sense for applications to specify STATX_ALL, since they don't have any > way to know w

Re: statx(2) API and documentation

2018-10-17 Thread Amir Goldstein
On Wed, Oct 17, 2018 at 10:12 PM Miklos Szeredi wrote: > >> - STATX_ALL definition is unclear, can this change, or is it fixed? > >> If it's the former, than that's a backward compatibility nightmare. > >> If it's the latter, then what's the point? > > > > The value can change over time. It is i

Re: statx(2) API and documentation

2018-10-17 Thread Andreas Dilger
On Oct 17, 2018, at 1:04 PM, Miklos Szeredi wrote: > > On Wed, Oct 17, 2018 at 8:45 PM, Andreas Dilger wrote: >> On Oct 17, 2018, at 12:24 PM, Miklos Szeredi wrote: >>> >>> I'm trying to implement statx for fuse and ran into the following issues: >>> >>> - Need a STATX_ATTRIBUTES bit, so that

Re: statx(2) API and documentation

2018-10-17 Thread Miklos Szeredi
On Wed, Oct 17, 2018 at 8:45 PM, Andreas Dilger wrote: > On Oct 17, 2018, at 12:24 PM, Miklos Szeredi wrote: >> >> I'm trying to implement statx for fuse and ran into the following issues: >> >> - Need a STATX_ATTRIBUTES bit, so that userspace can explicitly ask >> for stx_attribute; otherwise if

Re: statx(2) API and documentation

2018-10-17 Thread Andreas Dilger
On Oct 17, 2018, at 12:24 PM, Miklos Szeredi wrote: > > I'm trying to implement statx for fuse and ran into the following issues: > > - Need a STATX_ATTRIBUTES bit, so that userspace can explicitly ask > for stx_attribute; otherwise if querying has non-zero cost, then > filesystem cannot do it w