Re: tracing: user events UAF crash report

2024-07-25 Thread Mathias Krause
On 25.07.24 22:15, Steven Rostedt wrote: > On Thu, 25 Jul 2024 21:42:41 +0200 > Mathias Krause wrote: > >> Right. But the point is, that 'event_call' is really some '>call'. >> With 'user' being free'd memory, what gives? Dereferencing 'event_call' >> is UB, so this function is doomed to fail

Re: tracing: user events UAF crash report

2024-07-25 Thread Steven Rostedt
On Thu, 25 Jul 2024 21:42:41 +0200 Mathias Krause wrote: > Right. But the point is, that 'event_call' is really some '>call'. > With 'user' being free'd memory, what gives? Dereferencing 'event_call' > is UB, so this function is doomed to fail because it cannot know if its > only argument points

Re: tracing: user events UAF crash report

2024-07-25 Thread Mathias Krause
On 25.07.24 21:05, Steven Rostedt wrote: > Here's the proper fix: > > diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c > index 6ef29eba90ce..3a2d2ff1625b 100644 > --- a/kernel/trace/trace_events.c > +++ b/kernel/trace/trace_events.c > @@ -3140,8 +3140,10 @@

Re: tracing: user events UAF crash report

2024-07-25 Thread Mathias Krause
On 25.07.24 21:05, Steven Rostedt wrote: > On Thu, 25 Jul 2024 20:12:33 +0200 > Mathias Krause wrote: @@ -973,6 +975,11 @@ size_t copy_nofault(void *addr, size_t bytes, struct iov_iter *i) static struct list_head *user_event_get_fields(struct trace_event_call *call) {

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-25 Thread David Woodhouse
On Thu, 2024-07-25 at 12:38 -0400, Michael S. Tsirkin wrote: > On Thu, Jul 25, 2024 at 04:18:43PM +0100, David Woodhouse wrote: > > The use case isn't necessarily for all users of gettimeofday(), of > > course; this is for those applications which *need* precision time. > > Like distributed

Re: [PATCH] module: Add hard dependencies as syntactic sugar

2024-07-25 Thread Dragan Simic
Hello Lucas, On 2024-07-25 19:18, Lucas De Marchi wrote: On Thu, Jul 25, 2024 at 04:39:40PM GMT, Steven Price wrote: On 25/07/2024 15:29, Lucas De Marchi wrote: On Thu, Jul 25, 2024 at 01:37:46PM GMT, Dragan Simic wrote: Panfrost and Lima DRM drivers use devfreq to perform DVFS, which is

Re: tracing: user events UAF crash report

2024-07-25 Thread Steven Rostedt
On Thu, 25 Jul 2024 20:12:33 +0200 Mathias Krause wrote: > > > > >> + > >>if (WARN_ON_ONCE(!schedule_work(>put_work))) { > >>/* > >> * If we fail we must wait for an admin to attempt delete or > >> @@ -973,6 +975,11 @@ size_t copy_nofault(void *addr, size_t bytes,

Re: tracing: user events UAF crash report

2024-07-25 Thread Mathias Krause
On 25.07.24 19:16, Steven Rostedt wrote: > On Thu, 25 Jul 2024 13:10:21 -0400 > Steven Rostedt wrote: >> >> diff --git a/kernel/trace/trace_events_user.c >> b/kernel/trace/trace_events_user.c >> index 3a2b46847c8b..e9ed2826ff46 100644 >> --- a/kernel/trace/trace_events_user.c >> +++

Re: [PATH v6 3/3] vdpa/mlx5: Add the support of set mac address

2024-07-25 Thread Joe Damato
On Thu, Jul 25, 2024 at 09:31:04AM +0800, Cindy Lu wrote: > Add the function to support setting the MAC address. > For vdpa/mlx5, the function will use mlx5_mpfs_add_mac > to set the mac address > > Tested in ConnectX-6 Dx device > > Signed-off-by: Cindy Lu > --- >

Re: [PATH v6 1/3] vdpa: support set mac address from vdpa tool

2024-07-25 Thread Joe Damato
On Thu, Jul 25, 2024 at 09:31:02AM +0800, Cindy Lu wrote: [...] > diff --git a/drivers/vdpa/vdpa.c b/drivers/vdpa/vdpa.c > index 8d391947eb8d..532cf3b52b26 100644 > --- a/drivers/vdpa/vdpa.c > +++ b/drivers/vdpa/vdpa.c > @@ -1361,6 +1361,81 @@ static int vdpa_nl_cmd_dev_config_get_doit(struct >

Re: [PATH v6 0/3] vdpa: support set mac address from vdpa tool

2024-07-25 Thread Joe Damato
On Thu, Jul 25, 2024 at 09:31:01AM +0800, Cindy Lu wrote: > Add support for setting the MAC address using the VDPA tool. > This feature will allow setting the MAC address using the VDPA tool. > For example, in vdpa_sim_net, the implementation sets the MAC address > to the config space. However,

Re: [PATCH] module: Add hard dependencies as syntactic sugar

2024-07-25 Thread Lucas De Marchi
On Thu, Jul 25, 2024 at 04:39:40PM GMT, Steven Price wrote: On 25/07/2024 15:29, Lucas De Marchi wrote: On Thu, Jul 25, 2024 at 01:37:46PM GMT, Dragan Simic wrote: Panfrost and Lima DRM drivers use devfreq to perform DVFS, which is supported on the associated platforms, while using

Re: tracing: user events UAF crash report

2024-07-25 Thread Steven Rostedt
On Thu, 25 Jul 2024 13:10:21 -0400 Steven Rostedt wrote: > > diff --git a/kernel/trace/trace_events_user.c > b/kernel/trace/trace_events_user.c > index 3a2b46847c8b..e9ed2826ff46 100644 > --- a/kernel/trace/trace_events_user.c > +++ b/kernel/trace/trace_events_user.c > @@ -321,6 +321,8 @@

Re: tracing: user events UAF crash report

2024-07-25 Thread Steven Rostedt
On Thu, 25 Jul 2024 22:00:14 +0530 Ajay Kaher wrote: > Thread A (read event) Thread B (remove event) > > . worker_thread() > . delayed_destroy_user_event() > .

Re: tracing: user events UAF crash report

2024-07-25 Thread Steven Rostedt
On Thu, 25 Jul 2024 21:45:03 +0530 Ajay Kaher wrote: > On Mon, Jul 22, 2024 at 5:38 PM Mathias Krause wrote: > > > > On 22.07.24 13:13, Ajay Kaher wrote: > > > On Sat, Jul 20, 2024 at 2:17 AM Mathias Krause > > > wrote: > > >> > > >> I noticed, the user events ftrace selftest is crashing

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-25 Thread Michael S. Tsirkin
On Thu, Jul 25, 2024 at 04:18:43PM +0100, David Woodhouse wrote: > On Thu, 2024-07-25 at 10:11 -0400, Michael S. Tsirkin wrote: > > On Thu, Jul 25, 2024 at 02:50:50PM +0100, David Woodhouse wrote: > > > Even if the virtio-rtc specification were official today, and I was > > > able to expose it via

Re: tracing: user events UAF crash report

2024-07-25 Thread Ajay Kaher
On Thu, Jul 25, 2024 at 9:45 PM Ajay Kaher wrote: > > On Mon, Jul 22, 2024 at 5:38 PM Mathias Krause wrote: > > > > On 22.07.24 13:13, Ajay Kaher wrote: > > > On Sat, Jul 20, 2024 at 2:17 AM Mathias Krause > > > wrote: > > >> > > >> I noticed, the user events ftrace selftest is crashing every

Re: tracing: user events UAF crash report

2024-07-25 Thread Ajay Kaher
On Mon, Jul 22, 2024 at 5:38 PM Mathias Krause wrote: > > On 22.07.24 13:13, Ajay Kaher wrote: > > On Sat, Jul 20, 2024 at 2:17 AM Mathias Krause > > wrote: > >> > >> I noticed, the user events ftrace selftest is crashing every now and > >> then in our automated tests. Digging into, I found

Re: [PATCH] module: Add hard dependencies as syntactic sugar

2024-07-25 Thread Steven Price
On 25/07/2024 15:29, Lucas De Marchi wrote: > On Thu, Jul 25, 2024 at 01:37:46PM GMT, Dragan Simic wrote: >> Panfrost and Lima DRM drivers use devfreq to perform DVFS, which is >> supported >> on the associated platforms, while using simple_ondemand devfreq >> governor by >> default.  This makes

Re: [PATCH] module: Add hard dependencies as syntactic sugar

2024-07-25 Thread Dragan Simic
Hello Lucas, On 2024-07-25 16:29, Lucas De Marchi wrote: On Thu, Jul 25, 2024 at 01:37:46PM GMT, Dragan Simic wrote: Panfrost and Lima DRM drivers use devfreq to perform DVFS, which is supported on the associated platforms, while using simple_ondemand devfreq governor by default. This makes

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-25 Thread David Woodhouse
On Thu, 2024-07-25 at 10:11 -0400, Michael S. Tsirkin wrote: > On Thu, Jul 25, 2024 at 02:50:50PM +0100, David Woodhouse wrote: > > Even if the virtio-rtc specification were official today, and I was > > able to expose it via PCI, I probably wouldn't do it that way. There's > > just far more in

Re: [PATCH v2] remoteproc: xlnx: add sram support

2024-07-25 Thread Mathieu Poirier
On Wed, 24 Jul 2024 at 16:04, Tanmay Shah wrote: > > Hello Mathieu, > > Thanks for reviews. > > All the comments looks good, I will send next revision addressing them all. > > On 7/22/24 11:39 AM, Mathieu Poirier wrote: > > Good morning, > > > > On Mon, Jul 15, 2024 at 06:39:54PM -0700, Tanmay

Re: [POC 0/7] livepatch: Make livepatch states, callbacks, and shadow variables work together

2024-07-25 Thread Nicolai Stange
Miroslav Benes writes: > > Do we still need klp_state->data member? Now that it can be easily coupled > with shadow variables, is there a reason to preserve it? I would say yes, it could point to e.g. some lock protecting an associated shadow variable's usage. Or be used to conveniently pass

Re: [PATCH] module: Add hard dependencies as syntactic sugar

2024-07-25 Thread Lucas De Marchi
On Thu, Jul 25, 2024 at 01:37:46PM GMT, Dragan Simic wrote: Panfrost and Lima DRM drivers use devfreq to perform DVFS, which is supported on the associated platforms, while using simple_ondemand devfreq governor by default. This makes the simple_ondemand module a hard dependency for both

Re: [POC 0/7] livepatch: Make livepatch states, callbacks, and shadow variables work together

2024-07-25 Thread Miroslav Benes
Hi Petr, On Fri, 10 Nov 2023, Petr Mladek wrote: > This POC is a material for the discussion "Simplify Livepatch Callbacks, > Shadow Variables, and States handling" at LPC 2013, see > https://lpc.events/event/17/contributions/1541/ > > It obsoletes the patchset adding the garbage collection of

Re: [POC 0/7] livepatch: Make livepatch states, callbacks, and shadow variables work together

2024-07-25 Thread Miroslav Benes
On Fri, 10 Nov 2023, Josh Poimboeuf wrote: > On Fri, Nov 10, 2023 at 06:04:21PM +0100, Petr Mladek wrote: > > This POC is a material for the discussion "Simplify Livepatch Callbacks, > > Shadow Variables, and States handling" at LPC 2013, see > > https://lpc.events/event/17/contributions/1541/ >

Re: [POC 7/7] livepatching: Remove per-state version

2024-07-25 Thread Miroslav Benes
On Fri, 10 Nov 2023, Petr Mladek wrote: > The livepatch state API was added to help with maintaining: > >+ changes done by livepatch callbasks >+ lifetime of shadow variables > > The original API was hard to use. Both objectives are better handled > by the new per-state callbacks. They

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-25 Thread Michael S. Tsirkin
On Thu, Jul 25, 2024 at 02:50:50PM +0100, David Woodhouse wrote: > Even if the virtio-rtc specification were official today, and I was > able to expose it via PCI, I probably wouldn't do it that way. There's > just far more in virtio-rtc than we need; the simple shared memory > region is perfectly

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-25 Thread David Woodhouse
On Thu, 2024-07-25 at 08:33 -0400, Michael S. Tsirkin wrote: > On Thu, Jul 25, 2024 at 01:31:19PM +0100, David Woodhouse wrote: > > On Thu, 2024-07-25 at 08:29 -0400, Michael S. Tsirkin wrote: > > > On Thu, Jul 25, 2024 at 01:27:49PM +0100, David Woodhouse wrote: > > > > On Thu, 2024-07-25 at

Re: tracing: user events UAF crash report

2024-07-25 Thread Ajay Kaher
On Mon, Jul 22, 2024 at 5:38 PM Mathias Krause wrote: > > On 22.07.24 13:13, Ajay Kaher wrote: > > On Sat, Jul 20, 2024 at 2:17 AM Mathias Krause > > wrote: > >> > >> I noticed, the user events ftrace selftest is crashing every now and > >> then in our automated tests. Digging into, I found

Re: [PATCH] trace: riscv: Remove deprecated kprobe on ftrace support

2024-07-25 Thread patchwork-bot+linux-riscv
Hello: This patch was applied to riscv/linux.git (for-next) by Palmer Dabbelt : On Thu, 13 Jun 2024 19:13:47 +0800 you wrote: > Since commit 7caa9765465f60 ("ftrace: riscv: move from REGS to ARGS"), > kprobe on ftrace is not supported by riscv, because riscv's support for > FTRACE_WITH_REGS has

Re: [PATCH] module: Add hard dependencies as syntactic sugar

2024-07-25 Thread Steven Price
On 25/07/2024 12:37, Dragan Simic wrote: > Panfrost and Lima DRM drivers use devfreq to perform DVFS, which is supported > on the associated platforms, while using simple_ondemand devfreq governor by > default. This makes the simple_ondemand module a hard dependency for both > Panfrost and Lima,

Re: [PATCH 1/2] module: Split modules_install compression and in-kernel decompression

2024-07-25 Thread Petr Pavlu
On 7/22/24 12:23, Masahiro Yamada wrote: > On Mon, Jul 22, 2024 at 6:07 PM Petr Pavlu wrote: >> >> The kernel configuration allows specifying a module compression mode. If >> one is selected then each module gets compressed during >> 'make modules_install' and additionally one can also enable

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-25 Thread Michael S. Tsirkin
On Thu, Jul 25, 2024 at 01:31:19PM +0100, David Woodhouse wrote: > On Thu, 2024-07-25 at 08:29 -0400, Michael S. Tsirkin wrote: > > On Thu, Jul 25, 2024 at 01:27:49PM +0100, David Woodhouse wrote: > > > On Thu, 2024-07-25 at 08:17 -0400, Michael S. Tsirkin wrote: > > > > On Thu, Jul 25, 2024 at

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-25 Thread David Woodhouse
On Thu, 2024-07-25 at 08:29 -0400, Michael S. Tsirkin wrote: > On Thu, Jul 25, 2024 at 01:27:49PM +0100, David Woodhouse wrote: > > On Thu, 2024-07-25 at 08:17 -0400, Michael S. Tsirkin wrote: > > > On Thu, Jul 25, 2024 at 10:56:05AM +0100, David Woodhouse wrote: > > > > > Do you want to just help

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-25 Thread Michael S. Tsirkin
On Thu, Jul 25, 2024 at 01:27:49PM +0100, David Woodhouse wrote: > On Thu, 2024-07-25 at 08:17 -0400, Michael S. Tsirkin wrote: > > On Thu, Jul 25, 2024 at 10:56:05AM +0100, David Woodhouse wrote: > > > > Do you want to just help complete virtio-rtc then? Would be easier than > > > > trying to

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-25 Thread David Woodhouse
On Thu, 2024-07-25 at 08:17 -0400, Michael S. Tsirkin wrote: > On Thu, Jul 25, 2024 at 10:56:05AM +0100, David Woodhouse wrote: > > > Do you want to just help complete virtio-rtc then? Would be easier than > > > trying to keep two specs in sync. > > > > The ACPI version is much more lightweight

Re: [POC 5/7] livepatch: Convert klp module callbacks tests into livepatch module tests

2024-07-25 Thread Miroslav Benes
> diff --git a/lib/livepatch/test_klp_speaker.c > b/lib/livepatch/test_klp_speaker.c > index d2d31072639a..d8e42267f5cd 100644 > --- a/lib/livepatch/test_klp_speaker.c > +++ b/lib/livepatch/test_klp_speaker.c > @@ -9,23 +9,174 @@ > > #include > #include > +#include > +#include > + >

Re: [RFC v11 04/14] mm: page_frag: add '_va' suffix to page_frag API

2024-07-25 Thread Yunsheng Lin
On 2024/7/22 4:41, Alexander Duyck wrote: > On Fri, Jul 19, 2024 at 2:37 AM Yunsheng Lin wrote: >> >> Currently the page_frag API is returning 'virtual address' >> or 'va' when allocing and expecting 'virtual address' or >> 'va' as input when freeing. >> >> As we are about to support new use

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-25 Thread Michael S. Tsirkin
On Thu, Jul 25, 2024 at 10:56:05AM +0100, David Woodhouse wrote: > > Do you want to just help complete virtio-rtc then? Would be easier than > > trying to keep two specs in sync. > > The ACPI version is much more lightweight and doesn't take up a > valuable PCI slot#. (I know, you can do virtio

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-25 Thread Daniel P . Berrangé
On Thu, Jul 25, 2024 at 12:53:34PM +0100, David Woodhouse wrote: > On Thu, 2024-07-25 at 12:31 +0100, Daniel P. Berrangé wrote: > > On Thu, Jul 25, 2024 at 10:56:05AM +0100, David Woodhouse wrote: > > > Hi Michael, thanks for the review! > > > > > > On Thu, 2024-07-25 at 01:48 -0400, Michael S.

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-25 Thread David Woodhouse
On Thu, 2024-07-25 at 12:31 +0100, Daniel P. Berrangé wrote: > On Thu, Jul 25, 2024 at 10:56:05AM +0100, David Woodhouse wrote: > > Hi Michael, thanks for the review! > > > > On Thu, 2024-07-25 at 01:48 -0400, Michael S. Tsirkin wrote: > > > Do you want to just help complete virtio-rtc then?

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-25 Thread David Woodhouse
On Thu, 2024-07-25 at 13:20 +0200, Paolo Abeni wrote: > > > Just a bunch of 'nits below Thank you. Fixed in https://git.infradead.org/users/dwmw2/linux.git/shortlog/refs/heads/vmclock I'll post a new version once I've finished resolving mst's and any other feedback. smime.p7s Description:

Re: [POC 3/7] livepatch: Use per-state callbacks in state API tests

2024-07-25 Thread Miroslav Benes
Hi, On Fri, 10 Nov 2023, Petr Mladek wrote: > Recent changes in the livepatch core have allowed to connect states, > shadow variables, and callbacks. Use these new features in > the state tests. > > Use the shadow variable API to store the original loglevel. It is > better suited for this

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-25 Thread Daniel P . Berrangé
On Thu, Jul 25, 2024 at 10:56:05AM +0100, David Woodhouse wrote: > Hi Michael, thanks for the review! > > On Thu, 2024-07-25 at 01:48 -0400, Michael S. Tsirkin wrote: > > On Wed, Jul 24, 2024 at 06:16:37PM +0100, David Woodhouse wrote: > > > From: David Woodhouse > > > > > > The vmclock

Re: [POC 2/7] livepatch: Allow to handle lifetime of shadow variables using the livepatch state

2024-07-25 Thread Miroslav Benes
> diff --git a/kernel/livepatch/state.c b/kernel/livepatch/state.c > index 6693d808106b..4ec65afe3a43 100644 > --- a/kernel/livepatch/state.c > +++ b/kernel/livepatch/state.c > @@ -198,11 +198,17 @@ void klp_release_states(struct klp_patch *patch) > if

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-25 Thread Paolo Abeni
Hi, Just a bunch of 'nits below On 7/24/24 19:16, David Woodhouse wrote: diff --git a/drivers/ptp/ptp_vmclock.c b/drivers/ptp/ptp_vmclock.c new file mode 100644 index ..9c508c21c062 --- /dev/null +++ b/drivers/ptp/ptp_vmclock.c [...] +/* + * Multiply a 64-bit count by a 64-bit

Re: [PATCH v2 06/11] arm64: dts: qcom: sm6115-pro1x: Enable MDSS and GPU

2024-07-25 Thread Konrad Dybcio
On 25.07.2024 3:42 AM, Dang Huynh wrote: > Fxtec Pro1x uses the same display (BOE BF060Y8M-AJ0) as Pro1. > > Signed-off-by: Dang Huynh > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v2 05/11] arm64: dts: qcom: sm6115-pro1x: Enable SD card slot

2024-07-25 Thread Konrad Dybcio
On 25.07.2024 3:42 AM, Dang Huynh wrote: > Fxtec Pro1X has two card slots and allow either 2xSIM cards or > 1xSIM, 1xSD Card configuration. > > Signed-off-by: Dang Huynh > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v2 04/11] arm64: dts: qcom: sm6115-pro1x: Add Caps Lock LED

2024-07-25 Thread Konrad Dybcio
On 25.07.2024 3:42 AM, Dang Huynh wrote: > The Pro1X has a caps lock LED on the keyboard. > > Signed-off-by: Dang Huynh > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v2 11/11] arm64: dts: qcom: sm6115-pro1x: Enable ATH10K WLAN

2024-07-25 Thread Konrad Dybcio
On 25.07.2024 3:42 AM, Dang Huynh wrote: > Enable onboard Wi-Fi on the F(x)tec Pro1X. > > For reference, HW/SW identifies as: > qmi chip_id 0x120 chip_family 0x4007 board_id 0xff soc_id 0x4067 > qmi fw_version 0x324103d6 fw_build_timestamp 2021-12-02 08:20 > fw_build_id

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-25 Thread David Woodhouse
On Thu, 2024-07-25 at 01:54 -0400, Michael S. Tsirkin wrote: > one other thing worth mentioning is that this design can't work > with confidential computing setups. By comparison, mapping e.g. a > range in a PCI BAR would work for these setups. Why so? This is just like mapping a PCI BAR, isn't

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-25 Thread David Woodhouse
Hi Michael, thanks for the review! On Thu, 2024-07-25 at 01:48 -0400, Michael S. Tsirkin wrote: > On Wed, Jul 24, 2024 at 06:16:37PM +0100, David Woodhouse wrote: > > From: David Woodhouse > > > > The vmclock "device" provides a shared memory region with precision clock > > information. By

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-24 Thread Michael S. Tsirkin
On Wed, Jul 24, 2024 at 06:16:37PM +0100, David Woodhouse wrote: > From: David Woodhouse > > The vmclock "device" provides a shared memory region with precision clock > information. By using shared memory, it is safe across Live Migration. > > Like the KVM PTP clock, this can convert TSC-based

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-24 Thread Michael S. Tsirkin
On Wed, Jul 24, 2024 at 06:16:37PM +0100, David Woodhouse wrote: > From: David Woodhouse > > The vmclock "device" provides a shared memory region with precision clock > information. By using shared memory, it is safe across Live Migration. > > Like the KVM PTP clock, this can convert TSC-based

Re: [PATCH v4 1/3] x86/sgx: Split SGX_ENCL_PAGE_BEING_RECLAIMED into two flags

2024-07-24 Thread Huang, Kai
On 5/07/2024 7:45 pm, Dmitrii Kuvaiskii wrote: SGX_ENCL_PAGE_BEING_RECLAIMED flag is set when the enclave page is being reclaimed (moved to the backing store). This flag however has two logical meanings: 1. Don't attempt to load the enclave page (the page is busy). 2. Don't attempt to remove

Re: [PATCH v4 3/3] x86/sgx: Resolve EREMOVE page vs EAUG page data race

2024-07-24 Thread Huang, Kai
On 5/07/2024 7:45 pm, Dmitrii Kuvaiskii wrote: Two enclave threads may try to add and remove the same enclave page simultaneously (e.g., if the SGX runtime supports both lazy allocation and MADV_DONTNEED semantics). Consider some enclave page added to the enclave. User space decides to

Re: [PATCH v4 2/3] x86/sgx: Resolve EAUG race where losing thread returns SIGBUS

2024-07-24 Thread Huang, Kai
if (ret) goto err_out_shrink; And this patch actually does that. But instead of using xa_insert() to detect such case, where we have done bunch of things and needs to revert of all them if xa_insert() fails, could we just re-check the encl_page inside the encl->lock

Re: [PATCH bpf-next v2 2/2] bpf: allow bpf_current_task_under_cgroup() with BPF_CGROUP_*

2024-07-24 Thread Andrii Nakryiko
On Mon, Jul 22, 2024 at 6:29 PM wrote: > > From: Matteo Croce > > The helper bpf_current_task_under_cgroup() currently is only allowed for > tracing programs. > Allow its usage also in the BPF_CGROUP_* program types. > Move the code from kernel/trace/bpf_trace.c to kernel/bpf/helpers.c, > so it

Re: [PATCH bpf-next v2 1/2] bpf: enable generic kfuncs for BPF_CGROUP_* programs

2024-07-24 Thread Andrii Nakryiko
On Mon, Jul 22, 2024 at 6:28 PM wrote: > > From: Matteo Croce > > These kfuncs are enabled even in BPF_PROG_TYPE_TRACING, so they > should be safe also in BPF_CGROUP_* programs. > > Signed-off-by: Matteo Croce > --- > kernel/bpf/helpers.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff

Re: [PATCH bpf-next 1/2] bpf: implement bpf_send_signal_pid/tgid() helpers

2024-07-24 Thread Alexei Starovoitov
On Wed, Jul 24, 2024 at 4:40 AM Puranjay Mohan wrote: > > Implement bpf_send_signal_pid and bpf_send_signal_tgid helpers which are > similar to bpf_send_signal_thread and bpf_send_signal helpers > respectively but can be used to send signals to other threads and > processes. Thanks for working

Re: [PATCH v2] remoteproc: xlnx: add sram support

2024-07-24 Thread Tanmay Shah
Hello Mathieu, Thanks for reviews. All the comments looks good, I will send next revision addressing them all. On 7/22/24 11:39 AM, Mathieu Poirier wrote: > Good morning, > > On Mon, Jul 15, 2024 at 06:39:54PM -0700, Tanmay Shah wrote: >> AMD-Xilinx zynqmp platform contains on-chip sram memory

Re: [PATCH] arm64: dts: qcom: msm8916-samsung-fortuna: Add touch keys

2024-07-24 Thread Konrad Dybcio
On 24.07.2024 4:32 PM, Raymond Hackley wrote: > Touch keys feature on fortuna phones are provided by Zinitix touchscreen. > Add property linux,keycodes to enable touch keys. > > Signed-off-by: Raymond Hackley > --- please bump the revision (v1 -> v2) when changing the commit message and keep a

Re: [PATCH v6 0/3] Clean up usage of rt_task()

2024-07-24 Thread Qais Yousef
On 06/10/24 20:20, Qais Yousef wrote: > Make rt_task() return true only for RT class and add new realtime_task() to > return true for RT and DL classes to avoid some confusion the old API can > cause. I am not aware of any pending review comments for this series. Is it ready to be picked up?

Re: [PATCH] rust: add `module_params` macro

2024-07-24 Thread Sami Tolvanen
Hi Luis, On Thu, Jul 18, 2024 at 5:15 PM Luis Chamberlain wrote: > > On Tue, Jul 09, 2024 at 12:08:16PM +0200, Miguel Ojeda wrote: > > On Mon, Jul 8, 2024 at 11:42 PM Luis Chamberlain wrote: > > > > > > The rationale here is that a rust binding means commitment then also > > > from fresh blood

Re: [PATCH] livepatch: Add using attribute to klp_func for using func show

2024-07-24 Thread zhang warden
Hi Petr! > The value is useless when the transition is in progress. > You simply do not know which variant is used in this case. > Yes, I agree that if the patch is in transition, we can not know which version of this function is running by one task. As my previous explanation, each patch

Re: [PATCH] livepatch: Add using attribute to klp_func for using func show

2024-07-24 Thread Petr Mladek
On Sat 2024-07-20 13:56:56, zhang warden wrote: > > > is this always correct though? See the logic in klp_ftrace_handler(). If > > there is a transition running, it is a little bit more complicated. > > > > Miroslav > > Hi! Miroslav. > > In reality, we often encounter such situation that

Re: [PATCH] arm64: dts: qcom: msm8916-samsung-fortuna: Enable the touchkeys

2024-07-24 Thread Raymond Hackley
> See the "In case your patch fixes a bug.." paragraph in: > > https://docs.kernel.org/process/submitting-patches.html Hi Konrad, the point is not to fix a bug, but to add touchkeys support instead. I will reword the patch when it's confusing. Regards, Raymond

Re: [PATCH] tools/virtio:Fix the wrong format specifier

2024-07-24 Thread Michael S. Tsirkin
On Wed, Jul 24, 2024 at 12:41:08AM -0700, Zhu Jun wrote: > The unsigned int should use "%u" instead of "%d". > > Signed-off-by: Zhu Jun which matters why? > --- > tools/virtio/ringtest/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH] tools/virtio:Fix the wrong format specifier

2024-07-24 Thread Eugenio Perez Martin
On Wed, Jul 24, 2024 at 9:44 AM Zhu Jun wrote: > > The unsigned int should use "%u" instead of "%d". > > Signed-off-by: Zhu Jun Reviewed-by: Eugenio Pérez Thanks! > --- > tools/virtio/ringtest/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH 1/2] uprobe: Change uretprobe syscall scope and number

2024-07-24 Thread Arnd Bergmann
On Wed, Jul 24, 2024, at 09:46, Dmitry V. Levin wrote: > On Fri, Jul 12, 2024 at 03:52:27PM +0200, Jiri Olsa wrote: >> diff --git a/arch/x86/entry/syscalls/syscall_64.tbl >> b/arch/x86/entry/syscalls/syscall_64.tbl >> index 6452c2ec469a..dabf1982de6d 100644 >> ---

Re: [PATCH 1/2] uprobe: Change uretprobe syscall scope and number

2024-07-24 Thread Dmitry V. Levin
On Fri, Jul 12, 2024 at 03:52:27PM +0200, Jiri Olsa wrote: > After discussing with Arnd [1] it's preferable to change uretprobe > syscall number to 467 to omit the merge conflict with xattrat syscalls. > > Also changing the ABI to 'common' which will ease up the global > scripts/syscall.tbl

Re: [PATCH v2 1/5] kallsyms: Emit symbol at the holes in the text

2024-07-23 Thread kernel test robot
Hi Zheng, kernel test robot noticed the following build warnings: [auto build test WARNING on linus/master] [also build test WARNING on v6.10] [cannot apply to mcgrof/modules-next masahiroy-kbuild/for-next masahiroy-kbuild/fixes powerpc/next powerpc/fixes tip/x86/core next-20240723] [If your

Re: [PATCH 2/2] LoongArch: KVM: Add paravirt qspinlock in guest side

2024-07-23 Thread kernel test robot
Hi Bibo, kernel test robot noticed the following build warnings: [auto build test WARNING on 7846b618e0a4c3e0099d1d4512722b39ca99] url: https://github.com/intel-lab-lkp/linux/commits/Bibo-Mao/LoongArch-KVM-Add-paravirt-qspinlock-in-kvm-side/20240723-160536 base:

Re: [PATH v5 1/3] vdpa: support set mac address from vdpa tool

2024-07-23 Thread Cindy Lu
On Wed, 24 Jul 2024 at 02:48, Andrew Lunn wrote: > > On Tue, Jul 23, 2024 at 01:39:20PM +0800, Cindy Lu wrote: > > Add new UAPI to support the mac address from vdpa tool > > Function vdpa_nl_cmd_dev_attr_set_doit() will get the > > new MAC address from the vdpa tool and then set it to the device.

Re: [PATH v5 3/3] vdpa/mlx5: Add the support of set mac address

2024-07-23 Thread Cindy Lu
On Tue, 23 Jul 2024 at 19:29, Michael S. Tsirkin wrote: > > On Tue, Jul 23, 2024 at 07:49:44AM +, Dragos Tatulea wrote: > > On Tue, 2024-07-23 at 13:39 +0800, Cindy Lu wrote: > > > Add the function to support setting the MAC address. > > > For vdpa/mlx5, the function will use

Re: [PATH v5 0/3] vdpa: support set mac address from vdpa tool

2024-07-23 Thread Cindy Lu
On Wed, 24 Jul 2024 at 02:45, Andrew Lunn wrote: > > On Tue, Jul 23, 2024 at 01:39:19PM +0800, Cindy Lu wrote: > > Add support for setting the MAC address using the VDPA tool. > > This feature will allow setting the MAC address using the VDPA tool. > > For example, in vdpa_sim_net, the

Re: [PATCH v2 1/5] kallsyms: Emit symbol at the holes in the text

2024-07-23 Thread kernel test robot
Hi Zheng, kernel test robot noticed the following build warnings: [auto build test WARNING on linus/master] [also build test WARNING on v6.10] [cannot apply to mcgrof/modules-next masahiroy-kbuild/for-next masahiroy-kbuild/fixes powerpc/next powerpc/fixes tip/x86/core next-20240723] [If your

Re: [PATCH 2/2] LoongArch: KVM: Add paravirt qspinlock in guest side

2024-07-23 Thread maobibo
On 2024/7/24 上午3:57, kernel test robot wrote: Hi Bibo, kernel test robot noticed the following build errors: yes, forgot to mention, it depends on this patch https://lore.kernel.org/lkml/20240721164552.50175-1-ubiz...@gmail.com/ Regards Bibo Mao [auto build test ERROR on

Re: [PATCH] eventfs: Use SRCU for freeing eventfs_inodes

2024-07-23 Thread Steven Rostedt
On Tue, 23 Jul 2024 23:07:53 +0200 Mathias Krause wrote: > To mirror the SRCU lock held in eventfs_iterate() when iterating over > eventfs inodes, use call_srcu() to free them too. > > This was accidentally(?) degraded to RCU in commit 43aa6f97c2d0 > ("eventfs: Get rid of dentry pointers

Re: [GIT PULL] rpmsg updates for v6.11

2024-07-23 Thread pr-tracker-bot
The pull request you sent on Tue, 23 Jul 2024 12:17:49 -0700: > https://git.kernel.org/pub/scm/linux/kernel/git/remoteproc/linux.git > tags/rpmsg-v6.11 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/643af93f15be901982b2b08f241263934201c99f Thank you! --

Re: [GIT PULL] hwspinlock updates for v6.11

2024-07-23 Thread pr-tracker-bot
The pull request you sent on Tue, 23 Jul 2024 10:20:47 -0700: > https://git.kernel.org/pub/scm/linux/kernel/git/remoteproc/linux.git > tags/hwlock-v6.11 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/58bffbac533d4526cb4922b8563d1963a90729be Thank you! --

Re: [GIT PULL] remoteproc updates for v6.11

2024-07-23 Thread pr-tracker-bot
The pull request you sent on Tue, 23 Jul 2024 11:30:41 -0700: > https://git.kernel.org/pub/scm/linux/kernel/git/remoteproc/linux.git > tags/rproc-v6.11 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/60c6119cadba52bee86b3e88011495483e26eb43 Thank you! --

Re: tracing: user events UAF crash report

2024-07-23 Thread Mathias Krause
On 23.07.24 16:43, Steven Rostedt wrote: > On Fri, 19 Jul 2024 22:47:01 +0200 > Mathias Krause wrote: > >> Beside the obvious bug, I noticed the following (not fixing the issue, >> tho): >> >> diff --git a/fs/tracefs/event_inode.c b/fs/tracefs/event_inode.c >> index 5d88c184f0fc..687ad0a26458

Re: [PATCH 2/2] LoongArch: KVM: Add paravirt qspinlock in guest side

2024-07-23 Thread kernel test robot
Hi Bibo, kernel test robot noticed the following build errors: [auto build test ERROR on 7846b618e0a4c3e0099d1d4512722b39ca99] url: https://github.com/intel-lab-lkp/linux/commits/Bibo-Mao/LoongArch-KVM-Add-paravirt-qspinlock-in-kvm-side/20240723-160536 base:

Re: [GIT PULL] livepatching for 6.11

2024-07-23 Thread pr-tracker-bot
The pull request you sent on Tue, 23 Jul 2024 17:46:20 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/livepatching/livepatching > tags/livepatching-for-6.11 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/d2d721e2eb1337c67f0c5bba303f8a013b622bed Thank you!

Re: [GIT PULL] Modules changes for v6.11-rc1

2024-07-23 Thread pr-tracker-bot
The pull request you sent on Tue, 23 Jul 2024 10:14:01 -0700: > git://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/ > tags/modules-6.11-rc1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/f488790059fe7be6b2b059ddee10835b2500b603 Thank you! --

Re: [PATCH v2] lib: test_objpool: add missing MODULE_DESCRIPTION() macro

2024-07-23 Thread Jeff Johnson
On 7/15/2024 7:18 AM, Jeff Johnson wrote: > make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_objpool.o > > Add the missing invocation of the MODULE_DESCRIPTION() macro. > > Reviewed-by: Matt Wu > Signed-off-by: Jeff Johnson > --- > Changes

Re: [PATH v5 2/3] vdpa_sim_net: Add the support of set mac address

2024-07-23 Thread Andrew Lunn
> +static int vdpasim_net_set_attr(struct vdpa_mgmt_dev *mdev, > + struct vdpa_device *dev, > + const struct vdpa_dev_set_config *config) > +{ > + struct vdpasim *vdpasim = container_of(dev, struct vdpasim, vdpa); > + struct

Re: [PATH v5 1/3] vdpa: support set mac address from vdpa tool

2024-07-23 Thread Andrew Lunn
On Tue, Jul 23, 2024 at 01:39:20PM +0800, Cindy Lu wrote: > Add new UAPI to support the mac address from vdpa tool > Function vdpa_nl_cmd_dev_attr_set_doit() will get the > new MAC address from the vdpa tool and then set it to the device. > > The usage is: vdpa dev set name vdpa_name mac

Re: [PATH v5 0/3] vdpa: support set mac address from vdpa tool

2024-07-23 Thread Andrew Lunn
On Tue, Jul 23, 2024 at 01:39:19PM +0800, Cindy Lu wrote: > Add support for setting the MAC address using the VDPA tool. > This feature will allow setting the MAC address using the VDPA tool. > For example, in vdpa_sim_net, the implementation sets the MAC address > to the config space. However,

Re: [PATCH] rpmsg: char: add missing MODULE_DESCRIPTION() macro

2024-07-23 Thread Jeff Johnson
On 6/10/2024 10:25 AM, Mathieu Poirier wrote: > On Tue, Jun 04, 2024 at 06:53:44PM -0700, Jeff Johnson wrote: >> make allmodconfig && make W=1 C=1 reports: >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/rpmsg/rpmsg_char.o >> >> Add the missing invocation of the MODULE_DESCRIPTION()

Re: tracing: user events UAF crash report

2024-07-23 Thread Steven Rostedt
On Fri, 19 Jul 2024 22:47:01 +0200 Mathias Krause wrote: > Beside the obvious bug, I noticed the following (not fixing the issue, > tho): > > diff --git a/fs/tracefs/event_inode.c b/fs/tracefs/event_inode.c > index 5d88c184f0fc..687ad0a26458 100644 > --- a/fs/tracefs/event_inode.c > +++

Re: [PATCH] arm64: dts: qcom: msm8916-samsung-fortuna: Enable the touchkeys

2024-07-23 Thread Konrad Dybcio
On 23.07.2024 3:39 PM, Raymond Hackley wrote: >> Fixes? >> >> Konrad > > Hi Konrad, > > the issue is not reported or discussed on lkml, so there is no thread to fix? See the "In case your patch fixes a bug.." paragraph in: https://docs.kernel.org/process/submitting-patches.html > > Regards, >

Re: [PATCH] arm64: dts: qcom: msm8916-samsung-fortuna: Enable the touchkeys

2024-07-23 Thread Raymond Hackley
> Fixes? > > Konrad Hi Konrad, the issue is not reported or discussed on lkml, so there is no thread to fix? Regards, Raymond

Re: [PATCH] arm64: dts: qcom: msm8916-samsung-rossa: Add touchscreen

2024-07-23 Thread Konrad Dybcio
On 23.07.2024 3:15 PM, Raymond Hackley wrote: > Core Prime uses an Imagis IST3038 touchscreen that is connected to > blsp_i2c5. Add it to the device tree. > > Signed-off-by: Raymond Hackley > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH] arm64: dts: qcom: msm8916-samsung-rossa: Add touchscreen

2024-07-23 Thread Raymond Hackley
Tested-by: Juan-Rafael Fernandez Regards, Raymond

Re: [PATCH] arm64: dts: qcom: msm8916-samsung-fortuna: Enable the touchkeys

2024-07-23 Thread Konrad Dybcio
On 23.07.2024 3:12 PM, Raymond Hackley wrote: > The phone needs the touchkeys to be enabled so the sense lines of the > touch controller are mapped properly. Otherwise the touchscreen is not > mapped to the display properly. > > Signed-off-by: Raymond Hackley > --- Fixes? Konrad

Re: [PATCH v3 7/9] dt-bindings: interconnect: qcom: msm8939: Fix example

2024-07-23 Thread Konrad Dybcio
On 9.07.2024 12:22 PM, Adam Skladowski wrote: > For now example list snoc_mm as children of bimc which is obviously > not valid, drop bimc and move snoc_mm into snoc. > > Signed-off-by: Adam Skladowski > --- loool, thanks Reviewed-by: Konrad Dybcio Konrad

Re: [PATH v5 3/3] vdpa/mlx5: Add the support of set mac address

2024-07-23 Thread Michael S. Tsirkin
On Tue, Jul 23, 2024 at 07:49:44AM +, Dragos Tatulea wrote: > On Tue, 2024-07-23 at 13:39 +0800, Cindy Lu wrote: > > Add the function to support setting the MAC address. > > For vdpa/mlx5, the function will use mlx5_mpfs_add_mac > > to set the mac address > > > > Tested in ConnectX-6 Dx

<    1   2   3   4   5   6   7   8   9   10   >