Re: Re : Re: Re: Re : Re: [PATCH] Squashfs: add asynchronous read support

2013-12-22 Thread Minchan Kim
On Mon, Dec 23, 2013 at 12:03:39PM +0900, Chanho Min wrote: > > > > read_pages > > for(page_idx ...) { > > if (!add_to_page_cache_lru)) { <-- 1) > > mapping->a_ops->readpage(filp, page) > > squashfs_readpage > > for (i ...) { 2) Here, 31 pages are inserted into

Re : Re: Re: Re : Re: [PATCH] Squashfs: add asynchronous read support

2013-12-22 Thread Chanho Min
> read_pages > for(page_idx ...) { > if (!add_to_page_cache_lru)) { <-- 1) > mapping->a_ops->readpage(filp, page) > squashfs_readpage > for (i ...) { 2) Here, 31 pages are inserted into page cache > grab_cahe_page_nowait <--/ >

Re: Re: Re : Re: [PATCH] Squashfs: add asynchronous read support

2013-12-22 Thread Minchan Kim
On Sat, Dec 21, 2013 at 11:05:51AM +0900, Chanho Min wrote: > > > Please don't break thread. > > You should reply to my mail instead of your original post. > Sorry, It seems to be my mailer issue. I'm trying to fix it. > > > It's a result which isn't what I want to know. > > What I wnat to know

Re: Re: Re : Re: [PATCH] Squashfs: add asynchronous read support

2013-12-22 Thread Minchan Kim
On Sat, Dec 21, 2013 at 11:05:51AM +0900, Chanho Min wrote: Please don't break thread. You should reply to my mail instead of your original post. Sorry, It seems to be my mailer issue. I'm trying to fix it. It's a result which isn't what I want to know. What I wnat to know is why

Re : Re: Re: Re : Re: [PATCH] Squashfs: add asynchronous read support

2013-12-22 Thread Chanho Min
read_pages for(page_idx ...) { if (!add_to_page_cache_lru)) { -- 1) mapping-a_ops-readpage(filp, page) squashfs_readpage for (i ...) { 2) Here, 31 pages are inserted into page cache grab_cahe_page_nowait --/

Re: Re : Re: Re: Re : Re: [PATCH] Squashfs: add asynchronous read support

2013-12-22 Thread Minchan Kim
On Mon, Dec 23, 2013 at 12:03:39PM +0900, Chanho Min wrote: read_pages for(page_idx ...) { if (!add_to_page_cache_lru)) { -- 1) mapping-a_ops-readpage(filp, page) squashfs_readpage for (i ...) { 2) Here, 31 pages are inserted into page cache

Re: Re: Re : Re: [PATCH] Squashfs: add asynchronous read support

2013-12-20 Thread Chanho Min
> Please don't break thread. > You should reply to my mail instead of your original post. Sorry, It seems to be my mailer issue. I'm trying to fix it. > It's a result which isn't what I want to know. > What I wnat to know is why upper layer issues more I/O per second. > For example, you read 32K

Re: Re: Re : Re: [PATCH] Squashfs: add asynchronous read support

2013-12-20 Thread Chanho Min
Please don't break thread. You should reply to my mail instead of your original post. Sorry, It seems to be my mailer issue. I'm trying to fix it. It's a result which isn't what I want to know. What I wnat to know is why upper layer issues more I/O per second. For example, you read 32K so

Re: Re : Re: [PATCH] Squashfs: add asynchronous read support

2013-12-17 Thread Minchan Kim
Hello, Please don't break thread. You should reply to my mail instead of your original post. On Wed, Dec 18, 2013 at 01:29:37PM +0900, Chanho Min wrote: > > > I did test it on x86 with USB stick and ARM with eMMC on my Nexus 4. > > In experiment, I couldn't see much gain like you both system

Re : Re: [PATCH] Squashfs: add asynchronous read support

2013-12-17 Thread Chanho Min
> I did test it on x86 with USB stick and ARM with eMMC on my Nexus 4. > In experiment, I couldn't see much gain like you both system and even it > was regressed at bs=32k test, maybe workqueue allocation/schedule of work > per I/O. > Your test is rather special or what I am missing? Can you

Re : Re: [PATCH] Squashfs: add asynchronous read support

2013-12-17 Thread Chanho Min
I did test it on x86 with USB stick and ARM with eMMC on my Nexus 4. In experiment, I couldn't see much gain like you both system and even it was regressed at bs=32k test, maybe workqueue allocation/schedule of work per I/O. Your test is rather special or what I am missing? Can you specify

Re: Re : Re: [PATCH] Squashfs: add asynchronous read support

2013-12-17 Thread Minchan Kim
Hello, Please don't break thread. You should reply to my mail instead of your original post. On Wed, Dec 18, 2013 at 01:29:37PM +0900, Chanho Min wrote: I did test it on x86 with USB stick and ARM with eMMC on my Nexus 4. In experiment, I couldn't see much gain like you both system and