Re: Regression: commit "ide: constify struct ide_port_info" causes breakage

2007-10-26 Thread Bartlomiej Zolnierkiewicz
On Friday 26 October 2007, Russell King wrote: > commit 8562043606430185cad26d085d46adcc7ad67fd1 is broken, causing: > > CC drivers/ide/pci/cmd64x.o > CC drivers/ide/pci/hpt366.o > drivers/ide/pci/hpt366.c:1428: error: hpt366_chipsets causes a section type > conflict > > and theref

Re: Regression: commit "ide: constify struct ide_port_info" causes breakage

2007-10-26 Thread Arjan van de Ven
On Fri, 26 Oct 2007 09:30:20 -0700 (PDT) Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > On Fri, 26 Oct 2007, Sergei Shtylyov wrote: > > > >We can just convert cariables declared as 'struct hpt_info' to > > const too -- they are read-only templates. > > Generally "__devinitdata" is better

Re: Regression: commit "ide: constify struct ide_port_info" causes breakage

2007-10-26 Thread Sergei Shtylyov
Hello. Linus Torvalds wrote: We can just convert cariables declared as 'struct hpt_info' to const too -- they are read-only templates. Generally "__devinitdata" is better than "const", since it means that the data may be thrown away. Agreed. So if you drop one over the other, N

Re: Regression: commit "ide: constify struct ide_port_info" causes breakage

2007-10-26 Thread Linus Torvalds
On Fri, 26 Oct 2007, Sergei Shtylyov wrote: > >We can just convert cariables declared as 'struct hpt_info' to const too > -- > they are read-only templates. Generally "__devinitdata" is better than "const", since it means that the data may be thrown away. So if you drop one over the oth

Re: Regression: commit "ide: constify struct ide_port_info" causes breakage

2007-10-26 Thread Linus Torvalds
On Fri, 26 Oct 2007, Russell King wrote: > > commit 8562043606430185cad26d085d46adcc7ad67fd1 is broken, causing: > > CC drivers/ide/pci/cmd64x.o > CC drivers/ide/pci/hpt366.o > drivers/ide/pci/hpt366.c:1428: error: hpt366_chipsets causes a section type > conflict > > and therefor

Re: Regression: commit "ide: constify struct ide_port_info" causes breakage

2007-10-26 Thread Sergei Shtylyov
Hello. Russell King wrote: commit 8562043606430185cad26d085d46adcc7ad67fd1 is broken, causing: CC drivers/ide/pci/cmd64x.o CC drivers/ide/pci/hpt366.o drivers/ide/pci/hpt366.c:1428: error: hpt366_chipsets causes a section type conflict and therefore should be reverted. The

Regression: commit "ide: constify struct ide_port_info" causes breakage

2007-10-26 Thread Russell King
commit 8562043606430185cad26d085d46adcc7ad67fd1 is broken, causing: CC drivers/ide/pci/cmd64x.o CC drivers/ide/pci/hpt366.o drivers/ide/pci/hpt366.c:1428: error: hpt366_chipsets causes a section type conflict and therefore should be reverted. The problem arises because hpt366 has