Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On 29-05-18, 07:17, Marek Szyprowski wrote: > Hi Vinod, > > On 2018-05-18 09:21, Vinod wrote: > > On 18-05-18, 08:28, Marek Szyprowski wrote: > >> Hi Vinod, > >> > >> Okay, I see that in theory, there are some tricky bits in implementing DMA > >> support in UART drivers. On the other hand there

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On 29-05-18, 07:17, Marek Szyprowski wrote: > Hi Vinod, > > On 2018-05-18 09:21, Vinod wrote: > > On 18-05-18, 08:28, Marek Szyprowski wrote: > >> Hi Vinod, > >> > >> Okay, I see that in theory, there are some tricky bits in implementing DMA > >> support in UART drivers. On the other hand there

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

Hi Vinod, On 2018-05-18 09:21, Vinod wrote: > On 18-05-18, 08:28, Marek Szyprowski wrote: >> Hi Vinod, >> >> Okay, I see that in theory, there are some tricky bits in implementing DMA >> support in UART drivers. On the other hand there are already drivers >> with seems >> to be working fine. This

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

Hi Vinod, On 2018-05-18 09:21, Vinod wrote: > On 18-05-18, 08:28, Marek Szyprowski wrote: >> Hi Vinod, >> >> Okay, I see that in theory, there are some tricky bits in implementing DMA >> support in UART drivers. On the other hand there are already drivers >> with seems >> to be working fine. This

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On 22-05-18, 10:27, Frank Mori Hess wrote: > On Mon, May 21, 2018 at 11:37 PM, Vinod Koul wrote: > > > > Well looks like even adding support for sync_pause doesn't solve your issue > > on > > pl330. Do you want to move this to PIO mode then..? The issue for which you

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On 22-05-18, 10:27, Frank Mori Hess wrote: > On Mon, May 21, 2018 at 11:37 PM, Vinod Koul wrote: > > > > Well looks like even adding support for sync_pause doesn't solve your issue > > on > > pl330. Do you want to move this to PIO mode then..? The issue for which you requested the revert of

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On Mon, May 21, 2018 at 11:37 PM, Vinod Koul wrote: > > Well looks like even adding support for sync_pause doesn't solve your issue on > pl330. Do you want to move this to PIO mode then..? > I'm not sure what you think my issue is with the pl330, are you confusing me with

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On Mon, May 21, 2018 at 11:37 PM, Vinod Koul wrote: > > Well looks like even adding support for sync_pause doesn't solve your issue on > pl330. Do you want to move this to PIO mode then..? > I'm not sure what you think my issue is with the pl330, are you confusing me with Marek? My position is

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On 21-05-18, 20:56, Frank Mori Hess wrote: > On Mon, May 21, 2018 at 5:16 AM, Vinod Koul wrote: > >> > >> I understand the residue can't be read after terminate, that's why > >> reading the residue is step 2 in pause/residue/terminate. My question > >> was whether the

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On 21-05-18, 20:56, Frank Mori Hess wrote: > On Mon, May 21, 2018 at 5:16 AM, Vinod Koul wrote: > >> > >> I understand the residue can't be read after terminate, that's why > >> reading the residue is step 2 in pause/residue/terminate. My question > >> was whether the entire sequence

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On Mon, May 21, 2018 at 5:16 AM, Vinod Koul wrote: >> >> I understand the residue can't be read after terminate, that's why >> reading the residue is step 2 in pause/residue/terminate. My question >> was whether the entire sequence pause/residue/terminate taken as a >>

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On Mon, May 21, 2018 at 5:16 AM, Vinod Koul wrote: >> >> I understand the residue can't be read after terminate, that's why >> reading the residue is step 2 in pause/residue/terminate. My question >> was whether the entire sequence pause/residue/terminate taken as a >> whole can or cannot lose

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On 18-05-18, 14:56, Frank Mori Hess wrote: > On Fri, May 18, 2018 at 12:03 AM, Vinod wrote: > > > > You are simply mixing things up! > > It certainly feels like I'm mixed up. If I have to resolve this, I'd > like to be a little less mixed up before I submit more patches which

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On 18-05-18, 14:56, Frank Mori Hess wrote: > On Fri, May 18, 2018 at 12:03 AM, Vinod wrote: > > > > You are simply mixing things up! > > It certainly feels like I'm mixed up. If I have to resolve this, I'd > like to be a little less mixed up before I submit more patches which > are going to

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On Thu, May 17, 2018 at 1:22 PM, Lars-Peter Clausen wrote: > On 05/17/2018 06:20 PM, Frank Mori Hess wrote: > The problem is not so much on the software side but even more so on the > hardware side. Not all hardware even supports aborting a transfer with no > data loss because

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On Thu, May 17, 2018 at 1:22 PM, Lars-Peter Clausen wrote: > On 05/17/2018 06:20 PM, Frank Mori Hess wrote: > The problem is not so much on the software side but even more so on the > hardware side. Not all hardware even supports aborting a transfer with no > data loss because there is no precise

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On Fri, May 18, 2018 at 12:03 AM, Vinod wrote: > > You are simply mixing things up! It certainly feels like I'm mixed up. If I have to resolve this, I'd like to be a little less mixed up before I submit more patches which are going to inevitably result in subtly broken code

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On Fri, May 18, 2018 at 12:03 AM, Vinod wrote: > > You are simply mixing things up! It certainly feels like I'm mixed up. If I have to resolve this, I'd like to be a little less mixed up before I submit more patches which are going to inevitably result in subtly broken code suddenly becoming

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On 18-05-18, 08:28, Marek Szyprowski wrote: > Hi Vinod, > > Okay, I see that in theory, there are some tricky bits in implementing DMA > support in UART drivers. On the other hand there are already drivers > with seems > to be working fine. This discussion is about revert of the feature >

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On 18-05-18, 08:28, Marek Szyprowski wrote: > Hi Vinod, > > Okay, I see that in theory, there are some tricky bits in implementing DMA > support in UART drivers. On the other hand there are already drivers > with seems > to be working fine. This discussion is about revert of the feature >

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

Hi Vinod, On 2018-05-18 06:03, Vinod wrote: > On 17-05-18, 12:20, Frank Mori Hess wrote: >> Sorry to keep coming back to this, but I'm experiencing a bit of >> incredulity that you are saying what you seem to be saying. You seem >> to be saying dmaengine provides no way to permanently stop a

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

Hi Vinod, On 2018-05-18 06:03, Vinod wrote: > On 17-05-18, 12:20, Frank Mori Hess wrote: >> Sorry to keep coming back to this, but I'm experiencing a bit of >> incredulity that you are saying what you seem to be saying. You seem >> to be saying dmaengine provides no way to permanently stop a

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On 17-05-18, 12:20, Frank Mori Hess wrote: > Sorry to keep coming back to this, but I'm experiencing a bit of > incredulity that you are saying what you seem to be saying. You seem > to be saying dmaengine provides no way to permanently stop a transfer > safely other than transferring the full

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On 17-05-18, 12:20, Frank Mori Hess wrote: > Sorry to keep coming back to this, but I'm experiencing a bit of > incredulity that you are saying what you seem to be saying. You seem > to be saying dmaengine provides no way to permanently stop a transfer > safely other than transferring the full

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On 05/17/2018 06:20 PM, Frank Mori Hess wrote: > Sorry to keep coming back to this, but I'm experiencing a bit of > incredulity that you are saying what you seem to be saying. You seem > to be saying dmaengine provides no way to permanently stop a transfer > safely other than transferring the

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On 05/17/2018 06:20 PM, Frank Mori Hess wrote: > Sorry to keep coming back to this, but I'm experiencing a bit of > incredulity that you are saying what you seem to be saying. You seem > to be saying dmaengine provides no way to permanently stop a transfer > safely other than transferring the

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

Sorry to keep coming back to this, but I'm experiencing a bit of incredulity that you are saying what you seem to be saying. You seem to be saying dmaengine provides no way to permanently stop a transfer safely other than transferring the full number of bytes initially requested. So the proper

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

Sorry to keep coming back to this, but I'm experiencing a bit of incredulity that you are saying what you seem to be saying. You seem to be saying dmaengine provides no way to permanently stop a transfer safely other than transferring the full number of bytes initially requested. So the proper

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On 15-05-18, 11:50, Frank Mori Hess wrote: > On Tue, May 15, 2018 at 2:21 AM, Vinod wrote: > > > > For Pause/resume data loss is _not_ expected. > > > >> > and some of the 8250 drivers like 8250_dw.c set a maxburst > 1. If it > >> > can't count on the pause/residue/terminate

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On 15-05-18, 11:50, Frank Mori Hess wrote: > On Tue, May 15, 2018 at 2:21 AM, Vinod wrote: > > > > For Pause/resume data loss is _not_ expected. > > > >> > and some of the 8250 drivers like 8250_dw.c set a maxburst > 1. If it > >> > can't count on the pause/residue/terminate working without data

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On Tue, May 15, 2018 at 2:21 AM, Vinod wrote: > > For Pause/resume data loss is _not_ expected. > >> > and some of the 8250 drivers like 8250_dw.c set a maxburst > 1. If it >> > can't count on the pause/residue/terminate working without data loss >> > then it is just broken.

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On Tue, May 15, 2018 at 2:21 AM, Vinod wrote: > > For Pause/resume data loss is _not_ expected. > >> > and some of the 8250 drivers like 8250_dw.c set a maxburst > 1. If it >> > can't count on the pause/residue/terminate working without data loss >> > then it is just broken. As is the

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On 15-05-18, 14:24, Marek Szyprowski wrote: > Hi Vinod, > > On 2018-05-15 08:21, Vinod wrote: > > On 11-05-18, 14:57, Marek Szyprowski wrote: > >> On 2018-05-10 18:04, Frank Mori Hess wrote: > >>> On Thu, May 10, 2018 at 4:31 AM, Marek Szyprowski > >>> wrote: > On

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On 15-05-18, 14:24, Marek Szyprowski wrote: > Hi Vinod, > > On 2018-05-15 08:21, Vinod wrote: > > On 11-05-18, 14:57, Marek Szyprowski wrote: > >> On 2018-05-10 18:04, Frank Mori Hess wrote: > >>> On Thu, May 10, 2018 at 4:31 AM, Marek Szyprowski > >>> wrote: > On 2018-05-09 19:48, Frank

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

Hi Vinod, On 2018-05-15 08:21, Vinod wrote: > On 11-05-18, 14:57, Marek Szyprowski wrote: >> On 2018-05-10 18:04, Frank Mori Hess wrote: >>> On Thu, May 10, 2018 at 4:31 AM, Marek Szyprowski >>> wrote: On 2018-05-09 19:48, Frank Mori Hess wrote: > On Wed, May

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

Hi Vinod, On 2018-05-15 08:21, Vinod wrote: > On 11-05-18, 14:57, Marek Szyprowski wrote: >> On 2018-05-10 18:04, Frank Mori Hess wrote: >>> On Thu, May 10, 2018 at 4:31 AM, Marek Szyprowski >>> wrote: On 2018-05-09 19:48, Frank Mori Hess wrote: > On Wed, May 9, 2018 at 9:19 AM, Marek

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On 11-05-18, 14:57, Marek Szyprowski wrote: > Hi Frank, > > On 2018-05-10 18:04, Frank Mori Hess wrote: > > On Thu, May 10, 2018 at 4:31 AM, Marek Szyprowski > > wrote: > >> On 2018-05-09 19:48, Frank Mori Hess wrote: > >>> On Wed, May 9, 2018 at 9:19 AM, Marek

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On 11-05-18, 14:57, Marek Szyprowski wrote: > Hi Frank, > > On 2018-05-10 18:04, Frank Mori Hess wrote: > > On Thu, May 10, 2018 at 4:31 AM, Marek Szyprowski > > wrote: > >> On 2018-05-09 19:48, Frank Mori Hess wrote: > >>> On Wed, May 9, 2018 at 9:19 AM, Marek Szyprowski > >>> wrote: > I

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On Fri, May 11, 2018 at 8:57 AM, Marek Szyprowski wrote: > > Okay, so you don't have any evidence that DMA transfers done in single > reads/writes is broken with the current cmd_pause implementation. I think the easiest way to test this empirically would be to just hack

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On Fri, May 11, 2018 at 8:57 AM, Marek Szyprowski wrote: > > Okay, so you don't have any evidence that DMA transfers done in single > reads/writes is broken with the current cmd_pause implementation. I think the easiest way to test this empirically would be to just hack dmatest to do a bunch of

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

Hi Frank, On 2018-05-10 18:04, Frank Mori Hess wrote: > On Thu, May 10, 2018 at 4:31 AM, Marek Szyprowski > wrote: >> On 2018-05-09 19:48, Frank Mori Hess wrote: >>> On Wed, May 9, 2018 at 9:19 AM, Marek Szyprowski >>> wrote: I understand

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

Hi Frank, On 2018-05-10 18:04, Frank Mori Hess wrote: > On Thu, May 10, 2018 at 4:31 AM, Marek Szyprowski > wrote: >> On 2018-05-09 19:48, Frank Mori Hess wrote: >>> On Wed, May 9, 2018 at 9:19 AM, Marek Szyprowski >>> wrote: I understand that pl330 doesn't support real PAUSE, but as it

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On Thu, May 10, 2018 at 4:31 AM, Marek Szyprowski wrote: > Hi Frank, > > On 2018-05-09 19:48, Frank Mori Hess wrote: >> On Wed, May 9, 2018 at 9:19 AM, Marek Szyprowski >> wrote: >>> I understand that pl330 doesn't support real PAUSE, but as it

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On Thu, May 10, 2018 at 4:31 AM, Marek Szyprowski wrote: > Hi Frank, > > On 2018-05-09 19:48, Frank Mori Hess wrote: >> On Wed, May 9, 2018 at 9:19 AM, Marek Szyprowski >> wrote: >>> I understand that pl330 doesn't support real PAUSE, but as it has been >>> implemented since 2015 the limited

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

Hi Frank, On 2018-05-09 19:48, Frank Mori Hess wrote: > On Wed, May 9, 2018 at 9:19 AM, Marek Szyprowski > wrote: >> I understand that pl330 doesn't support real PAUSE, but as it has been >> implemented since 2015 the limited support is perfectly possible - just >> to

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

Hi Frank, On 2018-05-09 19:48, Frank Mori Hess wrote: > On Wed, May 9, 2018 at 9:19 AM, Marek Szyprowski > wrote: >> I understand that pl330 doesn't support real PAUSE, but as it has been >> implemented since 2015 the limited support is perfectly possible - just >> to let serial driver to read

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On Wed, May 9, 2018 at 9:19 AM, Marek Szyprowski wrote: > > I understand that pl330 doesn't support real PAUSE, but as it has been > implemented since 2015 the limited support is perfectly possible - just > to let serial driver to read the amount of data transferred. > >

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On Wed, May 9, 2018 at 9:19 AM, Marek Szyprowski wrote: > > I understand that pl330 doesn't support real PAUSE, but as it has been > implemented since 2015 the limited support is perfectly possible - just > to let serial driver to read the amount of data transferred. > > Please note that DMA

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

Hi Frank, On 2018-05-08 16:36, Frank Mori Hess wrote: > On Tue, May 8, 2018 at 5:04 AM, Marek Szyprowski > wrote: >> Hi Frank and Vinod, >> >> On 2018-04-28 23:50, Frank Mori Hess wrote: >>> This reverts commit 88987d2c7534a0269f567fb101e6d71a08f0f01d. >>> >>> The

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

Hi Frank, On 2018-05-08 16:36, Frank Mori Hess wrote: > On Tue, May 8, 2018 at 5:04 AM, Marek Szyprowski > wrote: >> Hi Frank and Vinod, >> >> On 2018-04-28 23:50, Frank Mori Hess wrote: >>> This reverts commit 88987d2c7534a0269f567fb101e6d71a08f0f01d. >>> >>> The pl330.c pause implementation

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On 08-05-18, 10:36, Frank Mori Hess wrote: > On Tue, May 8, 2018 at 5:04 AM, Marek Szyprowski > wrote: > > Hi Frank and Vinod, > > > > On 2018-04-28 23:50, Frank Mori Hess wrote: > >> This reverts commit 88987d2c7534a0269f567fb101e6d71a08f0f01d. > >> > >> The pl330.c

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On 08-05-18, 10:36, Frank Mori Hess wrote: > On Tue, May 8, 2018 at 5:04 AM, Marek Szyprowski > wrote: > > Hi Frank and Vinod, > > > > On 2018-04-28 23:50, Frank Mori Hess wrote: > >> This reverts commit 88987d2c7534a0269f567fb101e6d71a08f0f01d. > >> > >> The pl330.c pause implementation violates

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On Tue, May 8, 2018 at 5:04 AM, Marek Szyprowski wrote: > Hi Frank and Vinod, > > On 2018-04-28 23:50, Frank Mori Hess wrote: >> This reverts commit 88987d2c7534a0269f567fb101e6d71a08f0f01d. >> >> The pl330.c pause implementation violates the dmaengine requirement >> for

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On Tue, May 8, 2018 at 5:04 AM, Marek Szyprowski wrote: > Hi Frank and Vinod, > > On 2018-04-28 23:50, Frank Mori Hess wrote: >> This reverts commit 88987d2c7534a0269f567fb101e6d71a08f0f01d. >> >> The pl330.c pause implementation violates the dmaengine requirement >> for no data loss, since it

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

Hi Frank and Vinod, On 2018-04-28 23:50, Frank Mori Hess wrote: > This reverts commit 88987d2c7534a0269f567fb101e6d71a08f0f01d. > > The pl330.c pause implementation violates the dmaengine requirement > for no data loss, since it relies on the DMAKILL > instruction. However, DMAKILL discards

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

Hi Frank and Vinod, On 2018-04-28 23:50, Frank Mori Hess wrote: > This reverts commit 88987d2c7534a0269f567fb101e6d71a08f0f01d. > > The pl330.c pause implementation violates the dmaengine requirement > for no data loss, since it relies on the DMAKILL > instruction. However, DMAKILL discards

Re: [PATCH] Revert "dmaengine: pl330: add DMA_PAUSE feature"

On Sat, Apr 28, 2018 at 05:50:58PM -0400, Frank Mori Hess wrote: > This reverts commit 88987d2c7534a0269f567fb101e6d71a08f0f01d. > > The pl330.c pause implementation violates the dmaengine requirement > for no data loss, since it relies on the DMAKILL > instruction. However, DMAKILL discards

Re: [PATCH] Revert "dmaengine: pl330: add DMA_PAUSE feature"

On Sat, Apr 28, 2018 at 05:50:58PM -0400, Frank Mori Hess wrote: > This reverts commit 88987d2c7534a0269f567fb101e6d71a08f0f01d. > > The pl330.c pause implementation violates the dmaengine requirement > for no data loss, since it relies on the DMAKILL > instruction. However, DMAKILL discards

Re: [PATCH] Revert "dmaengine: pl330: add DMA_PAUSE feature"

On Wed, May 02, 2018 at 10:37:09AM -0400, Frank Mori Hess wrote: > On Wed, May 2, 2018 at 12:32 AM, Vinod Koul wrote: > > On Sat, Apr 28, 2018 at 05:50:58PM -0400, Frank Mori Hess wrote: > >> This reverts commit 88987d2c7534a0269f567fb101e6d71a08f0f01d. > >> > > > > I am

Re: [PATCH] Revert "dmaengine: pl330: add DMA_PAUSE feature"

On Wed, May 02, 2018 at 10:37:09AM -0400, Frank Mori Hess wrote: > On Wed, May 2, 2018 at 12:32 AM, Vinod Koul wrote: > > On Sat, Apr 28, 2018 at 05:50:58PM -0400, Frank Mori Hess wrote: > >> This reverts commit 88987d2c7534a0269f567fb101e6d71a08f0f01d. > >> > > > > I am dropping the orignal

Re: [PATCH] Revert "dmaengine: pl330: add DMA_PAUSE feature"

On Wed, May 2, 2018 at 12:32 AM, Vinod Koul wrote: > On Sat, Apr 28, 2018 at 05:50:58PM -0400, Frank Mori Hess wrote: >> This reverts commit 88987d2c7534a0269f567fb101e6d71a08f0f01d. >> > > I am dropping the orignal patch for queue, so no need for revert patch. > I don't

Re: [PATCH] Revert "dmaengine: pl330: add DMA_PAUSE feature"

On Wed, May 2, 2018 at 12:32 AM, Vinod Koul wrote: > On Sat, Apr 28, 2018 at 05:50:58PM -0400, Frank Mori Hess wrote: >> This reverts commit 88987d2c7534a0269f567fb101e6d71a08f0f01d. >> > > I am dropping the orignal patch for queue, so no need for revert patch. > I don't understand,

Re: [PATCH] Revert "dmaengine: pl330: add DMA_PAUSE feature"

On Sat, Apr 28, 2018 at 05:50:58PM -0400, Frank Mori Hess wrote: > This reverts commit 88987d2c7534a0269f567fb101e6d71a08f0f01d. > > The pl330.c pause implementation violates the dmaengine requirement > for no data loss, since it relies on the DMAKILL > instruction. However, DMAKILL discards

Re: [PATCH] Revert "dmaengine: pl330: add DMA_PAUSE feature"

On Sat, Apr 28, 2018 at 05:50:58PM -0400, Frank Mori Hess wrote: > This reverts commit 88987d2c7534a0269f567fb101e6d71a08f0f01d. > > The pl330.c pause implementation violates the dmaengine requirement > for no data loss, since it relies on the DMAKILL > instruction. However, DMAKILL discards

[PATCH] Revert "dmaengine: pl330: add DMA_PAUSE feature"

This reverts commit 88987d2c7534a0269f567fb101e6d71a08f0f01d. The pl330.c pause implementation violates the dmaengine requirement for no data loss, since it relies on the DMAKILL instruction. However, DMAKILL discards in-flight data from the dma controller's fifo. This is documented in the

[PATCH] Revert "dmaengine: pl330: add DMA_PAUSE feature"

This reverts commit 88987d2c7534a0269f567fb101e6d71a08f0f01d. The pl330.c pause implementation violates the dmaengine requirement for no data loss, since it relies on the DMAKILL instruction. However, DMAKILL discards in-flight data from the dma controller's fifo. This is documented in the