Re: SATA link power management issues

2015-04-24 Thread Tejun Heo
Hello, Gabriele. On Tue, Apr 21, 2015 at 11:44:28PM +0200, Gabriele Mazzotta wrote: > I haven't considered that possibility. Something like the following then? Yeah, looks great. Some minor comments below. > --- a/drivers/ata/libahci.c > +++ b/drivers/ata/libahci.c > @@ -1700,6 +1700,8 @@ stati

Re: SATA link power management issues

2015-04-21 Thread Gabriele Mazzotta
On Tuesday 21 April 2015 16:56:08 Tejun Heo wrote: > Hello, > > On Tue, Apr 21, 2015 at 10:29:38PM +0200, Gabriele Mazzotta wrote: > > Doing some quick tests I found that in some cases it takes 5 or 6 > > seconds for the first interrupt to arrive, so I'd have to use a quite > > long interval to co

Re: SATA link power management issues

2015-04-21 Thread Tejun Heo
Hello, On Tue, Apr 21, 2015 at 10:29:38PM +0200, Gabriele Mazzotta wrote: > Doing some quick tests I found that in some cases it takes 5 or 6 > seconds for the first interrupt to arrive, so I'd have to use a quite > long interval to completely prevent errors. Hmm... > I am wondering if it would

Re: SATA link power management issues

2015-04-21 Thread Gabriele Mazzotta
On Tuesday 21 April 2015 11:31:21 Tejun Heo wrote: > On Mon, Apr 20, 2015 at 10:02:12PM +0200, Gabriele Mazzotta wrote: > > On Sunday 22 February 2015 21:53:35 Gabriele Mazzotta wrote: > > > It seems that the following patch prevents errors when the policy is > > > changed. Could anybody explain wh

Re: SATA link power management issues

2015-04-21 Thread Tejun Heo
On Mon, Apr 20, 2015 at 10:02:12PM +0200, Gabriele Mazzotta wrote: > On Sunday 22 February 2015 21:53:35 Gabriele Mazzotta wrote: > > It seems that the following patch prevents errors when the policy is > > changed. Could anybody explain why? The device is generating a spurious PHY event after LPM

Re: SATA link power management issues

2015-04-20 Thread Gabriele Mazzotta
On Sunday 22 February 2015 21:53:35 Gabriele Mazzotta wrote: > Hi, > > It seems that the following patch prevents errors when the policy is > changed. Could anybody explain why? > > Thanks, > Gabriele > > diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c > index 61a9c07..38d39f7 100644

Re: SATA link power management issues

2015-02-22 Thread Gabriele Mazzotta
Hi, It seems that the following patch prevents errors when the policy is changed. Could anybody explain why? Thanks, Gabriele diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c index 61a9c07..38d39f7 100644 --- a/drivers/ata/libahci.c +++ b/drivers/ata/libahci.c @@ -1708,7 +1708,10 @@ st

Re: SATA link power management issues

2015-01-12 Thread Gabriele Mazzotta
I just tried the following and I no longer get errors: diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c index 97683e4..c815b31 100644 --- a/drivers/ata/libahci.c +++ b/drivers/ata/libahci.c @@ -1708,10 +1708,10 @@ static void ahci_handle_port_interrupt(struct ata_port *ap,

Re: SATA link power management issues

2015-01-12 Thread Gabriele Mazzotta
On Tuesday 13 January 2015 02:17:00 Suman Tripathi wrote: > Hi, > > On Tuesday 13 January 2015 02:00:45 Suman Tripathi wrote: > > On Monday 12 January 2015 22:46:02 Suman Tripathi wrote: > > > Can you dump the ata_id parameters(LPM section) from the drive and we > > > can check the related LPM par

Re: SATA link power management issues

2015-01-12 Thread Gabriele Mazzotta
On Tuesday 13 January 2015 02:00:45 Suman Tripathi wrote: > On Monday 12 January 2015 22:46:02 Suman Tripathi wrote: > > Can you dump the ata_id parameters(LPM section) from the drive and we > > can check the related LPM parameters of the drive ? > > Hi, > > I'm sorry, but I'm not really familiar

Re: SATA link power management issues

2015-01-12 Thread Gabriele Mazzotta
On Monday 12 January 2015 22:46:02 Suman Tripathi wrote: > Can you dump the ata_id parameters(LPM section) from the drive and we > can check the related LPM parameters of the drive ? Hi, I'm sorry, but I'm not really familiar with ata, could you be a bit more specific about what you'd like to see

Re: SATA link power management issues

2015-01-12 Thread Suman Tripathi
Can you dump the ata_id parameters(LPM section) from the drive and we can check the related LPM parameters of the drive ? On Mon, Jan 12, 2015 at 10:42 PM, Suman Tripathi wrote: > Hi, > > I'm having some problems with the link_power_management_policy on my > Dell XPS13 9333. > Changing policy fro

Re: SATA link power management issues

2015-01-12 Thread Gabriele Mazzotta
On Monday 12 January 2015 12:07:34 Tejun Heo wrote: > Hello, Gabriele. > > On Mon, Jan 12, 2015 at 06:03:41PM +0100, Gabriele Mazzotta wrote: > > I tried it and got the same result: > > > > [ 451.077463] ahci :00:1f.2: port does not support device sleep > > [ 452.162451] ata3.00: exception

Re: SATA link power management issues

2015-01-12 Thread Tejun Heo
Hello, Gabriele. On Mon, Jan 12, 2015 at 06:03:41PM +0100, Gabriele Mazzotta wrote: > I tried it and got the same result: > > [ 451.077463] ahci :00:1f.2: port does not support device sleep > [ 452.162451] ata3.00: exception Emask 0x10 SAct 0x400 SErr 0x5 action > 0xe frozen > [ 452.1

Re: SATA link power management issues

2015-01-12 Thread Gabriele Mazzotta
On Monday 12 January 2015 08:16:02 Tejun Heo wrote: > Hello, > > What you're experiencing looks like the ssd behaving badly after link > state transition. I wonder whether the right solution is plugging > PHYRDY IRQ for a while after LPM state change. Does the following > path make any differenc

Re: SATA link power management issues

2015-01-12 Thread Tejun Heo
Hello, What you're experiencing looks like the ssd behaving badly after link state transition. I wonder whether the right solution is plugging PHYRDY IRQ for a while after LPM state change. Does the following path make any difference? Thanks. diff --git a/drivers/ata/libahci.c b/drivers/ata/li

Re: SATA link power management issues

2015-01-09 Thread Gabriele Mazzotta
On Friday 09 January 2015 17:02:53 Tejun Heo wrote: > On Fri, Jan 09, 2015 at 05:00:18PM -0500, Tejun Heo wrote: > > It's not normal. It definitely doesn't happen with all devices. I > > guess it could be a quirk from the device side. What's on the other > > side of the connector? Can you post

Re: SATA link power management issues

2015-01-09 Thread Gabriele Mazzotta
On Friday 09 January 2015 17:00:18 Tejun Heo wrote: > Hello, Gabriele. > > On Thu, Jan 08, 2015 at 08:37:35PM +0100, Gabriele Mazzotta wrote: > > I'm having some problems with the link_power_management_policy on my > > Dell XPS13 9333. > > Changing policy from min_power or medium_power to max_perf

Re: SATA link power management issues

2015-01-09 Thread Tejun Heo
On Fri, Jan 09, 2015 at 05:02:53PM -0500, Tejun Heo wrote: > On Fri, Jan 09, 2015 at 05:00:18PM -0500, Tejun Heo wrote: > > It's not normal. It definitely doesn't happen with all devices. I > > guess it could be a quirk from the device side. What's on the other > > side of the connector? Can yo

Re: SATA link power management issues

2015-01-09 Thread Tejun Heo
On Fri, Jan 09, 2015 at 05:00:18PM -0500, Tejun Heo wrote: > It's not normal. It definitely doesn't happen with all devices. I > guess it could be a quirk from the device side. What's on the other > side of the connector? Can you post the full kernel log after such > incidence? What happens if

Re: SATA link power management issues

2015-01-09 Thread Tejun Heo
Hello, Gabriele. On Thu, Jan 08, 2015 at 08:37:35PM +0100, Gabriele Mazzotta wrote: > I'm having some problems with the link_power_management_policy on my > Dell XPS13 9333. > Changing policy from min_power or medium_power to max_performance > causes the following errors: > > [ 3955.667086] ahci

SATA link power management issues

2015-01-08 Thread Gabriele Mazzotta
Hi, I'm having some problems with the link_power_management_policy on my Dell XPS13 9333. Changing policy from min_power or medium_power to max_performance causes the following errors: [ 3955.667086] ahci :00:1f.2: port does not support device sleep [ 3958.257106] ata3.00: exception Emask 0x1