Re: STT_FUNC for assembler checksum and semaphore ops" in git-x86

2008-01-10 Thread John Reiser
Andi Kleen wrote: > On Thu, Jan 10, 2008 at 04:59:52PM -0800, John Reiser wrote: > >>Andi Kleen wrote: >> >>>But actually checking the default implementation in linkage.h already >>>implements size: [snip] >> >>>Are you sure it doesn't work? Your patch should be not needed. If it's >>>still wrong

Re: STT_FUNC for assembler checksum and semaphore ops" in git-x86

2008-01-10 Thread Andi Kleen
On Thu, Jan 10, 2008 at 04:59:52PM -0800, John Reiser wrote: > Andi Kleen wrote: > > But actually checking the default implementation in linkage.h already > > implements size: [snip] > > > Are you sure it doesn't work? Your patch should be not needed. If it's > > still wrong then just ENDPROCs()

Re: STT_FUNC for assembler checksum and semaphore ops" in git-x86

2008-01-10 Thread John Reiser
Andi Kleen wrote: > But actually checking the default implementation in linkage.h already > implements size: [snip] > Are you sure it doesn't work? Your patch should be not needed. If it's > still wrong then just ENDPROCs() need to be added. The ENDPROCs() were not used everywhere. Some code us

Re: STT_FUNC for assembler checksum and semaphore ops" in git-x86

2008-01-10 Thread Andi Kleen
> It does look ugly. But .size and .type are oriented towards static > description, while the dwarf2 CurrentFrameInfo (CFI) annotations > are oriented towards dynamic traceback and unwinding. Forcing the ENTRY/ENDPROC have nothing to do with dwarf2. That is CFI_STARTPROC/ENDPROC. But actually c

Re: STT_FUNC for assembler checksum and semaphore ops" in git-x86

2008-01-10 Thread John Reiser
>>+ .type csum_partial, @function >> ENTRY(csum_partial) >>+ .type csum_partial, @function >> ENTRY(csum_partial) >>CFI_STARTPROC >>pushl %esi >>@@ -141,11 +142,13 @@ ENTRY(csum_partial) >>ret >>CFI_ENDPROC >> ENDPROC(csum_partial) >>+ .size csum_pa

Re: STT_FUNC for assembler checksum and semaphore ops" in git-x86

2008-01-09 Thread Sam Ravnborg
On Wed, Jan 09, 2008 at 10:57:25PM +0100, Andi Kleen wrote: > > In gitx86: > > commit 692effca950d7c6032e8e2ae785a32383e7af4a3 > Author: John Reiser <[EMAIL PROTECTED]> > Date: Wed Jan 9 13:31:12 2008 +0100 > > STT_FUNC for assembler checksum and semaphore ops > ... > Comments? >

STT_FUNC for assembler checksum and semaphore ops" in git-x86

2008-01-09 Thread Andi Kleen
In gitx86: commit 692effca950d7c6032e8e2ae785a32383e7af4a3 Author: John Reiser <[EMAIL PROTECTED]> Date: Wed Jan 9 13:31:12 2008 +0100 STT_FUNC for assembler checksum and semaphore ops ... Comments? Signed-off-by: Thomas Gleixner <[EMAIL PROTECTED]> Signed-off-by: Ingo Mol