SED Opal Fixups

2017-02-13 Thread Scott Bauer
So we have a few patches here, they're pretty small. First patch changes the sed-opal ioctl function parameters to take a void __user* instead of an unsigned long, this required a small cast in the nvme driver. Patch 2 is a UAPI fixup for the IOW to make an ioctl the right size. Patch 3 fixes a

SED Opal Fixups

2017-02-13 Thread Scott Bauer
So we have a few patches here, they're pretty small. First patch changes the sed-opal ioctl function parameters to take a void __user* instead of an unsigned long, this required a small cast in the nvme driver. Patch 2 is a UAPI fixup for the IOW to make an ioctl the right size. Patch 3 fixes a

Re: Sed-opal fixups

2017-02-09 Thread Scott Bauer
e0;136;0csOn Thu, Feb 09, 2017 at 11:24:58AM -0700, Jens Axboe wrote: > On 02/09/2017 10:45 AM, Scott Bauer wrote: > > On Thu, Feb 09, 2017 at 05:43:20PM +, David Laight wrote: > >> From: Scott Bauer > >>> Sent: 09 February 2017 17:20 > >>> It may be too late to change anyhting in the uapi

Re: Sed-opal fixups

2017-02-09 Thread Scott Bauer
e0;136;0csOn Thu, Feb 09, 2017 at 11:24:58AM -0700, Jens Axboe wrote: > On 02/09/2017 10:45 AM, Scott Bauer wrote: > > On Thu, Feb 09, 2017 at 05:43:20PM +, David Laight wrote: > >> From: Scott Bauer > >>> Sent: 09 February 2017 17:20 > >>> It may be too late to change anyhting in the uapi

Re: Sed-opal fixups

2017-02-09 Thread Jens Axboe
On 02/09/2017 10:45 AM, Scott Bauer wrote: > On Thu, Feb 09, 2017 at 05:43:20PM +, David Laight wrote: >> From: Scott Bauer >>> Sent: 09 February 2017 17:20 >>> It may be too late to change anyhting in the uapi header. When we >>> switched over to using IOC_SIZE I found a bug where I had

Re: Sed-opal fixups

2017-02-09 Thread Jens Axboe
On 02/09/2017 10:45 AM, Scott Bauer wrote: > On Thu, Feb 09, 2017 at 05:43:20PM +, David Laight wrote: >> From: Scott Bauer >>> Sent: 09 February 2017 17:20 >>> It may be too late to change anyhting in the uapi header. When we >>> switched over to using IOC_SIZE I found a bug where I had

RE: Sed-opal fixups

2017-02-09 Thread David Laight
From: Scott Bauer > Sent: 09 February 2017 17:20 > It may be too late to change anyhting in the uapi header. When we > switched over to using IOC_SIZE I found a bug where I had switched > up a structure in one of the series from v4 to v5 but never changed > the structure in the IOW. The structure

RE: Sed-opal fixups

2017-02-09 Thread David Laight
From: Scott Bauer > Sent: 09 February 2017 17:20 > It may be too late to change anyhting in the uapi header. When we > switched over to using IOC_SIZE I found a bug where I had switched > up a structure in one of the series from v4 to v5 but never changed > the structure in the IOW. The structure

Re: Sed-opal fixups

2017-02-09 Thread Scott Bauer
On Thu, Feb 09, 2017 at 05:43:20PM +, David Laight wrote: > From: Scott Bauer > > Sent: 09 February 2017 17:20 > > It may be too late to change anyhting in the uapi header. When we > > switched over to using IOC_SIZE I found a bug where I had switched > > up a structure in one of the series

Re: Sed-opal fixups

2017-02-09 Thread Scott Bauer
On Thu, Feb 09, 2017 at 05:43:20PM +, David Laight wrote: > From: Scott Bauer > > Sent: 09 February 2017 17:20 > > It may be too late to change anyhting in the uapi header. When we > > switched over to using IOC_SIZE I found a bug where I had switched > > up a structure in one of the series

Sed-opal fixups

2017-02-09 Thread Scott Bauer
It may be too late to change anyhting in the uapi header. When we switched over to using IOC_SIZE I found a bug where I had switched up a structure in one of the series from v4 to v5 but never changed the structure in the IOW. The structure that was in there was to small so when we kzalloc on it

Sed-opal fixups

2017-02-09 Thread Scott Bauer
It may be too late to change anyhting in the uapi header. When we switched over to using IOC_SIZE I found a bug where I had switched up a structure in one of the series from v4 to v5 but never changed the structure in the IOW. The structure that was in there was to small so when we kzalloc on it