Re: SetPageDirty in shmem_nopage

2001-01-14 Thread Christoph Rohland
Linus Torvalds <[EMAIL PROTECTED]> writes: > On 14 Jan 2001, Christoph Rohland wrote: > Why do you increment the use counter at all in nopage? First to be able to limit the overall number of pages used by the filesystem and second to have the right value for the number of blocks in [f]stat. Sho

Re: SetPageDirty in shmem_nopage

2001-01-14 Thread Linus Torvalds
On 14 Jan 2001, Christoph Rohland wrote: > > Since we do not mark the page dirty at allocation time the vm can drop > it at any time as long as it is not written to. But shmem never > adjusts its accounting to that and will happily increase the use > counter for both the inode and the fs. Why

SetPageDirty in shmem_nopage

2001-01-14 Thread Christoph Rohland
Hi Linus, While playing with the shmem read/write support I realised that the accounting for shmem is broken: Since we do not mark the page dirty at allocation time the vm can drop it at any time as long as it is not written to. But shmem never adjusts its accounting to that and will happily inc