Re: Silence compiler warning in arch/x86/kvm/emulate.c

2016-02-19 Thread Valdis . Kletnieks
On Fri, 19 Feb 2016 18:56:05 +0100, Paolo Bonzini said: > On 19/02/2016 18:54, valdis.kletni...@vt.edu wrote: > > But under what conditions is 'la' a 64-bit quantity that has any > > bits set in the high 32 bits (meaning it's a pointer to something > > over the 4G line) - but it's still valid to sm

Re: Silence compiler warning in arch/x86/kvm/emulate.c

2016-02-19 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 19/02/2016 18:54, valdis.kletni...@vt.edu wrote: > la can get changed here - but there's 2 cases to consider. If it's > in a 32-bit kernel, anding with -1 is a no-op. > > Now if we're on a 64-bit kernel, the 'and' clears the high 32 > bits. >

Re: Silence compiler warning in arch/x86/kvm/emulate.c

2016-02-19 Thread Valdis . Kletnieks
On Fri, 19 Feb 2016 17:45:48 +0100, Aurelien Jarno said: > On 2016-02-19 12:11, Aurelien Jarno wrote: > Actually the same patch with a bit more context shows the issue: > > > diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c > > index e7a4fde..b372a75 100644 > > --- a/arch/x86/kvm/emul

Re: Silence compiler warning in arch/x86/kvm/emulate.c

2016-02-19 Thread Aurelien Jarno
On 2016-02-19 13:05, Paolo Bonzini wrote: > > > On 19/02/2016 12:11, Aurelien Jarno wrote: > > On 2015-08-29 17:49, Valdis Kletnieks wrote: > >> Compiler warning: > >> > >> CC [M] arch/x86/kvm/emulate.o > >> arch/x86/kvm/emulate.c: In function "__do_insn_fetch_bytes": > >> arch/x86/kvm/emulate.

Re: Silence compiler warning in arch/x86/kvm/emulate.c

2016-02-19 Thread Aurelien Jarno
On 2016-02-19 12:11, Aurelien Jarno wrote: > On 2015-08-29 17:49, Valdis Kletnieks wrote: > > Compiler warning: > > > > CC [M] arch/x86/kvm/emulate.o > > arch/x86/kvm/emulate.c: In function "__do_insn_fetch_bytes": > > arch/x86/kvm/emulate.c:814:9: warning: "linear" may be used uninitialized >

Re: Silence compiler warning in arch/x86/kvm/emulate.c

2016-02-19 Thread Paolo Bonzini
On 19/02/2016 12:11, Aurelien Jarno wrote: > On 2015-08-29 17:49, Valdis Kletnieks wrote: >> Compiler warning: >> >> CC [M] arch/x86/kvm/emulate.o >> arch/x86/kvm/emulate.c: In function "__do_insn_fetch_bytes": >> arch/x86/kvm/emulate.c:814:9: warning: "linear" may be used uninitialized in >>

Re: Silence compiler warning in arch/x86/kvm/emulate.c

2016-02-19 Thread Aurelien Jarno
On 2015-08-29 17:49, Valdis Kletnieks wrote: > Compiler warning: > > CC [M] arch/x86/kvm/emulate.o > arch/x86/kvm/emulate.c: In function "__do_insn_fetch_bytes": > arch/x86/kvm/emulate.c:814:9: warning: "linear" may be used uninitialized in > this function [-Wmaybe-uninitialized] > > GCC is sm

Silence compiler warning in arch/x86/kvm/emulate.c

2015-08-29 Thread Valdis Kletnieks
Compiler warning: CC [M] arch/x86/kvm/emulate.o arch/x86/kvm/emulate.c: In function "__do_insn_fetch_bytes": arch/x86/kvm/emulate.c:814:9: warning: "linear" may be used uninitialized in this function [-Wmaybe-uninitialized] GCC is smart enough to realize that the inlined __linearize may return