Re: Speaker pops with max98357a on rk3399-gru-kevin since v5.7

2020-07-21 Thread Alper Nebi Yasak
On 21/07/2020 14:46, Tzung-Bi Shih wrote: > Hi, I got a rk3399-gru-kevin and can reproduce the issue. > > Could you take a try on the proposed patch here > https://patchwork.kernel.org/patch/11675533/ to see if it fixes? It does eliminate the pops, thanks. (I've replied to the patch, I am

Re: Speaker pops with max98357a on rk3399-gru-kevin since v5.7

2020-07-21 Thread Tzung-Bi Shih
On Tue, Jul 21, 2020 at 6:40 AM Alper Nebi Yasak wrote: > > On 17/07/2020 05:27, Tzung-Bi Shih wrote: > > I am not convinced the pop comes from 128f825aeab7. > > Maybe some pre-existing defect in rk3399_gru_sound got exposed by > 128f825aeab7 or the machine driver needs some changes to complement

Re: Speaker pops with max98357a on rk3399-gru-kevin since v5.7

2020-07-20 Thread Alper Nebi Yasak
On 17/07/2020 05:27, Tzung-Bi Shih wrote: > I am not convinced the pop comes from 128f825aeab7. Maybe some pre-existing defect in rk3399_gru_sound got exposed by 128f825aeab7 or the machine driver needs some changes to complement that commit? > (I don't have a rk3399-gru-kevin so I got another

Re: Speaker pops with max98357a on rk3399-gru-kevin since v5.7

2020-07-16 Thread Tzung-Bi Shih
On Thu, Jul 16, 2020 at 7:49 PM Alper Nebi Yasak wrote: > I have been getting "pop" sounds from the speaker on my rk3399-gru-kevin > for a while, and bisected it to 128f825aeab7 ("ASoC: max98357a: move > control of SD_MODE to DAPM"), but looks like the pops were somewhat > expected: I am not

Speaker pops with max98357a on rk3399-gru-kevin since v5.7

2020-07-16 Thread Alper Nebi Yasak
Hi, I have been getting "pop" sounds from the speaker on my rk3399-gru-kevin for a while, and bisected it to 128f825aeab7 ("ASoC: max98357a: move control of SD_MODE to DAPM"), but looks like the pops were somewhat expected: On 12 Feb 2020 13:55:15 +0800, Tzung-Bi Shih wrote [1]: > Possible