Re: Spinlocking patch for in xprt.c

2001-01-14 Thread Trond Myklebust
> " " == David S Miller <[EMAIL PROTECTED]> writes: > Trond, did you actually look at how this code works before you > made modifications to my fixes? > xprt_lock serializes sleep/wakeup sequences in the xprt code, > so you cannot remove xprt_lock from the sections where

Re: Spinlocking patch for in xprt.c

2001-01-14 Thread Trond Myklebust
" " == David S Miller [EMAIL PROTECTED] writes: Trond, did you actually look at how this code works before you made modifications to my fixes? xprt_lock serializes sleep/wakeup sequences in the xprt code, so you cannot remove xprt_lock from the sections where I added

Re: Spinlocking patch for in xprt.c

2001-01-13 Thread David S. Miller
Trond, did you actually look at how this code works before you made modifications to my fixes? xprt_lock serializes sleep/wakeup sequences in the xprt code, so you cannot remove xprt_lock from the sections where I added holding of xprt_sock_lock to protect the state of xprt->snd_task. So for

Re: Spinlocking patch for in xprt.c

2001-01-13 Thread David S. Miller
Trond, did you actually look at how this code works before you made modifications to my fixes? xprt_lock serializes sleep/wakeup sequences in the xprt code, so you cannot remove xprt_lock from the sections where I added holding of xprt_sock_lock to protect the state of xprt-snd_task. So for

Spinlocking patch for in xprt.c

2001-01-12 Thread Trond Myklebust
The following patch (taken from the zero copy networking) upgrades the spinlocking of the xprt_(up|down)_transmit() 'semaphores' in order to work safely with the networking bottom halves. Several of the latter (cf. xprt.c:tcp_write_space() & friends) do want to test the value of

Spinlocking patch for in xprt.c

2001-01-12 Thread Trond Myklebust
The following patch (taken from the zero copy networking) upgrades the spinlocking of the xprt_(up|down)_transmit() 'semaphores' in order to work safely with the networking bottom halves. Several of the latter (cf. xprt.c:tcp_write_space() friends) do want to test the value of 'xprt-snd_task'.