Re: [PATCH] Staging: slicoss: Fix checkpatch.pl issues

2015-03-26 Thread Greg KH
On Wed, Mar 25, 2015 at 01:28:43AM +0530, Niranjan Dighe wrote: > Removed unused block of code guarded by #ifdef SLIC_TRACE_DUMP_ENABLED > And removed redundant static char *slic_banner and replaced actual string in > place of format string. That's multiple things you are doing all in the same pat

Re: Staging: slicoss: Fix checkpatch.pl issues

2015-03-24 Thread Joe Perches
On Tue, 2015-03-24 at 23:14 +0300, Dan Carpenter wrote: > On Wed, Mar 25, 2015 at 12:39:06AM +0530, Niranjan Dighe wrote: > > The following files had coding style issues that I tried to address. > > It was mostly about lines spanning more than 80 characters. [] > > diff --git a/drivers/staging/slic

Re: Staging: slicoss: Fix checkpatch.pl issues

2015-03-24 Thread Dan Carpenter
On Wed, Mar 25, 2015 at 12:39:06AM +0530, Niranjan Dighe wrote: > The following files had coding style issues that I tried to address. > It was mostly about lines spanning more than 80 characters. > > Signed-off-by: Niranjan Dighe > > diff --git a/drivers/staging/slicoss/slicoss.c > b/drivers/s

[PATCH] Staging: slicoss: Fix checkpatch.pl issues

2015-03-24 Thread Niranjan Dighe
Removed unused block of code guarded by #ifdef SLIC_TRACE_DUMP_ENABLED And removed redundant static char *slic_banner and replaced actual string in place of format string. Signed-off-by: Niranjan Dighe diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c index 3104

Re: Staging: slicoss: Fix checkpatch.pl issues

2015-03-24 Thread Joe Perches
On Wed, 2015-03-25 at 00:39 +0530, Niranjan Dighe wrote: > The following files had coding style issues that I tried to address. > It was mostly about lines spanning more than 80 characters. [] > diff --git a/drivers/staging/slicoss/slicoss.c > b/drivers/staging/slicoss/slicoss.c [] > @@ -98,7 +98,

Staging: slicoss: Fix checkpatch.pl issues

2015-03-24 Thread Niranjan Dighe
The following files had coding style issues that I tried to address. It was mostly about lines spanning more than 80 characters. Signed-off-by: Niranjan Dighe diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c index 3104cb0..2161bdb 100644 --- a/drivers/staging/s