Re: Stopping watchdog in watchdog driver remove functions

2017-01-01 Thread Guenter Roeck
On 01/01/2017 03:14 AM, Wim Van Sebroeck wrote: Hi Guenter, I noticed that several watchdog drivers stop the watchdog in trhe driver remove function. A non-exhaustive list of drivers doing that is drivers/watchdog/bcm7038_wdt.c drivers/watchdog/cadence_wdt.c drivers/wat

Re: Stopping watchdog in watchdog driver remove functions

2017-01-01 Thread Andy Shevchenko
On Sun, Jan 1, 2017 at 1:14 PM, Wim Van Sebroeck wrote: >> Given that, does it even make sense to stop the watchdog in the remove >> function ? >> Should it even be permitted ? > > From an API point of view: if WDIOF_MAGICCLOSE is being used then the watchdog > _SHOULD_ continue to run when the w

Re: Stopping watchdog in watchdog driver remove functions

2017-01-01 Thread Wim Van Sebroeck
Hi Guenter, > I noticed that several watchdog drivers stop the watchdog in trhe driver > remove function. > A non-exhaustive list of drivers doing that is > > drivers/watchdog/bcm7038_wdt.c > drivers/watchdog/cadence_wdt.c > drivers/watchdog/imgpdc_wdt.c > drivers/watchdo

Stopping watchdog in watchdog driver remove functions

2016-12-31 Thread Guenter Roeck
Hi, I noticed that several watchdog drivers stop the watchdog in trhe driver remove function. A non-exhaustive list of drivers doing that is drivers/watchdog/bcm7038_wdt.c drivers/watchdog/cadence_wdt.c drivers/watchdog/imgpdc_wdt.c drivers/watchdog/jz4740_wdt.c