Re: Stricter module param and sysfs permission checks

2015-04-28 Thread Gobinda Charan Maji
Robert Jarzmik free.fr> writes: As per the newly added restriction (User perms >= group perms >= other perms) is concerned, there is an inconsistency in the permission. Say for example, permission value is "0432". Here User has only READ permission whereas Group has both WRITE and EXECUTE perm

Re: Stricter module param and sysfs permission checks

2014-07-02 Thread Gobinda Charan Maji
Gobinda Charan Maji gmail.com> writes: > > Hi All, > > I could not get any response yet. > > Hi Rusty, > > Please at least give me a reply even if my concept seems to be incorrect to > you. > > Thanks in advance, > Gobinda > > Hi All, I am new to this mail chain. I could not get any rep

Re: Stricter module param and sysfs permission checks

2014-06-25 Thread Gobinda Charan Maji
Gobinda Charan Maji gmail.com> writes: > > Hi All, > > As per the newly added restriction (User perms >= group perms >= other > perms) is concerned, there is an inconsistency in the permission. Say for > example, permission value is "0432". Here User has only READ permission > whereas Grou

Re: Stricter module param and sysfs permission checks

2014-06-18 Thread Gobinda Charan Maji
Robert Jarzmik free.fr> writes: > > Dave Jones redhat.com> writes: > > > On Thu, Mar 20, 2014 at 01:43:44PM +1030, Rusty Russell wrote: > > > > > drivers/mtd/devices/docg3.c: > > > __ATTR(f##id##_dps0_protection_key, S_IWUGO, NULL, dps0_insert_key), \ > > > __ATTR(f##id##_dps1_pr

Re: Stricter module param and sysfs permission checks

2014-03-20 Thread Robert Jarzmik
Dave Jones writes: > On Thu, Mar 20, 2014 at 01:43:44PM +1030, Rusty Russell wrote: > > > drivers/mtd/devices/docg3.c: > >__ATTR(f##id##_dps0_protection_key, S_IWUGO, NULL, dps0_insert_key), \ > >__ATTR(f##id##_dps1_protection_key, S_IWUGO, NULL, dps1_insert_key), \ > > > > drivers/

Re: Stricter module param and sysfs permission checks

2014-03-20 Thread Alexey Dobriyan
On Thu, Mar 20, 2014 at 7:27 AM, Dave Jones wrote: > On Thu, Mar 20, 2014 at 01:43:44PM +1030, Rusty Russell wrote: > > > drivers/mtd/devices/docg3.c: > > __ATTR(f##id##_dps0_protection_key, S_IWUGO, NULL, dps0_insert_key), \ > > __ATTR(f##id##_dps1_protection_key, S_IWUGO, NULL, dps1

Re: Stricter module param and sysfs permission checks

2014-03-19 Thread Dave Jones
On Thu, Mar 20, 2014 at 01:43:44PM +1030, Rusty Russell wrote: > drivers/mtd/devices/docg3.c: > __ATTR(f##id##_dps0_protection_key, S_IWUGO, NULL, dps0_insert_key), \ > __ATTR(f##id##_dps1_protection_key, S_IWUGO, NULL, dps1_insert_key), \ > > drivers/scsi/pm8001/pm8001_ctl.c: > s

Stricter module param and sysfs permission checks

2014-03-19 Thread Rusty Russell
CC's trimmed, this is not a virtio issue. Joe Perches writes: > On Wed, 2014-03-19 at 17:07 +1030, Rusty Russell wrote: >> Ted: module_param(queue_depth, int, 444) >> Joe: 0444! >> Rusty: User perms >= group perms >= other perms? >> Joe: CLASS_ATTR, DEVICE_ATTR, SENSOR_ATTR and SENSOR_ATT