Re: Subject: [PATCH v2] staging: media: meson: vdec: declare u32 as static const appropriately

2021-04-13 Thread Hans Verkuil
On 13/04/2021 13:09, Mitali Borkar wrote: > On Tue, Apr 13, 2021 at 09:26:01AM +0200, Hans Verkuil wrote: >> On 13/04/2021 08:27, Mitali Borkar wrote: >>> Declared 32 bit unsigned int as static constant inside a function >>> appropriately. >>> >>> Reported-by: kernel test robot >>> Signed-off-by:

Re: Subject: [PATCH v2] staging: media: meson: vdec: declare u32 as static const appropriately

2021-04-13 Thread Mitali Borkar
On Tue, Apr 13, 2021 at 09:26:01AM +0200, Hans Verkuil wrote: > On 13/04/2021 08:27, Mitali Borkar wrote: > > Declared 32 bit unsigned int as static constant inside a function > > appropriately. > > > > Reported-by: kernel test robot > > Signed-off-by: Mitali Borkar > > --- > > > > Changes from

Re: Subject: [PATCH v2] staging: media: meson: vdec: declare u32 as static const appropriately

2021-04-13 Thread Hans Verkuil
On 13/04/2021 08:27, Mitali Borkar wrote: > Declared 32 bit unsigned int as static constant inside a function > appropriately. > > Reported-by: kernel test robot > Signed-off-by: Mitali Borkar > --- > > Changes from v1:- Rectified the mistake by declaring u32 as static const > properly. > > d

Re: Subject: [PATCH v2] staging: media: meson: vdec: declare u32 as static const appropriately

2021-04-13 Thread Greg KH
On Tue, Apr 13, 2021 at 11:57:52AM +0530, Mitali Borkar wrote: > Declared 32 bit unsigned int as static constant inside a function > appropriately. > > Reported-by: kernel test robot > Signed-off-by: Mitali Borkar Why does your Subject: line have "Subject:" twice?

Re: [Outreachy kernel] Subject: [PATCH v2] staging: media: meson: vdec: declare u32 as static const appropriately

2021-04-12 Thread Julia Lawall
On Tue, 13 Apr 2021, Mitali Borkar wrote: > Declared 32 bit unsigned int as static constant inside a function > appropriately. I don't think that the description matches what is done. Perhaps all the meaning is intended to be in the word "appropriately", but that is not very clear. The messa

Subject: [PATCH v2] staging: media: meson: vdec: declare u32 as static const appropriately

2021-04-12 Thread Mitali Borkar
Declared 32 bit unsigned int as static constant inside a function appropriately. Reported-by: kernel test robot Signed-off-by: Mitali Borkar --- Changes from v1:- Rectified the mistake by declaring u32 as static const properly. drivers/staging/media/meson/vdec/codec_h264.c | 4 ++-- 1 file ch