Re: [PATCH net-next] net: dsa: mv88e6xxx: Add suspend/resume callbacks

2019-01-17 Thread Vivien Didelot
Hi, On Wed, 16 Jan 2019 23:23:29 +0100, Andrew Lunn wrote: > Hi Florian > > > A possible approach could be to call the port_disable, port_enable > > callbacks from dsa_slave_suspend() and dsa_slave_resume(), I might have > > some patches doing that already somewhere. > > I expect it is also on

Re: [PATCHv2] watchdog: qcom: Add suspend/resume support

2019-01-17 Thread Sai Prakash Ranjan
On 1/17/2019 8:49 PM, Sai Prakash Ranjan wrote: This adds the support for qcom watchdog suspend and resume when entering and exiting deep sleep states. Otherwise having watchdog active after suspend would result in unwanted crashes/resets if resume happens after a long time. Signed-off-by: Sai

[PATCHv2] watchdog: qcom: Add suspend/resume support

2019-01-17 Thread Sai Prakash Ranjan
This adds the support for qcom watchdog suspend and resume when entering and exiting deep sleep states. Otherwise having watchdog active after suspend would result in unwanted crashes/resets if resume happens after a long time. Signed-off-by: Sai Prakash Ranjan --- v2: * Use __maybe_unused

Re: [PATCH] watchdog: qcom: Add suspend/resume support

2019-01-17 Thread Sai Prakash Ranjan
Hi Guenter, On 1/17/2019 8:00 PM, Guenter Roeck wrote: I personally very much prefer __maybe_unused over #ifdef, for the reasons stated above. Other maintainers may think differently. Thanks for making your preference clear. I will post the second version soon with the changes. - Sai --

Re: [PATCH] watchdog: qcom: Add suspend/resume support

2019-01-17 Thread Guenter Roeck
config is disabled? We could just discard it. We would just It is beneficial to know that a future change in the conditional code, or an infrastructure change affecting it, doesn't cause a build error, even if the person submitting the change didn't bother compiling with PM_SLEEP=y. > increase the b

Re: [PATCH] watchdog: qcom: Add suspend/resume support

2019-01-17 Thread Sai Prakash Ranjan
build time with this attribute (although for this case it would be negligible but say we compile with PM_SLEEP disabled for all those suspend/resume functions with maybe_unused attribute). Looking at previous discussions in LKML[1] as to why the pm suspend/resume functions used __maybe_unu

Re: [PATCH] watchdog: qcom: Add suspend/resume support

2019-01-17 Thread Brian Masney
On Thu, Jan 17, 2019 at 04:08:52PM +0530, Sai Prakash Ranjan wrote: > On 1/17/2019 3:01 PM, Brian Masney wrote: > > > > You can use the __maybe_unused attribute to remove the #ifdef: > > > > static int __maybe_unused qcom_wdt_suspend(struct device *dev) > > > > Thanks for looking into this. >

Re: [PATCH] watchdog: qcom: Add suspend/resume support

2019-01-17 Thread Sai Prakash Ranjan
Hi Brian, On 1/17/2019 3:01 PM, Brian Masney wrote: You can use the __maybe_unused attribute to remove the #ifdef: static int __maybe_unused qcom_wdt_suspend(struct device *dev) Thanks for looking into this. As for __maybe_unused, I think it's better to keep #ifdef rather than this

Re: [PATCH 2/3] scsi: arcmsr: Fix suspend/resume of ACB_ADAPTER_TYPE_B part 2

2019-01-17 Thread Ching Huang
Ching Huang > > > > > > > > Fix suspend/resume of ACB_ADAPTER_TYPE_B part 2. > > > > > > > > > > What does this look like from a user perspective? Does it fail every > > > time or does it only fail sometimes? > > > > >

Re: [PATCH] watchdog: qcom: Add suspend/resume support

2019-01-17 Thread Brian Masney
On Thu, Jan 17, 2019 at 02:45:55PM +0530, Sai Prakash Ranjan wrote: > +#ifdef CONFIG_PM_SLEEP > +static int qcom_wdt_suspend(struct device *dev) > +{ > + struct qcom_wdt *wdt = dev_get_drvdata(dev); > + > + if (watchdog_active(>wdd)) > + qcom_wdt_stop(>wdd); > + > + return

Re: [PATCH 2/3] scsi: arcmsr: Fix suspend/resume of ACB_ADAPTER_TYPE_B part 2

2019-01-17 Thread Dan Carpenter
On Thu, Jan 17, 2019 at 04:47:07PM +0800, Ching Huang wrote: > On Thu, 2019-01-17 at 10:59 +0300, Dan Carpenter wrote: > > On Thu, Jan 17, 2019 at 11:45:03AM +0800, Ching Huang wrote: > > > >From Ching Huang > > > > > > Fix suspend/resume of ACB_ADAPTER_T

[PATCH] watchdog: qcom: Add suspend/resume support

2019-01-17 Thread Sai Prakash Ranjan
This adds the support for qcom watchdog suspend and resume when entering and exiting deep sleep states. Otherwise having watchdog active after suspend would result in unwanted crashes/resets if resume happens after a long time. Signed-off-by: Sai Prakash Ranjan --- drivers/watchdog/qcom-wdt.c |

Re: [PATCH 2/3] scsi: arcmsr: Fix suspend/resume of ACB_ADAPTER_TYPE_B part 2

2019-01-17 Thread Ching Huang
On Thu, 2019-01-17 at 10:59 +0300, Dan Carpenter wrote: > On Thu, Jan 17, 2019 at 11:45:03AM +0800, Ching Huang wrote: > > >From Ching Huang > > > > Fix suspend/resume of ACB_ADAPTER_TYPE_B part 2. > > > > What does this look like from a user perspective

Re: [PATCH 2/3] scsi: arcmsr: Fix suspend/resume of ACB_ADAPTER_TYPE_B part 2

2019-01-17 Thread Dan Carpenter
On Thu, Jan 17, 2019 at 11:45:03AM +0800, Ching Huang wrote: > >From Ching Huang > > Fix suspend/resume of ACB_ADAPTER_TYPE_B part 2. > What does this look like from a user perspective? Does it fail every time or does it only fail sometimes? What's the bug exactly? There

[PATCH 0/3] scsi: arcmsr: Fix suspend/resume of ACB_ADAPTER_TYPE_B part 2

2019-01-16 Thread Ching Huang
This patch series are against to mkp's 5.1/scsi-queue. 1. Due to dma_zalloc_coherent will be phase out, so use dma_alloc_coherent to replace it. 2. Fix suspend/resume of ACB_ADAPTER_TYPE_B part 2. 3. Update driver version to v1.40.00.10-20190116 ---

[PATCH 2/3] scsi: arcmsr: Fix suspend/resume of ACB_ADAPTER_TYPE_B part 2

2019-01-16 Thread Ching Huang
>From Ching Huang Fix suspend/resume of ACB_ADAPTER_TYPE_B part 2. Signed-off-by: Ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h index a94c513..b98c632 100755 --- a/drivers/scsi/arcmsr/arcmsr.h +++ b/drivers/scsi/arcmsr/arcmsr.h @@ -508,9 +50

Fix suspend/resume of ACB_ADAPTER_TYPE_B part 2

2019-01-16 Thread Ching Huang
This patch series are against to mkp's 5.1/scsi-queue. 1. Due to dma_zalloc_coherent will be phase out, so use dma_alloc_coherent to replace it. 2. Fix suspend/resume of ACB_ADAPTER_TYPE_B part 2. 3. Update driver version to v1.40.00.10-20190116 ---

Re: [PATCH net-next] net: dsa: mv88e6xxx: Add suspend/resume callbacks

2019-01-16 Thread Andrew Lunn
Hi Florian > A possible approach could be to call the port_disable, port_enable > callbacks from dsa_slave_suspend() and dsa_slave_resume(), I might have > some patches doing that already somewhere. I expect it is also on Viviens TODO list, since this really could be in the core. Andrew

Re: [PATCH net-next] net: dsa: mv88e6xxx: Add suspend/resume callbacks

2019-01-16 Thread Florian Fainelli
On 1/16/19 7:56 AM, Andrew Lunn wrote: > On Wed, Jan 16, 2019 at 04:34:19PM +0100, Miquel Raynal wrote: >> Bring S2RAM support to the mv88e6xxx DSA driver. >> >> The content of the *_irq_poll() helper is moved in *_do_irq_poll() so >> that that the function can be called from the ->resume()

Re: [PATCH net-next] net: dsa: mv88e6xxx: Add suspend/resume callbacks

2019-01-16 Thread Andrew Lunn
On Wed, Jan 16, 2019 at 04:34:19PM +0100, Miquel Raynal wrote: > Bring S2RAM support to the mv88e6xxx DSA driver. > > The content of the *_irq_poll() helper is moved in *_do_irq_poll() so > that that the function can be called from the ->resume() callback > without using the *work pointer. > >

[PATCH net-next] net: dsa: mv88e6xxx: Add suspend/resume callbacks

2019-01-16 Thread Miquel Raynal
Bring S2RAM support to the mv88e6xxx DSA driver. The content of the *_irq_poll() helper is moved in *_do_irq_poll() so that that the function can be called from the ->resume() callback without using the *work pointer. Signed-off-by: Miquel Raynal --- drivers/net/dsa/mv88e6xxx/chip.c | 52

Re: [PATCH v4 08/16] drm/bochs: atomic: use suspend/resume helpers

2019-01-11 Thread Oleksandr Andrushchenko
On 1/11/19 7:37 AM, Gerd Hoffmann wrote: Switch to atomic helpers: drm_mode_config_helper_suspend/resume(). Signed-off-by: Gerd Hoffmann Reviewed-by: Oleksandr Andrushchenko --- drivers/gpu/drm/bochs/bochs_drv.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff

[PATCH v4 08/16] drm/bochs: atomic: use suspend/resume helpers

2019-01-10 Thread Gerd Hoffmann
Switch to atomic helpers: drm_mode_config_helper_suspend/resume(). Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs_drv.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/bochs/bochs_drv.c b/drivers/gpu/drm/bochs/bochs_drv.c index

Re: [PATCH v2 0/3] drm/amdgpu: Fix suspend/resume issues with MST

2019-01-08 Thread Lyude Paul
On Tue, 2019-01-08 at 16:17 -0500, Alex Deucher wrote: > On Tue, Jan 8, 2019 at 4:11 PM Lyude Paul wrote: > > Fix the suspend/issues that Jerry Zuo found in amdgpu, and add some > > compiler warnings for drivers ignoring the return code of > > drm_dp_mst_topology_mgr_resume() to help ensure we

Re: [PATCH v2 0/3] drm/amdgpu: Fix suspend/resume issues with MST

2019-01-08 Thread Alex Deucher
On Tue, Jan 8, 2019 at 4:11 PM Lyude Paul wrote: > > Fix the suspend/issues that Jerry Zuo found in amdgpu, and add some > compiler warnings for drivers ignoring the return code of > drm_dp_mst_topology_mgr_resume() to help ensure we don't need to fix > this again in the future for someone else's

[PATCH v2 0/3] drm/amdgpu: Fix suspend/resume issues with MST

2019-01-08 Thread Lyude Paul
Fix the suspend/issues that Jerry Zuo found in amdgpu, and add some compiler warnings for drivers ignoring the return code of drm_dp_mst_topology_mgr_resume() to help ensure we don't need to fix this again in the future for someone else's driver. Cc: Jerry Zuo Lyude Paul (3): drm/amdgpu:

Re: [PATCH 0/3] drm/amdgpu: Fix suspend/resume issues with MST

2019-01-08 Thread Wentland, Harry
On 2019-01-07 7:56 p.m., Lyude Paul wrote: > Fix the suspend/issues that Jerry Zuo found in amdgpu, and add some > compiler warnings for drivers ignoring the return code of > drm_dp_mst_topology_mgr_resume() to help ensure we don't need to fix > this again in the future for someone else's driver.

[PATCH 0/3] drm/amdgpu: Fix suspend/resume issues with MST

2019-01-07 Thread Lyude Paul
Fix the suspend/issues that Jerry Zuo found in amdgpu, and add some compiler warnings for drivers ignoring the return code of drm_dp_mst_topology_mgr_resume() to help ensure we don't need to fix this again in the future for someone else's driver. Cc: Jerry Zuo Lyude Paul (3): drm/amdgpu:

Re: [PATCH v3 4/5] drivers: power: suspend: call devfreq suspend/resume

2019-01-03 Thread Rafael J. Wysocki
On Wed, Jan 2, 2019 at 4:08 PM Lukasz Luba wrote: > > Hi Rafael, > > Gentle ping... > Please take this patch, it got ACK. > The other patches have been taken through MyungJoo's > tree, but this one is actually enabling the feature. Applied now and sorry for missing it. Thanks!

Re: [PATCH v3 4/5] drivers: power: suspend: call devfreq suspend/resume

2019-01-02 Thread Lukasz Luba
vfreq framework supports suspend of its devices. >>> Call the the devfreq interface and allow devfreq devices preserve/restore >>> their states during suspend/resume. >>> >>> Suggested-by: Tobias Jakobi >>> Reviewed-by: Chanwoo Choi >>> S

RE: Re: [PATCH v3 4/5] drivers: power: suspend: call devfreq suspend/resume

2018-12-20 Thread MyungJoo Ham
>On 2018-12-05 12:05, Lukasz Luba wrote: >> Devfreq framework supports suspend of its devices. >> Call the the devfreq interface and allow devfreq devices preserve/restore >> their states during suspend/resume. >> >> Suggested-by: Tobias Jakobi >> R

[PATCH 10/10] i2c: rcar: add suspend/resume support

2018-12-19 Thread Wolfram Sang
Because the adapter will be set up before every transaction anyhow, we just need to mark it as suspended to the I2C core. Signed-off-by: Hiromitsu Yamasaki Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-rcar.c | 25 + 1 file changed, 25 insertions(+) diff --git

[PATCH 11/12] scsi: arcmsr: Fix suspend/resume of ACB_ADAPTER_TYPE_B

2018-12-19 Thread Ching Huang
>From Ching Huang Fix suspend/resume of ACB_ADAPTER_TYPE_B Signed-off-by: Ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c index 30dff6c..9f85d5a 100755 --- a/drivers/scsi/arcmsr/arcmsr_hba.c +++ b/drivers/scsi/arcmsr/arcmsr_hba.c @@ -1110

Re: [RFC/RFT 10/10] i2c: rcar: add suspend/resume support

2018-12-18 Thread Wolfram Sang
> > Because the adapter will be set up before every transaction anyhow, we > > just need to mark it as adapted to the I2C core. > > mark it as "suspended", not "adapted"? Sure thing :D Thanks! signature.asc Description: PGP signature

Re: [PATCH v3 4/5] drivers: power: suspend: call devfreq suspend/resume

2018-12-13 Thread Lukasz Luba
eserve/restore > their states during suspend/resume. > > Suggested-by: Tobias Jakobi > Reviewed-by: Chanwoo Choi > Signed-off-by: Lukasz Luba > --- > drivers/base/power/main.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/base/power/main.c

Re: [PATCH v3 2/5] devfreq: add support for suspend/resume of a devfreq device

2018-12-11 Thread Lukasz Luba
Hi MyungJoo, Thank you for taking the patch set. Please check my response bellow. On 12/11/18 2:43 AM, MyungJoo Ham wrote: >> Hi Lukasz, >> >> On 2018년 12월 05일 20:05, Lukasz Luba wrote: >>> The patch prepares devfreq device for handling suspend/resume >>> func

RE: Re: [PATCH v3 2/5] devfreq: add support for suspend/resume of a devfreq device

2018-12-10 Thread MyungJoo Ham
> Hi Lukasz, > > On 2018년 12월 05일 20:05, Lukasz Luba wrote: > > The patch prepares devfreq device for handling suspend/resume > > functionality. The new fields will store needed information during this > > process. Devfreq framework handles opp-suspend DT ent

Re: [RFC/RFT 10/10] i2c: rcar: add suspend/resume support

2018-12-10 Thread Peter Rosin
On 2018-12-10 22:03, Wolfram Sang wrote: > Because the adapter will be set up before every transaction anyhow, we > just need to mark it as adapted to the I2C core. mark it as "suspended", not "adapted"? Cheers, Peter > > Signed-off-by: Hiromitsu Yamasaki > Signed-off-by: Wolfram Sang > ---

[RFC/RFT 10/10] i2c: rcar: add suspend/resume support

2018-12-10 Thread Wolfram Sang
Because the adapter will be set up before every transaction anyhow, we just need to mark it as adapted to the I2C core. Signed-off-by: Hiromitsu Yamasaki Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-rcar.c | 25 + 1 file changed, 25 insertions(+) diff --git

Re: [PATCH v2 2/5] devfreq: add support for suspend/resume of a devfreq device

2018-12-09 Thread Pavel Machek
On Tue 2018-12-04 14:36:11, Chanwoo Choi wrote: > Hi Lukasz, > > Looks good to me. But, I add the some comments. > If you will fix it, feel free to add my tag: > Reviewed-by: Chanwoo choi > > On 2018년 12월 03일 23:31, Lukasz Luba wrote: > > The patch prepares devfreq

Re: [PATCH v3 2/5] devfreq: add support for suspend/resume of a devfreq device

2018-12-06 Thread Lukasz Luba
Hi Chanwoo, On 12/6/18 2:17 AM, Chanwoo Choi wrote: > Hi Lukasz, > > On 2018년 12월 05일 20:05, Lukasz Luba wrote: >> The patch prepares devfreq device for handling suspend/resume >> functionality. The new fields will store needed information during this >> process. De

Re: [PATCH v3 2/5] devfreq: add support for suspend/resume of a devfreq device

2018-12-06 Thread Lukasz Luba
Hi Chanwoo, On 12/6/18 2:17 AM, Chanwoo Choi wrote: > Hi Lukasz, > > On 2018년 12월 05일 20:05, Lukasz Luba wrote: >> The patch prepares devfreq device for handling suspend/resume >> functionality. The new fields will store needed information during this >> process. De

Re: [PATCH v3 2/5] devfreq: add support for suspend/resume of a devfreq device

2018-12-05 Thread Chanwoo Choi
Hi Lukasz, On 2018년 12월 05일 20:05, Lukasz Luba wrote: > The patch prepares devfreq device for handling suspend/resume > functionality. The new fields will store needed information during this > process. Devfreq framework handles opp-suspend DT entry and there is no > need of m

Re: [PATCH v3 2/5] devfreq: add support for suspend/resume of a devfreq device

2018-12-05 Thread Chanwoo Choi
Hi Lukasz, On 2018년 12월 05일 20:05, Lukasz Luba wrote: > The patch prepares devfreq device for handling suspend/resume > functionality. The new fields will store needed information during this > process. Devfreq framework handles opp-suspend DT entry and there is no > need of m

Re: [PATCH v2 2/5] devfreq: add support for suspend/resume of a devfreq device

2018-12-05 Thread Lukasz Luba
gt;> If you will fix it, feel free to add my tag: >>>>> Reviewed-by: Chanwoo choi >>>> >>>> Sorry. Fix typo 'choi' to 'Choi' as following. >>>> Reviewed-by: Chanwoo Choi >>>> >>>>> >>>>> On

Re: [PATCH v2 2/5] devfreq: add support for suspend/resume of a devfreq device

2018-12-05 Thread Lukasz Luba
gt;> If you will fix it, feel free to add my tag: >>>>> Reviewed-by: Chanwoo choi >>>> >>>> Sorry. Fix typo 'choi' to 'Choi' as following. >>>> Reviewed-by: Chanwoo Choi >>>> >>>>> >>>>> On

[PATCH v3 2/5] devfreq: add support for suspend/resume of a devfreq device

2018-12-05 Thread Lukasz Luba
The patch prepares devfreq device for handling suspend/resume functionality. The new fields will store needed information during this process. Devfreq framework handles opp-suspend DT entry and there is no need of modyfications in the drivers code. It uses atomic variables to make sure no race

[PATCH v3 2/5] devfreq: add support for suspend/resume of a devfreq device

2018-12-05 Thread Lukasz Luba
The patch prepares devfreq device for handling suspend/resume functionality. The new fields will store needed information during this process. Devfreq framework handles opp-suspend DT entry and there is no need of modyfications in the drivers code. It uses atomic variables to make sure no race

[PATCH v3 4/5] drivers: power: suspend: call devfreq suspend/resume

2018-12-05 Thread Lukasz Luba
Devfreq framework supports suspend of its devices. Call the the devfreq interface and allow devfreq devices preserve/restore their states during suspend/resume. Suggested-by: Tobias Jakobi Reviewed-by: Chanwoo Choi Signed-off-by: Lukasz Luba --- drivers/base/power/main.c | 3 +++ 1 file

[PATCH v3 4/5] drivers: power: suspend: call devfreq suspend/resume

2018-12-05 Thread Lukasz Luba
Devfreq framework supports suspend of its devices. Call the the devfreq interface and allow devfreq devices preserve/restore their states during suspend/resume. Suggested-by: Tobias Jakobi Reviewed-by: Chanwoo Choi Signed-off-by: Lukasz Luba --- drivers/base/power/main.c | 3 +++ 1 file

[PATCH v3 0/5] devfreq: handle suspend/resume

2018-12-05 Thread Lukasz Luba
Hi all, This v3 patch set aims to address the issue with devfreq devices' frequency during suspend/resume. It extends suspend/resume by calls to Devfreq framework. In the devfreq framework there is a small refactoring to avoid code duplication in changging frequency (patch 1

[PATCH v3 0/5] devfreq: handle suspend/resume

2018-12-05 Thread Lukasz Luba
Hi all, This v3 patch set aims to address the issue with devfreq devices' frequency during suspend/resume. It extends suspend/resume by calls to Devfreq framework. In the devfreq framework there is a small refactoring to avoid code duplication in changging frequency (patch 1

Re: [PATCH v2 2/5] devfreq: add support for suspend/resume of a devfreq device

2018-12-04 Thread Chanwoo Choi
t;>> Sorry. Fix typo 'choi' to 'Choi' as following. >>> Reviewed-by: Chanwoo Choi >>> >>>> >>>> On 2018년 12월 03일 23:31, Lukasz Luba wrote: >>>>> The patch prepares devfreq device for handling suspend/resume >>>>> functionality. The

Re: [PATCH v2 2/5] devfreq: add support for suspend/resume of a devfreq device

2018-12-04 Thread Chanwoo Choi
t;>> Sorry. Fix typo 'choi' to 'Choi' as following. >>> Reviewed-by: Chanwoo Choi >>> >>>> >>>> On 2018년 12월 03일 23:31, Lukasz Luba wrote: >>>>> The patch prepares devfreq device for handling suspend/resume >>>>> functionality. The

Re: [PATCH v2 2/5] devfreq: add support for suspend/resume of a devfreq device

2018-12-04 Thread Lukasz Luba
>>> Looks good to me. But, I add the some comments. >>> If you will fix it, feel free to add my tag: >>> Reviewed-by: Chanwoo choi >> >> Sorry. Fix typo 'choi' to 'Choi' as following. >> Reviewed-by: Chanwoo Choi >> >>> >>> On 2018년

Re: [PATCH v2 2/5] devfreq: add support for suspend/resume of a devfreq device

2018-12-04 Thread Lukasz Luba
>>> Looks good to me. But, I add the some comments. >>> If you will fix it, feel free to add my tag: >>> Reviewed-by: Chanwoo choi >> >> Sorry. Fix typo 'choi' to 'Choi' as following. >> Reviewed-by: Chanwoo Choi >> >>> >>> On 2018년

Re: [PATCH v2 2/5] devfreq: add support for suspend/resume of a devfreq device

2018-12-04 Thread Lukasz Luba
devfreq device for handling suspend/resume >> functionality. The new fields will store needed information during this > > nitpick. Remove unneeded space. There are two spaces between '.' and 'The > new'. > >> process. Devfreq framework handles opp-suspend DT entry and

Re: [PATCH v2 2/5] devfreq: add support for suspend/resume of a devfreq device

2018-12-04 Thread Lukasz Luba
devfreq device for handling suspend/resume >> functionality. The new fields will store needed information during this > > nitpick. Remove unneeded space. There are two spaces between '.' and 'The > new'. > >> process. Devfreq framework handles opp-suspend DT entry and

Re: [PATCH v2 2/5] devfreq: add support for suspend/resume of a devfreq device

2018-12-03 Thread Chanwoo Choi
tag: >> Reviewed-by: Chanwoo choi > > Sorry. Fix typo 'choi' to 'Choi' as following. > Reviewed-by: Chanwoo Choi > >> >> On 2018년 12월 03일 23:31, Lukasz Luba wrote: >>> The patch prepares devfreq device for handling suspend/resume >>> functionality

Re: [PATCH v2 2/5] devfreq: add support for suspend/resume of a devfreq device

2018-12-03 Thread Chanwoo Choi
tag: >> Reviewed-by: Chanwoo choi > > Sorry. Fix typo 'choi' to 'Choi' as following. > Reviewed-by: Chanwoo Choi > >> >> On 2018년 12월 03일 23:31, Lukasz Luba wrote: >>> The patch prepares devfreq device for handling suspend/resume >>> functionality

Re: [PATCH v2 2/5] devfreq: add support for suspend/resume of a devfreq device

2018-12-03 Thread Chanwoo Choi
n 2018년 12월 03일 23:31, Lukasz Luba wrote: >> The patch prepares devfreq device for handling suspend/resume >> functionality. The new fields will store needed information during this > > nitpick. Remove unneeded space. There are two spaces between '.' and 'The > new'. > >&

Re: [PATCH v2 2/5] devfreq: add support for suspend/resume of a devfreq device

2018-12-03 Thread Chanwoo Choi
n 2018년 12월 03일 23:31, Lukasz Luba wrote: >> The patch prepares devfreq device for handling suspend/resume >> functionality. The new fields will store needed information during this > > nitpick. Remove unneeded space. There are two spaces between '.' and 'The > new'. > >&

Re: [PATCH v2 2/5] devfreq: add support for suspend/resume of a devfreq device

2018-12-03 Thread Chanwoo Choi
Hi Lukasz, Looks good to me. But, I add the some comments. If you will fix it, feel free to add my tag: Reviewed-by: Chanwoo choi On 2018년 12월 03일 23:31, Lukasz Luba wrote: > The patch prepares devfreq device for handling suspend/resume > functionality. The new fields will store

Re: [PATCH v2 2/5] devfreq: add support for suspend/resume of a devfreq device

2018-12-03 Thread Chanwoo Choi
Hi Lukasz, Looks good to me. But, I add the some comments. If you will fix it, feel free to add my tag: Reviewed-by: Chanwoo choi On 2018년 12월 03일 23:31, Lukasz Luba wrote: > The patch prepares devfreq device for handling suspend/resume > functionality. The new fields will store

[PATCH v2 0/5] devfreq: handle suspend/resume

2018-12-03 Thread Lukasz Luba
Hi all, This v2 patch set aims to address the issue with devfreq devices' frequency during suspend/resume. It extends suspend/resume by calls to Devfreq framework. In the devfreq framework there is a small refactoring to avoid code duplication in changging frequency (patch 1

[PATCH v2 0/5] devfreq: handle suspend/resume

2018-12-03 Thread Lukasz Luba
Hi all, This v2 patch set aims to address the issue with devfreq devices' frequency during suspend/resume. It extends suspend/resume by calls to Devfreq framework. In the devfreq framework there is a small refactoring to avoid code duplication in changging frequency (patch 1

[PATCH v2 4/5] drivers: power: suspend: call devfreq suspend/resume

2018-12-03 Thread Lukasz Luba
Devfreq framework supports suspend of its devices. Call the the devfreq interface and allow devfreq devices preserve/restore their states during suspend/resume. The patch is based on earlier work by Tobias Jakobi. Suggested-by: Tobias Jakobi Reviewed-by: Chanwoo Choi Signed-off-by: Lukasz Luba

[PATCH v2 4/5] drivers: power: suspend: call devfreq suspend/resume

2018-12-03 Thread Lukasz Luba
Devfreq framework supports suspend of its devices. Call the the devfreq interface and allow devfreq devices preserve/restore their states during suspend/resume. The patch is based on earlier work by Tobias Jakobi. Suggested-by: Tobias Jakobi Reviewed-by: Chanwoo Choi Signed-off-by: Lukasz Luba

[PATCH v2 2/5] devfreq: add support for suspend/resume of a devfreq device

2018-12-03 Thread Lukasz Luba
The patch prepares devfreq device for handling suspend/resume functionality. The new fields will store needed information during this process. Devfreq framework handles opp-suspend DT entry and there is no need of modyfications in the drivers code. It uses atomic variables to make sure no race

[PATCH v2 2/5] devfreq: add support for suspend/resume of a devfreq device

2018-12-03 Thread Lukasz Luba
The patch prepares devfreq device for handling suspend/resume functionality. The new fields will store needed information during this process. Devfreq framework handles opp-suspend DT entry and there is no need of modyfications in the drivers code. It uses atomic variables to make sure no race

Re: [PATCH 3/6] devfreq: add support for suspend/resume of a devfreq device

2018-12-03 Thread Lukasz Luba
Hi Lukasz, >>> >>> I add one more comment about devfreq_resume_device(). >>> >>> On 2018년 11월 22일 20:00, Lukasz Luba wrote: >>>> >>>> >>>> On 11/22/18 3:58 AM, Chanwoo Choi wrote: >>>>> On 2018년 11월 22일 03:01, L

Re: [PATCH 3/6] devfreq: add support for suspend/resume of a devfreq device

2018-12-03 Thread Lukasz Luba
Hi Lukasz, >>> >>> I add one more comment about devfreq_resume_device(). >>> >>> On 2018년 11월 22일 20:00, Lukasz Luba wrote: >>>> >>>> >>>> On 11/22/18 3:58 AM, Chanwoo Choi wrote: >>>>> On 2018년 11월 22일 03:01, L

[PATCH 3.18 38/83] Input: xpad - workaround dead irq_out after suspend/ resume

2018-11-29 Thread Greg Kroah-Hartman
3.18-stable review patch. If anyone has any objections, please let me know. -- [ Upstream commit 4220f7db1e424f2a086ad41217b5770cc9f003a9 ] The irq_out urb is dead after suspend/ resume on my x360 wr pad. (also reproduced by Zachary Lund [0]) Work around this by implementing

[PATCH 3.18 38/83] Input: xpad - workaround dead irq_out after suspend/ resume

2018-11-29 Thread Greg Kroah-Hartman
3.18-stable review patch. If anyone has any objections, please let me know. -- [ Upstream commit 4220f7db1e424f2a086ad41217b5770cc9f003a9 ] The irq_out urb is dead after suspend/ resume on my x360 wr pad. (also reproduced by Zachary Lund [0]) Work around this by implementing

[PATCH 4.4 35/86] Input: xpad - workaround dead irq_out after suspend/ resume

2018-11-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- [ Upstream commit 4220f7db1e424f2a086ad41217b5770cc9f003a9 ] The irq_out urb is dead after suspend/ resume on my x360 wr pad. (also reproduced by Zachary Lund [0]) Work around this by implementing

[PATCH 4.4 35/86] Input: xpad - workaround dead irq_out after suspend/ resume

2018-11-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- [ Upstream commit 4220f7db1e424f2a086ad41217b5770cc9f003a9 ] The irq_out urb is dead after suspend/ resume on my x360 wr pad. (also reproduced by Zachary Lund [0]) Work around this by implementing

[PATCH v2 4/4] net: macb: Add support for suspend/resume with full power down

2018-11-25 Thread Harini Katakam
When macb device is suspended and system is powered down, the clocks are removed and hence macb should be closed gracefully and restored upon resume. This patch does the same by switching off the net device, suspending phy and performing necessary cleanup of interrupts and BDs. Upon resume, all

[PATCH v2 4/4] net: macb: Add support for suspend/resume with full power down

2018-11-25 Thread Harini Katakam
When macb device is suspended and system is powered down, the clocks are removed and hence macb should be closed gracefully and restored upon resume. This patch does the same by switching off the net device, suspending phy and performing necessary cleanup of interrupts and BDs. Upon resume, all

Re: [PATCH 3/6] devfreq: add support for suspend/resume of a devfreq device

2018-11-25 Thread Chanwoo Choi
2018년 11월 22일 20:00, Lukasz Luba wrote: >>> >>> >>> On 11/22/18 3:58 AM, Chanwoo Choi wrote: >>>> On 2018년 11월 22일 03:01, Lukasz Luba wrote: >>>>> The patch adds support for handling suspend/resume process. >>>>> It uses atom

Re: [PATCH 3/6] devfreq: add support for suspend/resume of a devfreq device

2018-11-25 Thread Chanwoo Choi
2018년 11월 22일 20:00, Lukasz Luba wrote: >>> >>> >>> On 11/22/18 3:58 AM, Chanwoo Choi wrote: >>>> On 2018년 11월 22일 03:01, Lukasz Luba wrote: >>>>> The patch adds support for handling suspend/resume process. >>>>> It uses atom

Re: [PATCH 3/6] devfreq: add support for suspend/resume of a devfreq device

2018-11-23 Thread Lukasz Luba
01, Lukasz Luba wrote: >>>> The patch adds support for handling suspend/resume process. >>>> It uses atomic variables to make sure no race condition >>>> affects the process. >>>> >>>> The patch draws on Tobias Jakobi's work posted ~2 years

Re: [PATCH 3/6] devfreq: add support for suspend/resume of a devfreq device

2018-11-23 Thread Lukasz Luba
01, Lukasz Luba wrote: >>>> The patch adds support for handling suspend/resume process. >>>> It uses atomic variables to make sure no race condition >>>> affects the process. >>>> >>>> The patch draws on Tobias Jakobi's work posted ~2 years

Re: [PATCH 3/6] devfreq: add support for suspend/resume of a devfreq device

2018-11-22 Thread Chanwoo Choi
Hi Lukasz, I add one more comment about devfreq_resume_device(). On 2018년 11월 22일 20:00, Lukasz Luba wrote: > > > On 11/22/18 3:58 AM, Chanwoo Choi wrote: >> On 2018년 11월 22일 03:01, Lukasz Luba wrote: >>> The patch adds support for handling suspend/resume process. >

Re: [PATCH 3/6] devfreq: add support for suspend/resume of a devfreq device

2018-11-22 Thread Chanwoo Choi
Hi Lukasz, I add one more comment about devfreq_resume_device(). On 2018년 11월 22일 20:00, Lukasz Luba wrote: > > > On 11/22/18 3:58 AM, Chanwoo Choi wrote: >> On 2018년 11월 22일 03:01, Lukasz Luba wrote: >>> The patch adds support for handling suspend/resume process. >

Re: [PATCH 0/6] devfreq: handle suspend/resume

2018-11-22 Thread Lukasz Luba
all, >> >> This patch set aims to address the issue with devfreq devices' frequency >> during suspend/resume. It extends suspend/resume by calls to Devfreq >> framework. In the devfreq framework there is a small refactoring to avoid >> code duplication in changgin

Re: [PATCH 0/6] devfreq: handle suspend/resume

2018-11-22 Thread Lukasz Luba
all, >> >> This patch set aims to address the issue with devfreq devices' frequency >> during suspend/resume. It extends suspend/resume by calls to Devfreq >> framework. In the devfreq framework there is a small refactoring to avoid >> code duplication in changgin

Re: [PATCH 0/6] devfreq: handle suspend/resume

2018-11-22 Thread Tobias Jakobi
the issue with devfreq devices' frequency > during suspend/resume. It extends suspend/resume by calls to Devfreq > framework. In the devfreq framework there is a small refactoring to avoid > code duplication in changging frequency (patch 2) and there are extensions > for suspending devi

Re: [PATCH 0/6] devfreq: handle suspend/resume

2018-11-22 Thread Tobias Jakobi
the issue with devfreq devices' frequency > during suspend/resume. It extends suspend/resume by calls to Devfreq > framework. In the devfreq framework there is a small refactoring to avoid > code duplication in changging frequency (patch 2) and there are extensions > for suspending devi

Re: [PATCH v2] PCI: imx: Add imx6sx suspend/resume support

2018-11-22 Thread Lorenzo Pieralisi
On Wed, Nov 07, 2018 at 01:57:03PM +, Leonard Crestez wrote: > Enable PCI suspend/resume support on imx6sx socs. This is similar to > imx7d with a few differences: > > * The PM_Turn_Off bit is exposed through an IOMUX GPR, like all other > pcie control bits on 6sx. > * Th

Re: [PATCH v2] PCI: imx: Add imx6sx suspend/resume support

2018-11-22 Thread Lorenzo Pieralisi
On Wed, Nov 07, 2018 at 01:57:03PM +, Leonard Crestez wrote: > Enable PCI suspend/resume support on imx6sx socs. This is similar to > imx7d with a few differences: > > * The PM_Turn_Off bit is exposed through an IOMUX GPR, like all other > pcie control bits on 6sx. > * Th

Re: [PATCH v2] PCI: imx: Add imx6sx suspend/resume support

2018-11-22 Thread Lucas Stach
Am Donnerstag, den 22.11.2018, 11:38 + schrieb Lorenzo Pieralisi: > On Wed, Nov 07, 2018 at 01:57:03PM +, Leonard Crestez wrote: > > Enable PCI suspend/resume support on imx6sx socs. This is similar to > > imx7d with a few differences: > > > > * The PM_Turn

Re: [PATCH v2] PCI: imx: Add imx6sx suspend/resume support

2018-11-22 Thread Lucas Stach
Am Donnerstag, den 22.11.2018, 11:38 + schrieb Lorenzo Pieralisi: > On Wed, Nov 07, 2018 at 01:57:03PM +, Leonard Crestez wrote: > > Enable PCI suspend/resume support on imx6sx socs. This is similar to > > imx7d with a few differences: > > > > * The PM_Turn

Re: [PATCH v2] PCI: imx: Add imx6sx suspend/resume support

2018-11-22 Thread Lorenzo Pieralisi
On Wed, Nov 07, 2018 at 01:57:03PM +, Leonard Crestez wrote: > Enable PCI suspend/resume support on imx6sx socs. This is similar to > imx7d with a few differences: > > * The PM_Turn_Off bit is exposed through an IOMUX GPR, like all other > pcie control bits on 6sx. > * Th

Re: [PATCH v2] PCI: imx: Add imx6sx suspend/resume support

2018-11-22 Thread Lorenzo Pieralisi
On Wed, Nov 07, 2018 at 01:57:03PM +, Leonard Crestez wrote: > Enable PCI suspend/resume support on imx6sx socs. This is similar to > imx7d with a few differences: > > * The PM_Turn_Off bit is exposed through an IOMUX GPR, like all other > pcie control bits on 6sx. > * Th

Re: [PATCH 3/6] devfreq: add support for suspend/resume of a devfreq device

2018-11-22 Thread Lukasz Luba
On 11/22/18 3:58 AM, Chanwoo Choi wrote: > On 2018년 11월 22일 03:01, Lukasz Luba wrote: >> The patch adds support for handling suspend/resume process. >> It uses atomic variables to make sure no race condition >> affects the process. >> >> The patch draws on Tob

Re: [PATCH 3/6] devfreq: add support for suspend/resume of a devfreq device

2018-11-22 Thread Lukasz Luba
On 11/22/18 3:58 AM, Chanwoo Choi wrote: > On 2018년 11월 22일 03:01, Lukasz Luba wrote: >> The patch adds support for handling suspend/resume process. >> It uses atomic variables to make sure no race condition >> affects the process. >> >> The patch draws on Tob

Re: [PATCH 5/6] drivers: power: suspend: call devfreq suspend/resume

2018-11-21 Thread Chanwoo Choi
Hi, On 2018년 11월 22일 03:01, Lukasz Luba wrote: > Devfreq framework supports suspend of its devices. > Call the the devfreq interface and allow devfreq devices preserve/restore > their states during suspend/resume. > > The patch draws on Tobias Jakobi's work posted ~2 years

Re: [PATCH 5/6] drivers: power: suspend: call devfreq suspend/resume

2018-11-21 Thread Chanwoo Choi
Hi, On 2018년 11월 22일 03:01, Lukasz Luba wrote: > Devfreq framework supports suspend of its devices. > Call the the devfreq interface and allow devfreq devices preserve/restore > their states during suspend/resume. > > The patch draws on Tobias Jakobi's work posted ~2 years

Re: [PATCH 3/6] devfreq: add support for suspend/resume of a devfreq device

2018-11-21 Thread Chanwoo Choi
On 2018년 11월 22일 03:01, Lukasz Luba wrote: > The patch adds support for handling suspend/resume process. > It uses atomic variables to make sure no race condition > affects the process. > > The patch draws on Tobias Jakobi's work posted ~2 years ago, who tried to > solve

Re: [PATCH 3/6] devfreq: add support for suspend/resume of a devfreq device

2018-11-21 Thread Chanwoo Choi
On 2018년 11월 22일 03:01, Lukasz Luba wrote: > The patch adds support for handling suspend/resume process. > It uses atomic variables to make sure no race condition > affects the process. > > The patch draws on Tobias Jakobi's work posted ~2 years ago, who tried to > solve

<    4   5   6   7   8   9   10   11   12   13   >