Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-05 Thread Kristen Carlson Accardi
On Mon, 05 Nov 2007 07:53:58 -0500 Jeff Garzik <[EMAIL PROTECTED]> wrote: > > Yep, works for me! Can we get this expedited upstream? > > If everybody's happy with it, I've got it ready for upstream in > libata-dev.git#dlpm-fix > > Jeff Thanks! It'd be great if you could get it in ASAP.

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-05 Thread Jeff Garzik
Jens Axboe wrote: On Fri, Nov 02 2007, Kristen Carlson Accardi wrote: On Thu, 1 Nov 2007 09:41:46 +0100 Jens Axboe <[EMAIL PROTECTED]> wrote: On Wed, Oct 31 2007, Jens Axboe wrote: Hi, My x60 stopped suspending about two days ago. It just freezes after printing Suspending console(s) where

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-05 Thread Jens Axboe
On Fri, Nov 02 2007, Kristen Carlson Accardi wrote: > On Thu, 1 Nov 2007 09:41:46 +0100 > Jens Axboe <[EMAIL PROTECTED]> wrote: > > > On Wed, Oct 31 2007, Jens Axboe wrote: > > > Hi, > > > > > > My x60 stopped suspending about two days ago. It just freezes after > > > printing > > > > > >

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-05 Thread Jens Axboe
On Fri, Nov 02 2007, Kristen Carlson Accardi wrote: On Thu, 1 Nov 2007 09:41:46 +0100 Jens Axboe [EMAIL PROTECTED] wrote: On Wed, Oct 31 2007, Jens Axboe wrote: Hi, My x60 stopped suspending about two days ago. It just freezes after printing Suspending console(s)

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-05 Thread Jeff Garzik
Jens Axboe wrote: On Fri, Nov 02 2007, Kristen Carlson Accardi wrote: On Thu, 1 Nov 2007 09:41:46 +0100 Jens Axboe [EMAIL PROTECTED] wrote: On Wed, Oct 31 2007, Jens Axboe wrote: Hi, My x60 stopped suspending about two days ago. It just freezes after printing Suspending console(s) where

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-05 Thread Kristen Carlson Accardi
On Mon, 05 Nov 2007 07:53:58 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: Yep, works for me! Can we get this expedited upstream? If everybody's happy with it, I've got it ready for upstream in libata-dev.git#dlpm-fix Jeff Thanks! It'd be great if you could get it in ASAP. - To

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-03 Thread Arjan van de Ven
On Sat, 3 Nov 2007 02:23:04 -0400 Theodore Tso <[EMAIL PROTECTED]> wrote: > Yep, this fixes suspend/resume on my X61 thinkpad. Interestingly I'm > not seeing any power savings with ALPM set to min_power, at least not > compared to what I get after suspend and resuming (which mysteriously > cause

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-03 Thread Arjan van de Ven
On Sat, 3 Nov 2007 02:23:04 -0400 Theodore Tso [EMAIL PROTECTED] wrote: Yep, this fixes suspend/resume on my X61 thinkpad. Interestingly I'm not seeing any power savings with ALPM set to min_power, at least not compared to what I get after suspend and resuming (which mysteriously cause the

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-02 Thread Theodore Tso
On Fri, Nov 02, 2007 at 04:37:08PM -0700, Kristen Carlson Accardi wrote: > > Does this patch fix your problem? It seems to get hung up while disabling > DIPM, and after thinking about this a bit, I don't think we really need > to do this anyway. Yep, this fixes suspend/resume on my X61

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-02 Thread Kristen Carlson Accardi
On Thu, 1 Nov 2007 09:41:46 +0100 Jens Axboe <[EMAIL PROTECTED]> wrote: > On Wed, Oct 31 2007, Jens Axboe wrote: > > Hi, > > > > My x60 stopped suspending about two days ago. It just freezes after > > printing > > > > Suspending console(s) > > > > where it would normally turn everything off

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-02 Thread Kristen Carlson Accardi
On Thu, 1 Nov 2007 09:41:46 +0100 Jens Axboe [EMAIL PROTECTED] wrote: On Wed, Oct 31 2007, Jens Axboe wrote: Hi, My x60 stopped suspending about two days ago. It just freezes after printing Suspending console(s) where it would normally turn everything off and the 'moon' light

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-02 Thread Theodore Tso
On Fri, Nov 02, 2007 at 04:37:08PM -0700, Kristen Carlson Accardi wrote: Does this patch fix your problem? It seems to get hung up while disabling DIPM, and after thinking about this a bit, I don't think we really need to do this anyway. Yep, this fixes suspend/resume on my X61 thinkpad.

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-01 Thread Kristen Carlson Accardi
On Thu, 01 Nov 2007 07:20:16 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Jens Axboe wrote: > > Reverting just the default AHCI flags makes it work again. IOW, with the > > below patch I can suspend properly with current -git. > > > > diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c > >

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-01 Thread Jens Axboe
On Thu, Nov 01 2007, Jeff Garzik wrote: > Jens Axboe wrote: >> On Thu, Nov 01 2007, Jeff Garzik wrote: >>> Jens Axboe wrote: Reverting just the default AHCI flags makes it work again. IOW, with the below patch I can suspend properly with current -git. diff --git a/drivers/ata/ahci.c

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-01 Thread Jeff Garzik
Jens Axboe wrote: On Thu, Nov 01 2007, Jeff Garzik wrote: Jens Axboe wrote: Reverting just the default AHCI flags makes it work again. IOW, with the below patch I can suspend properly with current -git. diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index ed9b407..77f7631 100644 ---

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-01 Thread Jens Axboe
On Thu, Nov 01 2007, Jeff Garzik wrote: > Jens Axboe wrote: >> Reverting just the default AHCI flags makes it work again. IOW, with the >> below patch I can suspend properly with current -git. >> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c >> index ed9b407..77f7631 100644 >> ---

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-01 Thread Jeff Garzik
Jens Axboe wrote: Reverting just the default AHCI flags makes it work again. IOW, with the below patch I can suspend properly with current -git. diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index ed9b407..77f7631 100644 --- a/drivers/ata/ahci.c +++ b/drivers/ata/ahci.c @@ -190,8 +190,7

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-01 Thread Jens Axboe
On Thu, Nov 01 2007, Jens Axboe wrote: > On Thu, Nov 01 2007, Jens Axboe wrote: > > On Wed, Oct 31 2007, Jens Axboe wrote: > > > Hi, > > > > > > My x60 stopped suspending about two days ago. It just freezes after > > > printing > > > > > > Suspending console(s) > > > > > > where it would

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-01 Thread Jens Axboe
On Thu, Nov 01 2007, Jens Axboe wrote: > On Wed, Oct 31 2007, Jens Axboe wrote: > > Hi, > > > > My x60 stopped suspending about two days ago. It just freezes after > > printing > > > > Suspending console(s) > > > > where it would normally turn everything off and the 'moon' light would > > go

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-01 Thread Jens Axboe
On Wed, Oct 31 2007, Jens Axboe wrote: > Hi, > > My x60 stopped suspending about two days ago. It just freezes after > printing > > Suspending console(s) > > where it would normally turn everything off and the 'moon' light would > go on. Posting this message in case somebody else knows what is

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-01 Thread Jens Axboe
On Wed, Oct 31 2007, Jens Axboe wrote: Hi, My x60 stopped suspending about two days ago. It just freezes after printing Suspending console(s) where it would normally turn everything off and the 'moon' light would go on. Posting this message in case somebody else knows what is up, if

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-01 Thread Jens Axboe
On Thu, Nov 01 2007, Jens Axboe wrote: On Wed, Oct 31 2007, Jens Axboe wrote: Hi, My x60 stopped suspending about two days ago. It just freezes after printing Suspending console(s) where it would normally turn everything off and the 'moon' light would go on. Posting this

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-01 Thread Jens Axboe
On Thu, Nov 01 2007, Jens Axboe wrote: On Thu, Nov 01 2007, Jens Axboe wrote: On Wed, Oct 31 2007, Jens Axboe wrote: Hi, My x60 stopped suspending about two days ago. It just freezes after printing Suspending console(s) where it would normally turn everything off and

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-01 Thread Jeff Garzik
Jens Axboe wrote: Reverting just the default AHCI flags makes it work again. IOW, with the below patch I can suspend properly with current -git. diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index ed9b407..77f7631 100644 --- a/drivers/ata/ahci.c +++ b/drivers/ata/ahci.c @@ -190,8 +190,7

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-01 Thread Jens Axboe
On Thu, Nov 01 2007, Jeff Garzik wrote: Jens Axboe wrote: Reverting just the default AHCI flags makes it work again. IOW, with the below patch I can suspend properly with current -git. diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index ed9b407..77f7631 100644 --- a/drivers/ata/ahci.c

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-01 Thread Jens Axboe
On Thu, Nov 01 2007, Jeff Garzik wrote: Jens Axboe wrote: On Thu, Nov 01 2007, Jeff Garzik wrote: Jens Axboe wrote: Reverting just the default AHCI flags makes it work again. IOW, with the below patch I can suspend properly with current -git. diff --git a/drivers/ata/ahci.c

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-01 Thread Jeff Garzik
Jens Axboe wrote: On Thu, Nov 01 2007, Jeff Garzik wrote: Jens Axboe wrote: Reverting just the default AHCI flags makes it work again. IOW, with the below patch I can suspend properly with current -git. diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index ed9b407..77f7631 100644 ---

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-01 Thread Kristen Carlson Accardi
On Thu, 01 Nov 2007 07:20:16 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: Jens Axboe wrote: Reverting just the default AHCI flags makes it work again. IOW, with the below patch I can suspend properly with current -git. diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index

Suspend to ram regression (2.6.24-rc1-git)

2007-10-31 Thread Jens Axboe
Hi, My x60 stopped suspending about two days ago. It just freezes after printing Suspending console(s) where it would normally turn everything off and the 'moon' light would go on. Posting this message in case somebody else knows what is up, if not I'll do a bisect on it tomorrow. -- Jens

Suspend to ram regression (2.6.24-rc1-git)

2007-10-31 Thread Jens Axboe
Hi, My x60 stopped suspending about two days ago. It just freezes after printing Suspending console(s) where it would normally turn everything off and the 'moon' light would go on. Posting this message in case somebody else knows what is up, if not I'll do a bisect on it tomorrow. -- Jens