Re: Swsusp, resume and kernel versions

2005-02-18 Thread Bernard Blackham
On Fri, Feb 18, 2005 at 12:24:09PM +0100, Pavel Machek wrote: > If you want to be 100% safe, add support to LILO/GRUB: just do not > allow selecting wrong kernel if last action was suspend. Bootloader > knows, it seen the command lines. That's a very good point/solution indeed. The hibernate

Re: Swsusp, resume and kernel versions

2005-02-18 Thread Stefan Seyfried
Nigel Cunningham wrote: > Hi Stefan. > > For Suspend2, we also put a device id in the space, so there's only room > for one character, which is a lower or upper case Z. (We also validate > the device ID, so a random Z won't cause an oops). > > Thanks for the code. With your/Suse's permission,

Re: Swsusp, resume and kernel versions

2005-02-18 Thread Pavel Machek
Hi! > > > > Just remember you're doing the mkswap if you decide to rearrange your > > > > partitions at all, or code a script smart enough to grep your swap > > > > partitions out of your fstab. > > > > > > It could be a workaround. Still it will cause loss of unsaved work if > > > I happen to

Re: Swsusp, resume and kernel versions

2005-02-18 Thread Nigel Cunningham
Hi Stefan. For Suspend2, we also put a device id in the space, so there's only room for one character, which is a lower or upper case Z. (We also validate the device ID, so a random Z won't cause an oops). Thanks for the code. With your/Suse's permission, I'll ask Bernard (cc'd) to include the

Re: Swsusp, resume and kernel versions

2005-02-18 Thread Stefan Seyfried
Nigel Cunningham wrote: > If the mistakenly booted kernel isn't suspend enabled, however, you need > a more generic method of removing the image, such as mkswapping the > storage device. This is what I was speaking of. The following code is used in the SUSE bootscripts to do exactly this:

Re: Swsusp, resume and kernel versions

2005-02-18 Thread Stefan Seyfried
Nigel Cunningham wrote: If the mistakenly booted kernel isn't suspend enabled, however, you need a more generic method of removing the image, such as mkswapping the storage device. This is what I was speaking of. The following code is used in the SUSE bootscripts to do exactly this:

Re: Swsusp, resume and kernel versions

2005-02-18 Thread Nigel Cunningham
Hi Stefan. For Suspend2, we also put a device id in the space, so there's only room for one character, which is a lower or upper case Z. (We also validate the device ID, so a random Z won't cause an oops). Thanks for the code. With your/Suse's permission, I'll ask Bernard (cc'd) to include the

Re: Swsusp, resume and kernel versions

2005-02-18 Thread Pavel Machek
Hi! Just remember you're doing the mkswap if you decide to rearrange your partitions at all, or code a script smart enough to grep your swap partitions out of your fstab. It could be a workaround. Still it will cause loss of unsaved work if I happen to load wrong kernel.

Re: Swsusp, resume and kernel versions

2005-02-18 Thread Stefan Seyfried
Nigel Cunningham wrote: Hi Stefan. For Suspend2, we also put a device id in the space, so there's only room for one character, which is a lower or upper case Z. (We also validate the device ID, so a random Z won't cause an oops). Thanks for the code. With your/Suse's permission, I'll ask

Re: Swsusp, resume and kernel versions

2005-02-18 Thread Bernard Blackham
On Fri, Feb 18, 2005 at 12:24:09PM +0100, Pavel Machek wrote: If you want to be 100% safe, add support to LILO/GRUB: just do not allow selecting wrong kernel if last action was suspend. Bootloader knows, it seen the command lines. That's a very good point/solution indeed. The hibernate script

Re: Swsusp, resume and kernel versions

2005-02-17 Thread Bernard Blackham
On Thu, Feb 17, 2005 at 08:56:52PM +0100, Pavel Machek wrote: > > > Just remember you're doing the mkswap if you decide to rearrange your > > > partitions at all, or code a script smart enough to grep your swap > > > partitions out of your fstab. > > > > It could be a workaround. Still it will

Re: Swsusp, resume and kernel versions

2005-02-17 Thread Dmitry Torokhov
On Thu, 17 Feb 2005 20:56:52 +0100, Pavel Machek <[EMAIL PROTECTED]> wrote: > Hi! > > > > Just remember you're doing the mkswap if you decide to rearrange your > > > partitions at all, or code a script smart enough to grep your swap > > > partitions out of your fstab. > > > > It could be a

Re: Swsusp, resume and kernel versions

2005-02-17 Thread Pavel Machek
Hi! > > Just remember you're doing the mkswap if you decide to rearrange your > > partitions at all, or code a script smart enough to grep your swap > > partitions out of your fstab. > > It could be a workaround. Still it will cause loss of unsaved work if > I happen to load wrong kernel. Given

Re: Swsusp, resume and kernel versions

2005-02-17 Thread Dmitry Torokhov
On Thu, 17 Feb 2005 11:28:47 -0500, John M Flinchbaugh <[EMAIL PROTECTED]> wrote: > On Thu, Feb 17, 2005 at 12:07:31PM +0100, Pavel Machek wrote: > > When all the vendor's kernels have swsusp, it will magically kill the > > signature. Or stick mkswap /dev/XXX in your init scripts. > > This is

Re: Swsusp, resume and kernel versions

2005-02-17 Thread John M Flinchbaugh
On Thu, Feb 17, 2005 at 12:07:31PM +0100, Pavel Machek wrote: > When all the vendor's kernels have swsusp, it will magically kill the > signature. Or stick mkswap /dev/XXX in your init scripts. This is what I've done in some instances. There should be no harm in sticking that mkswap into your

Re: Swsusp, resume and kernel versions

2005-02-17 Thread Pavel Machek
Hi! > First of all I must say that swsusp has progressed alot and now works > very reliably, at least for my configuration, and I use it a lot. Great > job! > > But I think there is one pretty severe issue present - even if swsusp > is not enabled kernel should check if there is an image in swap

Re: Swsusp, resume and kernel versions

2005-02-17 Thread Nigel Cunningham
Hi. On Thu, 2005-02-17 at 16:38, Dmitry Torokhov wrote: > On Thursday 17 February 2005 00:15, Nigel Cunningham wrote: > > On Thu, 2005-02-17 at 15:46, Dmitry Torokhov wrote: > > > But I think there is one pretty severe issue present - even if swsusp > > > is not enabled kernel should check if

Re: Swsusp, resume and kernel versions

2005-02-17 Thread Nigel Cunningham
Hi. On Thu, 2005-02-17 at 16:38, Dmitry Torokhov wrote: On Thursday 17 February 2005 00:15, Nigel Cunningham wrote: On Thu, 2005-02-17 at 15:46, Dmitry Torokhov wrote: But I think there is one pretty severe issue present - even if swsusp is not enabled kernel should check if there is an

Re: Swsusp, resume and kernel versions

2005-02-17 Thread Pavel Machek
Hi! First of all I must say that swsusp has progressed alot and now works very reliably, at least for my configuration, and I use it a lot. Great job! But I think there is one pretty severe issue present - even if swsusp is not enabled kernel should check if there is an image in swap and

Re: Swsusp, resume and kernel versions

2005-02-17 Thread John M Flinchbaugh
On Thu, Feb 17, 2005 at 12:07:31PM +0100, Pavel Machek wrote: When all the vendor's kernels have swsusp, it will magically kill the signature. Or stick mkswap /dev/XXX in your init scripts. This is what I've done in some instances. There should be no harm in sticking that mkswap into your init

Re: Swsusp, resume and kernel versions

2005-02-17 Thread Dmitry Torokhov
On Thu, 17 Feb 2005 11:28:47 -0500, John M Flinchbaugh [EMAIL PROTECTED] wrote: On Thu, Feb 17, 2005 at 12:07:31PM +0100, Pavel Machek wrote: When all the vendor's kernels have swsusp, it will magically kill the signature. Or stick mkswap /dev/XXX in your init scripts. This is what I've

Re: Swsusp, resume and kernel versions

2005-02-17 Thread Pavel Machek
Hi! Just remember you're doing the mkswap if you decide to rearrange your partitions at all, or code a script smart enough to grep your swap partitions out of your fstab. It could be a workaround. Still it will cause loss of unsaved work if I happen to load wrong kernel. Given that the

Re: Swsusp, resume and kernel versions

2005-02-17 Thread Dmitry Torokhov
On Thu, 17 Feb 2005 20:56:52 +0100, Pavel Machek [EMAIL PROTECTED] wrote: Hi! Just remember you're doing the mkswap if you decide to rearrange your partitions at all, or code a script smart enough to grep your swap partitions out of your fstab. It could be a workaround. Still it

Re: Swsusp, resume and kernel versions

2005-02-17 Thread Bernard Blackham
On Thu, Feb 17, 2005 at 08:56:52PM +0100, Pavel Machek wrote: Just remember you're doing the mkswap if you decide to rearrange your partitions at all, or code a script smart enough to grep your swap partitions out of your fstab. It could be a workaround. Still it will cause loss of

Re: Swsusp, resume and kernel versions

2005-02-16 Thread Dmitry Torokhov
Hi Nigel, On Thursday 17 February 2005 00:15, Nigel Cunningham wrote: > Hi Dmitry. > > On Thu, 2005-02-17 at 15:46, Dmitry Torokhov wrote: > > Pavel, > > > > First of all I must say that swsusp has progressed alot and now works > > very reliably, at least for my configuration, and I use it a

Re: Swsusp, resume and kernel versions

2005-02-16 Thread Nigel Cunningham
Hi Dmitry. On Thu, 2005-02-17 at 15:46, Dmitry Torokhov wrote: > Pavel, > > First of all I must say that swsusp has progressed alot and now works > very reliably, at least for my configuration, and I use it a lot. Great > job! > > But I think there is one pretty severe issue present - even if

Swsusp, resume and kernel versions

2005-02-16 Thread Dmitry Torokhov
Pavel, First of all I must say that swsusp has progressed alot and now works very reliably, at least for my configuration, and I use it a lot. Great job! But I think there is one pretty severe issue present - even if swsusp is not enabled kernel should check if there is an image in swap and

Swsusp, resume and kernel versions

2005-02-16 Thread Dmitry Torokhov
Pavel, First of all I must say that swsusp has progressed alot and now works very reliably, at least for my configuration, and I use it a lot. Great job! But I think there is one pretty severe issue present - even if swsusp is not enabled kernel should check if there is an image in swap and

Re: Swsusp, resume and kernel versions

2005-02-16 Thread Nigel Cunningham
Hi Dmitry. On Thu, 2005-02-17 at 15:46, Dmitry Torokhov wrote: Pavel, First of all I must say that swsusp has progressed alot and now works very reliably, at least for my configuration, and I use it a lot. Great job! But I think there is one pretty severe issue present - even if swsusp

Re: Swsusp, resume and kernel versions

2005-02-16 Thread Dmitry Torokhov
Hi Nigel, On Thursday 17 February 2005 00:15, Nigel Cunningham wrote: Hi Dmitry. On Thu, 2005-02-17 at 15:46, Dmitry Torokhov wrote: Pavel, First of all I must say that swsusp has progressed alot and now works very reliably, at least for my configuration, and I use it a lot. Great