Re: Task watchers v2

2006-12-19 Thread Paul Jackson
Matt wrote: > Previous iterations of task watchers would prevent the code in these > paths from being inlined. Furthermore, the code certainly wouldn't be > placed near the table of function pointers (which was in an entirely > different ELF section). By placing them adjacent to each other in the >

Re: Task watchers v2

2006-12-19 Thread Matt Helsley
On Mon, 2006-12-18 at 21:41 -0800, Paul Jackson wrote: > Matt wrote: > > - Task watchers can actually improve kernel performance slightly (up to > > 2% in extremely fork-heavy workloads for instance). > > Nice. > > Could you explain why? After the last round of patches I set out to improve instr

Re: Task watchers v2

2006-12-18 Thread Paul Jackson
Matt wrote: > - Task watchers can actually improve kernel performance slightly (up to > 2% in extremely fork-heavy workloads for instance). Nice. Could you explain why? -- I won't rest till it's the best ... Programmer, Linux Scalability Pau

Re: Task watchers v2

2006-12-18 Thread Matt Helsley
On Mon, 2006-12-18 at 13:44 +0800, Zhang, Yanmin wrote: > On Thu, 2006-12-14 at 16:07 -0800, Matt Helsley wrote: > > plain text document attachment (task-watchers-v2) > > Associate function calls with significant events in a task's lifetime much > > like > > we ha

Re: Task watchers v2

2006-12-17 Thread Zhang, Yanmin
On Thu, 2006-12-14 at 16:07 -0800, Matt Helsley wrote: > plain text document attachment (task-watchers-v2) > Associate function calls with significant events in a task's lifetime much > like > we handle kernel and module init/exit functions. This creates a table for each > of

Re: Task watchers v2

2006-12-15 Thread Matt Helsley
On Fri, 2006-12-15 at 09:34 +0100, Christoph Hellwig wrote: > On Thu, Dec 14, 2006 at 04:07:55PM -0800, Matt Helsley wrote: > > Associate function calls with significant events in a task's lifetime much > > like > > we handle kernel and module init/exit functions. This creates a table for > > eac

Re: Task watchers v2

2006-12-15 Thread Matt Helsley
On Fri, 2006-12-15 at 09:34 +0100, Christoph Hellwig wrote: > On Thu, Dec 14, 2006 at 04:07:55PM -0800, Matt Helsley wrote: > > Associate function calls with significant events in a task's lifetime much > > like > > we handle kernel and module init/exit functions. This creates a table for > > eac

Re: Task watchers v2

2006-12-15 Thread Christoph Hellwig
On Thu, Dec 14, 2006 at 04:07:55PM -0800, Matt Helsley wrote: > Associate function calls with significant events in a task's lifetime much > like > we handle kernel and module init/exit functions. This creates a table for each > of the following events in the task_watchers_table ELF section: > >

Task watchers v2

2006-12-14 Thread Matt Helsley
Associate function calls with significant events in a task's lifetime much like we handle kernel and module init/exit functions. This creates a table for each of the following events in the task_watchers_table ELF section: WATCH_TASK_INIT at the beginning of a fork/clone system call when the new t