Re: [stable] The SMP alternatives code breaks exception fixup?

2008-02-07 Thread Thomas Gleixner
On Wed, 6 Feb 2008, Greg KH wrote: > On Tue, Jan 22, 2008 at 03:19:33PM -0500, Chuck Ebbert wrote: > > On 01/22/2008 07:35 AM, Thomas Gleixner wrote: > > > > > > That's a long standing bug in both the PI futex and the standard futex > > > code. Needs to go to stable as well. > > > > > > >

Re: [stable] The SMP alternatives code breaks exception fixup?

2008-02-07 Thread Thomas Gleixner
On Wed, 6 Feb 2008, Greg KH wrote: On Tue, Jan 22, 2008 at 03:19:33PM -0500, Chuck Ebbert wrote: On 01/22/2008 07:35 AM, Thomas Gleixner wrote: That's a long standing bug in both the PI futex and the standard futex code. Needs to go to stable as well. Here's the 2.6.23

Re: [stable] The SMP alternatives code breaks exception fixup?

2008-02-06 Thread Greg KH
On Thu, Feb 07, 2008 at 12:43:09AM +0100, Ingo Molnar wrote: > > * Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > > I don't see this in Linus's tree, am I just missing it? Do you have > > > a git commit id? > > > > Isn't this 9d55b9923a1b7ea8193b8875c57ec940dc2ff027 (possibly with > >

Re: [stable] The SMP alternatives code breaks exception fixup?

2008-02-06 Thread Greg KH
On Thu, Feb 07, 2008 at 12:43:09AM +0100, Ingo Molnar wrote: > > * Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > > I don't see this in Linus's tree, am I just missing it? Do you have > > > a git commit id? > > > > Isn't this 9d55b9923a1b7ea8193b8875c57ec940dc2ff027 (possibly with > >

Re: [stable] The SMP alternatives code breaks exception fixup?

2008-02-06 Thread Ingo Molnar
* Linus Torvalds <[EMAIL PROTECTED]> wrote: > > I don't see this in Linus's tree, am I just missing it? Do you have > > a git commit id? > > Isn't this 9d55b9923a1b7ea8193b8875c57ec940dc2ff027 (possibly with > 2532ec6d178abc55681d049097d3dc577eaa266c on top)? yeah. Greg: note that this is

Re: [stable] The SMP alternatives code breaks exception fixup?

2008-02-06 Thread Linus Torvalds
On Wed, 6 Feb 2008, Greg KH wrote: > > I don't see this in Linus's tree, am I just missing it? Do you have a > git commit id? Isn't this 9d55b9923a1b7ea8193b8875c57ec940dc2ff027 (possibly with 2532ec6d178abc55681d049097d3dc577eaa266c on top)? Linus -- To unsubscribe from

Re: [stable] The SMP alternatives code breaks exception fixup?

2008-02-06 Thread Greg KH
On Tue, Jan 22, 2008 at 03:19:33PM -0500, Chuck Ebbert wrote: > On 01/22/2008 07:35 AM, Thomas Gleixner wrote: > > > > That's a long standing bug in both the PI futex and the standard futex > > code. Needs to go to stable as well. > > > > Here's the 2.6.23 version: > > > Subject: x86: fix

Re: [stable] The SMP alternatives code breaks exception fixup?

2008-02-06 Thread Greg KH
On Tue, Jan 22, 2008 at 03:19:33PM -0500, Chuck Ebbert wrote: On 01/22/2008 07:35 AM, Thomas Gleixner wrote: That's a long standing bug in both the PI futex and the standard futex code. Needs to go to stable as well. Here's the 2.6.23 version: Subject: x86: fix missing exception

Re: [stable] The SMP alternatives code breaks exception fixup?

2008-02-06 Thread Linus Torvalds
On Wed, 6 Feb 2008, Greg KH wrote: I don't see this in Linus's tree, am I just missing it? Do you have a git commit id? Isn't this 9d55b9923a1b7ea8193b8875c57ec940dc2ff027 (possibly with 2532ec6d178abc55681d049097d3dc577eaa266c on top)? Linus -- To unsubscribe from this

Re: [stable] The SMP alternatives code breaks exception fixup?

2008-02-06 Thread Ingo Molnar
* Linus Torvalds [EMAIL PROTECTED] wrote: I don't see this in Linus's tree, am I just missing it? Do you have a git commit id? Isn't this 9d55b9923a1b7ea8193b8875c57ec940dc2ff027 (possibly with 2532ec6d178abc55681d049097d3dc577eaa266c on top)? yeah. Greg: note that this is against

Re: [stable] The SMP alternatives code breaks exception fixup?

2008-02-06 Thread Greg KH
On Thu, Feb 07, 2008 at 12:43:09AM +0100, Ingo Molnar wrote: * Linus Torvalds [EMAIL PROTECTED] wrote: I don't see this in Linus's tree, am I just missing it? Do you have a git commit id? Isn't this 9d55b9923a1b7ea8193b8875c57ec940dc2ff027 (possibly with

Re: The SMP alternatives code breaks exception fixup?

2008-01-22 Thread Chuck Ebbert
On 01/22/2008 07:35 AM, Thomas Gleixner wrote: > > That's a long standing bug in both the PI futex and the standard futex > code. Needs to go to stable as well. > Here's the 2.6.23 version: Subject: x86: fix missing exception entry for SMP alternatives in futex macros From: Thomas Gleixner

Re: The SMP alternatives code breaks exception fixup?

2008-01-22 Thread Thomas Gleixner
On Tue, 22 Jan 2008, Andi Kleen wrote: > Chuck Ebbert <[EMAIL PROTECTED]> writes: > > > > There is a fixup, so this should never happen. But the lock instruction > > was replaced with a nop by the altinstruction code, and that makes the fixup > > address wrong. AFAICT we don't fix up the

Re: The SMP alternatives code breaks exception fixup?

2008-01-22 Thread Thomas Gleixner
On Tue, 22 Jan 2008, Andi Kleen wrote: Chuck Ebbert [EMAIL PROTECTED] writes: There is a fixup, so this should never happen. But the lock instruction was replaced with a nop by the altinstruction code, and that makes the fixup address wrong. AFAICT we don't fix up the exception table

Re: The SMP alternatives code breaks exception fixup?

2008-01-22 Thread Chuck Ebbert
On 01/22/2008 07:35 AM, Thomas Gleixner wrote: That's a long standing bug in both the PI futex and the standard futex code. Needs to go to stable as well. Here's the 2.6.23 version: Subject: x86: fix missing exception entry for SMP alternatives in futex macros From: Thomas Gleixner [EMAIL

Re: The SMP alternatives code breaks exception fixup?

2008-01-21 Thread Andi Kleen
Chuck Ebbert <[EMAIL PROTECTED]> writes: > > There is a fixup, so this should never happen. But the lock instruction > was replaced with a nop by the altinstruction code, and that makes the fixup > address wrong. AFAICT we don't fix up the exception table when we replace > a lock with a nop,

Re: The SMP alternatives code breaks exception fixup?

2008-01-21 Thread Chuck Ebbert
On 01/21/2008 03:47 PM, Chuck Ebbert wrote: > Looking at the oops report from this bug: > > [bugzilla] https://bugzilla.redhat.com/show_bug.cgi?id=429412 > [oops] https://bugzilla.redhat.com/attachment.cgi?id=292260 > > It was an unhandled page fault (protection violation.) > > I tracked

The SMP alternatives code breaks exception fixup?

2008-01-21 Thread Chuck Ebbert
Looking at the oops report from this bug: [bugzilla] https://bugzilla.redhat.com/show_bug.cgi?id=429412 [oops] https://bugzilla.redhat.com/attachment.cgi?id=292260 It was an unhandled page fault (protection violation.) I tracked it down to the cmpxchg in this code:

The SMP alternatives code breaks exception fixup?

2008-01-21 Thread Chuck Ebbert
Looking at the oops report from this bug: [bugzilla] https://bugzilla.redhat.com/show_bug.cgi?id=429412 [oops] https://bugzilla.redhat.com/attachment.cgi?id=292260 It was an unhandled page fault (protection violation.) I tracked it down to the cmpxchg in this code:

Re: The SMP alternatives code breaks exception fixup?

2008-01-21 Thread Chuck Ebbert
On 01/21/2008 03:47 PM, Chuck Ebbert wrote: Looking at the oops report from this bug: [bugzilla] https://bugzilla.redhat.com/show_bug.cgi?id=429412 [oops] https://bugzilla.redhat.com/attachment.cgi?id=292260 It was an unhandled page fault (protection violation.) I tracked it down

Re: The SMP alternatives code breaks exception fixup?

2008-01-21 Thread Andi Kleen
Chuck Ebbert [EMAIL PROTECTED] writes: There is a fixup, so this should never happen. But the lock instruction was replaced with a nop by the altinstruction code, and that makes the fixup address wrong. AFAICT we don't fix up the exception table when we replace a lock with a nop, which makes