Re: The sheer number of sparse warnings in the kernel

2014-03-04 Thread Valdis . Kletnieks
On Wed, 26 Feb 2014 15:31:47 -0800, "H. Peter Anvin" said: > Yes... it looks like the 0.4.5-rc1 that shipped in Fedora is indeed out > of date. With 0.5.0 I "only" see 8,207 messages, which means that at > least the linux/err.h issue is gone. Unfortunately, that's not true, at least with the

Re: The sheer number of sparse warnings in the kernel

2014-03-04 Thread Valdis . Kletnieks
On Wed, 26 Feb 2014 15:31:47 -0800, H. Peter Anvin said: Yes... it looks like the 0.4.5-rc1 that shipped in Fedora is indeed out of date. With 0.5.0 I only see 8,207 messages, which means that at least the linux/err.h issue is gone. Unfortunately, that's not true, at least with the Fedora

Re: The sheer number of sparse warnings in the kernel

2014-02-27 Thread Dr. David Alan Gilbert
* H. Peter Anvin (h...@zytor.com) wrote: > The number of sparse errors in the current kernel is staggering, and it > makes sparse a lot less valuable of a tool that it otherwise could be. > On a build of x86-64 allyesconfig I'm getting 20,676 sparse messages. > Out of those, 12,358 come from

Re: The sheer number of sparse warnings in the kernel

2014-02-27 Thread Guenter Roeck
So getting this to the point where it is genuinely useful and can be made a ubiquitous part of the Linux development process is going to take more work and probably involve improvements to sparse so we can indicate in the kernel sources when something is okay or removing completely bogus

Re: The sheer number of sparse warnings in the kernel

2014-02-27 Thread Geert Uytterhoeven
On Thu, Feb 27, 2014 at 2:52 AM, Peter Hurley wrote: >> The bigger question, again, is what do we need to do to make this >> happen, assuming it is worth doing? We certainly have had bugs, >> including security holes, which sparse would have caught. At the same >> time, this kind of work tends

Re: The sheer number of sparse warnings in the kernel

2014-02-27 Thread Richard Weinberger
Am 27.02.2014 00:25, schrieb Borislav Petkov: > On Wed, Feb 26, 2014 at 02:49:26PM -0800, H. Peter Anvin wrote: >> What do we need to do to actually make our tools be able to do work >> for us? Newbie projects to clean up? > > It certainly would be a much better way for newbies to get involved

Re: The sheer number of sparse warnings in the kernel

2014-02-27 Thread Richard Weinberger
Am 27.02.2014 00:25, schrieb Borislav Petkov: On Wed, Feb 26, 2014 at 02:49:26PM -0800, H. Peter Anvin wrote: What do we need to do to actually make our tools be able to do work for us? Newbie projects to clean up? It certainly would be a much better way for newbies to get involved than all

Re: The sheer number of sparse warnings in the kernel

2014-02-27 Thread Geert Uytterhoeven
On Thu, Feb 27, 2014 at 2:52 AM, Peter Hurley pe...@hurleysoftware.com wrote: The bigger question, again, is what do we need to do to make this happen, assuming it is worth doing? We certainly have had bugs, including security holes, which sparse would have caught. At the same time, this

Re: The sheer number of sparse warnings in the kernel

2014-02-27 Thread Guenter Roeck
So getting this to the point where it is genuinely useful and can be made a ubiquitous part of the Linux development process is going to take more work and probably involve improvements to sparse so we can indicate in the kernel sources when something is okay or removing completely bogus

Re: The sheer number of sparse warnings in the kernel

2014-02-27 Thread Dr. David Alan Gilbert
* H. Peter Anvin (h...@zytor.com) wrote: The number of sparse errors in the current kernel is staggering, and it makes sparse a lot less valuable of a tool that it otherwise could be. On a build of x86-64 allyesconfig I'm getting 20,676 sparse messages. Out of those, 12,358 come from

Re: The sheer number of sparse warnings in the kernel

2014-02-26 Thread Greg KH
On Wed, Feb 26, 2014 at 10:15:08PM -0500, Dave Jones wrote: > On Wed, Feb 26, 2014 at 05:34:24PM -0800, Greg KH wrote: > > > Yes, for some areas of the kernel it will take some work, but for > > others, sparse works really well. As an example, building all of > > drivers/usb/* with sparse

Re: The sheer number of sparse warnings in the kernel

2014-02-26 Thread Greg KH
On Wed, Feb 26, 2014 at 08:19:23PM -0800, H. Peter Anvin wrote: > On 02/26/2014 05:52 PM, Peter Hurley wrote: > > > > Well there was that "should we do a bug-fix-only 4.0 release?" message > > from Linus back at the 3.12 release. > > > > Sure... but will it actually happen? I sure hope not,

Re: The sheer number of sparse warnings in the kernel

2014-02-26 Thread H. Peter Anvin
On 02/26/2014 05:52 PM, Peter Hurley wrote: > > Well there was that "should we do a bug-fix-only 4.0 release?" message > from Linus back at the 3.12 release. > Sure... but will it actually happen? -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: The sheer number of sparse warnings in the kernel

2014-02-26 Thread Dave Jones
On Wed, Feb 26, 2014 at 05:34:24PM -0800, Greg KH wrote: > Yes, for some areas of the kernel it will take some work, but for > others, sparse works really well. As an example, building all of > drivers/usb/* with sparse only brings up 2 issues, both of which should > probably be fixed (or

Re: The sheer number of sparse warnings in the kernel

2014-02-26 Thread Joe Perches
On Wed, 2014-02-26 at 17:34 -0800, Greg KH wrote: > On Wed, Feb 26, 2014 at 04:11:30PM -0800, H. Peter Anvin wrote: > > I have seen this phenomenon, too. I also see a bunch of sparse warnings > > which are clearly bogus, for example complaining about sizeof(bool) when > > in bits like: > > > >

Re: The sheer number of sparse warnings in the kernel

2014-02-26 Thread Peter Hurley
On 02/26/2014 07:11 PM, H. Peter Anvin wrote: On 02/26/2014 03:28 PM, Greg KH wrote: What do we need to do to actually make our tools be able to do work for us? Newbie projects to clean up? Trying to get the larger Linux companies to put resources on it? It's not the easiest "newbie"

Re: The sheer number of sparse warnings in the kernel

2014-02-26 Thread Greg KH
On Wed, Feb 26, 2014 at 04:11:30PM -0800, H. Peter Anvin wrote: > On 02/26/2014 03:28 PM, Greg KH wrote: > >> > >> What do we need to do to actually make our tools be able to do work for > >> us? Newbie projects to clean up? Trying to get the larger Linux > >> companies to put resources on it? >

Re: The sheer number of sparse warnings in the kernel

2014-02-26 Thread H. Peter Anvin
That would be good. On February 26, 2014 5:19:51 PM PST, Josh Boyer wrote: >On Wed, Feb 26, 2014 at 6:37 PM, H. Peter Anvin wrote: >> On 02/26/2014 03:31 PM, H. Peter Anvin wrote: >>> On 02/26/2014 03:29 PM, Greg KH wrote: On Wed, Feb 26, 2014 at 03:28:59PM -0800, Greg KH wrote: > On

Re: The sheer number of sparse warnings in the kernel

2014-02-26 Thread Josh Boyer
On Wed, Feb 26, 2014 at 6:37 PM, H. Peter Anvin wrote: > On 02/26/2014 03:31 PM, H. Peter Anvin wrote: >> On 02/26/2014 03:29 PM, Greg KH wrote: >>> On Wed, Feb 26, 2014 at 03:28:59PM -0800, Greg KH wrote: On Wed, Feb 26, 2014 at 02:49:26PM -0800, H. Peter Anvin wrote: > The number of

Re: The sheer number of sparse warnings in the kernel

2014-02-26 Thread Joe Perches
On Wed, 2014-02-26 at 16:51 -0800, H. Peter Anvin wrote: > On 02/26/2014 04:48 PM, Joe Perches wrote: > > err.h could also return bool instead of long for the > > IS_ERR and IS_ERR_OR_NULL tests. > > This is definitely true... although we should check that that doesn't > make the code worse as

Re: The sheer number of sparse warnings in the kernel

2014-02-26 Thread H. Peter Anvin
On 02/26/2014 04:48 PM, Joe Perches wrote: > err.h could also return bool instead of long for the > IS_ERR and IS_ERR_OR_NULL tests. This is definitely true... although we should check that that doesn't make the code worse as this is used *all over* the kernel. > Maybe something like this could

Re: The sheer number of sparse warnings in the kernel

2014-02-26 Thread Joe Perches
On Wed, 2014-02-26 at 14:49 -0800, H. Peter Anvin wrote: > The number of sparse errors in the current kernel is staggering, and it > makes sparse a lot less valuable of a tool that it otherwise could be. > On a build of x86-64 allyesconfig I'm getting 20,676 sparse messages. > Out of those, 12,358

Re: The sheer number of sparse warnings in the kernel

2014-02-26 Thread H. Peter Anvin
On 02/26/2014 03:28 PM, Greg KH wrote: >> >> What do we need to do to actually make our tools be able to do work for >> us? Newbie projects to clean up? Trying to get the larger Linux >> companies to put resources on it? > > It's not the easiest "newbie" project as usually the first reflex to >

Re: The sheer number of sparse warnings in the kernel

2014-02-26 Thread H. Peter Anvin
On 02/26/2014 03:31 PM, H. Peter Anvin wrote: > On 02/26/2014 03:29 PM, Greg KH wrote: >> On Wed, Feb 26, 2014 at 03:28:59PM -0800, Greg KH wrote: >>> On Wed, Feb 26, 2014 at 02:49:26PM -0800, H. Peter Anvin wrote: The number of sparse errors in the current kernel is staggering, and it

Re: The sheer number of sparse warnings in the kernel

2014-02-26 Thread H. Peter Anvin
On 02/26/2014 03:29 PM, Greg KH wrote: > On Wed, Feb 26, 2014 at 03:28:59PM -0800, Greg KH wrote: >> On Wed, Feb 26, 2014 at 02:49:26PM -0800, H. Peter Anvin wrote: >>> The number of sparse errors in the current kernel is staggering, and it >>> makes sparse a lot less valuable of a tool that it

Re: The sheer number of sparse warnings in the kernel

2014-02-26 Thread Greg KH
On Wed, Feb 26, 2014 at 03:28:59PM -0800, Greg KH wrote: > On Wed, Feb 26, 2014 at 02:49:26PM -0800, H. Peter Anvin wrote: > > The number of sparse errors in the current kernel is staggering, and it > > makes sparse a lot less valuable of a tool that it otherwise could be. > > On a build of x86-64

Re: The sheer number of sparse warnings in the kernel

2014-02-26 Thread Greg KH
On Wed, Feb 26, 2014 at 02:49:26PM -0800, H. Peter Anvin wrote: > The number of sparse errors in the current kernel is staggering, and it > makes sparse a lot less valuable of a tool that it otherwise could be. > On a build of x86-64 allyesconfig I'm getting 20,676 sparse messages. > Out of those,

Re: The sheer number of sparse warnings in the kernel

2014-02-26 Thread Borislav Petkov
On Wed, Feb 26, 2014 at 02:49:26PM -0800, H. Peter Anvin wrote: > What do we need to do to actually make our tools be able to do work > for us? Newbie projects to clean up? It certainly would be a much better way for newbies to get involved than all the useless OCD-jerking off that floats back

The sheer number of sparse warnings in the kernel

2014-02-26 Thread H. Peter Anvin
The number of sparse errors in the current kernel is staggering, and it makes sparse a lot less valuable of a tool that it otherwise could be. On a build of x86-64 allyesconfig I'm getting 20,676 sparse messages. Out of those, 12,358 come from linux/err.h. Given that the latter basically spams

The sheer number of sparse warnings in the kernel

2014-02-26 Thread H. Peter Anvin
The number of sparse errors in the current kernel is staggering, and it makes sparse a lot less valuable of a tool that it otherwise could be. On a build of x86-64 allyesconfig I'm getting 20,676 sparse messages. Out of those, 12,358 come from linux/err.h. Given that the latter basically spams

Re: The sheer number of sparse warnings in the kernel

2014-02-26 Thread Borislav Petkov
On Wed, Feb 26, 2014 at 02:49:26PM -0800, H. Peter Anvin wrote: What do we need to do to actually make our tools be able to do work for us? Newbie projects to clean up? It certainly would be a much better way for newbies to get involved than all the useless OCD-jerking off that floats back and

Re: The sheer number of sparse warnings in the kernel

2014-02-26 Thread Greg KH
On Wed, Feb 26, 2014 at 02:49:26PM -0800, H. Peter Anvin wrote: The number of sparse errors in the current kernel is staggering, and it makes sparse a lot less valuable of a tool that it otherwise could be. On a build of x86-64 allyesconfig I'm getting 20,676 sparse messages. Out of those,

Re: The sheer number of sparse warnings in the kernel

2014-02-26 Thread Greg KH
On Wed, Feb 26, 2014 at 03:28:59PM -0800, Greg KH wrote: On Wed, Feb 26, 2014 at 02:49:26PM -0800, H. Peter Anvin wrote: The number of sparse errors in the current kernel is staggering, and it makes sparse a lot less valuable of a tool that it otherwise could be. On a build of x86-64

Re: The sheer number of sparse warnings in the kernel

2014-02-26 Thread H. Peter Anvin
On 02/26/2014 03:29 PM, Greg KH wrote: On Wed, Feb 26, 2014 at 03:28:59PM -0800, Greg KH wrote: On Wed, Feb 26, 2014 at 02:49:26PM -0800, H. Peter Anvin wrote: The number of sparse errors in the current kernel is staggering, and it makes sparse a lot less valuable of a tool that it otherwise

Re: The sheer number of sparse warnings in the kernel

2014-02-26 Thread H. Peter Anvin
On 02/26/2014 03:31 PM, H. Peter Anvin wrote: On 02/26/2014 03:29 PM, Greg KH wrote: On Wed, Feb 26, 2014 at 03:28:59PM -0800, Greg KH wrote: On Wed, Feb 26, 2014 at 02:49:26PM -0800, H. Peter Anvin wrote: The number of sparse errors in the current kernel is staggering, and it makes sparse a

Re: The sheer number of sparse warnings in the kernel

2014-02-26 Thread H. Peter Anvin
On 02/26/2014 03:28 PM, Greg KH wrote: What do we need to do to actually make our tools be able to do work for us? Newbie projects to clean up? Trying to get the larger Linux companies to put resources on it? It's not the easiest newbie project as usually the first reflex to just cast it

Re: The sheer number of sparse warnings in the kernel

2014-02-26 Thread Joe Perches
On Wed, 2014-02-26 at 14:49 -0800, H. Peter Anvin wrote: The number of sparse errors in the current kernel is staggering, and it makes sparse a lot less valuable of a tool that it otherwise could be. On a build of x86-64 allyesconfig I'm getting 20,676 sparse messages. Out of those, 12,358

Re: The sheer number of sparse warnings in the kernel

2014-02-26 Thread H. Peter Anvin
On 02/26/2014 04:48 PM, Joe Perches wrote: err.h could also return bool instead of long for the IS_ERR and IS_ERR_OR_NULL tests. This is definitely true... although we should check that that doesn't make the code worse as this is used *all over* the kernel. Maybe something like this could be

Re: The sheer number of sparse warnings in the kernel

2014-02-26 Thread Joe Perches
On Wed, 2014-02-26 at 16:51 -0800, H. Peter Anvin wrote: On 02/26/2014 04:48 PM, Joe Perches wrote: err.h could also return bool instead of long for the IS_ERR and IS_ERR_OR_NULL tests. This is definitely true... although we should check that that doesn't make the code worse as this is

Re: The sheer number of sparse warnings in the kernel

2014-02-26 Thread Josh Boyer
On Wed, Feb 26, 2014 at 6:37 PM, H. Peter Anvin h...@zytor.com wrote: On 02/26/2014 03:31 PM, H. Peter Anvin wrote: On 02/26/2014 03:29 PM, Greg KH wrote: On Wed, Feb 26, 2014 at 03:28:59PM -0800, Greg KH wrote: On Wed, Feb 26, 2014 at 02:49:26PM -0800, H. Peter Anvin wrote: The number of

Re: The sheer number of sparse warnings in the kernel

2014-02-26 Thread H. Peter Anvin
That would be good. On February 26, 2014 5:19:51 PM PST, Josh Boyer jwbo...@fedoraproject.org wrote: On Wed, Feb 26, 2014 at 6:37 PM, H. Peter Anvin h...@zytor.com wrote: On 02/26/2014 03:31 PM, H. Peter Anvin wrote: On 02/26/2014 03:29 PM, Greg KH wrote: On Wed, Feb 26, 2014 at 03:28:59PM

Re: The sheer number of sparse warnings in the kernel

2014-02-26 Thread Greg KH
On Wed, Feb 26, 2014 at 04:11:30PM -0800, H. Peter Anvin wrote: On 02/26/2014 03:28 PM, Greg KH wrote: What do we need to do to actually make our tools be able to do work for us? Newbie projects to clean up? Trying to get the larger Linux companies to put resources on it? It's not

Re: The sheer number of sparse warnings in the kernel

2014-02-26 Thread Peter Hurley
On 02/26/2014 07:11 PM, H. Peter Anvin wrote: On 02/26/2014 03:28 PM, Greg KH wrote: What do we need to do to actually make our tools be able to do work for us? Newbie projects to clean up? Trying to get the larger Linux companies to put resources on it? It's not the easiest newbie project

Re: The sheer number of sparse warnings in the kernel

2014-02-26 Thread Joe Perches
On Wed, 2014-02-26 at 17:34 -0800, Greg KH wrote: On Wed, Feb 26, 2014 at 04:11:30PM -0800, H. Peter Anvin wrote: I have seen this phenomenon, too. I also see a bunch of sparse warnings which are clearly bogus, for example complaining about sizeof(bool) when in bits like:

Re: The sheer number of sparse warnings in the kernel

2014-02-26 Thread Dave Jones
On Wed, Feb 26, 2014 at 05:34:24PM -0800, Greg KH wrote: Yes, for some areas of the kernel it will take some work, but for others, sparse works really well. As an example, building all of drivers/usb/* with sparse only brings up 2 issues, both of which should probably be fixed (or

Re: The sheer number of sparse warnings in the kernel

2014-02-26 Thread H. Peter Anvin
On 02/26/2014 05:52 PM, Peter Hurley wrote: Well there was that should we do a bug-fix-only 4.0 release? message from Linus back at the 3.12 release. Sure... but will it actually happen? -hpa -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a

Re: The sheer number of sparse warnings in the kernel

2014-02-26 Thread Greg KH
On Wed, Feb 26, 2014 at 08:19:23PM -0800, H. Peter Anvin wrote: On 02/26/2014 05:52 PM, Peter Hurley wrote: Well there was that should we do a bug-fix-only 4.0 release? message from Linus back at the 3.12 release. Sure... but will it actually happen? I sure hope not, the backlog it

Re: The sheer number of sparse warnings in the kernel

2014-02-26 Thread Greg KH
On Wed, Feb 26, 2014 at 10:15:08PM -0500, Dave Jones wrote: On Wed, Feb 26, 2014 at 05:34:24PM -0800, Greg KH wrote: Yes, for some areas of the kernel it will take some work, but for others, sparse works really well. As an example, building all of drivers/usb/* with sparse only brings