Re: The who needs reviews anyways [PATCH]

2007-02-09 Thread Oleg Verych
On Fri, Feb 09, 2007 at 12:35:04PM +0100, Roman Zippel wrote: [] > > > +$(error bash is required to build the kernel) > > > +endif > > > +SHELL := $(CONFIG_SHELL) > > > > here is policy to have `bash' introduced, so due to original > > issue, where `root' users ended with removed /dev/null, may

Re: The who needs reviews anyways [PATCH]

2007-02-09 Thread Roman Zippel
Hi, On Fri, 9 Feb 2007, Oleg Verych wrote: > > - else if [ -x /bin/bash ]; then echo /bin/bash; \ > > - else echo sh; fi ; fi) > > + else if [ -x /bin/bash ]; then echo /bin/bash; fi; fi) > > +ifeq ($(CONFIG_SHELL),) > > +$(error bash is required to build the kernel) > > +endif > >

Re: The who needs reviews anyways [PATCH]

2007-02-09 Thread Roman Zippel
Hi, On Fri, 9 Feb 2007, Oleg Verych wrote: - else if [ -x /bin/bash ]; then echo /bin/bash; \ - else echo sh; fi ; fi) + else if [ -x /bin/bash ]; then echo /bin/bash; fi; fi) +ifeq ($(CONFIG_SHELL),) +$(error bash is required to build the kernel) +endif +SHELL :=

Re: The who needs reviews anyways [PATCH]

2007-02-09 Thread Oleg Verych
On Fri, Feb 09, 2007 at 12:35:04PM +0100, Roman Zippel wrote: [] +$(error bash is required to build the kernel) +endif +SHELL := $(CONFIG_SHELL) here is policy to have `bash' introduced, so due to original issue, where `root' users ended with removed /dev/null, may policy to have

Re: The who needs reviews anyways [PATCH]

2007-02-08 Thread Oleg Verych
On Thu, Feb 08, 2007 at 10:48:51PM +0100, Roman Zippel wrote: [] > - printf has other side effects, instead stop pretending we support > something else than bash More on printf, `sh', tmpfiles. As we know original problem is: something from binutils is removing output files on failure. > -

Re: The who needs reviews anyways [PATCH]

2007-02-08 Thread Valdis . Kletnieks
On Fri, 09 Feb 2007 00:20:49 +0100, Roman Zippel said: > > The point is, neither $BASH nor /bin/bash may be set. > > Is that really a problem? I think any system that has bash without > /bin/bash is simply broken. If you're trying to bootstrap a Linux box onto a new platform from some non-Linux

Re: The who needs reviews anyways [PATCH]

2007-02-08 Thread Roman Zippel
Hi, On Fri, 9 Feb 2007, Andreas Schwab wrote: > Roman Zippel <[EMAIL PROTECTED]> writes: > > > - printf has other side effects, instead stop pretending we support > > something else than bash > > printf is a much better echo, but you need to use it properly as well. > Either use %s to print

Re: The who needs reviews anyways [PATCH]

2007-02-08 Thread Andreas Schwab
Roman Zippel <[EMAIL PROTECTED]> writes: > - printf has other side effects, instead stop pretending we support > something else than bash printf is a much better echo, but you need to use it properly as well. Either use %s to print a literal string or %b to let it interpret escape sequences.

Re: The who needs reviews anyways [PATCH]

2007-02-08 Thread Roman Zippel
Hi, On Thu, 8 Feb 2007, Linus Torvalds wrote: > On Thu, 8 Feb 2007, Roman Zippel wrote: > > > I don't quite understand, the Makefile doesn't care anymore about /bin/sh > > with this patch, the Makefile checks only for $BASH and /bin/bash > > Exactly. > > The point is, neither $BASH nor

Re: The who needs reviews anyways [PATCH]

2007-02-08 Thread Linus Torvalds
On Thu, 8 Feb 2007, Roman Zippel wrote: > I don't quite understand, the Makefile doesn't care anymore about /bin/sh > with this patch, the Makefile checks only for $BASH and /bin/bash Exactly. The point is, neither $BASH nor /bin/bash may be set. If you run make while running tcsh, "BASH"

Kbuild refactoring (Re: The who needs reviews anyways [PATCH])

2007-02-08 Thread Oleg Verych
On Thu, Feb 08, 2007 at 10:48:51PM +0100, Roman Zippel wrote: [] > - printf has other side effects, instead stop pretending we support > something else than bash Yes. With `%' in option strings there will be side effects. I would suggest to use printf %s "$(1)" with "paranoia mode on",

Re: The who needs reviews anyways [PATCH]

2007-02-08 Thread Roman Zippel
Hi, On Thu, 8 Feb 2007, Linus Torvalds wrote: > Historically, people used to do: > - /bin/sh was the "standard shell" (bash) > - /bin/[t]csh is what clueless weenies use for interactive work. > > (Yeah, I'm not a [t]csh fan ;) > > And you did break that. > > It's quite possible that all

Re: The who needs reviews anyways [PATCH]

2007-02-08 Thread Linus Torvalds
On Thu, 8 Feb 2007, Roman Zippel wrote: > > Sorry for the delay, but the git server were gone. > > - the define command is inappropriate (it's primarily for rule > definitions) Looks fine. Especially considering the strange whitespace issues. > - execute commands in the current dir as all

Re: The who needs reviews anyways [PATCH]

2007-02-08 Thread Sam Ravnborg
On Thu, Feb 08, 2007 at 10:48:51PM +0100, Roman Zippel wrote: > Hi, > > This adds the remaining changes which should have been part of the review > process. Oleg could have learned something in process, but who needs that > if wasting everyones time is so much more fun... > > Sorry for the

The who needs reviews anyways [PATCH]

2007-02-08 Thread Roman Zippel
Hi, This adds the remaining changes which should have been part of the review process. Oleg could have learned something in process, but who needs that if wasting everyones time is so much more fun... Sorry for the delay, but the git server were gone. - the define command is inappropriate

The who needs reviews anyways [PATCH]

2007-02-08 Thread Roman Zippel
Hi, This adds the remaining changes which should have been part of the review process. Oleg could have learned something in process, but who needs that if wasting everyones time is so much more fun... Sorry for the delay, but the git server were gone. - the define command is inappropriate

Re: The who needs reviews anyways [PATCH]

2007-02-08 Thread Sam Ravnborg
On Thu, Feb 08, 2007 at 10:48:51PM +0100, Roman Zippel wrote: Hi, This adds the remaining changes which should have been part of the review process. Oleg could have learned something in process, but who needs that if wasting everyones time is so much more fun... Sorry for the delay, but

Re: The who needs reviews anyways [PATCH]

2007-02-08 Thread Linus Torvalds
On Thu, 8 Feb 2007, Roman Zippel wrote: Sorry for the delay, but the git server were gone. - the define command is inappropriate (it's primarily for rule definitions) Looks fine. Especially considering the strange whitespace issues. - execute commands in the current dir as all other

Re: The who needs reviews anyways [PATCH]

2007-02-08 Thread Roman Zippel
Hi, On Thu, 8 Feb 2007, Linus Torvalds wrote: Historically, people used to do: - /bin/sh was the standard shell (bash) - /bin/[t]csh is what clueless weenies use for interactive work. (Yeah, I'm not a [t]csh fan ;) And you did break that. It's quite possible that all modern

Kbuild refactoring (Re: The who needs reviews anyways [PATCH])

2007-02-08 Thread Oleg Verych
On Thu, Feb 08, 2007 at 10:48:51PM +0100, Roman Zippel wrote: [] - printf has other side effects, instead stop pretending we support something else than bash Yes. With `%' in option strings there will be side effects. I would suggest to use printf %s $(1) with paranoia mode on, and

Re: The who needs reviews anyways [PATCH]

2007-02-08 Thread Linus Torvalds
On Thu, 8 Feb 2007, Roman Zippel wrote: I don't quite understand, the Makefile doesn't care anymore about /bin/sh with this patch, the Makefile checks only for $BASH and /bin/bash Exactly. The point is, neither $BASH nor /bin/bash may be set. If you run make while running tcsh, BASH

Re: The who needs reviews anyways [PATCH]

2007-02-08 Thread Roman Zippel
Hi, On Thu, 8 Feb 2007, Linus Torvalds wrote: On Thu, 8 Feb 2007, Roman Zippel wrote: I don't quite understand, the Makefile doesn't care anymore about /bin/sh with this patch, the Makefile checks only for $BASH and /bin/bash Exactly. The point is, neither $BASH nor /bin/bash may

Re: The who needs reviews anyways [PATCH]

2007-02-08 Thread Andreas Schwab
Roman Zippel [EMAIL PROTECTED] writes: - printf has other side effects, instead stop pretending we support something else than bash printf is a much better echo, but you need to use it properly as well. Either use %s to print a literal string or %b to let it interpret escape sequences.

Re: The who needs reviews anyways [PATCH]

2007-02-08 Thread Roman Zippel
Hi, On Fri, 9 Feb 2007, Andreas Schwab wrote: Roman Zippel [EMAIL PROTECTED] writes: - printf has other side effects, instead stop pretending we support something else than bash printf is a much better echo, but you need to use it properly as well. Either use %s to print a literal

Re: The who needs reviews anyways [PATCH]

2007-02-08 Thread Valdis . Kletnieks
On Fri, 09 Feb 2007 00:20:49 +0100, Roman Zippel said: The point is, neither $BASH nor /bin/bash may be set. Is that really a problem? I think any system that has bash without /bin/bash is simply broken. If you're trying to bootstrap a Linux box onto a new platform from some non-Linux

Re: The who needs reviews anyways [PATCH]

2007-02-08 Thread Oleg Verych
On Thu, Feb 08, 2007 at 10:48:51PM +0100, Roman Zippel wrote: [] - printf has other side effects, instead stop pretending we support something else than bash More on printf, `sh', tmpfiles. As we know original problem is: something from binutils is removing output files on failure. -