Re: Time to re-enable Runtime PM per default for PCI devcies?

2021-01-04 Thread Heiner Kallweit
On 04.01.2021 18:39, Lukas Wunner wrote: > On Thu, Dec 31, 2020 at 10:38:12AM +0100, Heiner Kallweit wrote: >> On 31.12.2020 05:07, Lukas Wunner wrote: >>> FWIW, if platform_pci_power_manageable() returns true, it can probably >>> be assumed that allowing runtime PM by default is okay. So as a

Re: Time to re-enable Runtime PM per default for PCI devcies?

2021-01-04 Thread Lukas Wunner
On Thu, Dec 31, 2020 at 10:38:12AM +0100, Heiner Kallweit wrote: > On 31.12.2020 05:07, Lukas Wunner wrote: > > FWIW, if platform_pci_power_manageable() returns true, it can probably > > be assumed that allowing runtime PM by default is okay. So as a first > > step, you may want to call that

Re: Time to re-enable Runtime PM per default for PCI devcies?

2020-12-31 Thread Heiner Kallweit
On 31.12.2020 10:38, Heiner Kallweit wrote: > On 31.12.2020 05:07, Lukas Wunner wrote: >> On Wed, Dec 30, 2020 at 11:56:04PM +0100, Heiner Kallweit wrote: >>> --- a/drivers/pci/pci.c >>> +++ b/drivers/pci/pci.c >>> @@ -3024,7 +3024,9 @@ void pci_pm_init(struct pci_dev *dev) >>> u16 status; >>>

Re: Time to re-enable Runtime PM per default for PCI devcies?

2020-12-31 Thread Heiner Kallweit
On 31.12.2020 05:07, Lukas Wunner wrote: > On Wed, Dec 30, 2020 at 11:56:04PM +0100, Heiner Kallweit wrote: >> --- a/drivers/pci/pci.c >> +++ b/drivers/pci/pci.c >> @@ -3024,7 +3024,9 @@ void pci_pm_init(struct pci_dev *dev) >> u16 status; >> u16 pmc; >> >> -

Re: Time to re-enable Runtime PM per default for PCI devcies?

2020-12-30 Thread Lukas Wunner
On Wed, Dec 30, 2020 at 11:56:04PM +0100, Heiner Kallweit wrote: > --- a/drivers/pci/pci.c > +++ b/drivers/pci/pci.c > @@ -3024,7 +3024,9 @@ void pci_pm_init(struct pci_dev *dev) > u16 status; > u16 pmc; > > - pm_runtime_forbid(>dev); > + if (pci_acpi_forbid_runtime_pm()) > +

Re: Time to re-enable Runtime PM per default for PCI devcies?

2020-12-30 Thread Heiner Kallweit
On 17.11.2020 17:57, Rafael J. Wysocki wrote: > On Tue, Nov 17, 2020 at 5:38 PM Bjorn Helgaas wrote: >> >> [+to Rafael, author of the commit you mentioned, >> +cc Mika, Kai Heng, Lukas, linux-pm, linux-kernel] >> >> On Tue, Nov 17, 2020 at 04:56:09PM +0100, Heiner Kallweit wrote: >>> More than 10

Re: Time to re-enable Runtime PM per default for PCI devcies?

2020-12-29 Thread Heiner Kallweit
On 29.12.2020 12:56, Kai-Heng Feng wrote: > On Sat, Dec 26, 2020 at 11:26 PM Heiner Kallweit wrote: >> >> On 17.11.2020 17:57, Rafael J. Wysocki wrote: >>> On Tue, Nov 17, 2020 at 5:38 PM Bjorn Helgaas wrote: [+to Rafael, author of the commit you mentioned, +cc Mika, Kai Heng,

Re: Time to re-enable Runtime PM per default for PCI devcies?

2020-12-29 Thread Kai-Heng Feng
On Sat, Dec 26, 2020 at 11:26 PM Heiner Kallweit wrote: > > On 17.11.2020 17:57, Rafael J. Wysocki wrote: > > On Tue, Nov 17, 2020 at 5:38 PM Bjorn Helgaas wrote: > >> > >> [+to Rafael, author of the commit you mentioned, > >> +cc Mika, Kai Heng, Lukas, linux-pm, linux-kernel] > >> > >> On Tue,

Re: Time to re-enable Runtime PM per default for PCI devcies?

2020-12-29 Thread Lukas Wunner
> On Tue, Nov 17, 2020 at 04:56:09PM +0100, Heiner Kallweit wrote: > > With Runtime PM disabled e.g. the PHY on network devices may remain > > powered up even with no cable plugged in, affecting battery lifetime > > on mobile devices. Currently we have to rely on the respective distro > > or user

Re: Time to re-enable Runtime PM per default for PCI devcies?

2020-12-26 Thread Heiner Kallweit
On 17.11.2020 17:57, Rafael J. Wysocki wrote: > On Tue, Nov 17, 2020 at 5:38 PM Bjorn Helgaas wrote: >> >> [+to Rafael, author of the commit you mentioned, >> +cc Mika, Kai Heng, Lukas, linux-pm, linux-kernel] >> >> On Tue, Nov 17, 2020 at 04:56:09PM +0100, Heiner Kallweit wrote: >>> More than 10

Re: Time to re-enable Runtime PM per default for PCI devcies?

2020-11-17 Thread Rafael J. Wysocki
On Tue, Nov 17, 2020 at 5:38 PM Bjorn Helgaas wrote: > > [+to Rafael, author of the commit you mentioned, > +cc Mika, Kai Heng, Lukas, linux-pm, linux-kernel] > > On Tue, Nov 17, 2020 at 04:56:09PM +0100, Heiner Kallweit wrote: > > More than 10 yrs ago Runtime PM was disabled per default by

Re: Time to re-enable Runtime PM per default for PCI devcies?

2020-11-17 Thread Bjorn Helgaas
[+to Rafael, author of the commit you mentioned, +cc Mika, Kai Heng, Lukas, linux-pm, linux-kernel] On Tue, Nov 17, 2020 at 04:56:09PM +0100, Heiner Kallweit wrote: > More than 10 yrs ago Runtime PM was disabled per default by bb910a7040 > ("PCI/PM Runtime: Make runtime PM of PCI devices inactive