Re: UBSAN: Undefined behaviour in net/can/bcm.c

2019-01-12 Thread Oliver Hartkopp
On 1/12/19 10:03 PM, Kyungtae Kim wrote: On Sat, Jan 12, 2019 at 3:02 PM Oliver Hartkopp wrote: So there could potentially be some other users of timeval_to_ktime() that might have the same issue. The following would be the one related. Yes - it is also in bcm_rx_setup(). Same issue ca

Re: UBSAN: Undefined behaviour in net/can/bcm.c

2019-01-12 Thread Kyungtae Kim
On Sat, Jan 12, 2019 at 3:02 PM Oliver Hartkopp wrote: > > So there could potentially be some other users of timeval_to_ktime() > that might have the same issue. > The following would be the one related. = UBSAN: Undefined behaviour in ./include/linux/ktim

Re: UBSAN: Undefined behaviour in net/can/bcm.c

2019-01-12 Thread Oliver Hartkopp
Hi, thanks for the report! On 1/12/19 8:25 PM, Kyungtae Kim wrote: We report a bug in linux-4.19.13: "UBSAN: Undefined behaviour in net/can/bcm.c" kernel config: https://kt0755.github.io/etc/config_4.19.13 repro: https://kt0755.github.io/etc/repro.296b5.c An integer overflo

UBSAN: Undefined behaviour in net/can/bcm.c

2019-01-12 Thread Kyungtae Kim
We report a bug in linux-4.19.13: "UBSAN: Undefined behaviour in net/can/bcm.c" kernel config: https://kt0755.github.io/etc/config_4.19.13 repro: https://kt0755.github.io/etc/repro.296b5.c An integer overflow arose in bcm_timeval_to_ktime() when tv.tv_usec * NSEC_PER_USEC is large