Re: USB: serial: Deletion of an unnecessary check before the function call "release_firmware"

2014-11-24 Thread Johan Hovold
On Fri, Nov 21, 2014 at 06:59:00PM +0100, Julia Lawall wrote: > On Fri, 21 Nov 2014, SF Markus Elfring wrote: > > > >> diff --git a/drivers/usb/serial/mxuport.c b/drivers/usb/serial/mxuport.c > > >> index ab1d690..3653ec1 100644 > > >> --- a/drivers/usb/serial/mxuport.c > > >> +++ b/drivers/usb/se

Re: USB: serial: Deletion of an unnecessary check before the function call "release_firmware"

2014-11-21 Thread Julia Lawall
On Fri, 21 Nov 2014, SF Markus Elfring wrote: > >> diff --git a/drivers/usb/serial/mxuport.c b/drivers/usb/serial/mxuport.c > >> index ab1d690..3653ec1 100644 > >> --- a/drivers/usb/serial/mxuport.c > >> +++ b/drivers/usb/serial/mxuport.c > >> @@ -1101,8 +1101,7 @@ static int mxuport_probe(struc

Re: USB: serial: Deletion of an unnecessary check before the function call "release_firmware"

2014-11-21 Thread SF Markus Elfring
>> diff --git a/drivers/usb/serial/mxuport.c b/drivers/usb/serial/mxuport.c >> index ab1d690..3653ec1 100644 >> --- a/drivers/usb/serial/mxuport.c >> +++ b/drivers/usb/serial/mxuport.c >> @@ -1101,8 +1101,7 @@ static int mxuport_probe(struct usb_serial *serial, >> */ >> usb_set_serial_da

Re: [PATCH 1/1] USB: serial: Deletion of an unnecessary check before the function call "release_firmware"

2014-11-21 Thread Julia Lawall
On Fri, 21 Nov 2014, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 21 Nov 2014 16:15:34 +0100 > > The release_firmware() function tests whether its argument is NULL > and then returns immediately. Thus the test around the call is not needed. > > This issue was detected by using t

[PATCH 1/1] USB: serial: Deletion of an unnecessary check before the function call "release_firmware"

2014-11-21 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 21 Nov 2014 16:15:34 +0100 The release_firmware() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---