Re: USB autosuspend vs. URB submission

2013-01-10 Thread Oliver Neukum
On Thursday 10 January 2013 10:20:42 Alan Stern wrote: > On Thu, 10 Jan 2013, Oliver Neukum wrote: > > In the long run it is probably a good idea to pass duplicated URBs to > > usbmon by > > a special code path. > > I'd prefer to add extra information to the WARN_ONCE message. Even > though

Re: USB autosuspend vs. URB submission

2013-01-10 Thread Alan Stern
On Thu, 10 Jan 2013, Oliver Neukum wrote: > On Thursday 10 January 2013 00:05:55 Laurent Pinchart wrote: > > > I've had a quick look at the trace posted at > > https://bugzilla.redhat.com/show_bug.cgi?id=879462 but usbmon only shows > > URBs > > that are successfully submitted. I'm not sure

Re: USB autosuspend vs. URB submission

2013-01-10 Thread Alan Stern
On Thu, 10 Jan 2013, Laurent Pinchart wrote: > Hi Josh, > > On Tuesday 08 January 2013 11:03:22 Josh Boyer wrote: > > On Tue, Jan 08, 2013 at 10:51:20AM -0500, Alan Stern wrote: > > > On Mon, 7 Jan 2013, Josh Boyer wrote: > > > > Hi, > > > > > > > > We've had a few reports in Fedora of users

Re: USB autosuspend vs. URB submission

2013-01-10 Thread Oliver Neukum
On Thursday 10 January 2013 13:13:58 Ming Lei wrote: > IMO, there is a minor fault in the error handling path of > uvc_status_start() inside uvc_v4l2_open(), and the 'users' count > should have been decreased before usb_autopm_put_interface(). > In theory, the warning can be triggered when the

Re: USB autosuspend vs. URB submission

2013-01-10 Thread Oliver Neukum
On Thursday 10 January 2013 00:05:55 Laurent Pinchart wrote: > I've had a quick look at the trace posted at > https://bugzilla.redhat.com/show_bug.cgi?id=879462 but usbmon only shows URBs > that are successfully submitted. I'm not sure what useful information I could > get from the trace. The

Re: USB autosuspend vs. URB submission

2013-01-10 Thread Oliver Neukum
On Thursday 10 January 2013 10:20:42 Alan Stern wrote: On Thu, 10 Jan 2013, Oliver Neukum wrote: In the long run it is probably a good idea to pass duplicated URBs to usbmon by a special code path. I'd prefer to add extra information to the WARN_ONCE message. Even though it would

Re: USB autosuspend vs. URB submission

2013-01-10 Thread Oliver Neukum
On Thursday 10 January 2013 00:05:55 Laurent Pinchart wrote: I've had a quick look at the trace posted at https://bugzilla.redhat.com/show_bug.cgi?id=879462 but usbmon only shows URBs that are successfully submitted. I'm not sure what useful information I could get from the trace. The

Re: USB autosuspend vs. URB submission

2013-01-10 Thread Oliver Neukum
On Thursday 10 January 2013 13:13:58 Ming Lei wrote: IMO, there is a minor fault in the error handling path of uvc_status_start() inside uvc_v4l2_open(), and the 'users' count should have been decreased before usb_autopm_put_interface(). In theory, the warning can be triggered when the device

Re: USB autosuspend vs. URB submission

2013-01-10 Thread Alan Stern
On Thu, 10 Jan 2013, Laurent Pinchart wrote: Hi Josh, On Tuesday 08 January 2013 11:03:22 Josh Boyer wrote: On Tue, Jan 08, 2013 at 10:51:20AM -0500, Alan Stern wrote: On Mon, 7 Jan 2013, Josh Boyer wrote: Hi, We've had a few reports in Fedora of users hitting the WARN_ONCE

Re: USB autosuspend vs. URB submission

2013-01-10 Thread Alan Stern
On Thu, 10 Jan 2013, Oliver Neukum wrote: On Thursday 10 January 2013 00:05:55 Laurent Pinchart wrote: I've had a quick look at the trace posted at https://bugzilla.redhat.com/show_bug.cgi?id=879462 but usbmon only shows URBs that are successfully submitted. I'm not sure what useful

Re: USB autosuspend vs. URB submission

2013-01-09 Thread Ming Lei
On Thu, Jan 10, 2013 at 7:05 AM, Laurent Pinchart wrote: > > I've never heard of such problems with the uvcvideo driver, and I don't see > anything wrong with the code at first sight. The driver only submits URBs when IMO, there is a minor fault in the error handling path of uvc_status_start()

Re: USB autosuspend vs. URB submission

2013-01-09 Thread Laurent Pinchart
Hi Josh, On Tuesday 08 January 2013 11:03:22 Josh Boyer wrote: > On Tue, Jan 08, 2013 at 10:51:20AM -0500, Alan Stern wrote: > > On Mon, 7 Jan 2013, Josh Boyer wrote: > > > Hi, > > > > > > We've had a few reports in Fedora of users hitting the WARN_ONCE in > > > drivers/usb/core/urb.c that

Re: USB autosuspend vs. URB submission

2013-01-09 Thread Laurent Pinchart
Hi Josh, On Tuesday 08 January 2013 11:03:22 Josh Boyer wrote: On Tue, Jan 08, 2013 at 10:51:20AM -0500, Alan Stern wrote: On Mon, 7 Jan 2013, Josh Boyer wrote: Hi, We've had a few reports in Fedora of users hitting the WARN_ONCE in drivers/usb/core/urb.c that prints a warning

Re: USB autosuspend vs. URB submission

2013-01-09 Thread Ming Lei
On Thu, Jan 10, 2013 at 7:05 AM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: I've never heard of such problems with the uvcvideo driver, and I don't see anything wrong with the code at first sight. The driver only submits URBs when IMO, there is a minor fault in the error

Re: USB autosuspend vs. URB submission

2013-01-08 Thread Josh Boyer
On Tue, Jan 08, 2013 at 10:51:20AM -0500, Alan Stern wrote: > On Mon, 7 Jan 2013, Josh Boyer wrote: > > > Hi, > > > > We've had a few reports in Fedora of users hitting the WARN_ONCE in > > drivers/usb/core/urb.c that prints a warning about a usb_submit_urb > > being called on an active URB.

Re: USB autosuspend vs. URB submission

2013-01-08 Thread Alan Stern
On Mon, 7 Jan 2013, Josh Boyer wrote: > Hi, > > We've had a few reports in Fedora of users hitting the WARN_ONCE in > drivers/usb/core/urb.c that prints a warning about a usb_submit_urb > being called on an active URB. One of them[1] is from the ums_realtek > driver and the other[2] is from the

Re: USB autosuspend vs. URB submission

2013-01-08 Thread Alan Stern
On Mon, 7 Jan 2013, Josh Boyer wrote: Hi, We've had a few reports in Fedora of users hitting the WARN_ONCE in drivers/usb/core/urb.c that prints a warning about a usb_submit_urb being called on an active URB. One of them[1] is from the ums_realtek driver and the other[2] is from the

Re: USB autosuspend vs. URB submission

2013-01-08 Thread Josh Boyer
On Tue, Jan 08, 2013 at 10:51:20AM -0500, Alan Stern wrote: On Mon, 7 Jan 2013, Josh Boyer wrote: Hi, We've had a few reports in Fedora of users hitting the WARN_ONCE in drivers/usb/core/urb.c that prints a warning about a usb_submit_urb being called on an active URB. One of them[1]

USB autosuspend vs. URB submission

2013-01-07 Thread Josh Boyer
Hi, We've had a few reports in Fedora of users hitting the WARN_ONCE in drivers/usb/core/urb.c that prints a warning about a usb_submit_urb being called on an active URB. One of them[1] is from the ums_realtek driver and the other[2] is from the uvcvideo driver. However, I noticed that in both

USB autosuspend vs. URB submission

2013-01-07 Thread Josh Boyer
Hi, We've had a few reports in Fedora of users hitting the WARN_ONCE in drivers/usb/core/urb.c that prints a warning about a usb_submit_urb being called on an active URB. One of them[1] is from the ums_realtek driver and the other[2] is from the uvcvideo driver. However, I noticed that in both