Re: WARNING: CPU: 0 PID: 3031 at ./arch/x86/include/asm/fpu/internal.h:530 fpu__restore+0x90/0x130()

2016-02-17 Thread Andy Lutomirski
On Feb 17, 2016 1:29 AM, "Borislav Petkov" wrote: > > On Wed, Feb 17, 2016 at 09:16:46AM +0100, Ingo Molnar wrote: > > So I'm wondering why this started triggering only now. Is this a > > pre-existing bug > > that somehow got triggered via: > > > > 58122bf1d856 x86/fpu: Default eagerfpu=on on a

Re: WARNING: CPU: 0 PID: 3031 at ./arch/x86/include/asm/fpu/internal.h:530 fpu__restore+0x90/0x130()

2016-02-17 Thread Borislav Petkov
On Wed, Feb 17, 2016 at 11:31:41AM +0100, Borislav Petkov wrote: > On Wed, Feb 17, 2016 at 10:35:12AM +0100, Ingo Molnar wrote: > > So it probably triggers on vanilla v4.4 (or v4.5-rc4) as well, with no > > recent FPU bits applied? > > Nope, 4.4 doesn't trigger. Lemme try some of those other commi

Re: WARNING: CPU: 0 PID: 3031 at ./arch/x86/include/asm/fpu/internal.h:530 fpu__restore+0x90/0x130()

2016-02-17 Thread Ingo Molnar
* Borislav Petkov wrote: > On Wed, Feb 17, 2016 at 10:35:12AM +0100, Ingo Molnar wrote: > > So it probably triggers on vanilla v4.4 (or v4.5-rc4) as well, with no > > recent FPU bits applied? > > Nope, 4.4 doesn't trigger. Lemme try some of those other commits... My guess is: 58122bf1d856 x

Re: WARNING: CPU: 0 PID: 3031 at ./arch/x86/include/asm/fpu/internal.h:530 fpu__restore+0x90/0x130()

2016-02-17 Thread Borislav Petkov
On Wed, Feb 17, 2016 at 10:35:12AM +0100, Ingo Molnar wrote: > So it probably triggers on vanilla v4.4 (or v4.5-rc4) as well, with no > recent FPU bits applied? Nope, 4.4 doesn't trigger. Lemme try some of those other commits... -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when yo

Re: WARNING: CPU: 0 PID: 3031 at ./arch/x86/include/asm/fpu/internal.h:530 fpu__restore+0x90/0x130()

2016-02-17 Thread Ingo Molnar
* Borislav Petkov wrote: > On Wed, Feb 17, 2016 at 09:16:46AM +0100, Ingo Molnar wrote: > > So I'm wondering why this started triggering only now. Is this a > > pre-existing bug > > that somehow got triggered via: > > > > 58122bf1d856 x86/fpu: Default eagerfpu=on on all CPUs > > > > ? > >

Re: WARNING: CPU: 0 PID: 3031 at ./arch/x86/include/asm/fpu/internal.h:530 fpu__restore+0x90/0x130()

2016-02-17 Thread Borislav Petkov
On Wed, Feb 17, 2016 at 09:16:46AM +0100, Ingo Molnar wrote: > So I'm wondering why this started triggering only now. Is this a pre-existing > bug > that somehow got triggered via: > > 58122bf1d856 x86/fpu: Default eagerfpu=on on all CPUs > > ? Well, that's an interesting question. See, the

Re: WARNING: CPU: 0 PID: 3031 at ./arch/x86/include/asm/fpu/internal.h:530 fpu__restore+0x90/0x130()

2016-02-17 Thread Ingo Molnar
* Andy Lutomirski wrote: > On Feb 15, 2016 12:14 PM, "Borislav Petkov" wrote: > > > > --- > > From: Borislav Petkov > > Date: Mon, 15 Feb 2016 19:50:33 +0100 > > Subject: [RFC PATCH] x86/FPU: Fix double FPU regs activation > > > > On the entry_INT80_32->do_syscall_32_irqs_on path on 32-bit we

Re: WARNING: CPU: 0 PID: 3031 at ./arch/x86/include/asm/fpu/internal.h:530 fpu__restore+0x90/0x130()

2016-02-15 Thread Andy Lutomirski
On Feb 15, 2016 12:14 PM, "Borislav Petkov" wrote: > > --- > From: Borislav Petkov > Date: Mon, 15 Feb 2016 19:50:33 +0100 > Subject: [RFC PATCH] x86/FPU: Fix double FPU regs activation > > On the entry_INT80_32->do_syscall_32_irqs_on path on 32-bit we run with > interrupts enabled. I would chan

Re: WARNING: CPU: 0 PID: 3031 at ./arch/x86/include/asm/fpu/internal.h:530 fpu__restore+0x90/0x130()

2016-02-15 Thread Borislav Petkov
reemption disabled and thus not trigger fpu.preload: switch_fpu_prepare ... fpu.preload = static_cpu_has(X86_FEATURE_FPU) && new_fpu->fpstate_active && ^^ prematurely. WARNING: CPU: 0 PID: 3031 at ./arch/x86/include/asm/fpu/internal.h:5

Re: WARNING: CPU: 0 PID: 3031 at ./arch/x86/include/asm/fpu/internal.h:530 fpu__restore+0x90/0x130()

2016-02-15 Thread Borislav Petkov
On Thu, Feb 11, 2016 at 05:16:00PM -0800, Andy Lutomirski wrote: > Are you running 32-bit userspace by any chance? Sure, that's a 32-bit kernel testing partition. :) > I'm guessing you're hitting this in __fpu_restore_sig: Yeah, I was looking at that too. > fpu__drop(fpu); > if

Re: WARNING: CPU: 0 PID: 3031 at ./arch/x86/include/asm/fpu/internal.h:530 fpu__restore+0x90/0x130()

2016-02-12 Thread Borislav Petkov
On Thu, Feb 11, 2016 at 05:16:00PM -0800, Andy Lutomirski wrote: > fpu__drop(fpu); > if (__copy_from_user(&fpu->state.xsave, buf_fx, state_size) || > __copy_from_user(&env, buf, sizeof(env))) { > fpstate_init(&fpu->state); > err = -1; > }

Re: WARNING: CPU: 0 PID: 3031 at ./arch/x86/include/asm/fpu/internal.h:530 fpu__restore+0x90/0x130()

2016-02-12 Thread Borislav Petkov
On Thu, Feb 11, 2016 at 03:47:12PM -0800, Andy Lutomirski wrote: > Can you send all the fpu info that the kernel prints really early when it > boots? $ dmesg | grep -i fpu [0.00] x86/fpu: xstate_offset[2]: 576, xstate_sizes[2]: 256 [0.00] x86/fpu: Supporting XSAVE feature 0x01:

Re: WARNING: CPU: 0 PID: 3031 at ./arch/x86/include/asm/fpu/internal.h:530 fpu__restore+0x90/0x130()

2016-02-11 Thread Andy Lutomirski
On Thu, Feb 11, 2016 at 3:47 PM, Andy Lutomirski wrote: > On Thu, Feb 11, 2016 at 11:27 AM, Borislav Petkov wrote: >> Hey Andy, >> >> can you make any sense of this: >> >> [ 90.573923] [ cut here ]-------- >> [ 90.574977] WARNING: CPU

Re: WARNING: CPU: 0 PID: 3031 at ./arch/x86/include/asm/fpu/internal.h:530 fpu__restore+0x90/0x130()

2016-02-11 Thread Andy Lutomirski
On Thu, Feb 11, 2016 at 11:27 AM, Borislav Petkov wrote: > Hey Andy, > > can you make any sense of this: > > [ 90.573923] [ cut here ] > [ 90.574977] WARNING: CPU: 0 PID: 3031 at > ./arch/x86/include/asm/fpu/internal.h:530 fpu__restore+0x90/0x

WARNING: CPU: 0 PID: 3031 at ./arch/x86/include/asm/fpu/internal.h:530 fpu__restore+0x90/0x130()

2016-02-11 Thread Borislav Petkov
Hey Andy, can you make any sense of this: [ 90.573923] [ cut here ] [ 90.574977] WARNING: CPU: 0 PID: 3031 at ./arch/x86/include/asm/fpu/internal.h:530 fpu__restore+0x90/0x130() [ 90.576108] Modules linked in: hid_generic usbhid hid snd_hda_codec_hdmi