Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330()

2014-07-31 Thread James Bottomley
On Wed, 2014-07-30 at 19:59 +0200, Christoph Hellwig wrote: > On Wed, Jul 30, 2014 at 12:22:11PM -0500, Mike Christie wrote: > > Some drivers like qla2xxx do not set proc_name. I think if 2 drivers > > like that are loaded then you will hit some other warns/bugs in the kmem > > cache setup code rig

Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330()

2014-07-30 Thread Christoph Hellwig
On Wed, Jul 30, 2014 at 12:22:11PM -0500, Mike Christie wrote: > Some drivers like qla2xxx do not set proc_name. I think if 2 drivers > like that are loaded then you will hit some other warns/bugs in the kmem > cache setup code right? Drivers have to opt into using their own caches by setting .cmd

Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330()

2014-07-30 Thread Mike Christie
On 07/26/2014 11:21 AM, Christoph Hellwig wrote: > Here's a formal one. > > James, can I get your signoff for it? > > Vladimir, can I get a reviewed-by from you (or anyone else)? > > --- > From 73b1034ab1418e2dea75ccf642bc85c728b57313 Mon Sep 17 00:00:00 2001 > From: James Bottomley > Date: Sat

Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330()

2014-07-30 Thread Christoph Hellwig
On Wed, Jul 30, 2014 at 07:04:59PM +0400, James Bottomley wrote: > It's been remarkably current, I believe ... it's already up to date. I've updated the drivers tree today and it will get a few more updates さoon. > However, we only have 2 -next builds between now and the anticipated > 3.16 releas

Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330()

2014-07-30 Thread James Bottomley
On Wed, 2014-07-30 at 16:52 +0200, Christoph Hellwig wrote: > On Wed, Jul 30, 2014 at 08:21:35AM -0400, Josh Boyer wrote: > > > Thanks, I've update the author, added a Cc to ћtable and pushed it out to > > > the core-for-3.17 branch. > > > > This fixes a bug in the 3.16 kernel. Why wouldn't it be

Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330()

2014-07-30 Thread Christoph Hellwig
On Wed, Jul 30, 2014 at 08:21:35AM -0400, Josh Boyer wrote: > > Thanks, I've update the author, added a Cc to ћtable and pushed it out to > > the core-for-3.17 branch. > > This fixes a bug in the 3.16 kernel. Why wouldn't it be sent to Linus > for inclusion in the final release there? I'm only c

Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330()

2014-07-30 Thread Josh Boyer
On Tue, Jul 29, 2014 at 02:26:11PM +0200, Christoph Hellwig wrote: > On Mon, Jul 28, 2014 at 11:49:22AM +0400, James Bottomley wrote: > > That needs to be > > > > From: James Bottomley > > > > As well. I do list handling on hansenpartnership.com to minimise > > exchange wreckage on mailinglists

Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330()

2014-07-29 Thread poma
On 29.07.2014 14:26, Christoph Hellwig wrote: > On Mon, Jul 28, 2014 at 11:49:22AM +0400, James Bottomley wrote: >> That needs to be >> >> From: James Bottomley >> >> As well. I do list handling on hansenpartnership.com to minimise >> exchange wreckage on mailinglists, but I should acknowledge Pa

Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330()

2014-07-29 Thread Christoph Hellwig
On Mon, Jul 28, 2014 at 11:49:22AM +0400, James Bottomley wrote: > That needs to be > > From: James Bottomley > > As well. I do list handling on hansenpartnership.com to minimise > exchange wreckage on mailinglists, but I should acknowledge Parallels as > supporting the work I do. Thanks, I've

Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330()

2014-07-28 Thread James Bottomley
On Sat, 2014-07-26 at 18:21 +0200, Christoph Hellwig wrote: > Here's a formal one. > > James, can I get your signoff for it? Sure: Signed-off-by: James Bottomley > Vladimir, can I get a reviewed-by from you (or anyone else)? > > --- > >From 73b1034ab1418e2dea75ccf642bc85c728b57313 Mon Sep 17

Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330()

2014-07-27 Thread Vladimir Davydov
On Sat, Jul 26, 2014 at 06:21:02PM +0200, Christoph Hellwig wrote: > Here's a formal one. > > James, can I get your signoff for it? > > Vladimir, can I get a reviewed-by from you (or anyone else)? > > --- > From 73b1034ab1418e2dea75ccf642bc85c728b57313 Mon Sep 17 00:00:00 2001 > From: James Bott

Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330()

2014-07-26 Thread Martin K. Petersen
> "Christoph" == Christoph Hellwig writes: Christoph> Here's a formal one. James, can I get your signoff for it? Christoph> Vladimir, can I get a reviewed-by from you (or anyone else)? Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe

Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330()

2014-07-26 Thread Christoph Hellwig
Here's a formal one. James, can I get your signoff for it? Vladimir, can I get a reviewed-by from you (or anyone else)? --- >From 73b1034ab1418e2dea75ccf642bc85c728b57313 Mon Sep 17 00:00:00 2001 From: James Bottomley Date: Sat, 26 Jul 2014 12:21:26 -0400 Subject: scsi: use short driver name fo

Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330()

2014-07-21 Thread poma
On 21.07.2014 16:58, Christoph Hellwig wrote: On Mon, Jul 21, 2014 at 11:39:15AM +0200, poma wrote: Thanks for the tip. Is there a patch somewhere? James sent the patch earlier and you replied to it. Yea I could be more precise. :) What I thought, is the patch pushed in some official repo a

Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330()

2014-07-21 Thread Christoph Hellwig
On Mon, Jul 21, 2014 at 11:39:15AM +0200, poma wrote: > Thanks for the tip. > Is there a patch somewhere? James sent the patch earlier and you replied to it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More major

Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330()

2014-07-21 Thread poma
On 19.07.2014 18:44, Christoph Hellwig wrote: On Fri, Jul 18, 2014 at 01:07:26PM -0700, James Bottomley wrote: Is this what you thought? No, he means this, if you want to try it. Yes, that's what I mean. Thanks for the tip. Is there a patch somewhere? poma -- To unsubscribe from this

Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330()

2014-07-19 Thread Christoph Hellwig
On Fri, Jul 18, 2014 at 01:07:26PM -0700, James Bottomley wrote: > > Is this what you thought? > > No, he means this, if you want to try it. Yes, that's what I mean. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org Mo

Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330()

2014-07-18 Thread poma
On 18.07.2014 22:03, poma wrote: On 18.07.2014 16:20, Christoph Lameter wrote: On Fri, 18 Jul 2014, poma wrote: I guess someone working over the summertime. :) Cache names should not contain blanks. I guess the WARN_ON(strchr(name, ' ')); /* It confuses parsers */ was triggered?

Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330()

2014-07-18 Thread poma
On 18.07.2014 22:16, poma wrote: On 18.07.2014 22:07, James Bottomley wrote: On Fri, 2014-07-18 at 22:01 +0200, poma wrote: On 18.07.2014 16:17, Christoph Hellwig wrote: On Fri, Jul 18, 2014 at 05:21:04PM +0400, Vladimir Davydov wrote: Slab warns, because the name of the cache being created c

Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330()

2014-07-18 Thread poma
On 18.07.2014 22:07, James Bottomley wrote: On Fri, 2014-07-18 at 22:01 +0200, poma wrote: On 18.07.2014 16:17, Christoph Hellwig wrote: On Fri, Jul 18, 2014 at 05:21:04PM +0400, Vladimir Davydov wrote: Slab warns, because the name of the cache being created contains spaces. The "bad" cache is

Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330()

2014-07-18 Thread James Bottomley
On Fri, 2014-07-18 at 22:01 +0200, poma wrote: > On 18.07.2014 16:17, Christoph Hellwig wrote: > > On Fri, Jul 18, 2014 at 05:21:04PM +0400, Vladimir Davydov wrote: > >> Slab warns, because the name of the cache being created contains spaces. > >> The "bad" cache is created by scsi_get_host_cmd_poo

Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330()

2014-07-18 Thread poma
On 18.07.2014 16:20, Christoph Lameter wrote: On Fri, 18 Jul 2014, poma wrote: I guess someone working over the summertime. :) Cache names should not contain blanks. I guess the WARN_ON(strchr(name, ' ')); /* It confuses parsers */ was triggered? I can only guess also. ;) poma

Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330()

2014-07-18 Thread poma
On 18.07.2014 16:17, Christoph Hellwig wrote: On Fri, Jul 18, 2014 at 05:21:04PM +0400, Vladimir Davydov wrote: Slab warns, because the name of the cache being created contains spaces. The "bad" cache is created by scsi_get_host_cmd_pool. Its name (pool->cmd_name) is initialized by scsi_alloc_ho

Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330()

2014-07-18 Thread Christoph Lameter
On Fri, 18 Jul 2014, poma wrote: > I guess someone working over the summertime. :) Cache names should not contain blanks. I guess the WARN_ON(strchr(name, ' ')); /* It confuses parsers */ was triggered? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the bod

Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330()

2014-07-18 Thread Christoph Hellwig
On Fri, Jul 18, 2014 at 05:21:04PM +0400, Vladimir Davydov wrote: > Slab warns, because the name of the cache being created contains spaces. > The "bad" cache is created by scsi_get_host_cmd_pool. Its name > (pool->cmd_name) is initialized by scsi_alloc_host_cmd_pool as follows: > > pool->cm

Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330()

2014-07-18 Thread Vladimir Davydov
d support for per-host cmd pools"). It can be fixed e.g. by substituting spaces with underscores in cache names. Adding the patch author and reviewers to Cc. On Fri, Jul 18, 2014 at 12:57:25PM +0200, poma wrote: > > I guess someone working over the summertime. :) > > ----[

WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330()

2014-07-18 Thread poma
I guess someone working over the summertime. :) [ cut here ] WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330() Modules linked in: virtio_net virtio_scsi(+) drm virtio_pci i2c_core virtio_ring ata_generic pata_acpi virtio sunrpc dm_crypt