Re: WARNING: __GFP_FS allocations with IRQs disabled (kmemcheck_alloc_shadow)

2012-07-09 Thread Christoph Lameter
On Mon, 9 Jul 2012, JoonSoo Kim wrote: > 2012/7/8 Fengguang Wu : > > Hi Vegard, > > > > This warning code is triggered for the attached config: > > > > __lockdep_trace_alloc(): > > /* > > * Oi! Can't be having __GFP_FS allocations with IRQs disabled. > > */ > > if

Re: WARNING: __GFP_FS allocations with IRQs disabled (kmemcheck_alloc_shadow)

2012-07-09 Thread JoonSoo Kim
2012/7/9 David Rientjes : > On Mon, 9 Jul 2012, JoonSoo Kim wrote: > >> diff --git a/mm/slub.c b/mm/slub.c >> index 8c691fa..5d41cad 100644 >> --- a/mm/slub.c >> +++ b/mm/slub.c >> @@ -1324,8 +1324,14 @@ static struct page *allocate_slab(struct >> kmem_cache *s, gfp_t flags, int node) >>

Re: WARNING: __GFP_FS allocations with IRQs disabled (kmemcheck_alloc_shadow)

2012-07-09 Thread Pekka Enberg
On Sun, 8 Jul 2012, David Rientjes wrote: > The correct fix is what I proposed at > http://marc.info/?l=linux-kernel&m=133754837703630 and was awaiting > testing. If Rus, Steven, or Fengguang could test this then we could add > it as a stable backport as well. Looks good to me. Care to send it

Re: WARNING: __GFP_FS allocations with IRQs disabled (kmemcheck_alloc_shadow)

2012-07-08 Thread Fengguang Wu
On Sun, Jul 08, 2012 at 04:01:44PM -0700, David Rientjes wrote: > On Mon, 9 Jul 2012, JoonSoo Kim wrote: > > > diff --git a/mm/slub.c b/mm/slub.c > > index 8c691fa..5d41cad 100644 > > --- a/mm/slub.c > > +++ b/mm/slub.c > > @@ -1324,8 +1324,14 @@ static struct page *allocate_slab(struct > > kmem_c

Re: WARNING: __GFP_FS allocations with IRQs disabled (kmemcheck_alloc_shadow)

2012-07-08 Thread David Rientjes
On Mon, 9 Jul 2012, JoonSoo Kim wrote: > diff --git a/mm/slub.c b/mm/slub.c > index 8c691fa..5d41cad 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -1324,8 +1324,14 @@ static struct page *allocate_slab(struct > kmem_cache *s, gfp_t flags, int node) > && !(s->flags & (SLAB_NOTRACK

Re: WARNING: __GFP_FS allocations with IRQs disabled (kmemcheck_alloc_shadow)

2012-07-08 Thread JoonSoo Kim
2012/7/8 Fengguang Wu : > Hi Vegard, > > This warning code is triggered for the attached config: > > __lockdep_trace_alloc(): > /* > * Oi! Can't be having __GFP_FS allocations with IRQs disabled. > */ > if (DEBUG_LOCKS_WARN_ON(irqs_disabled_flags(flags))) >