Re: WARNING: refcount bug in find_key_to_update

2019-10-22 Thread David Howells
Okay, I managed to catch a backtrace for this line: encrypted_key: key user:syz not found (-126) looking like: CPU: 0 PID: 8878 Comm: syz-executor.0 Not tainted 5.4.0-rc3+ #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011

Re: WARNING: refcount bug in find_key_to_update

2019-10-22 Thread David Howells
Linus Torvalds wrote: > > syzbot has bisected this bug to 0570bc8b7c9b ("Merge tag > > 'riscv/for-v5.3-rc1' ...") > > Yeah, that looks unlikely. The only non-riscv changes are from > documentation updates and moving a config variable around. > > Looks like the crash is quite unlikely, and

Re: WARNING: refcount bug in find_key_to_update

2019-10-21 Thread Dmitry Vyukov
On Mon, Oct 21, 2019 at 5:59 PM David Howells wrote: > > syzbot wrote: > > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=11c8adab60 > > How do I tell what's been passed into the add_key for the encrypted key? Hi David, The easiest and most reliable would be to run it and

Re: WARNING: refcount bug in find_key_to_update

2019-10-21 Thread David Howells
syzbot wrote: > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=11c8adab60 How do I tell what's been passed into the add_key for the encrypted key? David

Re: WARNING: refcount bug in find_key_to_update

2019-10-18 Thread David Howells
Hillf Danton wrote: > - (1 << KEY_FLAG_REVOKED))) { > + (1 << KEY_FLAG_REVOKED)) || !key_tryget(key)) { > kleave(" = NULL [x]"); > return NULL; > } > - __key_get(key); That should be ineffective and ought not to

Re: WARNING: refcount bug in find_key_to_update

2019-10-18 Thread David Howells
Linus Torvalds wrote: > The backtrace looks simple enough, though: > > RIP: 0010:refcount_inc_checked+0x2b/0x30 lib/refcount.c:156 >__key_get include/linux/key.h:281 [inline] >find_key_to_update+0x67/0x80 security/keys/keyring.c:1127 >key_create_or_update+0x4e5/0xb20

Re: WARNING: refcount bug in find_key_to_update

2019-10-17 Thread Eric Biggers
On Thu, Oct 17, 2019 at 08:53:06AM -0700, Linus Torvalds wrote: > On Wed, Oct 16, 2019 at 7:42 PM syzbot > wrote: > > > > syzbot has bisected this bug to 0570bc8b7c9b ("Merge tag > > 'riscv/for-v5.3-rc1' ...") > > Yeah, that looks unlikely. The only non-riscv changes are from > documentation

Re: WARNING: refcount bug in find_key_to_update

2019-10-17 Thread Linus Torvalds
On Wed, Oct 16, 2019 at 7:42 PM syzbot wrote: > > syzbot has bisected this bug to 0570bc8b7c9b ("Merge tag > 'riscv/for-v5.3-rc1' ...") Yeah, that looks unlikely. The only non-riscv changes are from documentation updates and moving a config variable around. Looks like the crash is quite

Re: WARNING: refcount bug in find_key_to_update

2019-10-16 Thread syzbot
syzbot has bisected this bug to: commit 0570bc8b7c9b41deba6f61ac218922e7168ad648 Author: Linus Torvalds Date: Thu Jul 18 19:26:59 2019 + Merge tag 'riscv/for-v5.3-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux bisection log:

WARNING: refcount bug in find_key_to_update

2019-10-16 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:bc88f85c kthread: make __kthread_queue_delayed_work static git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1730584b60 kernel config: https://syzkaller.appspot.com/x/.config?x=e0ac4d9b35046343