Re: WARNING in get_signal

2020-10-15 Thread Oleg Nesterov
On 10/06, Oleg Nesterov wrote: > > I still do not see a good fix. I am crying ;) Sorry for delay... Finally I think I have a simple and clean fix. We can leave ptrace_init_task() alone and fix task_join_group_stop(). I need to test it a bit and write the changelog, do you see any problem in the

Re: WARNING in get_signal

2020-10-06 Thread Oleg Nesterov
On 10/05, Oleg Nesterov wrote: > > On 10/05, Oleg Nesterov wrote: > > > > > It looks like this code was introduced in commit 73ddff2bee15 ("job > > > control: introduce JOBCTL_TRAP_STOP and use it for group stop trap"). > > > > Yes, but I bet this was broken later, _may be_ by 924de3b8c9410c4. > >

Re: WARNING in get_signal

2020-10-05 Thread Oleg Nesterov
On 10/05, Oleg Nesterov wrote: > > > It looks like this code was introduced in commit 73ddff2bee15 ("job > > control: introduce JOBCTL_TRAP_STOP and use it for group stop trap"). > > Yes, but I bet this was broken later, _may be_ by 924de3b8c9410c4. No, it seems this bug is really old. I'll try

Re: WARNING in get_signal

2020-10-05 Thread Oleg Nesterov
On 10/02, Eric W. Biederman wrote: > > syzbot writes: > > > Hello, > > > > syzbot found the following issue on: > > So this is: > > static void do_jobctl_trap(void) > { > struct signal_struct *signal = current->signal; > int signr = current->jobctl & JOBCTL_STOP_SIGMASK; > > if

Re: WARNING in get_signal

2020-10-02 Thread Eric W. Biederman
syzbot writes: > Hello, > > syzbot found the following issue on: So this is: static void do_jobctl_trap(void) { struct signal_struct *signal = current->signal; int signr = current->jobctl & JOBCTL_STOP_SIGMASK; if (current->ptrace & PT_SEIZED) { if

WARNING in get_signal

2020-10-02 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:fcadab74 Merge tag 'drm-fixes-2020-10-01-1' of git://anong.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=116865bd90 kernel config: https://syzkaller.appspot.com/x/.config?x=89ab6a0c48f30b49