Re: WARNING in hso_free_net_device

2019-09-09 Thread Oliver Neukum
Am Donnerstag, den 05.09.2019, 22:05 -0400 schrieb Hui Peng: > > On 9/5/2019 7:24 AM, Andrey Konovalov wrote: > > On Thu, Sep 5, 2019 at 4:20 AM Hui Peng wrote: > > > > > > Can you guys have a look at the attached patch? > > > > Let's try it: > > > > #syz test: https://github.com/google/kasan

Re: WARNING in hso_free_net_device

2019-09-05 Thread Hui Peng
On 9/5/2019 7:24 AM, Andrey Konovalov wrote: > On Thu, Sep 5, 2019 at 4:20 AM Hui Peng wrote: >> >> Can you guys have a look at the attached patch? > > Let's try it: > > #syz test: https://github.com/google/kasan.git eea39f24 > > FYI: there are two more reports coming from this driver, whic

Re: WARNING in hso_free_net_device

2019-09-05 Thread syzbot
Hello, syzbot has tested the proposed patch and the reproducer did not trigger crash: Reported-and-tested-by: syzbot+44d53c7255bb1aea2...@syzkaller.appspotmail.com Tested on: commit: eea39f24 usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasa

Re: WARNING in hso_free_net_device

2019-09-05 Thread Andrey Konovalov
On Thu, Sep 5, 2019 at 4:20 AM Hui Peng wrote: > > Can you guys have a look at the attached patch? Let's try it: #syz test: https://github.com/google/kasan.git eea39f24 FYI: there are two more reports coming from this driver, which might (or might not) have the same root cause. One of them has

Re: WARNING in hso_free_net_device

2019-09-04 Thread Hui Peng
Can you guys have  a look at the attached patch? On 9/4/19 6:41 PM, Stephen Hemminger wrote: > On Wed, 4 Sep 2019 16:27:50 -0400 > Hui Peng wrote: > >> Hi, all: >> >> I looked at the bug a little. >> >> The issue is that in the error handling code, hso_free_net_device >> unregisters >> >> the net

Re: WARNING in hso_free_net_device

2019-09-04 Thread Stephen Hemminger
On Wed, 4 Sep 2019 16:27:50 -0400 Hui Peng wrote: > Hi, all: > > I looked at the bug a little. > > The issue is that in the error handling code, hso_free_net_device > unregisters > > the net_device (hso_net->net)  by calling unregister_netdev. In the > error handling code path, > > hso_net->n

Re: WARNING in hso_free_net_device

2019-09-04 Thread Hui Peng
Hi, all: I looked at the bug a little. The issue is that in the error handling code, hso_free_net_device unregisters the net_device (hso_net->net)  by calling unregister_netdev. In the error handling code path, hso_net->net has not been registered yet. I think there are two ways to solve the i

WARNING in hso_free_net_device

2019-09-03 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:eea39f24 usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=15f17e6160 kernel config: https://syzkaller.appspot.com/x/.

usb/net/hso: warning in hso_free_net_device

2017-09-21 Thread Andrey Konovalov
Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit ebb2c2437d8008d46796902ff390653822af6cc4 (Sep 18). Looks like hso_create_net_device() can do goto exit before registering network device. hso 1-1:4.0: Can't find BULK IN endpoint [ cut here ]---