Re: WARNINGs in set_task_reclaim_state with memory cgroup and full memory usage

2019-08-27 Thread Yang Shi
On 8/27/19 3:43 AM, Michal Hocko wrote: If there are no objection to the patch I will post it as a standalong one. On Mon 26-08-19 12:55:21, Michal Hocko wrote: From 59d128214a62bf2d83c2a2a9cde887b4817275e7 Mon Sep 17 00:00:00 2001 From: Michal Hocko Date: Mon, 26 Aug 2019 12:43:15 +0200

Re: WARNINGs in set_task_reclaim_state with memory cgroup and full memory usage

2019-08-27 Thread Michal Hocko
On Tue 27-08-19 20:19:34, Yafang Shao wrote: > On Tue, Aug 27, 2019 at 8:03 PM Michal Hocko wrote: > > > > On Tue 27-08-19 19:56:16, Yafang Shao wrote: > > > On Tue, Aug 27, 2019 at 7:50 PM Michal Hocko wrote: > > > > > > > > On Tue 27-08-19 19:43:49, Yafang Shao wrote: > > > > > On Tue, Aug 27,

Re: WARNINGs in set_task_reclaim_state with memory cgroup and full memory usage

2019-08-27 Thread Yafang Shao
On Tue, Aug 27, 2019 at 8:03 PM Michal Hocko wrote: > > On Tue 27-08-19 19:56:16, Yafang Shao wrote: > > On Tue, Aug 27, 2019 at 7:50 PM Michal Hocko wrote: > > > > > > On Tue 27-08-19 19:43:49, Yafang Shao wrote: > > > > On Tue, Aug 27, 2019 at 6:43 PM Michal Hocko wrote: > > > > > > > > > >

Re: WARNINGs in set_task_reclaim_state with memory cgroup and full memory usage

2019-08-27 Thread Michal Hocko
On Tue 27-08-19 19:56:16, Yafang Shao wrote: > On Tue, Aug 27, 2019 at 7:50 PM Michal Hocko wrote: > > > > On Tue 27-08-19 19:43:49, Yafang Shao wrote: > > > On Tue, Aug 27, 2019 at 6:43 PM Michal Hocko wrote: > > > > > > > > If there are no objection to the patch I will post it as a standalong

Re: WARNINGs in set_task_reclaim_state with memory cgroup and full memory usage

2019-08-27 Thread Yafang Shao
On Tue, Aug 27, 2019 at 7:50 PM Michal Hocko wrote: > > On Tue 27-08-19 19:43:49, Yafang Shao wrote: > > On Tue, Aug 27, 2019 at 6:43 PM Michal Hocko wrote: > > > > > > If there are no objection to the patch I will post it as a standalong > > > one. > > > > I have no objection to your patch. It

Re: WARNINGs in set_task_reclaim_state with memory cgroup and full memory usage

2019-08-27 Thread Michal Hocko
On Tue 27-08-19 19:43:49, Yafang Shao wrote: > On Tue, Aug 27, 2019 at 6:43 PM Michal Hocko wrote: > > > > If there are no objection to the patch I will post it as a standalong > > one. > > I have no objection to your patch. It could fix the issue. > > I still think that it is not proper to use

Re: WARNINGs in set_task_reclaim_state with memory cgroup and full memory usage

2019-08-27 Thread Yafang Shao
On Tue, Aug 27, 2019 at 6:43 PM Michal Hocko wrote: > > If there are no objection to the patch I will post it as a standalong > one. I have no objection to your patch. It could fix the issue. I still think that it is not proper to use a new scan_control here as it breaks the global reclaim

Re: WARNINGs in set_task_reclaim_state with memory cgroup and full memory usage

2019-08-27 Thread Michal Hocko
If there are no objection to the patch I will post it as a standalong one. On Mon 26-08-19 12:55:21, Michal Hocko wrote: > From 59d128214a62bf2d83c2a2a9cde887b4817275e7 Mon Sep 17 00:00:00 2001 > From: Michal Hocko > Date: Mon, 26 Aug 2019 12:43:15 +0200 > Subject: [PATCH] mm, memcg: do not set

Re: WARNINGs in set_task_reclaim_state with memory cgroup and full memory usage

2019-08-26 Thread Michal Hocko
On Fri 23-08-19 18:03:01, Yang Shi wrote: > > > On 8/23/19 3:00 PM, Adric Blake wrote: > > Synopsis: > > A WARN_ON_ONCE is hit twice in set_task_reclaim_state under the > > following conditions: > > - a memory cgroup has been created and a task assigned it it > > - memory.limit_in_bytes has been

Re: WARNINGs in set_task_reclaim_state with memory cgroup and full memory usage

2019-08-23 Thread Yafang Shao
On Sat, Aug 24, 2019 at 10:57 AM Hillf Danton wrote: > > > On Fri, 23 Aug 2019 18:00:15 -0400 Adric Blake wrote: > > Synopsis: > > A WARN_ON_ONCE is hit twice in set_task_reclaim_state under the > > following conditions: > > - a memory cgroup has been created and a task assigned it it > > -

Re: WARNINGs in set_task_reclaim_state with memory cgroup and full memory usage

2019-08-23 Thread Yang Shi
On 8/23/19 3:00 PM, Adric Blake wrote: Synopsis: A WARN_ON_ONCE is hit twice in set_task_reclaim_state under the following conditions: - a memory cgroup has been created and a task assigned it it - memory.limit_in_bytes has been set - memory has filled up, likely from cache In my usage, I

WARNINGs in set_task_reclaim_state with memory cgroup and full memory usage

2019-08-23 Thread Adric Blake
Synopsis: A WARN_ON_ONCE is hit twice in set_task_reclaim_state under the following conditions: - a memory cgroup has been created and a task assigned it it - memory.limit_in_bytes has been set - memory has filled up, likely from cache In my usage, I create a cgroup under the current session