Re: Why do we need reset_control_get_optional() ?

Am Dienstag, den 16.08.2016, 18:41 +0900 schrieb Masahiro Yamada: > Hi Arnd, > > 2016-08-06 0:35 GMT+09:00 Arnd Bergmann : > > > > > config RESET_FOO > > bool "FOO reset controller" if COMPILE_TEST && !ARCH_FOO > > default ARCH_FOO > > > > then I think we get both:

Re: Why do we need reset_control_get_optional() ?

Am Dienstag, den 16.08.2016, 18:41 +0900 schrieb Masahiro Yamada: > Hi Arnd, > > 2016-08-06 0:35 GMT+09:00 Arnd Bergmann : > > > > > config RESET_FOO > > bool "FOO reset controller" if COMPILE_TEST && !ARCH_FOO > > default ARCH_FOO > > > > then I think we get both: you won't be

Re: Why do we need reset_control_get_optional() ?

Am Mittwoch, den 24.08.2016, 15:58 +0900 schrieb Masahiro Yamada: > Hi Philipp, > > 2016-08-16 23:36 GMT+09:00 Masahiro Yamada : > > Hi Philipp, Arnd. > > > > > > > > 2016-08-09 1:39 GMT+09:00 Philipp Zabel : > >> Am Freitag, den 05.08.2016,

Re: Why do we need reset_control_get_optional() ?

Am Mittwoch, den 24.08.2016, 15:58 +0900 schrieb Masahiro Yamada: > Hi Philipp, > > 2016-08-16 23:36 GMT+09:00 Masahiro Yamada : > > Hi Philipp, Arnd. > > > > > > > > 2016-08-09 1:39 GMT+09:00 Philipp Zabel : > >> Am Freitag, den 05.08.2016, 17:50 +0200 schrieb Arnd Bergmann: > >>> On Thursday,

Re: Why do we need reset_control_get_optional() ?

Hi Philipp, 2016-08-16 23:36 GMT+09:00 Masahiro Yamada : > Hi Philipp, Arnd. > > > > 2016-08-09 1:39 GMT+09:00 Philipp Zabel : >> Am Freitag, den 05.08.2016, 17:50 +0200 schrieb Arnd Bergmann: >>> On Thursday, July 28, 2016 1:00:49 PM CEST

Re: Why do we need reset_control_get_optional() ?

Hi Philipp, 2016-08-16 23:36 GMT+09:00 Masahiro Yamada : > Hi Philipp, Arnd. > > > > 2016-08-09 1:39 GMT+09:00 Philipp Zabel : >> Am Freitag, den 05.08.2016, 17:50 +0200 schrieb Arnd Bergmann: >>> On Thursday, July 28, 2016 1:00:49 PM CEST Philipp Zabel wrote: >>> > Am Donnerstag, den 28.07.2016,

Re: Why do we need reset_control_get_optional() ?

Hi Philipp, Arnd. 2016-08-09 1:39 GMT+09:00 Philipp Zabel : > Am Freitag, den 05.08.2016, 17:50 +0200 schrieb Arnd Bergmann: >> On Thursday, July 28, 2016 1:00:49 PM CEST Philipp Zabel wrote: >> > Am Donnerstag, den 28.07.2016, 19:52 +0900 schrieb Masahiro Yamada: >> >>

Re: Why do we need reset_control_get_optional() ?

Hi Philipp, Arnd. 2016-08-09 1:39 GMT+09:00 Philipp Zabel : > Am Freitag, den 05.08.2016, 17:50 +0200 schrieb Arnd Bergmann: >> On Thursday, July 28, 2016 1:00:49 PM CEST Philipp Zabel wrote: >> > Am Donnerstag, den 28.07.2016, 19:52 +0900 schrieb Masahiro Yamada: >> >> > > > In my experimental

Re: Why do we need reset_control_get_optional() ?

Hi Arnd, 2016-08-06 0:35 GMT+09:00 Arnd Bergmann : > > config RESET_FOO > bool "FOO reset controller" if COMPILE_TEST && !ARCH_FOO > default ARCH_FOO > > then I think we get both: you won't be able to turn it off > but also get the build testing. This looks

Re: Why do we need reset_control_get_optional() ?

Hi Arnd, 2016-08-06 0:35 GMT+09:00 Arnd Bergmann : > > config RESET_FOO > bool "FOO reset controller" if COMPILE_TEST && !ARCH_FOO > default ARCH_FOO > > then I think we get both: you won't be able to turn it off > but also get the build testing. This looks good to me, too. I

Re: Why do we need reset_control_get_optional() ?

On Monday, August 8, 2016 6:39:36 PM CEST Philipp Zabel wrote: > > Now I'm also confused about what we really need > > reset_control_get_optional() for, and which error codes the callers > > are supposed to check. > > > > This is the matrix I think you mean for _get_optional: > > > [...] > >

Re: Why do we need reset_control_get_optional() ?

On Monday, August 8, 2016 6:39:36 PM CEST Philipp Zabel wrote: > > Now I'm also confused about what we really need > > reset_control_get_optional() for, and which error codes the callers > > are supposed to check. > > > > This is the matrix I think you mean for _get_optional: > > > [...] > >

Re: Why do we need reset_control_get_optional() ?

Am Freitag, den 05.08.2016, 17:35 +0200 schrieb Arnd Bergmann: > On Friday, August 5, 2016 10:55:58 AM CEST Philipp Zabel wrote: > > Am Samstag, den 30.07.2016, 22:13 +0200 schrieb Arnd Bergmann: > > > On Friday, July 29, 2016 3:08:15 PM CEST Philipp Zabel wrote: > > > > Hi Masahiro, > > > > > >

Re: Why do we need reset_control_get_optional() ?

Am Freitag, den 05.08.2016, 17:35 +0200 schrieb Arnd Bergmann: > On Friday, August 5, 2016 10:55:58 AM CEST Philipp Zabel wrote: > > Am Samstag, den 30.07.2016, 22:13 +0200 schrieb Arnd Bergmann: > > > On Friday, July 29, 2016 3:08:15 PM CEST Philipp Zabel wrote: > > > > Hi Masahiro, > > > > > >

Re: Why do we need reset_control_get_optional() ?

Am Freitag, den 05.08.2016, 17:50 +0200 schrieb Arnd Bergmann: > On Thursday, July 28, 2016 1:00:49 PM CEST Philipp Zabel wrote: > > Am Donnerstag, den 28.07.2016, 19:52 +0900 schrieb Masahiro Yamada: > > > > > In my experimental patch, I make the _optional functions > > > > return NULL if no

Re: Why do we need reset_control_get_optional() ?

Am Freitag, den 05.08.2016, 17:50 +0200 schrieb Arnd Bergmann: > On Thursday, July 28, 2016 1:00:49 PM CEST Philipp Zabel wrote: > > Am Donnerstag, den 28.07.2016, 19:52 +0900 schrieb Masahiro Yamada: > > > > > In my experimental patch, I make the _optional functions > > > > return NULL if no

Re: Why do we need reset_control_get_optional() ?

On Thursday, July 28, 2016 1:00:49 PM CEST Philipp Zabel wrote: > Am Donnerstag, den 28.07.2016, 19:52 +0900 schrieb Masahiro Yamada: > > > In my experimental patch, I make the _optional functions > > > return NULL if no "resets" property is provided but return > > > an error if there are reset

Re: Why do we need reset_control_get_optional() ?

On Thursday, July 28, 2016 1:00:49 PM CEST Philipp Zabel wrote: > Am Donnerstag, den 28.07.2016, 19:52 +0900 schrieb Masahiro Yamada: > > > In my experimental patch, I make the _optional functions > > > return NULL if no "resets" property is provided but return > > > an error if there are reset

Re: Why do we need reset_control_get_optional() ?

On Friday, August 5, 2016 10:55:58 AM CEST Philipp Zabel wrote: > Am Samstag, den 30.07.2016, 22:13 +0200 schrieb Arnd Bergmann: > > On Friday, July 29, 2016 3:08:15 PM CEST Philipp Zabel wrote: > > > Hi Masahiro, > > > > > > Am Donnerstag, den 28.07.2016, 19:29 +0900 schrieb Masahiro Yamada: > >

Re: Why do we need reset_control_get_optional() ?

On Friday, August 5, 2016 10:55:58 AM CEST Philipp Zabel wrote: > Am Samstag, den 30.07.2016, 22:13 +0200 schrieb Arnd Bergmann: > > On Friday, July 29, 2016 3:08:15 PM CEST Philipp Zabel wrote: > > > Hi Masahiro, > > > > > > Am Donnerstag, den 28.07.2016, 19:29 +0900 schrieb Masahiro Yamada: > >

Re: Why do we need reset_control_get_optional() ?

Am Samstag, den 30.07.2016, 22:13 +0200 schrieb Arnd Bergmann: > On Friday, July 29, 2016 3:08:15 PM CEST Philipp Zabel wrote: > > Hi Masahiro, > > > > Am Donnerstag, den 28.07.2016, 19:29 +0900 schrieb Masahiro Yamada: > > [...] > > > However, I think the following makes more sense: > > > > > >

Re: Why do we need reset_control_get_optional() ?

Am Samstag, den 30.07.2016, 22:13 +0200 schrieb Arnd Bergmann: > On Friday, July 29, 2016 3:08:15 PM CEST Philipp Zabel wrote: > > Hi Masahiro, > > > > Am Donnerstag, den 28.07.2016, 19:29 +0900 schrieb Masahiro Yamada: > > [...] > > > However, I think the following makes more sense: > > > > > >

Re: Why do we need reset_control_get_optional() ?

On Friday, July 29, 2016 3:08:15 PM CEST Philipp Zabel wrote: > Hi Masahiro, > > Am Donnerstag, den 28.07.2016, 19:29 +0900 schrieb Masahiro Yamada: > [...] > > However, I think the following makes more sense: > > > > > > menuconfig RESET_CONTROLLER > > bool "Reset Controller Support" >

Re: Why do we need reset_control_get_optional() ?

On Friday, July 29, 2016 3:08:15 PM CEST Philipp Zabel wrote: > Hi Masahiro, > > Am Donnerstag, den 28.07.2016, 19:29 +0900 schrieb Masahiro Yamada: > [...] > > However, I think the following makes more sense: > > > > > > menuconfig RESET_CONTROLLER > > bool "Reset Controller Support" >

Re: Why do we need reset_control_get_optional() ?

Hi Masahiro, Am Donnerstag, den 28.07.2016, 19:29 +0900 schrieb Masahiro Yamada: [...] > However, I think the following makes more sense: > > > menuconfig RESET_CONTROLLER > bool "Reset Controller Support" > depends on (ARCH_HAS_RESET_CONTROLLER || COMPILE_TEST) >

Re: Why do we need reset_control_get_optional() ?

Hi Masahiro, Am Donnerstag, den 28.07.2016, 19:29 +0900 schrieb Masahiro Yamada: [...] > However, I think the following makes more sense: > > > menuconfig RESET_CONTROLLER > bool "Reset Controller Support" > depends on (ARCH_HAS_RESET_CONTROLLER || COMPILE_TEST) >

Re: Why do we need reset_control_get_optional() ?

Am Donnerstag, den 28.07.2016, 19:52 +0900 schrieb Masahiro Yamada: > Hi Arnd, > > > 2016-07-28 19:09 GMT+09:00 Arnd Bergmann : > > On Thursday, July 28, 2016 11:43:00 AM CEST Philipp Zabel wrote: > >> > I want to deprecate _optional variants in the following steps: > >> > > >> >

Re: Why do we need reset_control_get_optional() ?

Am Donnerstag, den 28.07.2016, 19:52 +0900 schrieb Masahiro Yamada: > Hi Arnd, > > > 2016-07-28 19:09 GMT+09:00 Arnd Bergmann : > > On Thursday, July 28, 2016 11:43:00 AM CEST Philipp Zabel wrote: > >> > I want to deprecate _optional variants in the following steps: > >> > > >> > [1] Add

Re: Why do we need reset_control_get_optional() ?

Am Donnerstag, den 28.07.2016, 12:09 +0200 schrieb Arnd Bergmann: > On Thursday, July 28, 2016 11:43:00 AM CEST Philipp Zabel wrote: > > > I want to deprecate _optional variants in the following steps: > > > > > > [1] Add "depends on RESET_CONTROLLER" to drivers > > > for which reset_control

Re: Why do we need reset_control_get_optional() ?

Am Donnerstag, den 28.07.2016, 12:09 +0200 schrieb Arnd Bergmann: > On Thursday, July 28, 2016 11:43:00 AM CEST Philipp Zabel wrote: > > > I want to deprecate _optional variants in the following steps: > > > > > > [1] Add "depends on RESET_CONTROLLER" to drivers > > > for which reset_control

Re: Why do we need reset_control_get_optional() ?

Hi Arnd, 2016-07-28 19:09 GMT+09:00 Arnd Bergmann : > On Thursday, July 28, 2016 11:43:00 AM CEST Philipp Zabel wrote: >> > I want to deprecate _optional variants in the following steps: >> > >> > [1] Add "depends on RESET_CONTROLLER" to drivers >> > for which reset_control is

Re: Why do we need reset_control_get_optional() ?

Hi Arnd, 2016-07-28 19:09 GMT+09:00 Arnd Bergmann : > On Thursday, July 28, 2016 11:43:00 AM CEST Philipp Zabel wrote: >> > I want to deprecate _optional variants in the following steps: >> > >> > [1] Add "depends on RESET_CONTROLLER" to drivers >> > for which reset_control is mandatory. >>

Re: Why do we need reset_control_get_optional() ?

Hi Philipp, 2016-07-28 18:43 GMT+09:00 Philipp Zabel : > Am Samstag, den 23.07.2016, 20:22 +0900 schrieb Masahiro Yamada: >> Hi. >> >> >> Now the reset subsystem provides >> a bunch of reset_control_get variants. >> >> I am still wondering why we need to have _optional

Re: Why do we need reset_control_get_optional() ?

Hi Philipp, 2016-07-28 18:43 GMT+09:00 Philipp Zabel : > Am Samstag, den 23.07.2016, 20:22 +0900 schrieb Masahiro Yamada: >> Hi. >> >> >> Now the reset subsystem provides >> a bunch of reset_control_get variants. >> >> I am still wondering why we need to have _optional ones. >> >> As far as I

Re: Why do we need reset_control_get_optional() ?

On Thursday, July 28, 2016 11:43:00 AM CEST Philipp Zabel wrote: > > I want to deprecate _optional variants in the following steps: > > > > [1] Add "depends on RESET_CONTROLLER" to drivers > > for which reset_control is mandatory. > > > > We can find those driver easily by grepping > >

Re: Why do we need reset_control_get_optional() ?

On Thursday, July 28, 2016 11:43:00 AM CEST Philipp Zabel wrote: > > I want to deprecate _optional variants in the following steps: > > > > [1] Add "depends on RESET_CONTROLLER" to drivers > > for which reset_control is mandatory. > > > > We can find those driver easily by grepping > >

Re: Why do we need reset_control_get_optional() ?

Am Samstag, den 23.07.2016, 20:22 +0900 schrieb Masahiro Yamada: > Hi. > > > Now the reset subsystem provides > a bunch of reset_control_get variants. > > I am still wondering why we need to have _optional ones. > > As far as I see, the difference is WARN_ON(1) > when CONFIG_RESET_CONTROLLER

Re: Why do we need reset_control_get_optional() ?

Am Samstag, den 23.07.2016, 20:22 +0900 schrieb Masahiro Yamada: > Hi. > > > Now the reset subsystem provides > a bunch of reset_control_get variants. > > I am still wondering why we need to have _optional ones. > > As far as I see, the difference is WARN_ON(1) > when CONFIG_RESET_CONTROLLER

Why do we need reset_control_get_optional() ?

Hi. Now the reset subsystem provides a bunch of reset_control_get variants. I am still wondering why we need to have _optional ones. As far as I see, the difference is WARN_ON(1) when CONFIG_RESET_CONTROLLER is not defined. [1] When the reset is mandatory, the code of the reset consumer is

Why do we need reset_control_get_optional() ?

Hi. Now the reset subsystem provides a bunch of reset_control_get variants. I am still wondering why we need to have _optional ones. As far as I see, the difference is WARN_ON(1) when CONFIG_RESET_CONTROLLER is not defined. [1] When the reset is mandatory, the code of the reset consumer is