On 5/24/13 3:03 AM, Dave Chinner wrote:
> Right, patch below should fix the problem.
>
> What a frustrating bug. Now, where's my bottle of scotch?
In your pantry, Dave. Next to the others! ;)
-Eric
> Cheers,
>
> Dave.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-ker
On Fri, May 24, 2013 at 06:03:00PM +1000, Dave Chinner wrote:
> xfstest generic/193 is *supposed* to test behaviour of suid/sgid bits
> and clearing them is various situations.
>
> You know what I'm about to say, don't you? The test doesn't test
> what it thinks it is testing. it puts the de
On Thu, May 23, 2013 at 11:03:00PM -0400, Dave Jones wrote:
> On Thu, May 23, 2013 at 09:52:19PM -0400, Dave Jones wrote:
> > On Fri, May 24, 2013 at 11:26:25AM +1000, Dave Chinner wrote:
> >
> > > You want to print the debug output if the masked value != 0.
> >
> > XFS (sda2): xfs_setattr
On Thu, May 23, 2013 at 09:52:19PM -0400, Dave Jones wrote:
> On Fri, May 24, 2013 at 11:26:25AM +1000, Dave Chinner wrote:
>
> > You want to print the debug output if the masked value != 0.
>
> XFS (sda2): xfs_setattr_size: mask 0xaa69, masked 0x801 ii
> 0x8802129e98c0, d 0x8802
On Fri, May 24, 2013 at 11:26:25AM +1000, Dave Chinner wrote:
> You want to print the debug output if the masked value != 0.
XFS (sda2): xfs_setattr_size: mask 0xaa69, masked 0x801 ii 0x8802129e98c0,
d 0x88021757d970 path /davej/src/trinity/tmp/tmp.5/
Dave
--
To unsubscribe fr
On Fri, May 24, 2013 at 11:26:25AM +1000, Dave Chinner wrote:
> You want to print the debug output if the masked value != 0.
Derp. Thanks.
Rerunning the tests now. Hopefully I'll have something in a few hours.
Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-ker
On Thu, May 23, 2013 at 08:49:06PM -0400, Dave Jones wrote:
> On Fri, May 24, 2013 at 08:30:38AM +1000, Dave Chinner wrote:
>
> > > > Which I put just before the assert that is firing on your machine.
> > > >
> > > > And, obviously, it isn't firing on mine and obviously shouldn't be
> firi
On Fri, May 24, 2013 at 08:30:38AM +1000, Dave Chinner wrote:
> > > Which I put just before the assert that is firing on your machine.
> > >
> > > And, obviously, it isn't firing on mine and obviously shouldn't be
> > firing on a
> > > mask of 0xa068.
> >
> > With this, I get a spew
On Thu, May 23, 2013 at 02:49:48PM -0400, Dave Jones wrote:
> On Thu, May 23, 2013 at 07:54:54AM +1000, Dave Chinner wrote:
>
> > Gah, I've got not idea what the hell I was smoking yesterday
> > afternoon. 0x2000 is actually ATTR_FILE, and 0x8000 is ATTR_OPEN.
> >
> > So a mask of 0xa068 is c
On Thu, May 23, 2013 at 07:54:54AM +1000, Dave Chinner wrote:
> Gah, I've got not idea what the hell I was smoking yesterday
> afternoon. 0x2000 is actually ATTR_FILE, and 0x8000 is ATTR_OPEN.
>
> So a mask of 0xa068 is correct and valid from the open path, and
> 0x2068 is just file from the
On Thu, May 23, 2013 at 11:17:21AM -0400, Dave Jones wrote:
> On Thu, May 23, 2013 at 08:09:33AM +1000, Dave Chinner wrote:
> > On Wed, May 22, 2013 at 12:19:46PM -0400, Dave Jones wrote:
> > > On Wed, May 22, 2013 at 10:22:52AM -0400, Dave Jones wrote:
> > > > On Wed, May 22, 2013 at 03:51
On Thu, May 23, 2013 at 08:09:33AM +1000, Dave Chinner wrote:
> On Wed, May 22, 2013 at 12:19:46PM -0400, Dave Jones wrote:
> > On Wed, May 22, 2013 at 10:22:52AM -0400, Dave Jones wrote:
> > > On Wed, May 22, 2013 at 03:51:47PM +1000, Dave Chinner wrote:
> > >
> > > > > Tomorrow I'll als
On Thu, May 23, 2013 at 08:09:33AM +1000, Dave Chinner wrote:
> On Wed, May 22, 2013 at 12:19:46PM -0400, Dave Jones wrote:
> > On Wed, May 22, 2013 at 10:22:52AM -0400, Dave Jones wrote:
> > > On Wed, May 22, 2013 at 03:51:47PM +1000, Dave Chinner wrote:
> > >
> > > > > Tomorrow I'll als
On Wed, May 22, 2013 at 12:19:46PM -0400, Dave Jones wrote:
> On Wed, May 22, 2013 at 10:22:52AM -0400, Dave Jones wrote:
> > On Wed, May 22, 2013 at 03:51:47PM +1000, Dave Chinner wrote:
> >
> > > > Tomorrow I'll also try running some older kernels with the same
> > > > options to see if it
On Wed, May 22, 2013 at 03:51:47PM +1000, Dave Chinner wrote:
> On Wed, May 22, 2013 at 01:29:38AM -0400, Dave Jones wrote:
> > On Wed, May 22, 2013 at 03:12:43PM +1000, Dave Chinner wrote:
> >
> > > > [ 36.339105] XFS (sda2): xfs_setattr_size: mask 0xa068 mismatch on
> > file 0\xffb8\xfff
On Wed, May 22, 2013 at 10:22:52AM -0400, Dave Jones wrote:
> On Wed, May 22, 2013 at 03:51:47PM +1000, Dave Chinner wrote:
>
> > > Tomorrow I'll also try running some older kernels with the same
> > > options to see if it's something new, or an older bug. This is a
> > > new machine, so i
On Wed, May 22, 2013 at 03:51:47PM +1000, Dave Chinner wrote:
> > Tomorrow I'll also try running some older kernels with the same
> > options to see if it's something new, or an older bug. This is a
> > new machine, so it may be something that's been around for a
> > while, and for whatever re
On Wed, May 22, 2013 at 01:29:38AM -0400, Dave Jones wrote:
> On Wed, May 22, 2013 at 03:12:43PM +1000, Dave Chinner wrote:
>
> > > [ 36.339105] XFS (sda2): xfs_setattr_size: mask 0xa068 mismatch on
> file 0\xffb8\xffd3-\xff88\x\x
> >
> > So, still the same stra
On Wed, May 22, 2013 at 03:12:43PM +1000, Dave Chinner wrote:
> > [ 36.339105] XFS (sda2): xfs_setattr_size: mask 0xa068 mismatch on file
> > 0\xffb8\xffd3-\xff88\x\x
>
> So, still the same strange mask. That just doesn't seem right.
any idea what I screwed up
On Wed, May 22, 2013 at 12:15:21AM -0400, Dave Jones wrote:
> On Wed, May 22, 2013 at 02:03:18PM +1000, Dave Chinner wrote:
>
> > That doesn't make a whole lot of sense to me. What am I missing?
> > Are you seeing this fire at all from notify_change()?
> >
> >WARN_ON_ONCE(!mutex_is_locked
On Wed, May 22, 2013 at 02:03:18PM +1000, Dave Chinner wrote:
> That doesn't make a whole lot of sense to me. What am I missing?
> Are you seeing this fire at all from notify_change()?
>
> WARN_ON_ONCE(!mutex_is_locked(&inode->i_mutex));
No.
>
>
> What's wrong with this code in d
On Tue, May 21, 2013 at 10:56:05PM -0400, Dave Jones wrote:
> On Wed, May 22, 2013 at 10:16:03AM +1000, Dave Chinner wrote:
>
> Seems like I can trigger this from paths other than truncate too.. (eg,
> sys_open)
O_TRUNC?
> The mask is always 0xa068 though if that helps.
A bit - it confirms wha
On Wed, May 22, 2013 at 10:16:03AM +1000, Dave Chinner wrote:
Seems like I can trigger this from paths other than truncate too.. (eg,
sys_open)
Here's what I ended up with for debug
diff --git a/fs/dcache.c b/fs/dcache.c
index 2b39d16..b579dfe 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -2792
On Tue, May 21, 2013 at 08:08:03PM -0400, Dave Jones wrote:
> On Wed, May 22, 2013 at 09:54:10AM +1000, Dave Chinner wrote:
> > On Tue, May 21, 2013 at 07:40:16PM -0400, Dave Jones wrote:
> > > On Wed, May 22, 2013 at 09:34:29AM +1000, Dave Chinner wrote:
> > > > On Tue, May 21, 2013 at 06:52:5
On Wed, May 22, 2013 at 09:54:10AM +1000, Dave Chinner wrote:
> On Tue, May 21, 2013 at 07:40:16PM -0400, Dave Jones wrote:
> > On Wed, May 22, 2013 at 09:34:29AM +1000, Dave Chinner wrote:
> > > On Tue, May 21, 2013 at 06:52:57PM -0400, Dave Jones wrote:
> > > > [ 464.210598] XFS: Assertion
On Tue, May 21, 2013 at 07:40:16PM -0400, Dave Jones wrote:
> On Wed, May 22, 2013 at 09:34:29AM +1000, Dave Chinner wrote:
> > On Tue, May 21, 2013 at 06:52:57PM -0400, Dave Jones wrote:
> > > [ 464.210598] XFS: Assertion failed: (mask &
> (ATTR_MODE|ATTR_UID|ATTR_GID|ATTR_ATIME|ATTR_ATIME_SET
On Wed, May 22, 2013 at 09:34:29AM +1000, Dave Chinner wrote:
> On Tue, May 21, 2013 at 06:52:57PM -0400, Dave Jones wrote:
> > [ 464.210598] XFS: Assertion failed: (mask &
> > (ATTR_MODE|ATTR_UID|ATTR_GID|ATTR_ATIME|ATTR_ATIME_SET|
> > ATTR_MTIME_SET|ATTR_KILL_SUID|ATTR_KILL_SGID|
> > ATT
On Tue, May 21, 2013 at 06:52:57PM -0400, Dave Jones wrote:
> [ 464.210598] XFS: Assertion failed: (mask &
> (ATTR_MODE|ATTR_UID|ATTR_GID|ATTR_ATIME|ATTR_ATIME_SET|
> ATTR_MTIME_SET|ATTR_KILL_SUID|ATTR_KILL_SGID| ATTR_KILL_PRIV|ATTR_TIMES_SET))
> == 0, file: fs/xfs/xfs_iops.c, line: 719
Never
[ 464.210598] XFS: Assertion failed: (mask &
(ATTR_MODE|ATTR_UID|ATTR_GID|ATTR_ATIME|ATTR_ATIME_SET|
ATTR_MTIME_SET|ATTR_KILL_SUID|ATTR_KILL_SGID| ATTR_KILL_PRIV|ATTR_TIMES_SET))
== 0, file: fs/xfs/xfs_iops.c, line: 719
[ 464.235108] [ cut here ]
[ 464.240898] kernel B
29 matches
Mail list logo
