Re: __might_sleep() warnings on v3.19-rc6

2015-02-05 Thread Chris Mason
On Sat, Jan 31, 2015 at 07:43:15PM -0800, Fengguang Wu wrote: > Hi all, > > I see 2 __might_sleep() warnings on when running LKP tests on > v3.19-rc6, one related to raid5 and another related to btrfs. > > They might be exposed by this patch. > FSUse%Count SizeFiles/sec

Re: __might_sleep() warnings on v3.19-rc6

2015-02-05 Thread NeilBrown
(high-jacking the thread a bit... I don't have the patch that I want to reply to still in my mail box: the subject still matches...) I just got a might-sleep warning in my own testing. This was introduced by commit e22b886a8a43b147e1994a9f970f678fc0df2033 Author: Peter Zijlstra Date: Wed

Re: __might_sleep() warnings on v3.19-rc6

2015-02-05 Thread NeilBrown
On Sun, 1 Feb 2015 21:08:12 -0800 Linus Torvalds wrote: > On Sun, Feb 1, 2015 at 3:03 PM, NeilBrown wrote: > > > > I guess I could > > __set_current_state(TASK_RUNNING); > > somewhere to defeat the warning, and add a comment explaining why. > > > > Would that be a good thing? > > Use

Re: __might_sleep() warnings on v3.19-rc6

2015-02-05 Thread Chris Mason
On Sat, Jan 31, 2015 at 07:43:15PM -0800, Fengguang Wu wrote: Hi all, I see 2 __might_sleep() warnings on when running LKP tests on v3.19-rc6, one related to raid5 and another related to btrfs. They might be exposed by this patch. FSUse%Count SizeFiles/sec App

Re: __might_sleep() warnings on v3.19-rc6

2015-02-05 Thread NeilBrown
(high-jacking the thread a bit... I don't have the patch that I want to reply to still in my mail box: the subject still matches...) I just got a might-sleep warning in my own testing. This was introduced by commit e22b886a8a43b147e1994a9f970f678fc0df2033 Author: Peter Zijlstra

Re: __might_sleep() warnings on v3.19-rc6

2015-02-05 Thread NeilBrown
On Sun, 1 Feb 2015 21:08:12 -0800 Linus Torvalds torva...@linux-foundation.org wrote: On Sun, Feb 1, 2015 at 3:03 PM, NeilBrown ne...@suse.de wrote: I guess I could __set_current_state(TASK_RUNNING); somewhere to defeat the warning, and add a comment explaining why. Would that

Re: __might_sleep() warnings on v3.19-rc6

2015-02-01 Thread NeilBrown
On Sun, 1 Feb 2015 21:08:12 -0800 Linus Torvalds wrote: > On Sun, Feb 1, 2015 at 3:03 PM, NeilBrown wrote: > > > > I guess I could > > __set_current_state(TASK_RUNNING); > > somewhere to defeat the warning, and add a comment explaining why. > > > > Would that be a good thing? > > Use

Re: __might_sleep() warnings on v3.19-rc6

2015-02-01 Thread Linus Torvalds
On Sun, Feb 1, 2015 at 3:03 PM, NeilBrown wrote: > > I guess I could > __set_current_state(TASK_RUNNING); > somewhere to defeat the warning, and add a comment explaining why. > > Would that be a good thing? Use "sched_annotate_sleep()" instead, but yes, add a comment about why it's ok.

Re: __might_sleep() warnings on v3.19-rc6

2015-02-01 Thread NeilBrown
(high-jacking the thread a bit... I don't have the patch that I want to reply to still in my mail box: the subject still matches...) I just got a might-sleep warning in my own testing. This was introduced by commit e22b886a8a43b147e1994a9f970f678fc0df2033 Author: Peter Zijlstra Date: Wed

Re: __might_sleep() warnings on v3.19-rc6

2015-02-01 Thread NeilBrown
On Sat, 31 Jan 2015 19:43:15 -0800 Fengguang Wu wrote: > Hi all, > > I see 2 __might_sleep() warnings on when running LKP tests on > v3.19-rc6, one related to raid5 and another related to btrfs. > > They might be exposed by this patch. > > commit 8eb23b9f35aae413140d3fda766a98092c21e9b0 >

Re: __might_sleep() warnings on v3.19-rc6

2015-02-01 Thread NeilBrown
On Sat, 31 Jan 2015 19:43:15 -0800 Fengguang Wu fengguang...@intel.com wrote: Hi all, I see 2 __might_sleep() warnings on when running LKP tests on v3.19-rc6, one related to raid5 and another related to btrfs. They might be exposed by this patch. commit

Re: __might_sleep() warnings on v3.19-rc6

2015-02-01 Thread NeilBrown
(high-jacking the thread a bit... I don't have the patch that I want to reply to still in my mail box: the subject still matches...) I just got a might-sleep warning in my own testing. This was introduced by commit e22b886a8a43b147e1994a9f970f678fc0df2033 Author: Peter Zijlstra

Re: __might_sleep() warnings on v3.19-rc6

2015-02-01 Thread Linus Torvalds
On Sun, Feb 1, 2015 at 3:03 PM, NeilBrown ne...@suse.de wrote: I guess I could __set_current_state(TASK_RUNNING); somewhere to defeat the warning, and add a comment explaining why. Would that be a good thing? Use sched_annotate_sleep() instead, but yes, add a comment about why it's

Re: __might_sleep() warnings on v3.19-rc6

2015-02-01 Thread NeilBrown
On Sun, 1 Feb 2015 21:08:12 -0800 Linus Torvalds torva...@linux-foundation.org wrote: On Sun, Feb 1, 2015 at 3:03 PM, NeilBrown ne...@suse.de wrote: I guess I could __set_current_state(TASK_RUNNING); somewhere to defeat the warning, and add a comment explaining why. Would that

__might_sleep() warnings on v3.19-rc6

2015-01-31 Thread Fengguang Wu
Hi all, I see 2 __might_sleep() warnings on when running LKP tests on v3.19-rc6, one related to raid5 and another related to btrfs. They might be exposed by this patch. commit 8eb23b9f35aae413140d3fda766a98092c21e9b0 Author: Peter Zijlstra sched: Debug nested sleeps Validate

__might_sleep() warnings on v3.19-rc6

2015-01-31 Thread Fengguang Wu
Hi all, I see 2 __might_sleep() warnings on when running LKP tests on v3.19-rc6, one related to raid5 and another related to btrfs. They might be exposed by this patch. commit 8eb23b9f35aae413140d3fda766a98092c21e9b0 Author: Peter Zijlstra pet...@infradead.org sched: Debug nested