ror: Oops: 9605 [#1] SMP
[ 45.393897] Modules linked in: ath9k ath9k_common ath9k_hw
[ 45.399574] CPU: 1 PID: 309 Comm: kworker/u4:2 Not tainted
5.12.0-rc2-dirty #785
[ 45.414746] Workqueue: phy0 ath_reset_work [ath9k]
[ 45.419713] pstate: 4005 (nZcv daif -PAN -UAO -
:00
Committer: Thomas Gleixner
CommitterDate: Wed, 17 Mar 2021 16:34:02 +01:00
ath9k: Use tasklet_disable_in_atomic()
All callers of ath9k_beacon_ensure_primary_slot() are preemptible /
acquire a mutex except for this callchain:
spin_lock_bh(&sc->sc_pcu_lock);
ath_complet
el.org/r/20210214184911.96702-1-...@nbd.name
Signed-off-by: Greg Kroah-Hartman
---
drivers/net/wireless/ath/ath9k/ath9k.h |3 ++-
drivers/net/wireless/ath/ath9k/xmit.c |6 ++
2 files changed, 8 insertions(+), 1 deletion(-)
--- a/drivers/net/wireless/ath/ath9k/ath9k.h
+++ b/drivers/net/wireless/a
el.org/r/20210214184911.96702-1-...@nbd.name
Signed-off-by: Greg Kroah-Hartman
---
drivers/net/wireless/ath/ath9k/ath9k.h |3 ++-
drivers/net/wireless/ath/ath9k/xmit.c |6 ++
2 files changed, 8 insertions(+), 1 deletion(-)
--- a/drivers/net/wireless/ath/ath9k/ath9k.h
+++ b/drivers/net/wireless/a
el.org/r/20210214184911.96702-1-...@nbd.name
Signed-off-by: Greg Kroah-Hartman
---
drivers/net/wireless/ath/ath9k/ath9k.h |3 ++-
drivers/net/wireless/ath/ath9k/xmit.c |6 ++
2 files changed, 8 insertions(+), 1 deletion(-)
--- a/drivers/net/wireless/ath/ath9k/ath9k.h
+++ b/drivers/net/wireless/a
el.org/r/20210214184911.96702-1-...@nbd.name
Signed-off-by: Greg Kroah-Hartman
---
drivers/net/wireless/ath/ath9k/ath9k.h |3 ++-
drivers/net/wireless/ath/ath9k/xmit.c |6 ++
2 files changed, 8 insertions(+), 1 deletion(-)
--- a/drivers/net/wireless/ath/ath9k/ath9k.h
+++ b/drivers/net/wireless/a
el.org/r/20210214184911.96702-1-...@nbd.name
Signed-off-by: Greg Kroah-Hartman
---
drivers/net/wireless/ath/ath9k/ath9k.h |3 ++-
drivers/net/wireless/ath/ath9k/xmit.c |6 ++
2 files changed, 8 insertions(+), 1 deletion(-)
--- a/drivers/net/wireless/ath/ath9k/ath9k.h
+++ b/drivers/net/wireless/a
el.org/r/20210214184911.96702-1-...@nbd.name
Signed-off-by: Greg Kroah-Hartman
---
drivers/net/wireless/ath/ath9k/ath9k.h |3 ++-
drivers/net/wireless/ath/ath9k/xmit.c |6 ++
2 files changed, 8 insertions(+), 1 deletion(-)
--- a/drivers/net/wireless/ath/ath9k/ath9k.h
+++ b/drivers/net/wireless/a
el.org/r/20210214184911.96702-1-...@nbd.name
Signed-off-by: Greg Kroah-Hartman
---
drivers/net/wireless/ath/ath9k/ath9k.h |3 ++-
drivers/net/wireless/ath/ath9k/xmit.c |6 ++
2 files changed, 8 insertions(+), 1 deletion(-)
--- a/drivers/net/wireless/ath/ath9k/ath9k.h
+++ b/drivers/net/wireless/a
by: Sebastian Andrzej Siewior
> Signed-off-by: Thomas Gleixner
> Cc: ath9k-de...@qca.qualcomm.com
> Cc: Kalle Valo
> Cc: "David S. Miller"
> Cc: Jakub Kicinski
> Cc: linux-wirel...@vger.kernel.org
> Cc: net...@vger.kernel.org
> ---
> drivers/net/wireless/ath/at
It's unclear how that can be distangled, so use tasklet_disable_in_atomic()
for now. This allows tasklet_disable() to become sleepable once the
remaining atomic users are cleaned up.
Signed-off-by: Sebastian Andrzej Siewior
Signed-off-by: Thomas Gleixner
Cc: ath9k-de...@qca.qualcomm.com
linked in: ath9k ath9k_common pppoe ppp_async l2tp_ppp
cdc_mbim batman_adv ath9k_hw ath sr9700 smsc95xx sierra_net rndis_host qmi_wwan
pppox ppp_generic pl2303 nf_conntrack_ipv6 mcs7830 mac80211 kalmia iptable_nat
ipt_REJECT ipt_MASQUERADE huawei_cdc_ncm ftdi_sio dm9601 cfg80211 cdc_subse
linked in: ath9k ath9k_common pppoe ppp_async l2tp_ppp
cdc_mbim batman_adv ath9k_hw ath sr9700 smsc95xx sierra_net rndis_host qmi_wwan
pppox ppp_generic pl2303 nf_conntrack_ipv6 mcs7830 mac80211 kalmia iptable_nat
ipt_REJECT ipt_MASQUERADE huawei_cdc_ncm ftdi_sio dm9601 cfg80211 cdc_subse
linked in: ath9k ath9k_common pppoe ppp_async l2tp_ppp
cdc_mbim batman_adv ath9k_hw ath sr9700 smsc95xx sierra_net rndis_host qmi_wwan
pppox ppp_generic pl2303 nf_conntrack_ipv6 mcs7830 mac80211 kalmia iptable_nat
ipt_REJECT ipt_MASQUERADE huawei_cdc_ncm ftdi_sio dm9601 cfg80211 cdc_subse
linked in: ath9k ath9k_common pppoe ppp_async l2tp_ppp
cdc_mbim batman_adv ath9k_hw ath sr9700 smsc95xx sierra_net rndis_host qmi_wwan
pppox ppp_generic pl2303 nf_conntrack_ipv6 mcs7830 mac80211 kalmia iptable_nat
ipt_REJECT ipt_MASQUERADE huawei_cdc_ncm ftdi_sio dm9601 cfg80211 cdc_subse
linked in: ath9k ath9k_common pppoe ppp_async l2tp_ppp
cdc_mbim batman_adv ath9k_hw ath sr9700 smsc95xx sierra_net rndis_host qmi_wwan
pppox ppp_generic pl2303 nf_conntrack_ipv6 mcs7830 mac80211 kalmia iptable_nat
ipt_REJECT ipt_MASQUERADE huawei_cdc_ncm ftdi_sio dm9601 cfg80211 cdc_subse
h_tx_complete_buf() should be fixed to check sta perhaps? Worth
> looking into.
>
> Reverting this patch because it doesn't solve the problem and introduces
> memory leak by skipping buffer completion if the pointer (sta) is NULL.
>
> Fixes: a56c14bb21b2 ("ath9k: fi
s? Worth
looking into.
Reverting this patch because it doesn't solve the problem and introduces
memory leak by skipping buffer completion if the pointer (sta) is NULL.
Fixes: a56c14bb21b2 ("ath9k: fix ath_tx_process_buffer() potential null ptr
dereference")
Signed-off-by: S
h_tx_complete_buf() should be fixed to check sta perhaps? Worth
> looking into.
>
> Reverting this patch because it doesn't solve the problem and introduces
> memory leak by skipping buffer completion if the pointer (sta) is NULL.
>
> Fixes: a56c14bb21b2 ("ath9k: fi
;>>>>>> of other callers of ieee80211_find_sta_by_ifaddr() that don't hold
>>>>>>> RCU read lock.
>>>>>>>
>>>>>>> Signed-off-by: Shuah Khan
>>>>>>> Signed-off-by: Kalle Valo
>>>>>>
g buffer completion if the pointer (sta) is NULL.
Signed-off-by: Shuah Khan
---
drivers/net/wireless/ath/ath9k/xmit.c | 28 ---
1 file changed, 12 insertions(+), 16 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/xmit.c
b/drivers/net/wireless/ath/ath9k
d-off-by: Shuah Khan
Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
a56c14bb21b2 ath9k: fix ath_tx_process_buffer() potential null ptr
dereference
I just took another look at this patch, and it is completely bogus.
Not only does the stated reason not make any
Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
a56c14bb21b2 ath9k: fix ath_tx_process_buffer() potential null ptr dereference
I just took another look at this patch, and it is completely bogus.
Not only does the stated reason not make any sense (sta is simply passed
to other func
her callers of ieee80211_find_sta_by_ifaddr() that don't hold
>>>> RCU read lock.
>>>>
>>>> Signed-off-by: Shuah Khan
>>>> Signed-off-by: Kalle Valo
>>>
>>> Patch applied to ath-next branch of ath.git, thanks.
>>>
>>&
hanks.
a56c14bb21b2 ath9k: fix ath_tx_process_buffer() potential null ptr dereference
I just took another look at this patch, and it is completely bogus.
Not only does the stated reason not make any sense (sta is simply passed
to other functions, not dereferenced without checks), but this also
introdu
-off-by: Kalle Valo
>
> Patch applied to ath-next branch of ath.git, thanks.
>
> a56c14bb21b2 ath9k: fix ath_tx_process_buffer() potential null ptr dereference
I just took another look at this patch, and it is completely bogus.
Not only does the stated reason not make any sense (sta is simpl
se_peer_stats_info() and a subsequent manual audit
> of other callers of ieee80211_find_sta_by_ifaddr() that don't hold
> RCU read lock.
>
> Signed-off-by: Shuah Khan
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
a56c14bb21b2 ath9k: fix ath_
From: Arnd Bergmann
[ Upstream commit b64acb28da8394485f0762e657470c9fc33aca4d ]
When CONFIG_ATH9K is built-in but LED support is in a loadable
module, both ath9k drivers fails to link:
x86_64-linux-ld: drivers/net/wireless/ath/ath9k/gpio.o: in function
`ath_deinit_leds':
gpio.c:(.text
On 2021-02-12 03:13, Shuah Khan wrote:
> ieee80211_find_sta_by_ifaddr() must be called under the RCU lock and
> the resulting pointer is only valid under RCU lock as well.
>
> Fix ath_tx_process_buffer() to hold RCU read lock before it calls
> ieee80211_find_sta_by_ifaddr() and release it when the
of other callers of ieee80211_find_sta_by_ifaddr() that don't hold
RCU read lock.
Signed-off-by: Shuah Khan
---
- Note: This patch is compile tested. I don't have access to
hardware.
drivers/net/wireless/ath/ath9k/xmit.c | 28 +++
1 file changed, 16 inserti
ave access to
hardware.
drivers/net/wireless/ath/ath9k/xmit.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/net/wireless/ath/ath9k/xmit.c
b/drivers/net/wireless/ath/ath9k/xmit.c
index e60d4737fc6e..1d36aae3f7b6 100644
--- a/drivers/net/wireless/ath/ath9k/xmit.c
+++ b/d
495070] Hi:
> [ 88.498044] Lo:
> [ 88.501040] epc : 80221c28 ioread32+0x8/0x10
> [ 88.505671] ra: 83314e60 ath9k_hw_loadnf+0x88/0x520 [ath9k_hw]
> [ 88.512049] Status: 1000fc03 KERNEL EXL IE
> [ 88.516369] Cause : 5080801c (ExcCode 07)
> [ 88.52
2+0x8/0x10
[ 88.505671] ra: 83314e60 ath9k_hw_loadnf+0x88/0x520 [ath9k_hw]
[ 88.512049] Status: 1000fc03 KERNEL EXL IE
[ 88.516369] Cause : 5080801c (ExcCode 07)
[ 88.520508] PrId : 00019374 (MIPS 24Kc)
[ 88.524556] Modules linked in: ath9k ath9k_common pppoe ppp_async l2tp_ppp
Krzysztof Kozlowski wrote:
> After commit 72cdab808714 ("ath9k: Do not select MAC80211_LEDS by
> default") a configuration like:
> - MAC80211_LEDS=y
> - LEDS_CLASS=m
> - NEW_LEDS=y
> - ATH9K=y
> leads to a build failure:
>
> /usr/bin/ld: driv
Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> When CONFIG_ATH9K is built-in but LED support is in a loadable
> module, both ath9k drivers fails to link:
>
> x86_64-linux-ld: drivers/net/wireless/ath/ath9k/gpio.o: in function
> `ath_deinit_leds':
> gpio.c:(.text+
i
> > > > wrote:
> > >
> > > I meant that having MAC80211_LEDS selected causes the ath9k driver to
> > > toggle on/off the WiFi LED. Every second, regardless whether it's
> > > doing something or not. In my setup, I have problems with a WiFi
> &
Arnd Bergmann writes:
> On Mon, Jan 25, 2021 at 4:04 PM Krzysztof Kozlowski wrote:
>> On Mon, 25 Jan 2021 at 15:38, Arnd Bergmann wrote:
>> > On Mon, Jan 25, 2021 at 2:27 PM Krzysztof Kozlowski
>> > wrote:
>>
>> I meant that having MAC80211_LEDS select
)
> > event. However I still have LEDS_CLASS for other LEDS in the system.
>
> What is the effect of this lost event every second? If it causes some
> runtime warning or other problem, then neither of our fixes would
> solve it completely, because someone with a distro kernel would
>
On Mon, Jan 25, 2021 at 2:27 PM Krzysztof Kozlowski wrote:
> On Mon, 25 Jan 2021 at 14:09, Arnd Bergmann wrote:
> > On Mon, Jan 25, 2021 at 12:40 PM Krzysztof Kozlowski
> > wrote:
> > > On Mon, 25 Jan 2021 at 12:36, Arnd Bergmann wrote:
> > > But we do not want to have this dependency (selecti
in but LED support is in a loadable
> > > module, both ath9k drivers fails to link:
> > >
> > > x86_64-linux-ld: drivers/net/wireless/ath/ath9k/gpio.o: in function
> > > `ath_deinit_leds':
> > > gpio.c:(.text+0x36): undefined reference to `
On Mon, Jan 25, 2021 at 12:40 PM Krzysztof Kozlowski wrote:
> On Mon, 25 Jan 2021 at 12:36, Arnd Bergmann wrote:
> >
> > From: Arnd Bergmann
> >
> > When CONFIG_ATH9K is built-in but LED support is in a loadable
> > module, both ath9k drivers fails to link:
>
On Mon, 25 Jan 2021 at 12:36, Arnd Bergmann wrote:
>
> From: Arnd Bergmann
>
> When CONFIG_ATH9K is built-in but LED support is in a loadable
> module, both ath9k drivers fails to link:
>
> x86_64-linux-ld: drivers/net/wireless/ath/ath9k/gpio.o: in function
> `ath_deini
From: Arnd Bergmann
When CONFIG_ATH9K is built-in but LED support is in a loadable
module, both ath9k drivers fails to link:
x86_64-linux-ld: drivers/net/wireless/ath/ath9k/gpio.o: in function
`ath_deinit_leds':
gpio.c:(.text+0x36): undefined reference to `led_classdev_unregister'
x8
On Mon, Jan 25, 2021 at 4:04 PM Krzysztof Kozlowski wrote:
> On Mon, 25 Jan 2021 at 15:38, Arnd Bergmann wrote:
> > On Mon, Jan 25, 2021 at 2:27 PM Krzysztof Kozlowski wrote:
>
> I meant that having MAC80211_LEDS selected causes the ath9k driver to
> toggle on/off the WiFi
After commit 72cdab808714 ("ath9k: Do not select MAC80211_LEDS by
default") a configuration like:
- MAC80211_LEDS=y
- LEDS_CLASS=m
- NEW_LEDS=y
- ATH9K=y
leads to a build failure:
/usr/bin/ld: drivers/net/wireless/ath/ath9k/gpio.o: in function
`ath_deinit_leds':
drive
Hi Krzysztof,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 614cb5894306cfa2c7d9b6168182876ff5948735
commit: 72cdab808714b1ec24b0c7bdebed163ce791f01f ath9k: Do not select
MAC80211_LEDS by default
date: 4 months
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 614cb5894306cfa2c7d9b6168182876ff5948735
commit: 72cdab808714b1ec24b0c7bdebed163ce791f01f ath9k: Do not select
MAC80211_LEDS by default
date: 4 months ago
config: i386-randconfig-a014-20201223 (attached
t...@redhat.com wrote:
> The macro use will already have a semicolon.
>
> Signed-off-by: Tom Rix
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
5a5b820d18c7 ath9k: remove trailing semicolon in macro definition
--
https://patchwork.kernel.org/p
Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/wireless/ath/ath9k/ar9330_1p1_initvals.h:1013:18: warning:
> ‘ar9331_common_tx_gain_offset1_1’ defined but not used
> [-Wunused-const-variable=]
>
> Cc: QCA ath9k Development
> Cc:
From: Tom Rix
The macro use will already have a semicolon.
Signed-off-by: Tom Rix
---
drivers/net/wireless/ath/ath9k/common-debug.c | 2 +-
drivers/net/wireless/ath/ath9k/dfs_debug.c| 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/ath/ath9k/dynack.c:52: warning: Function parameter or
member 'old' not described in 'ath_dynack_ewma'
drivers/net/wireless/ath/ath9k/dynack.c:52: warning: Function parameter or
member 'new' not
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/ath/ath9k/ar5008_phy.c:119: warning: Function parameter
or member 'rfBuf' not described in 'ar5008_hw_phy_modify_rx_buffer'
drivers/net/wireless/ath/ath9k/ar5008_phy.c:119: warning: Function parameter
o
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/ath/ath9k/ar9003_2p2_initvals.h:1734:18: warning:
‘ar9300PciePhy_clkreq_disable_L1_2p2’ defined but not used
[-Wunused-const-variable=]
drivers/net/wireless/ath/ath9k/ar9003_2p2_initvals.h:1727:18: warning
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/ath/ath9k/ar9340_initvals.h:624:18: warning:
‘ar9340Modes_ub124_tx_gain_table_1p0’ defined but not used
[-Wunused-const-variable=]
Cc: QCA ath9k Development
Cc: Kalle Valo
Cc: "David S. Miller"
Cc: Jakub Ki
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/ath/ath9k/ar9485_initvals.h:1009:18: warning:
‘ar9485_fast_clock_1_1_baseband_postamble’ defined but not used
[-Wunused-const-variable=]
Cc: QCA ath9k Development
Cc: Kalle Valo
Cc: "David S. Miller"
Cc: Jaku
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/ath/ath9k/ar9330_1p1_initvals.h:1013:18: warning:
‘ar9331_common_tx_gain_offset1_1’ defined but not used
[-Wunused-const-variable=]
Cc: QCA ath9k Development
Cc: Kalle Valo
Cc: "David S. Miller"
Cc: Jakub Ki
On Mon, Nov 23, 2020 at 07:59:28PM +0200, Jani Nikula wrote:
> Now that relay_open() accepts const callbacks, make relay callbacks
> const.
Looks good,
Reviewed-by: Christoph Hellwig
Now that relay_open() accepts const callbacks, make relay callbacks
const.
Cc: Kalle Valo
Cc: QCA ath9k Development
Cc: linux-wirel...@vger.kernel.org
Acked-by: Kalle Valo
Signed-off-by: Jani Nikula
---
drivers/net/wireless/ath/ath9k/common-spectral.c | 2 +-
1 file changed, 1 insertion
Kalle Valo writes:
> Jani Nikula writes:
>
>> Now that relay_open() accepts const callbacks, make relay callbacks
>> const.
>>
>> Cc: Kalle Valo
>> Cc: QCA ath9k Development
>> Cc: linux-wirel...@vger.kernel.org
>> Signed-off-by: Jani Nikula
Jani Nikula writes:
> Now that relay_open() accepts const callbacks, make relay callbacks
> const.
>
> Cc: Kalle Valo
> Cc: QCA ath9k Development
> Cc: linux-wirel...@vger.kernel.org
> Signed-off-by: Jani Nikula
Can I take this to my ath tree or what&#
Now that relay_open() accepts const callbacks, make relay callbacks
const.
Cc: Kalle Valo
Cc: QCA ath9k Development
Cc: linux-wirel...@vger.kernel.org
Signed-off-by: Jani Nikula
---
drivers/net/wireless/ath/ath9k/common-spectral.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Arnd Bergmann wrote:
> gcc-10 shows a false-positive warning with CONFIG_KASAN:
>
> drivers/net/wireless/ath/ath9k/dynack.c: In function
> 'ath_dynack_sample_tx_ts':
> include/linux/etherdevice.h:290:14: warning: writing 4 bytes into a region of
> size 0 [-
On Sat, Nov 7, 2020 at 12:21 PM Kalle Valo wrote:
> Johannes Berg writes:
> > On Mon, 2020-11-02 at 18:26 +0200, Kalle Valo wrote:
> >> Arnd Bergmann writes:
> >> Isn't there a better way to handle this? I really would not want
> >> checking for GCC versions become a common approach in drivers.
Johannes Berg writes:
> On Mon, 2020-11-02 at 18:26 +0200, Kalle Valo wrote:
>> Arnd Bergmann writes:
>>
>> > From: Arnd Bergmann
>> >
>> > gcc-10 shows a false-positive warning with CONFIG_KASAN:
>> >
>> > drivers/net/wireless/at
Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/wireless/ath/ath9k/ar9330_1p1_initvals.h:1013:18: warning:
> ‘ar9331_common_tx_gain_offset1_1’ defined but not used
> [-Wunused-const-variable=]
>
> Cc: QCA ath9k Development
> Cc:
On Mon, Nov 2, 2020 at 7:01 PM Johannes Berg wrote:
> On Mon, 2020-11-02 at 18:26 +0200, Kalle Valo wrote:
> > Arnd Bergmann writes:
> > > From: Arnd Bergmann
> >
> > Isn't there a better way to handle this? I really would not want
> > checking for GCC versions become a common approach in driver
troduced new
> regressions.
>
> Fixes: 03fb92a432ea ("ath9k: hif_usb: fix race condition between
> usb_get_urb() and usb_kill_anchored_urbs()")
> Signed-off-by: Brooke Basile
More background info is needed so that I'm not reverting the revert soon. What
were the new
On Mon, 2020-11-02 at 18:26 +0200, Kalle Valo wrote:
> Arnd Bergmann writes:
>
> > From: Arnd Bergmann
> >
> > gcc-10 shows a false-positive warning with CONFIG_KASAN:
> >
> > drivers/net/wireless/ath/ath9k/dynack.c: In function
> > 'ath_dynack
Arnd Bergmann writes:
> From: Arnd Bergmann
>
> gcc-10 shows a false-positive warning with CONFIG_KASAN:
>
> drivers/net/wireless/ath/ath9k/dynack.c: In function
> 'ath_dynack_sample_tx_ts':
> include/linux/etherdevice.h:290:14: warning: writing 4 bytes into a
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/ath/ath9k/ar9330_1p1_initvals.h:1013:18: warning:
‘ar9331_common_tx_gain_offset1_1’ defined but not used
[-Wunused-const-variable=]
Cc: QCA ath9k Development
Cc: Kalle Valo
Cc: "David S. Miller"
Cc: Jakub Ki
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/ath/ath9k/ar9340_initvals.h:624:18: warning:
‘ar9340Modes_ub124_tx_gain_table_1p0’ defined but not used
[-Wunused-const-variable=]
Cc: QCA ath9k Development
Cc: Kalle Valo
Cc: "David S. Miller"
Cc: Jakub Ki
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/ath/ath9k/ar9003_2p2_initvals.h:1734:18: warning:
‘ar9300PciePhy_clkreq_disable_L1_2p2’ defined but not used
[-Wunused-const-variable=]
drivers/net/wireless/ath/ath9k/ar9003_2p2_initvals.h:1727:18: warning
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/ath/ath9k/ar5008_phy.c:119: warning: Function parameter
or member 'rfBuf' not described in 'ar5008_hw_phy_modify_rx_buffer'
drivers/net/wireless/ath/ath9k/ar5008_phy.c:119: warning: Function parameter
o
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/ath/ath9k/ar9485_initvals.h:1009:18: warning:
‘ar9485_fast_clock_1_1_baseband_postamble’ defined but not used
[-Wunused-const-variable=]
Cc: QCA ath9k Development
Cc: Kalle Valo
Cc: "David S. Miller"
Cc: Jaku
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/ath/ath9k/dynack.c:52: warning: Function parameter or
member 'old' not described in 'ath_dynack_ewma'
drivers/net/wireless/ath/ath9k/dynack.c:52: warning: Function parameter or
member 'new' not
=cabffad18eb74197f84871802fd2c5117b61febf
Signed-off-by: Brooke Basile
Signed-off-by: Kalle Valo
Link: https://lore.kernel.org/r/20200911071427.32354-1-brookebas...@gmail.com
Signed-off-by: Sasha Levin
---
drivers/net/wireless/ath/ath9k/hif_usb.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a
=cabffad18eb74197f84871802fd2c5117b61febf
Signed-off-by: Brooke Basile
Signed-off-by: Kalle Valo
Link: https://lore.kernel.org/r/20200911071427.32354-1-brookebas...@gmail.com
Signed-off-by: Sasha Levin
---
drivers/net/wireless/ath/ath9k/hif_usb.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a
found in commit e4ff08a4d727
("ath9k: Fix use-after-free Write in ath9k_htc_rx_msg") so it is
probably a real issue.
Fixes: fb9987d0f748 ("ath9k_htc: Support for AR9271 chipset.")
Signed-off-by: Dan Carpenter
Signed-off-by: Kalle Valo
Link: https://lore.kernel.org/r/20200813141253.
found in commit e4ff08a4d727
("ath9k: Fix use-after-free Write in ath9k_htc_rx_msg") so it is
probably a real issue.
Fixes: fb9987d0f748 ("ath9k_htc: Support for AR9271 chipset.")
Signed-off-by: Dan Carpenter
Signed-off-by: Kalle Valo
Link: https://lore.kernel.org/r/20200813141253.
found in commit e4ff08a4d727
("ath9k: Fix use-after-free Write in ath9k_htc_rx_msg") so it is
probably a real issue.
Fixes: fb9987d0f748 ("ath9k_htc: Support for AR9271 chipset.")
Signed-off-by: Dan Carpenter
Signed-off-by: Kalle Valo
Link: https://lore.kernel.org/r/20200813141253.
=cabffad18eb74197f84871802fd2c5117b61febf
Signed-off-by: Brooke Basile
Signed-off-by: Kalle Valo
Link: https://lore.kernel.org/r/20200911071427.32354-1-brookebas...@gmail.com
Signed-off-by: Sasha Levin
---
drivers/net/wireless/ath/ath9k/hif_usb.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a
=cabffad18eb74197f84871802fd2c5117b61febf
Signed-off-by: Brooke Basile
Signed-off-by: Kalle Valo
Link: https://lore.kernel.org/r/20200911071427.32354-1-brookebas...@gmail.com
Signed-off-by: Sasha Levin
---
drivers/net/wireless/ath/ath9k/hif_usb.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a
found in commit e4ff08a4d727
("ath9k: Fix use-after-free Write in ath9k_htc_rx_msg") so it is
probably a real issue.
Fixes: fb9987d0f748 ("ath9k_htc: Support for AR9271 chipset.")
Signed-off-by: Dan Carpenter
Signed-off-by: Kalle Valo
Link: https://lore.kernel.org/r/20200813141253.
=cabffad18eb74197f84871802fd2c5117b61febf
Signed-off-by: Brooke Basile
Signed-off-by: Kalle Valo
Link: https://lore.kernel.org/r/20200911071427.32354-1-brookebas...@gmail.com
Signed-off-by: Sasha Levin
---
drivers/net/wireless/ath/ath9k/hif_usb.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a
=cabffad18eb74197f84871802fd2c5117b61febf
Signed-off-by: Brooke Basile
Signed-off-by: Kalle Valo
Link: https://lore.kernel.org/r/20200911071427.32354-1-brookebas...@gmail.com
Signed-off-by: Sasha Levin
---
drivers/net/wireless/ath/ath9k/hif_usb.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a
found in commit e4ff08a4d727
("ath9k: Fix use-after-free Write in ath9k_htc_rx_msg") so it is
probably a real issue.
Fixes: fb9987d0f748 ("ath9k_htc: Support for AR9271 chipset.")
Signed-off-by: Dan Carpenter
Signed-off-by: Kalle Valo
Link: https://lore.kernel.org/r/20200813141253.
=cabffad18eb74197f84871802fd2c5117b61febf
Signed-off-by: Brooke Basile
Signed-off-by: Kalle Valo
Link: https://lore.kernel.org/r/20200911071427.32354-1-brookebas...@gmail.com
Signed-off-by: Sasha Levin
---
drivers/net/wireless/ath/ath9k/hif_usb.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a
found in commit e4ff08a4d727
("ath9k: Fix use-after-free Write in ath9k_htc_rx_msg") so it is
probably a real issue.
Fixes: fb9987d0f748 ("ath9k_htc: Support for AR9271 chipset.")
Signed-off-by: Dan Carpenter
Signed-off-by: Kalle Valo
Link: https://lore.kernel.org/r/20200813141253.
found in commit e4ff08a4d727
("ath9k: Fix use-after-free Write in ath9k_htc_rx_msg") so it is
probably a real issue.
Fixes: fb9987d0f748 ("ath9k_htc: Support for AR9271 chipset.")
Signed-off-by: Dan Carpenter
Signed-off-by: Kalle Valo
Link: https://lore.kernel.org/r/20200813141253.
From: Arnd Bergmann
gcc-10 shows a false-positive warning with CONFIG_KASAN:
drivers/net/wireless/ath/ath9k/dynack.c: In function 'ath_dynack_sample_tx_ts':
include/linux/etherdevice.h:290:14: warning: writing 4 bytes into a region of
size 0 [-Wstringop-overflow=]
290 | *
=cabffad18eb74197f84871802fd2c5117b61febf
Signed-off-by: Brooke Basile
Signed-off-by: Kalle Valo
Link: https://lore.kernel.org/r/20200911071427.32354-1-brookebas...@gmail.com
Signed-off-by: Sasha Levin
---
drivers/net/wireless/ath/ath9k/hif_usb.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a
=cabffad18eb74197f84871802fd2c5117b61febf
Signed-off-by: Brooke Basile
Signed-off-by: Kalle Valo
Link: https://lore.kernel.org/r/20200911071427.32354-1-brookebas...@gmail.com
Signed-off-by: Sasha Levin
---
drivers/net/wireless/ath/ath9k/hif_usb.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a
=cabffad18eb74197f84871802fd2c5117b61febf
Signed-off-by: Brooke Basile
Signed-off-by: Kalle Valo
Link: https://lore.kernel.org/r/20200911071427.32354-1-brookebas...@gmail.com
Signed-off-by: Sasha Levin
---
drivers/net/wireless/ath/ath9k/hif_usb.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a
=cabffad18eb74197f84871802fd2c5117b61febf
Signed-off-by: Brooke Basile
Signed-off-by: Kalle Valo
Link: https://lore.kernel.org/r/20200911071427.32354-1-brookebas...@gmail.com
Signed-off-by: Sasha Levin
---
drivers/net/wireless/ath/ath9k/hif_usb.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a
=cabffad18eb74197f84871802fd2c5117b61febf
Signed-off-by: Brooke Basile
Signed-off-by: Kalle Valo
Link: https://lore.kernel.org/r/20200911071427.32354-1-brookebas...@gmail.com
Signed-off-by: Sasha Levin
---
drivers/net/wireless/ath/ath9k/hif_usb.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a
=cabffad18eb74197f84871802fd2c5117b61febf
Signed-off-by: Brooke Basile
Signed-off-by: Kalle Valo
Link: https://lore.kernel.org/r/20200911071427.32354-1-brookebas...@gmail.com
Signed-off-by: Sasha Levin
---
drivers/net/wireless/ath/ath9k/hif_usb.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a
=cabffad18eb74197f84871802fd2c5117b61febf
Signed-off-by: Brooke Basile
Signed-off-by: Kalle Valo
Link: https://lore.kernel.org/r/20200911071427.32354-1-brookebas...@gmail.com
Signed-off-by: Sasha Levin
---
drivers/net/wireless/ath/ath9k/hif_usb.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a
("ath9k: hif_usb: fix race condition between usb_get_urb()
and usb_kill_anchored_urbs()")
Signed-off-by: Brooke Basile
---
drivers/net/wireless/ath/ath9k/hif_usb.c | 19 ---
1 file changed, 19 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/hif_usb.c
b/d
Li Heng wrote:
> This addresses the following gcc warning with "make W=1":
>
> drivers/net/wireless/ath/ath9k/ar9580_1p0_initvals.h:1331:18: warning:
> ‘ar9580_1p0_pcie_phy_clkreq_enable_L1’ defined but not used
> [-Wunused-const-variable=]
>
>
This addresses the following gcc warning with "make W=1":
drivers/net/wireless/ath/ath9k/ar9580_1p0_initvals.h:1331:18: warning:
‘ar9580_1p0_pcie_phy_clkreq_enable_L1’ defined but not used
[-Wunused-const-variable=]
drivers/net/wireless/ath/ath9k/ar9580_1p0_initvals.h:1338:1
1 - 100 of 843 matches
Mail list logo
