Re: audit looks unmaintained? [was: Re: [PATCH 11/12] pid: rewrite task helper functions avoiding task->pid and task->tgid]

2013-09-14 Thread Oleg Nesterov
On 09/13, Steve Grubb wrote: > > On Tuesday, September 10, 2013 07:20:33 PM Oleg Nesterov wrote: > > > > So, Steve, do you still think that patch was wrong? Attached below > > just in case. > > I think this looks OK. If the task filter NACK's auditing the process, then > clearing the flag is probab

Re: audit looks unmaintained? [was: Re: [PATCH 11/12] pid: rewrite task helper functions avoiding task->pid and task->tgid]

2013-09-14 Thread Oleg Nesterov
On 09/13, Steve Grubb wrote: > > On Sunday, September 08, 2013 05:54:35 PM Oleg Nesterov wrote: > > > > Then why audit_alloc() doesn't set TIF_SYSCALL_AUDIT unconditionally? > > The code I'm looking at does right at the end of the function. The code I'm looking at does right at the end too ;) but

Re: audit looks unmaintained? [was: Re: [PATCH 11/12] pid: rewrite task helper functions avoiding task->pid and task->tgid]

2013-09-13 Thread Steve Grubb
On Sunday, September 08, 2013 05:54:35 PM Oleg Nesterov wrote: > Sorry for delay, vacation. > > First of all, I do not pretend I understand this code. This was mostly > the question, and in fact I mostly asked about audit_bprm() in 0/1. > > However, > > On 08/30, Steve Grubb wrote: > > On Friday

Re: audit looks unmaintained? [was: Re: [PATCH 11/12] pid: rewrite task helper functions avoiding task->pid and task->tgid]

2013-09-13 Thread Steve Grubb
On Tuesday, September 10, 2013 07:20:33 PM Oleg Nesterov wrote: > On 09/08, Oleg Nesterov wrote: > > First of all, I do not pretend I understand this code. This was mostly > > the question, and in fact I mostly asked about audit_bprm() in 0/1. > > > > However, > > > > On 08/30, Steve Grubb wrote:

Re: audit looks unmaintained? [was: Re: [PATCH 11/12] pid: rewrite task helper functions avoiding task->pid and task->tgid]

2013-09-10 Thread Oleg Nesterov
On 09/08, Oleg Nesterov wrote: > > First of all, I do not pretend I understand this code. This was mostly > the question, and in fact I mostly asked about audit_bprm() in 0/1. > > However, > > On 08/30, Steve Grubb wrote: > > On Friday, August 30, 2013 03:06:46 PM Richard Guy Briggs wrote: > > > On

Re: audit looks unmaintained? [was: Re: [PATCH 11/12] pid: rewrite task helper functions avoiding task->pid and task->tgid]

2013-09-08 Thread Oleg Nesterov
Sorry for delay, vacation. First of all, I do not pretend I understand this code. This was mostly the question, and in fact I mostly asked about audit_bprm() in 0/1. However, On 08/30, Steve Grubb wrote: > On Friday, August 30, 2013 03:06:46 PM Richard Guy Briggs wrote: > > On Tue, Aug 27, 2013

Re: audit looks unmaintained? [was: Re: [PATCH 11/12] pid: rewrite task helper functions avoiding task->pid and task->tgid]

2013-08-30 Thread Steve Grubb
On Friday, August 30, 2013 03:06:46 PM Richard Guy Briggs wrote: > On Tue, Aug 27, 2013 at 07:11:34PM +0200, Oleg Nesterov wrote: > > Btw. audit looks unmaintained... if you are going to take care of > > this code, perhaps you can look at > > > > http://marc.info/?l=linux-kernel&m=137589907108

audit looks unmaintained? [was: Re: [PATCH 11/12] pid: rewrite task helper functions avoiding task->pid and task->tgid]

2013-08-30 Thread Richard Guy Briggs
On Tue, Aug 27, 2013 at 07:11:34PM +0200, Oleg Nesterov wrote: > Btw. audit looks unmaintained... if you are going to take care of > this code, perhaps you can look at > > http://marc.info/?l=linux-kernel&m=137589907108485 > http://marc.info/?l=linux-kernel&m=137590271809664 (I don't