[PATCH v1 5/8] scsi: megaraid: clean up for "foo * bar"

2021-04-09 Thread Luo Jiaxing
Following error is reported by checkpatch.pl: "foo * bar" should be "foo *bar" + struct megasas_iocpacket __user * user_ioc, The format of the pointer variable must be "foo *bar", so fix them. Signed-off-by: Luo Jiaxing --- drivers/scsi/me

Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Reuse BAR definitions for MFD cell indexing

2021-03-24 Thread Lee Jones
On Tue, 23 Mar 2021, Andy Shevchenko wrote: > It's convenient and less error prone to use definitions to address > different cells in an array. For this purpose we may reuse existing > BAR definitions. > > Signed-off-by: Andy Shevchenko > --- > v2: used explicit in

[PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Reuse BAR definitions for MFD cell indexing

2021-03-23 Thread Andy Shevchenko
It's convenient and less error prone to use definitions to address different cells in an array. For this purpose we may reuse existing BAR definitions. Signed-off-by: Andy Shevchenko --- v2: used explicit indices for MFD cells in the array (Lee) drivers/mfd/intel_quark_i2c_gpio.c

Re: [PATCH v1 5/5] mfd: intel_quark_i2c_gpio: Reuse BAR definitions for MFD cell indexing

2021-03-23 Thread Andy Shevchenko
On Tue, Mar 23, 2021 at 09:20:57AM +, Lee Jones wrote: > On Tue, 02 Mar 2021, Andy Shevchenko wrote: > > > It's convenient and less error prone to use definitions to address > > different cells in an array. For this purpose we may reuse exist

Re: [PATCH v1 5/5] mfd: intel_quark_i2c_gpio: Reuse BAR definitions for MFD cell indexing

2021-03-23 Thread Lee Jones
On Tue, 02 Mar 2021, Andy Shevchenko wrote: > It's convenient and less error prone to use definitions to address > different cells in an array. For this purpose we may reuse existing > BAR definitions. > > Signed-off-by: Andy Shevchenko > --- > drivers/mfd/i

[PATCH 5.10 178/290] ALSA: usb-audio: Fix "cannot get freq eq" errors on Dell AE515 sound bar

2021-03-15 Thread gregkh
From: Greg Kroah-Hartman From: Takashi Iwai commit fec60c3bc5d1713db2727cdffc638d48f9c07dc3 upstream. Dell AE515 sound bar (413c:a506) spews the error messages when the driver tries to read the current sample frequency, hence it needs to be on the list in snd_usb_get_sample_rate_quirk

[PATCH 5.11 171/306] ALSA: usb-audio: Fix "cannot get freq eq" errors on Dell AE515 sound bar

2021-03-15 Thread gregkh
From: Greg Kroah-Hartman From: Takashi Iwai commit fec60c3bc5d1713db2727cdffc638d48f9c07dc3 upstream. Dell AE515 sound bar (413c:a506) spews the error messages when the driver tries to read the current sample frequency, hence it needs to be on the list in snd_usb_get_sample_rate_quirk

[PATCH 4.19 063/120] ALSA: usb-audio: Fix "cannot get freq eq" errors on Dell AE515 sound bar

2021-03-15 Thread gregkh
From: Greg Kroah-Hartman From: Takashi Iwai commit fec60c3bc5d1713db2727cdffc638d48f9c07dc3 upstream. Dell AE515 sound bar (413c:a506) spews the error messages when the driver tries to read the current sample frequency, hence it needs to be on the list in snd_usb_get_sample_rate_quirk

[PATCH 5.4 094/168] ALSA: usb-audio: Fix "cannot get freq eq" errors on Dell AE515 sound bar

2021-03-15 Thread gregkh
From: Greg Kroah-Hartman From: Takashi Iwai commit fec60c3bc5d1713db2727cdffc638d48f9c07dc3 upstream. Dell AE515 sound bar (413c:a506) spews the error messages when the driver tries to read the current sample frequency, hence it needs to be on the list in snd_usb_get_sample_rate_quirk

[PATCH 4.14 44/95] ALSA: usb-audio: Fix "cannot get freq eq" errors on Dell AE515 sound bar

2021-03-15 Thread gregkh
From: Greg Kroah-Hartman From: Takashi Iwai commit fec60c3bc5d1713db2727cdffc638d48f9c07dc3 upstream. Dell AE515 sound bar (413c:a506) spews the error messages when the driver tries to read the current sample frequency, hence it needs to be on the list in snd_usb_get_sample_rate_quirk

[PATCH 4.9 27/78] ALSA: usb-audio: Fix "cannot get freq eq" errors on Dell AE515 sound bar

2021-03-15 Thread gregkh
From: Greg Kroah-Hartman From: Takashi Iwai commit fec60c3bc5d1713db2727cdffc638d48f9c07dc3 upstream. Dell AE515 sound bar (413c:a506) spews the error messages when the driver tries to read the current sample frequency, hence it needs to be on the list in snd_usb_get_sample_rate_quirk

[PATCH 4.4 27/75] ALSA: usb-audio: Fix "cannot get freq eq" errors on Dell AE515 sound bar

2021-03-15 Thread gregkh
From: Greg Kroah-Hartman From: Takashi Iwai commit fec60c3bc5d1713db2727cdffc638d48f9c07dc3 upstream. Dell AE515 sound bar (413c:a506) spews the error messages when the driver tries to read the current sample frequency, hence it needs to be on the list in snd_usb_get_sample_rate_quirk

[PATCH 0/1] Init atombios timeout when amdgpu is Thunderbolt / USB4 when IO BAR is assigned

2021-03-13 Thread Nicholas Johnson
Hi all, I am not certain why this happens, but when IO bar is assigned on Thunderbolt, the amdgpu init fails: [drm:atom_op_jump [amdgpu]] *ERROR* atombios stuck in loop for more than 20secs aborting [drm:amdgpu_atom_execute_table_locked [amdgpu]] *ERROR* atombios stuck executing B456 (len 304

[PATCH v1 5/5] mfd: intel_quark_i2c_gpio: Reuse BAR definitions for MFD cell indexing

2021-03-02 Thread Andy Shevchenko
It's convenient and less error prone to use definitions to address different cells in an array. For this purpose we may reuse existing BAR definitions. Signed-off-by: Andy Shevchenko --- drivers/mfd/intel_quark_i2c_gpio.c | 20 ++-- 1 file changed, 10 insertions(+), 10 dele

Re: [PATCH 0/5] Touch Bar and ALS support for MacBook Pro's

2021-02-28 Thread Jonathan Cameron
On Sat, 27 Feb 2021 17:26:38 -0800 Ronald Tschalär wrote: > This patch set provides Touch Bar and ALS support on MacBook Pro's > 13,*, 14,*, and 15,*. > > Some time a go an earlier version of these were posted to the list; > all code comments from there have been incorpora

Re: [PATCH 5/5] HID: apple-touchbar - Add driver for the Touch Bar on MacBook Pro's.

2021-02-27 Thread kernel test robot
st to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Ronald-Tschal-r/Touch-Bar-and-ALS-support-for-MacBook-Pro-s/20210228-093451 base: https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-ne

Re: [PATCH 5/5] HID: apple-touchbar - Add driver for the Touch Bar on MacBook Pro's.

2021-02-27 Thread kernel test robot
. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Ronald-Tschal-r/Touch-Bar-and-ALS-support-for-MacBook-Pro-s/20210228-093451 base: https://git.kernel.org/pub/scm/linux

Re: [PATCH 5/5] HID: apple-touchbar - Add driver for the Touch Bar on MacBook Pro's.

2021-02-27 Thread kernel test robot
. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Ronald-Tschal-r/Touch-Bar-and-ALS-support-for-MacBook-Pro-s/20210228-093451 base: https://git.kernel.org/pub/scm/linux

[PATCH 5/5] HID: apple-touchbar - Add driver for the Touch Bar on MacBook Pro's.

2021-02-27 Thread Ronald Tschalär
This driver enables basic touch bar functionality: enabling it, switching between modes on FN key press, and dimming and turning the display off/on when idle/active. Signed-off-by: Ronald Tschalär --- drivers/hid/Kconfig | 10 + drivers/hid/Makefile |1 + drivers/hid

[PATCH 0/5] Touch Bar and ALS support for MacBook Pro's

2021-02-27 Thread Ronald Tschalär
This patch set provides Touch Bar and ALS support on MacBook Pro's 13,*, 14,*, and 15,*. Some time a go an earlier version of these were posted to the list; all code comments from there have been incorporated. In addition the approach has been cleaned up, especially given that we now know ho

[PATCH v11 02/17] PCI: endpoint: Make *_get_first_free_bar() take into account 64 bit BAR

2021-02-01 Thread Kishon Vijay Abraham I
pci_epc_get_first_free_bar() uses only "reserved_bar" member in epc_features to get the first unreserved BAR. However if the reserved BAR is also a 64-bit BAR, then the next BAR shouldn't be returned (since 64-bit BAR uses two BARs). Make pci_epc_get_first_free_bar() take into acc

[PATCH v11 03/17] PCI: endpoint: Add helper API to get the 'next' unreserved BAR

2021-02-01 Thread Kishon Vijay Abraham I
Add an API to get the next unreserved BAR starting from a given BAR number that can be used by the endpoint function. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/endpoint/pci-epc-core.c | 26 ++ include/linux/pci-epc.h | 2 ++ 2 files changed, 24

[PATCH 1/2] opp: Fix "foo * bar" should be "foo *bar"

2021-01-31 Thread Viresh Kumar
Fix checkpatch warning: ERROR: "foo * bar" should be "foo *bar". Signed-off-by: Viresh Kumar --- include/linux/pm_opp.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/pm_opp.h b/include/linux/pm_opp.h index 25e47ab937b9..c6c7d73eb015

[PATCH v9 02/17] PCI: endpoint: Make *_get_first_free_bar() take into account 64 bit BAR

2021-01-04 Thread Kishon Vijay Abraham I
pci_epc_get_first_free_bar() uses only "reserved_bar" member in epc_features to get the first unreserved BAR. However if the reserved BAR is also a 64-bit BAR, then the next BAR shouldn't be returned (since 64-bit BAR uses two BARs). Make pci_epc_get_first_free_bar() take into acc

[PATCH v9 03/17] PCI: endpoint: Add helper API to get the 'next' unreserved BAR

2021-01-04 Thread Kishon Vijay Abraham I
Add an API to get the next unreserved BAR starting from a given BAR number that can be used by the endpoint function. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/endpoint/pci-epc-core.c | 26 ++ include/linux/pci-epc.h | 2 ++ 2 files changed, 24

[PATCH v8 03/18] PCI: endpoint: Add helper API to get the 'next' unreserved BAR

2020-11-11 Thread Kishon Vijay Abraham I
Add an API to get the next unreserved BAR starting from a given BAR number that can be used by the endpoint function. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/endpoint/pci-epc-core.c | 26 ++ include/linux/pci-epc.h | 2 ++ 2 files changed, 24

[PATCH v8 02/18] PCI: endpoint: Make *_get_first_free_bar() take into account 64 bit BAR

2020-11-11 Thread Kishon Vijay Abraham I
pci_epc_get_first_free_bar() uses only "reserved_bar" member in epc_features to get the first unreserved BAR. However if the reserved BAR is also a 64-bit BAR, then the next BAR shouldn't be returned (since 64-bit BAR uses two BARs). Make pci_epc_get_first_free_bar() take into acc

[PATCH 5.8 41/70] net: hns3: Clear the CMDQ registers before unmapping BAR region

2020-10-31 Thread Greg Kroah-Hartman
] ksys_write+0x74/0xf8 [ 266.055677] __arm64_sys_write+0x24/0x30 [ 266.059584] el0_svc_common.constprop.3+0x84/0x270 [ 266.064354] do_el0_svc+0x34/0xa0 [ 266.067658] el0_svc+0x38/0x40 [ 266.070700] el0_sync_handler+0x8c/0xb0 [ 266.074519] el0_sync+0x140/0x180 It looks like the BAR memory

[PATCH 5.9 42/74] net: hns3: Clear the CMDQ registers before unmapping BAR region

2020-10-31 Thread Greg Kroah-Hartman
] ksys_write+0x74/0xf8 [ 266.055677] __arm64_sys_write+0x24/0x30 [ 266.059584] el0_svc_common.constprop.3+0x84/0x270 [ 266.064354] do_el0_svc+0x34/0xa0 [ 266.067658] el0_svc+0x38/0x40 [ 266.070700] el0_sync_handler+0x8c/0xb0 [ 266.074519] el0_sync+0x140/0x180 It looks like the BAR memory

[PATCH 5.4 25/49] net: hns3: Clear the CMDQ registers before unmapping BAR region

2020-10-31 Thread Greg Kroah-Hartman
] ksys_write+0x74/0xf8 [ 266.055677] __arm64_sys_write+0x24/0x30 [ 266.059584] el0_svc_common.constprop.3+0x84/0x270 [ 266.064354] do_el0_svc+0x34/0xa0 [ 266.067658] el0_svc+0x38/0x40 [ 266.070700] el0_sync_handler+0x8c/0xb0 [ 266.074519] el0_sync+0x140/0x180 It looks like the BAR memory

Re: AMD SME encrpytion and PCI BAR pages to user space

2020-10-27 Thread Jason Gunthorpe
On Tue, Oct 27, 2020 at 08:43:57AM +, Christoph Hellwig wrote: > On Wed, Oct 21, 2020 at 01:03:22PM -0300, Jason Gunthorpe wrote: > > Oh, interesting.. Yes the issue is no userspace DMA stuff uses the DMA > > API correctly (because it is in userspace) > > > > So SWIOTLB tricks don't work, I wi

Re: AMD SME encrpytion and PCI BAR pages to user space

2020-10-27 Thread Christoph Hellwig
On Wed, Oct 21, 2020 at 01:03:22PM -0300, Jason Gunthorpe wrote: > Oh, interesting.. Yes the issue is no userspace DMA stuff uses the DMA > API correctly (because it is in userspace) > > So SWIOTLB tricks don't work, I wish the dma_map could fail for these > situations Userspace DMA by definition

Re: [PATCH net] net: hns3: Clear the CMDQ registers before unmapping BAR region

2020-10-26 Thread Jakub Kicinski
On Tue, 27 Oct 2020 09:42:01 +0800 Yunsheng Lin wrote: > On 2020/10/27 9:25, Jakub Kicinski wrote: > > On Tue, 27 Oct 2020 09:24:10 +0800 Yunsheng Lin wrote: > >>> Fixes: 862d969a3a4d ("net: hns3: do VF's pci re-initialization while PF > >>> doing FLR") > >> > >> The correct Fixes tag should

Re: [PATCH net] net: hns3: Clear the CMDQ registers before unmapping BAR region

2020-10-26 Thread Yunsheng Lin
On 2020/10/27 9:25, Jakub Kicinski wrote: > On Tue, 27 Oct 2020 09:24:10 +0800 Yunsheng Lin wrote: >>> Fixes: 862d969a3a4d ("net: hns3: do VF's pci re-initialization while PF >>> doing FLR") >> >> The correct Fixes tag should be: >> >> Fixes: e3338205f0c7 ("net: hns3: uninitialize pci in the hcl

Re: [PATCH net] net: hns3: Clear the CMDQ registers before unmapping BAR region

2020-10-26 Thread Jakub Kicinski
On Tue, 27 Oct 2020 09:24:10 +0800 Yunsheng Lin wrote: > > Fixes: 862d969a3a4d ("net: hns3: do VF's pci re-initialization while PF > > doing FLR") > > The correct Fixes tag should be: > > Fixes: e3338205f0c7 ("net: hns3: uninitialize pci in the hclgevf_uninit") Why is that? Isn't the issue t

Re: [PATCH net] net: hns3: Clear the CMDQ registers before unmapping BAR region

2020-10-26 Thread Yunsheng Lin
On 2020/10/27 7:13, Jakub Kicinski wrote: > On Fri, 23 Oct 2020 15:01:14 +0800 Zenghui Yu wrote: >> On 2020/10/23 14:22, Yunsheng Lin wrote: >>> On 2020/10/23 13:15, Zenghui Yu wrote: When unbinding the hns3 driver with the HNS3 VF, I got the following kernel panic: [ 265.709

Re: [PATCH net] net: hns3: Clear the CMDQ registers before unmapping BAR region

2020-10-26 Thread Jakub Kicinski
On Fri, 23 Oct 2020 15:01:14 +0800 Zenghui Yu wrote: > On 2020/10/23 14:22, Yunsheng Lin wrote: > > On 2020/10/23 13:15, Zenghui Yu wrote: > >> When unbinding the hns3 driver with the HNS3 VF, I got the following > >> kernel panic: > >> > >> [ 265.709989] Unable to handle kernel paging request a

Re: [PATCH net] net: hns3: Clear the CMDQ registers before unmapping BAR region

2020-10-23 Thread Zenghui Yu
] ksys_write+0x74/0xf8 [ 266.055677] __arm64_sys_write+0x24/0x30 [ 266.059584] el0_svc_common.constprop.3+0x84/0x270 [ 266.064354] do_el0_svc+0x34/0xa0 [ 266.067658] el0_svc+0x38/0x40 [ 266.070700] el0_sync_handler+0x8c/0xb0 [ 266.074519] el0_sync+0x140/0x180 It looks like the BAR

Re: [PATCH net] net: hns3: Clear the CMDQ registers before unmapping BAR region

2020-10-22 Thread Yunsheng Lin
> [ 266.059584] el0_svc_common.constprop.3+0x84/0x270 > [ 266.064354] do_el0_svc+0x34/0xa0 > [ 266.067658] el0_svc+0x38/0x40 > [ 266.070700] el0_sync_handler+0x8c/0xb0 > [ 266.074519] el0_sync+0x140/0x180 > > It looks like the BAR memory region had already be

[PATCH net] net: hns3: Clear the CMDQ registers before unmapping BAR region

2020-10-22 Thread Zenghui Yu
] el0_svc_common.constprop.3+0x84/0x270 [ 266.064354] do_el0_svc+0x34/0xa0 [ 266.067658] el0_svc+0x38/0x40 [ 266.070700] el0_sync_handler+0x8c/0xb0 [ 266.074519] el0_sync+0x140/0x180 It looks like the BAR memory region had already been unmapped before we start clearing CMDQ registers in it

Re: AMD SME encrpytion and PCI BAR pages to user space

2020-10-21 Thread Jason Gunthorpe
On Wed, Oct 21, 2020 at 10:30:23AM -0500, Tom Lendacky wrote: > On 10/21/20 6:59 AM, Jason Gunthorpe wrote: > > On Mon, Oct 19, 2020 at 11:36:16AM -0500, Tom Lendacky wrote: > > > >>> io_remap_pfn_range()? Is there use cases where a caller actually wants > >>> encrypted io memory? > >> > >> As lon

Re: AMD SME encrpytion and PCI BAR pages to user space

2020-10-21 Thread Tom Lendacky
On 10/21/20 6:59 AM, Jason Gunthorpe wrote: > On Mon, Oct 19, 2020 at 11:36:16AM -0500, Tom Lendacky wrote: > >>> io_remap_pfn_range()? Is there use cases where a caller actually wants >>> encrypted io memory? >> >> As long as you never have physical memory / ram being mapped in this path, >> it s

Re: AMD SME encrpytion and PCI BAR pages to user space

2020-10-21 Thread Jason Gunthorpe
On Mon, Oct 19, 2020 at 11:36:16AM -0500, Tom Lendacky wrote: > > io_remap_pfn_range()? Is there use cases where a caller actually wants > > encrypted io memory? > > As long as you never have physical memory / ram being mapped in this path, > it seems that applying pgprot_decrypted() would be ok.

Re: AMD SME encrpytion and PCI BAR pages to user space

2020-10-19 Thread Jason Gunthorpe
On Mon, Oct 19, 2020 at 12:11:36PM -0500, Tom Lendacky wrote: > > Hum, I assume it is broken also. Actually quite a swath of drivers > > and devices will be broken under this :\ > > Not sure what you mean by the last statement - in general or when running > under VFIO/DPDK? In general, traditiona

Re: AMD SME encrpytion and PCI BAR pages to user space

2020-10-19 Thread Tom Lendacky
gt;> DPDK or something unrelated to virtualization? >> >> If user space is mapping un-encrypted memory, then, yes, it would seem >> that there is a gap in the support where the pgprot_decrypted() would be >> needed in order to override the protection map. > > It isn'

Re: AMD SME encrpytion and PCI BAR pages to user space

2020-10-19 Thread Jason Gunthorpe
; If user space is mapping un-encrypted memory, then, yes, it would seem > that there is a gap in the support where the pgprot_decrypted() would be > needed in order to override the protection map. It isn't "memory" it is PCI BAR pages, eg memory mapped IO > &g

Re: AMD SME encrpytion and PCI BAR pages to user space

2020-10-19 Thread Tom Lendacky
On 10/19/20 10:25 AM, Jason Gunthorpe wrote: > Hi Tom, Hi Jason, > > We've found a bug where systems that have the AMD SME turned on are > not able to run RDMA work loads. It seems the kernel is automatically > encrypting VMA's pointing at PCI BAR memory create

AMD SME encrpytion and PCI BAR pages to user space

2020-10-19 Thread Jason Gunthorpe
Hi Tom, We've found a bug where systems that have the AMD SME turned on are not able to run RDMA work loads. It seems the kernel is automatically encrypting VMA's pointing at PCI BAR memory created by io_remap_pfn_range() - adding a prot_decrypted() causes things to start working. To

[PATCH v7 03/18] PCI: endpoint: Add helper API to get the 'next' unreserved BAR

2020-09-30 Thread Kishon Vijay Abraham I
Add an API to get the next unreserved BAR starting from a given BAR number that can be used by the endpoint function. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/endpoint/pci-epc-core.c | 26 ++ include/linux/pci-epc.h | 2 ++ 2 files changed, 24

[PATCH v7 02/18] PCI: endpoint: Make *_get_first_free_bar() take into account 64 bit BAR

2020-09-30 Thread Kishon Vijay Abraham I
pci_epc_get_first_free_bar() uses only "reserved_bar" member in epc_features to get the first unreserved BAR. However if the reserved BAR is also a 64-bit BAR, then the next BAR shouldn't be returned (since 64-bit BAR uses two BARs). Make pci_epc_get_first_free_bar() take into acc

[PATCH v6 03/17] PCI: endpoint: Add helper API to get the 'next' unreserved BAR

2020-09-24 Thread Kishon Vijay Abraham I
Add an API to get the next unreserved BAR starting from a given BAR number that can be used by the endpoint function. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/endpoint/pci-epc-core.c | 26 ++ include/linux/pci-epc.h | 2 ++ 2 files changed, 24

[PATCH v6 02/17] PCI: endpoint: Make *_get_first_free_bar() take into account 64 bit BAR

2020-09-24 Thread Kishon Vijay Abraham I
pci_epc_get_first_free_bar() uses only "reserved_bar" member in epc_features to get the first unreserved BAR. However if the reserved BAR is also a 64-bit BAR, then the next BAR shouldn't be returned (since 64-bit BAR uses two BARs). Make pci_epc_get_first_free_bar() take into acc

[PATCH v5 02/17] PCI: endpoint: Make *_get_first_free_bar() take into account 64 bit BAR

2020-09-17 Thread Kishon Vijay Abraham I
pci_epc_get_first_free_bar() uses only "reserved_bar" member in epc_features to get the first unreserved BAR. However if the reserved BAR is also a 64-bit BAR, then the next BAR shouldn't be returned (since 64-bit BAR uses two BARs). Make pci_epc_get_first_free_bar() take into acc

[PATCH v5 03/17] PCI: endpoint: Add helper API to get the 'next' unreserved BAR

2020-09-17 Thread Kishon Vijay Abraham I
Add an API to get the next unreserved BAR starting from a given BAR number that can be used by the endpoint function. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/endpoint/pci-epc-core.c | 26 ++ include/linux/pci-epc.h | 2 ++ 2 files changed, 24

[PATCH v4 03/17] PCI: endpoint: Add helper API to get the 'next' unreserved BAR

2020-09-14 Thread Kishon Vijay Abraham I
Add an API to get the next unreserved BAR starting from a given BAR number that can be used by the endpoint function. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/endpoint/pci-epc-core.c | 26 ++ include/linux/pci-epc.h | 2 ++ 2 files changed, 24

[PATCH v4 02/17] PCI: endpoint: Make *_get_first_free_bar() take into account 64 bit BAR

2020-09-14 Thread Kishon Vijay Abraham I
pci_epc_get_first_free_bar() uses only "reserved_bar" member in epc_features to get the first unreserved BAR. However if the reserved BAR is also a 64-bit BAR, then the next BAR shouldn't be returned (since 64-bit BAR uses two BARs). Make pci_epc_get_first_free_bar() take into acc

[PATCH v3 02/17] PCI: endpoint: Make *_get_first_free_bar() take into account 64 bit BAR

2020-09-04 Thread Kishon Vijay Abraham I
pci_epc_get_first_free_bar() uses only "reserved_bar" member in epc_features to get the first unreserved BAR. However if the reserved BAR is also a 64-bit BAR, then the next BAR shouldn't be returned (since 64-bit BAR uses two BARs). Make pci_epc_get_first_free_bar() take into acc

[PATCH v3 03/17] PCI: endpoint: Add helper API to get the 'next' unreserved BAR

2020-09-04 Thread Kishon Vijay Abraham I
Add an API to get the next unreserved BAR starting from a given BAR number that can be used by the endpoint function. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/endpoint/pci-epc-core.c | 26 ++ include/linux/pci-epc.h | 2 ++ 2 files changed, 24

[PATCH v3 3/3] dyndbg: fix problem parsing format="foo bar"

2020-08-31 Thread Jim Cromie
commit 14775b049642 ("dyndbg: accept query terms like file=bar and module=foo") added the combined keyword=value parsing poorly; revert most of it, keeping the keyword & arg change. Instead, fix the tokenizer for the new input, by terminating the keyword (an unquoted word) on

Re: [PATCH v2 3/3] dyndbg: fix problem parsing format="foo bar"

2020-08-28 Thread Greg KH
On Tue, Aug 25, 2020 at 11:33:39AM -0600, Jim Cromie wrote: > 14775b049642 dyndbg: accept query terms like file=bar and module=foo > What does that above line mean??? > That commit broke on a tokenization modality where a word could start > with a quote, but couldnt continue with

[PATCH v2 3/3] dyndbg: fix problem parsing format="foo bar"

2020-08-25 Thread Jim Cromie
14775b049642 dyndbg: accept query terms like file=bar and module=foo That commit broke on a tokenization modality where a word could start with a quote, but couldnt continue with one. So the above would tokenize as 'format="foo' and 'bar"', and fail hard. This

[PATCH 3/3] dyndbg: fix problem parsing format="foo bar"

2020-08-24 Thread Jim Cromie
14775b049642 dyndbg: accept query terms like file=bar and module=foo That commit broke on a tokenization modality where a word could start with a quote, but couldnt continue with one. So the above would tokenize as 'format="foo' and 'bar"', and fail hard. This

Re: [PATCH v8 01/15] PCI: cadence: Use "dma-ranges" instead of "cdns,no-bar-match-nbits" property

2020-07-22 Thread Rob Herring
On Wed, Jul 22, 2020 at 5:03 AM Kishon Vijay Abraham I wrote: > > Cadence PCIe core driver (host mode) uses "cdns,no-bar-match-nbits" > property to configure the number of bits passed through from PCIe > address to internal address in Inbound Address Translation register. &

Re: [PATCH v8 01/15] PCI: cadence: Use "dma-ranges" instead of "cdns,no-bar-match-nbits" property

2020-07-22 Thread Lorenzo Pieralisi
On Wed, Jul 22, 2020 at 04:33:03PM +0530, Kishon Vijay Abraham I wrote: > Cadence PCIe core driver (host mode) uses "cdns,no-bar-match-nbits" > property to configure the number of bits passed through from PCIe > address to internal address in Inbound Address Translation registe

[PATCH v8 01/15] PCI: cadence: Use "dma-ranges" instead of "cdns,no-bar-match-nbits" property

2020-07-22 Thread Kishon Vijay Abraham I
Cadence PCIe core driver (host mode) uses "cdns,no-bar-match-nbits" property to configure the number of bits passed through from PCIe address to internal address in Inbound Address Translation register. This only used the NO MATCH BAR. However standard PCI dt-binding already defines &

[PATCH v5 14/18] dyndbg: accept query terms like file=bar and module=foo

2020-07-19 Thread Jim Cromie
Current code expects "keyword" "arg" as 2 words, space separated. Change to also accept "keyword=arg" form as well, and drop !(nwords%2) requirement. Then in rest of function, use new keyword, arg variables instead of word[i], word[i+1] Signed-off-by: Jim Cromie --- .../admin-guide/dynamic-debu

Re WE HAVE GOLD DUST AND BAR FOR SALE LOOKING FOR RELIABLE BUYER

2020-07-13 Thread Mr kweis owusu
Hello Sir WE HAVE GOLD DUST AND BAR FOR SALE LOOKING FOR RELIABLE BUYER WORLDWIDE. YOU CAN HELP TO CONNECT US WITH ANY BUYER AND TAKE YOUR COMMISSION AS AGENT. We have 800 kilogrammes gold dust and gold for sale now.follows: Commodity:Gold Form: Alluvial Dust Quality: 22+ Carat (94%) Price

[PATCH v4 14/17] dyndbg: accept query terms like file=bar and module=foo

2020-06-20 Thread Jim Cromie
Current code expects "keyword" "arg" as 2 space separated words. Change to also accept "keyword=arg" form as well, and drop !(nwords%2) requirement. Then in rest of function, use new keyword, arg variables instead of word[i], word[i+1] Signed-off-by: Jim Cromie --- .../admin-guide/dynamic-debug

Re: [PATCH v3 14/21] dyndbg: accept query terms like file=bar and module=foo

2020-06-18 Thread jim . cromie
oops. got 3 copies of 14/21, this is the good one. with module=foo AND file=bar On Wed, Jun 17, 2020 at 10:26 AM Jim Cromie wrote: > > Current code expects "keyword" "arg" as 2 space separated words. > Change to also accept "keyword=arg" form as w

[PATCH v3 14/21] dyndbg: accept query terms like file=bar module=foo

2020-06-17 Thread Jim Cromie
Current code expects "keyword" "arg" as 2 space separated words. Change to also accept "keyword=arg" form as well, and drop !(nwords%2) requirement. Then in rest of function, use new keyword, arg variables instead of word[i], word[i+1] Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 51

[PATCH v3 14/21] dyndbg: accept query terms like file=bar and module=foo

2020-06-17 Thread Jim Cromie
Current code expects "keyword" "arg" as 2 space separated words. Change to also accept "keyword=arg" form as well, and drop !(nwords%2) requirement. Then in rest of function, use new keyword, arg variables instead of word[i], word[i+1] Signed-off-by: Jim Cromie --- .../admin-guide/dynamic-debug

[PATCH v3 14/21] dyndbg: accept query terms like module:foo and file=bar

2020-06-17 Thread Jim Cromie
Current code expects "keyword" "arg" as 2 space separated words. Change to also accept "keyword=arg" form as well, and drop !(nwords%2) requirement. Then in rest of function, use new keyword,arg variables instead of word[i],word[i+1] Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 51 ++

Re: [PATCH v2 19/24] dyndbg: accept query terms like module:foo and file=bar

2020-06-17 Thread Greg KH
On Wed, Jun 17, 2020 at 07:32:44AM -0600, jim.cro...@gmail.com wrote: > hi Petr > > > You made to do some research and I was wrong. For example, getopt() > > operates with options and their arguments. So, 'keyword' and 'arg' names > > look good after all. > > > > Well, I still think that only one

Re: [PATCH v2 19/24] dyndbg: accept query terms like module:foo and file=bar

2020-06-17 Thread jim . cromie
hi Petr > You made to do some research and I was wrong. For example, getopt() > operates with options and their arguments. So, 'keyword' and 'arg' names > look good after all. > > Well, I still think that only one syntax should be supported. And it > is better to distinguish keywords and arguments

Re: [PATCH v2 19/24] dyndbg: accept query terms like module:foo and file=bar

2020-06-17 Thread Petr Mladek
On Tue 2020-06-16 14:08:57, jim.cro...@gmail.com wrote: > On Tue, Jun 16, 2020 at 5:57 AM Petr Mladek wrote: > > > > On Sat 2020-06-13 09:57:33, Jim Cromie wrote: > > > Current code expects "keyword" "arg" as 2 space separated words. > > > Change to also accept "keyword:arg" and "keyword=arg" form

Re: [PATCH v2 19/24] dyndbg: accept query terms like module:foo and file=bar

2020-06-16 Thread jim . cromie
On Tue, Jun 16, 2020 at 5:57 AM Petr Mladek wrote: > > On Sat 2020-06-13 09:57:33, Jim Cromie wrote: > > Current code expects "keyword" "arg" as 2 space separated words. > > Change to also accept "keyword:arg" and "keyword=arg" forms as well, > > and drop !(nwords%2) requirement. > > > > Then in r

Re: [PATCH v2 19/24] dyndbg: accept query terms like module:foo and file=bar

2020-06-16 Thread Petr Mladek
On Sat 2020-06-13 09:57:33, Jim Cromie wrote: > Current code expects "keyword" "arg" as 2 space separated words. > Change to also accept "keyword:arg" and "keyword=arg" forms as well, > and drop !(nwords%2) requirement. > > Then in rest of function, use new keyword,arg variables instead of > word[

[PATCH v2 19/24] dyndbg: accept query terms like module:foo and file=bar

2020-06-13 Thread Jim Cromie
Current code expects "keyword" "arg" as 2 space separated words. Change to also accept "keyword:arg" and "keyword=arg" forms as well, and drop !(nwords%2) requirement. Then in rest of function, use new keyword,arg variables instead of word[i],word[i+1] --- lib/dynamic_debug.c | 49 +++

[PATCH v2 03/14] PCI: endpoint: Add helper API to get the 'next' unreserved BAR

2020-06-11 Thread Kishon Vijay Abraham I
Add an API to get the next unreserved BAR starting from a given BAR number that can be used by the endpoint function. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/endpoint/pci-epc-core.c | 26 ++ include/linux/pci-epc.h | 2 ++ 2 files changed, 24

[PATCH v2 02/14] PCI: endpoint: Make *_get_first_free_bar() take into account 64 bit BAR

2020-06-11 Thread Kishon Vijay Abraham I
pci_epc_get_first_free_bar() uses only "reserved_bar" member in epc_features to get the first unreserved BAR. However if the reserved BAR is also a 64-bit BAR, then the next BAR shouldn't be returned (since 64-bit BAR uses two BARs). Make pci_epc_get_first_free_bar() take into acc

Re: [PATCH v4] PCI: cadence: Use "dma-ranges" instead of "cdns,no-bar-match-nbits" property

2020-06-09 Thread Kishon Vijay Abraham I
Hi Rob, On 5/27/2020 3:29 AM, Rob Herring wrote: > On Thu, May 21, 2020 at 2:02 AM Kishon Vijay Abraham I wrote: >> >> Cadence PCIe core driver (host mode) uses "cdns,no-bar-match-nbits" >> property to configure the number of bits passed through from PCIe &g

Re: [PATCH v4] PCI: cadence: Use "dma-ranges" instead of "cdns,no-bar-match-nbits" property

2020-05-26 Thread Rob Herring
On Thu, May 21, 2020 at 2:02 AM Kishon Vijay Abraham I wrote: > > Cadence PCIe core driver (host mode) uses "cdns,no-bar-match-nbits" > property to configure the number of bits passed through from PCIe > address to internal address in Inbound Address Translation register. &

Re: piix4-poweroff.c I/O BAR usage

2020-05-22 Thread Maciej W. Rozycki
On Thu, 21 May 2020, Paul Burton wrote: > I'm reachable but lacking free time & with no access to Malta hardware > I can't claim to be too useful here, so thanks for responding :) Great you're still around! I hope you're doing good in this difficult time, and overall. I have recently learnt W

Re: piix4-poweroff.c I/O BAR usage

2020-05-21 Thread Paul Burton
nowledge had been lost over time :) I suspect the code was based on visws_machine_power_off(): https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/x86/platform/visws/visws_quirks.c?h=v3.10#n125 > > pci_request_region() takes a BAR number (0-5), but here we'

Re: piix4-poweroff.c I/O BAR usage

2020-05-21 Thread Maciej W. Rozycki
st struct pci_device_id *id) > { > ... > /* Request access to the PIIX4 PM IO registers */ > res = pci_request_region(dev, piix4_pm_io_region, >"PIIX4 PM IO registers"); > > pci_request_reg

Re: [PATCH v3 4/4] PCI: cadence: Use "dma-ranges" instead of "cdns,no-bar-match-nbits" property

2020-05-21 Thread Kishon Vijay Abraham I
Rob, On 5/21/2020 9:00 AM, Kishon Vijay Abraham I wrote: > Hi Rob, > > On 5/19/2020 10:41 PM, Rob Herring wrote: >> On Fri, May 8, 2020 at 7:07 AM Kishon Vijay Abraham I wrote: >>> >>> Cadence PCIe core driver (host mode) uses "cdns,no-bar-match-nbits&qu

[PATCH v4] PCI: cadence: Use "dma-ranges" instead of "cdns,no-bar-match-nbits" property

2020-05-21 Thread Kishon Vijay Abraham I
Cadence PCIe core driver (host mode) uses "cdns,no-bar-match-nbits" property to configure the number of bits passed through from PCIe address to internal address in Inbound Address Translation register. This only used the NO MATCH BAR. However standard PCI dt-binding already defines &

Re: [PATCH v3 4/4] PCI: cadence: Use "dma-ranges" instead of "cdns,no-bar-match-nbits" property

2020-05-20 Thread Kishon Vijay Abraham I
Hi Rob, On 5/19/2020 10:41 PM, Rob Herring wrote: > On Fri, May 8, 2020 at 7:07 AM Kishon Vijay Abraham I wrote: >> >> Cadence PCIe core driver (host mode) uses "cdns,no-bar-match-nbits" >> property to configure the number of bits passed through from PCIe &g

piix4-poweroff.c I/O BAR usage

2020-05-20 Thread Bjorn Helgaas
registers */ res = pci_request_region(dev, piix4_pm_io_region, "PIIX4 PM IO registers"); pci_request_region() takes a BAR number (0-5), but here we're passing PCI_BRIDGE_RESOURCES (13 if CONFIG_PCI_IOV, or 7 otherwise), which is the bridge

Re: [PATCH v3 4/4] PCI: cadence: Use "dma-ranges" instead of "cdns,no-bar-match-nbits" property

2020-05-19 Thread Rob Herring
On Fri, May 8, 2020 at 7:07 AM Kishon Vijay Abraham I wrote: > > Cadence PCIe core driver (host mode) uses "cdns,no-bar-match-nbits" > property to configure the number of bits passed through from PCIe > address to internal address in Inbound Address Translation register. &

Re: [PATCH v3 4/4] PCI: cadence: Use "dma-ranges" instead of "cdns,no-bar-match-nbits" property

2020-05-18 Thread Kishon Vijay Abraham I
Hi RobH, Robin, On 5/8/2020 6:36 PM, Kishon Vijay Abraham I wrote: > Cadence PCIe core driver (host mode) uses "cdns,no-bar-match-nbits" > property to configure the number of bits passed through from PCIe > address to internal address in Inbound Address Translation register. &

[QEMU RFC PATCH v4] hw/vfio/pci: remap bar region irq

2020-05-17 Thread Yan Zhao
Added an irq type VFIO_IRQ_TYPE_REMAP_BAR_REGION to dynamically query and remap BAR regions. QEMU decodes the index of the BARs by reading cnt of eventfd. If bit n is set, the corresponding BAR will be requeried and its subregions will be remapped according to the its new flags. rely on [1

[RFC PATCH v4 10/10] i40e/vf_migration: vendor defined irq_type to support dynamic bar map

2020-05-17 Thread Yan Zhao
bars. It packs the target bar number in the ctx count. i.e. 1 << bar_number. if there are multiple bars to remap, the numbers are or'ed. b. on receiving this eventfd signal, userspace will read the bar number, re-query the bar flags (like READ/WRITE/MMAP/SPARSE ranges), a

[PATCH 07/19] PCI: endpoint: Add helper API to get the 'next' unreserved BAR

2020-05-14 Thread Kishon Vijay Abraham I
Add an API to get the next unreserved BAR starting from a given BAR number that can be used by the endpoint function. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/endpoint/pci-epc-core.c | 26 ++ include/linux/pci-epc.h | 2 ++ 2 files changed, 24

[PATCH 06/19] PCI: endpoint: Make *_get_first_free_bar() take into account 64 bit BAR

2020-05-14 Thread Kishon Vijay Abraham I
pci_epc_get_first_free_bar() uses only "reserved_bar" member in epc_features to get the first unreserved BAR. However if the reserved BAR is also a 64-bit BAR, then the next BAR shouldn't be returned (since 64-bit BAR uses two BARs). Make pci_epc_get_first_free_bar() take into acc

[PATCH v3 4/4] PCI: cadence: Use "dma-ranges" instead of "cdns,no-bar-match-nbits" property

2020-05-08 Thread Kishon Vijay Abraham I
Cadence PCIe core driver (host mode) uses "cdns,no-bar-match-nbits" property to configure the number of bits passed through from PCIe address to internal address in Inbound Address Translation register. This only used the NO MATCH BAR. However standard PCI dt-binding already defines &

Re: [PATCH v2 2/4] PCI: cadence: Use "dma-ranges" instead of "cdns,no-bar-match-nbits" property

2020-05-08 Thread Kishon Vijay Abraham I
1/2020 9:24 PM, Robin Murphy wrote: >>>>>>> On 2020-05-01 3:46 pm, Lorenzo Pieralisi wrote: >>>>>>>> [+Robin - to check on dma-ranges intepretation] >>>>>>>> >>>>>>>> I would need RobH and Robin to review this. &g

Re: [PATCH v2 2/4] PCI: cadence: Use "dma-ranges" instead of "cdns,no-bar-match-nbits" property

2020-05-08 Thread Kishon Vijay Abraham I
bin - to check on dma-ranges intepretation] >>>>>>> >>>>>>> I would need RobH and Robin to review this. >>>>>>> >>>>>>> Also, An ACK from Tom is required - for the whole series. >>>>>>> >>>

Re: [PATCH v2 2/4] PCI: cadence: Use "dma-ranges" instead of "cdns,no-bar-match-nbits" property

2020-05-07 Thread Rob Herring
I would need RobH and Robin to review this. > >>>>> > >>>>> Also, An ACK from Tom is required - for the whole series. > >>>>> > >>>>> On Fri, Apr 17, 2020 at 05:13:20PM +0530, Kishon Vijay Abraham I wrote: > >>&g

Re: [PATCH v2 2/4] PCI: cadence: Use "dma-ranges" instead of "cdns,no-bar-match-nbits" property

2020-05-05 Thread Kishon Vijay Abraham I
s. >>>>> >>>>> On Fri, Apr 17, 2020 at 05:13:20PM +0530, Kishon Vijay Abraham I wrote: >>>>>> Cadence PCIe core driver (host mode) uses "cdns,no-bar-match-nbits" >>>>>> property to configure the number of bits passed

  1   2   3   4   5   6   7   8   9   10   >