Re: bq2415x_charger: Use common error handling code in bq2415x_timer_work()

2017-11-09 Thread SF Markus Elfring
>> Which information (or wording) would you find more appropriate >> at these places? > > Hi! Basically dropping your patch and instead of the "Unknown error" > return to user reason why BQ2415X_BOOST_MODE_STATUS or > BQ2415X_FAULT_STATUS commands failed. Or at least instead of the > "Unknown

Re: bq2415x_charger: Use common error handling code in bq2415x_timer_work()

2017-11-09 Thread SF Markus Elfring
>> Which information (or wording) would you find more appropriate >> at these places? > > Hi! Basically dropping your patch and instead of the "Unknown error" > return to user reason why BQ2415X_BOOST_MODE_STATUS or > BQ2415X_FAULT_STATUS commands failed. Or at least instead of the > "Unknown

Re: bq2415x_charger: Use common error handling code in bq2415x_timer_work()

2017-11-09 Thread Pali Rohár
On Thursday 09 November 2017 14:04:19 SF Markus Elfring wrote: > > Better fix would be to display separate messages; user is probably > > interested in what failed... > > Which information (or wording) would you find more appropriate > at these places? Hi! Basically dropping your patch and

Re: bq2415x_charger: Use common error handling code in bq2415x_timer_work()

2017-11-09 Thread Pali Rohár
On Thursday 09 November 2017 14:04:19 SF Markus Elfring wrote: > > Better fix would be to display separate messages; user is probably > > interested in what failed... > > Which information (or wording) would you find more appropriate > at these places? Hi! Basically dropping your patch and

Re: bq2415x_charger: Use common error handling code in bq2415x_timer_work()

2017-11-09 Thread SF Markus Elfring
> Better fix would be to display separate messages; user is probably > interested in what failed... Which information (or wording) would you find more appropriate at these places? Regards, Markus

Re: bq2415x_charger: Use common error handling code in bq2415x_timer_work()

2017-11-09 Thread SF Markus Elfring
> Better fix would be to display separate messages; user is probably > interested in what failed... Which information (or wording) would you find more appropriate at these places? Regards, Markus

Re: [PATCH] bq2415x_charger: Use common error handling code in bq2415x_timer_work()

2017-11-09 Thread Pavel Machek
> From: Markus Elfring > Date: Mon, 30 Oct 2017 21:45:09 +0100 > > Add a jump target so that a bit of exception handling can be better reused > at the end of this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus

Re: [PATCH] bq2415x_charger: Use common error handling code in bq2415x_timer_work()

2017-11-09 Thread Pavel Machek
> From: Markus Elfring > Date: Mon, 30 Oct 2017 21:45:09 +0100 > > Add a jump target so that a bit of exception handling can be better reused > at the end of this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Better fix would be to

[PATCH] bq2415x_charger: Use common error handling code in bq2415x_timer_work()

2017-10-30 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 30 Oct 2017 21:45:09 +0100 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH] bq2415x_charger: Use common error handling code in bq2415x_timer_work()

2017-10-30 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 30 Oct 2017 21:45:09 +0100 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---