Re: [PATCHv4 net-next 0/4] bridge: multicast snooping patches / exports

2014-06-11 Thread David Miller
From: Linus Lüssing Date: Sat, 7 Jun 2014 18:26:25 +0200 > The first patch is simply a cosmetic patch. So far I (and maybe others > too?) have been regularly confusing these two structs, therefore I'd > suggest renaming them and therefore making the follow-up patches easier > to understand and

Re: [PATCHv4 net-next 0/4] bridge: multicast snooping patches / exports

2014-06-11 Thread David Miller
From: Linus Lüssing linus.luess...@web.de Date: Sat, 7 Jun 2014 18:26:25 +0200 The first patch is simply a cosmetic patch. So far I (and maybe others too?) have been regularly confusing these two structs, therefore I'd suggest renaming them and therefore making the follow-up patches easier

[PATCHv4 net-next 0/4] bridge: multicast snooping patches / exports

2014-06-07 Thread Linus Lüssing
The first patch is simply a cosmetic patch. So far I (and maybe others too?) have been regularly confusing these two structs, therefore I'd suggest renaming them and therefore making the follow-up patches easier to understand and nicer to fit in. The second patch fixes a minor issue, but probably

[PATCHv4 net-next 0/4] bridge: multicast snooping patches / exports

2014-06-07 Thread Linus Lüssing
The first patch is simply a cosmetic patch. So far I (and maybe others too?) have been regularly confusing these two structs, therefore I'd suggest renaming them and therefore making the follow-up patches easier to understand and nicer to fit in. The second patch fixes a minor issue, but probably

Re: [PATCHv3 net-next 0/4] bridge: multicast snooping patches / exports

2014-06-05 Thread David Miller
From: Linus Lüssing Date: Thu, 5 Jun 2014 23:20:16 +0200 > Oh, I'm sorry, I thought it'd only be necessary for the v1 > patchset. Going to change that from now on. Anyways, here it is > (copied 'n' pasted): When I ask for changes, you need to make a new fresh submission of your patch(s). -- To

Re: [PATCHv3 net-next 0/4] bridge: multicast snooping patches / exports

2014-06-05 Thread Linus Lüssing
On Thu, Jun 05, 2014 at 12:43:11AM -0700, David Miller wrote: > From: Linus Lüssing > Date: Mon, 2 Jun 2014 20:42:15 +0200 > > > Changes in v3: > > > > * use EXPORT_SYMBOL_GPL() instead of EXPORT_SYMBOL() > > This is not a sufficient header posting. > > You must also describe at a high level

Re: [PATCHv3 net-next 0/4] bridge: multicast snooping patches / exports

2014-06-05 Thread David Miller
From: Linus Lüssing Date: Mon, 2 Jun 2014 20:42:15 +0200 > Changes in v3: > > * use EXPORT_SYMBOL_GPL() instead of EXPORT_SYMBOL() This is not a sufficient header posting. You must also describe at a high level what this patch series is doing, and why you are doing it. -- To unsubscribe from

Re: [PATCHv3 net-next 0/4] bridge: multicast snooping patches / exports

2014-06-05 Thread David Miller
From: Linus Lüssing linus.luess...@web.de Date: Mon, 2 Jun 2014 20:42:15 +0200 Changes in v3: * use EXPORT_SYMBOL_GPL() instead of EXPORT_SYMBOL() This is not a sufficient header posting. You must also describe at a high level what this patch series is doing, and why you are doing it. -- To

Re: [PATCHv3 net-next 0/4] bridge: multicast snooping patches / exports

2014-06-05 Thread Linus Lüssing
On Thu, Jun 05, 2014 at 12:43:11AM -0700, David Miller wrote: From: Linus Lüssing linus.luess...@web.de Date: Mon, 2 Jun 2014 20:42:15 +0200 Changes in v3: * use EXPORT_SYMBOL_GPL() instead of EXPORT_SYMBOL() This is not a sufficient header posting. You must also describe at a

Re: [PATCHv3 net-next 0/4] bridge: multicast snooping patches / exports

2014-06-05 Thread David Miller
From: Linus Lüssing linus.luess...@web.de Date: Thu, 5 Jun 2014 23:20:16 +0200 Oh, I'm sorry, I thought it'd only be necessary for the v1 patchset. Going to change that from now on. Anyways, here it is (copied 'n' pasted): When I ask for changes, you need to make a new fresh submission of

[PATCHv3 net-next 0/4] bridge: multicast snooping patches / exports

2014-06-02 Thread Linus Lüssing
Changes in v3: * use EXPORT_SYMBOL_GPL() instead of EXPORT_SYMBOL() Cheers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

[PATCHv3 net-next 0/4] bridge: multicast snooping patches / exports

2014-06-02 Thread Linus Lüssing
Changes in v3: * use EXPORT_SYMBOL_GPL() instead of EXPORT_SYMBOL() Cheers -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

Re: [PATCHv2 net-next 0/4] bridge: multicast snooping patches / exports

2014-05-30 Thread Stephen Hemminger
On Thu, 29 May 2014 15:36:22 -0700 (PDT) David Miller wrote: > From: Linus Lüssing > Date: Sun, 25 May 2014 07:03:21 +0200 > > > Changes in v2: > > I really need a bridging expert to review this series, thank you. I am fine with these, but would like original author of IGMP snooping to weigh

Re: [PATCHv2 net-next 0/4] bridge: multicast snooping patches / exports

2014-05-30 Thread Stephen Hemminger
On Thu, 29 May 2014 15:36:22 -0700 (PDT) David Miller da...@davemloft.net wrote: From: Linus Lüssing linus.luess...@web.de Date: Sun, 25 May 2014 07:03:21 +0200 Changes in v2: I really need a bridging expert to review this series, thank you. I am fine with these, but would like original

Re: [PATCHv2 net-next 0/4] bridge: multicast snooping patches / exports

2014-05-29 Thread David Miller
From: Linus Lüssing Date: Sun, 25 May 2014 07:03:21 +0200 > Changes in v2: I really need a bridging expert to review this series, thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCHv2 net-next 0/4] bridge: multicast snooping patches / exports

2014-05-29 Thread David Miller
From: Linus Lüssing linus.luess...@web.de Date: Sun, 25 May 2014 07:03:21 +0200 Changes in v2: I really need a bridging expert to review this series, thank you. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

[PATCHv2 net-next 0/4] bridge: multicast snooping patches / exports

2014-05-24 Thread Linus Lüssing
Changes in v2: * fix a nasty typo in PATCH 1/4, br_multicast_update_query_timer(): "br->multicast_query_interval" vs. "br->multicast_querier_interval" => this accidentally reduced the other querier present timer from 255 to 125 seconds * fix a typo in PATCH 2/4,

[PATCHv2 net-next 0/4] bridge: multicast snooping patches / exports

2014-05-24 Thread Linus Lüssing
Changes in v2: * fix a nasty typo in PATCH 1/4, br_multicast_update_query_timer(): br-multicast_query_interval vs. br-multicast_querier_interval = this accidentally reduced the other querier present timer from 255 to 125 seconds * fix a typo in PATCH 2/4, br_ip{4,6}_multicast_query():

Re: bridge: multicast snooping patches / exports

2014-05-22 Thread David Miller
From: Linus Lüssing Date: Wed, 21 May 2014 10:58:58 +0200 > These two patches are exporting functionality needed to marry the bridge > multicast snooping with the batman-adv multicast optimizations recently > added for the 3.15 kernel, allowing to use these optimzations in common > setups having

Re: bridge: multicast snooping patches / exports

2014-05-22 Thread David Miller
From: Linus Lüssing linus.luess...@web.de Date: Wed, 21 May 2014 10:58:58 +0200 These two patches are exporting functionality needed to marry the bridge multicast snooping with the batman-adv multicast optimizations recently added for the 3.15 kernel, allowing to use these optimzations in

bridge: multicast snooping patches / exports

2014-05-21 Thread Linus Lüssing
Hi, The first patch is simply a cosmetic patch. So far I (and maybe others too?) have been regularly confusing these two structs, therefore I'd suggest renaming them and therefore making the follow-up patches easier to understand and nicer to fit in. The second patch fixes a minor issue, but

bridge: multicast snooping patches / exports

2014-05-21 Thread Linus Lüssing
Hi, The first patch is simply a cosmetic patch. So far I (and maybe others too?) have been regularly confusing these two structs, therefore I'd suggest renaming them and therefore making the follow-up patches easier to understand and nicer to fit in. The second patch fixes a minor issue, but