Re: cgroup_attach_task && while_each_thread (Was: cgroup attach task - slogging cpu)

2013-10-15 Thread Tejun Heo
On Tue, Oct 15, 2013 at 10:34:04AM +0530, anjana vk wrote: > Hi All, > > Thankyou for your suggestions. > I have made the modifications as suggested. I already applied the version Li posted (as you the author, of course). Thanks a lot! -- tejun -- To unsubscribe from this list: send the line

Re: cgroup_attach_task while_each_thread (Was: cgroup attach task - slogging cpu)

2013-10-15 Thread Tejun Heo
On Tue, Oct 15, 2013 at 10:34:04AM +0530, anjana vk wrote: Hi All, Thankyou for your suggestions. I have made the modifications as suggested. I already applied the version Li posted (as you the author, of course). Thanks a lot! -- tejun -- To unsubscribe from this list: send the line

Re: cgroup_attach_task && while_each_thread (Was: cgroup attach task - slogging cpu)

2013-10-14 Thread anjana vk
Hi All, Thankyou for your suggestions. I have made the modifications as suggested. Please find the patch below. >From fd85f093f912a160c0896ea2784dfbdd64f142ca Mon Sep 17 00:00:00 2001 From: Anjana V Kumar Date: Wed, 9 Oct 2013 16:49:22 +0530 Subject: [PATCH] Single thread break missing in

Re: cgroup_attach_task while_each_thread (Was: cgroup attach task - slogging cpu)

2013-10-14 Thread anjana vk
Hi All, Thankyou for your suggestions. I have made the modifications as suggested. Please find the patch below. From fd85f093f912a160c0896ea2784dfbdd64f142ca Mon Sep 17 00:00:00 2001 From: Anjana V Kumar anjanav...@gmail.com Date: Wed, 9 Oct 2013 16:49:22 +0530 Subject: [PATCH] Single thread

Re: cgroup_attach_task && while_each_thread (Was: cgroup attach task - slogging cpu)

2013-10-11 Thread Oleg Nesterov
On 10/11, Li Zefan wrote: > > On 2013/10/10 0:54, Oleg Nesterov wrote: > > > And I am starting to think that this change should also fix the > > while_each_thread() problems in this particular case. Please see below, > > In generak the code like > > > > rcu_read_lock(); > > task =

Re: cgroup_attach_task && while_each_thread (Was: cgroup attach task - slogging cpu)

2013-10-11 Thread Li Zefan
On 2013/10/10 0:54, Oleg Nesterov wrote: > And I am starting to think that this change should also fix the > while_each_thread() problems in this particular case. > > In generak the code like > > rcu_read_lock(); > task = find_get_task(...); > rcu_read_unlock(); > >

Re: cgroup_attach_task while_each_thread (Was: cgroup attach task - slogging cpu)

2013-10-11 Thread Li Zefan
On 2013/10/10 0:54, Oleg Nesterov wrote: And I am starting to think that this change should also fix the while_each_thread() problems in this particular case. In generak the code like rcu_read_lock(); task = find_get_task(...); rcu_read_unlock();

Re: cgroup_attach_task while_each_thread (Was: cgroup attach task - slogging cpu)

2013-10-11 Thread Oleg Nesterov
On 10/11, Li Zefan wrote: On 2013/10/10 0:54, Oleg Nesterov wrote: And I am starting to think that this change should also fix the while_each_thread() problems in this particular case. Please see below, In generak the code like rcu_read_lock(); task = find_get_task(...);

cgroup_attach_task && while_each_thread (Was: cgroup attach task - slogging cpu)

2013-10-09 Thread Oleg Nesterov
And I am starting to think that this change should also fix the while_each_thread() problems in this particular case. In generak the code like rcu_read_lock(); task = find_get_task(...); rcu_read_unlock(); rcu_read_lock(); t = task; do {

cgroup_attach_task while_each_thread (Was: cgroup attach task - slogging cpu)

2013-10-09 Thread Oleg Nesterov
And I am starting to think that this change should also fix the while_each_thread() problems in this particular case. In generak the code like rcu_read_lock(); task = find_get_task(...); rcu_read_unlock(); rcu_read_lock(); t = task; do {