Re: checker-shell still hosed...

2007-02-08 Thread Geert Uytterhoeven
On Thu, 8 Feb 2007, Geert Uytterhoeven wrote: > On Thu, 8 Feb 2007, David Miller wrote: > > From: David Miller <[EMAIL PROTECTED]> > > Date: Thu, 08 Feb 2007 04:10:04 -0800 (PST) > > > > > Removing them makes the spaces go away. > > > > FWIW, this patch below seems to fix the sparc64 build for

Re: checker-shell still hosed...

2007-02-08 Thread Geert Uytterhoeven
On Thu, 8 Feb 2007, David Miller wrote: > From: David Miller <[EMAIL PROTECTED]> > Date: Thu, 08 Feb 2007 04:10:04 -0800 (PST) > > > Removing them makes the spaces go away. > > FWIW, this patch below seems to fix the sparc64 build for me. > > Paul, does it work for you on powerpc too? Thx, it

Re: checker-shell still hosed...

2007-02-08 Thread David Miller
From: David Miller <[EMAIL PROTECTED]> Date: Thu, 08 Feb 2007 04:10:04 -0800 (PST) > Removing them makes the spaces go away. FWIW, this patch below seems to fix the sparc64 build for me. Paul, does it work for you on powerpc too? diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include

Re: checker-shell still hosed...

2007-02-08 Thread David Miller
From: David Miller <[EMAIL PROTECTED]> Date: Thu, 08 Feb 2007 03:05:31 -0800 (PST) > define test1 > $(shell echo "str1") > endef > > define test2 > $(call test1) > endef Someone just privately explained that my test case is broken because of the spaces before the "$(shell " in the defines.

checker-shell still hosed...

2007-02-08 Thread David Miller
Linus, things still fail for me even with the $(strip ...) construct you added works properly. For some reason things like $(call cc-option-yn...) still fail. My make version 3.81beta4 has the space problem, and with your change it just returns a space. :-) Without your change it gives the

checker-shell still hosed...

2007-02-08 Thread David Miller
Linus, things still fail for me even with the $(strip ...) construct you added works properly. For some reason things like $(call cc-option-yn...) still fail. My make version 3.81beta4 has the space problem, and with your change it just returns a space. :-) Without your change it gives the

Re: checker-shell still hosed...

2007-02-08 Thread David Miller
From: David Miller [EMAIL PROTECTED] Date: Thu, 08 Feb 2007 03:05:31 -0800 (PST) define test1 $(shell echo str1) endef define test2 $(call test1) endef Someone just privately explained that my test case is broken because of the spaces before the $(shell in the defines. Removing them

Re: checker-shell still hosed...

2007-02-08 Thread David Miller
From: David Miller [EMAIL PROTECTED] Date: Thu, 08 Feb 2007 04:10:04 -0800 (PST) Removing them makes the spaces go away. FWIW, this patch below seems to fix the sparc64 build for me. Paul, does it work for you on powerpc too? diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include index

Re: checker-shell still hosed...

2007-02-08 Thread Geert Uytterhoeven
On Thu, 8 Feb 2007, David Miller wrote: From: David Miller [EMAIL PROTECTED] Date: Thu, 08 Feb 2007 04:10:04 -0800 (PST) Removing them makes the spaces go away. FWIW, this patch below seems to fix the sparc64 build for me. Paul, does it work for you on powerpc too? Thx, it seems to

Re: checker-shell still hosed...

2007-02-08 Thread Geert Uytterhoeven
On Thu, 8 Feb 2007, Geert Uytterhoeven wrote: On Thu, 8 Feb 2007, David Miller wrote: From: David Miller [EMAIL PROTECTED] Date: Thu, 08 Feb 2007 04:10:04 -0800 (PST) Removing them makes the spaces go away. FWIW, this patch below seems to fix the sparc64 build for me. Paul,