Re: checkpatch falsepositives in Lustre code

2016-02-15 Thread Oleg Drokin
On Feb 15, 2016, at 10:05 PM, Joe Perches wrote: > On Mon, 2016-02-15 at 21:45 -0500, Oleg Drokin wrote: >> On Feb 15, 2016, at 9:27 PM, Joe Perches wrote: >> >>> On Mon, 2016-02-15 at 20:57 -0500, Oleg Drokin wrote: On Feb 15, 2016, at 7:56 PM, Joe Perches wrote: > [etc...] >

Re: checkpatch falsepositives in Lustre code

2016-02-15 Thread Joe Perches
On Mon, 2016-02-15 at 21:45 -0500, Oleg Drokin wrote: > On Feb 15, 2016, at 9:27 PM, Joe Perches wrote: > > > On Mon, 2016-02-15 at 20:57 -0500, Oleg Drokin wrote: > > > On Feb 15, 2016, at 7:56 PM, Joe Perches wrote: > > > > [etc...] > > > > > > > > Yeah, that's a defect of some type. > > > > >

Re: checkpatch falsepositives in Lustre code

2016-02-15 Thread Oleg Drokin
On Feb 15, 2016, at 9:27 PM, Joe Perches wrote: > On Mon, 2016-02-15 at 20:57 -0500, Oleg Drokin wrote: >> On Feb 15, 2016, at 7:56 PM, Joe Perches wrote: >>> [etc...] >>> >>> Yeah, that's a defect of some type. >> >> Also while I have your attention, here's another one: >> >> struct cfs_percp

Re: checkpatch falsepositives in Lustre code

2016-02-15 Thread Joe Perches
On Mon, 2016-02-15 at 20:57 -0500, Oleg Drokin wrote: > On Feb 15, 2016, at 7:56 PM, Joe Perches wrote: > > [etc...] > > > > Yeah, that's a defect of some type. > > Also while I have your attention, here's another one: > > struct cfs_percpt_lock * > cfs_percpt_lock_alloc(struct cfs_cpt_table *cp

Re: checkpatch falsepositives in Lustre code

2016-02-15 Thread Oleg Drokin
On Feb 15, 2016, at 7:56 PM, Joe Perches wrote: > [etc...] > > Yeah, that's a defect of some type. Also while I have your attention, here's another one: struct cfs_percpt_lock * cfs_percpt_lock_alloc(struct cfs_cpt_table *cptab) { struct cfs_percpt_lock *pcl; spinlock_t

Re: checkpatch falsepositives in Lustre code

2016-02-15 Thread Joe Perches
On Mon, 2016-02-15 at 18:49 -0500, Oleg Drokin wrote: > Hello! > > >    As I am going over Lustre to clean up the code style, I noticed this bunch > below. > >    Those all are function definitions, though I guess it might have been > foiled by >    return type on the previous line? >    Now s